http://bugs.winehq.org/show_bug.cgi?id=27767
Summary: htmlhelp not showing diacritic characters from html encoded entity Product: Wine Version: 1.3.24 Platform: x86 OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: hhctrl.ocx AssignedTo: wine-bugs@winehq.org ReportedBy: htl10@users.sourceforge.net
Created an attachment (id=35529) --> (http://bugs.winehq.org/attachment.cgi?id=35529) xchm vs wine htmlhelp, showing the bug with "ê"
See screenshot showing wine htmlhelp side by side with xchm, of the file in bug 10166c2 - "ê" and "ó" are shown in the cotent panel rather than the corresponding discritic e and o.
quote bug 11166c2, "Application name is Vatowiec (http://appdb.winehq.org/objectManager.php?sClass=application&iId=5787) can be downloaded for free from http://pk.inet.pl/brv_prg.htm (direct link: http://pk.inet.pl/br32.exe). Application is developed with CA-Visual Objects."
will attach the chm also, just saving somebody's trouble of installing the whole thing.
http://bugs.winehq.org/show_bug.cgi?id=27767
--- Comment #1 from Hin-Tak Leung htl10@users.sourceforge.net 2011-07-12 03:04:12 CDT --- Created an attachment (id=35530) --> (http://bugs.winehq.org/attachment.cgi?id=35530) the chm file used in the test screenshot
chm file for testing, in the screenshot.
http://bugs.winehq.org/show_bug.cgi?id=27767
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |download
http://bugs.winehq.org/show_bug.cgi?id=27767
Edward edi67@gazeta.pl changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |edi67@gazeta.pl
http://bugs.winehq.org/show_bug.cgi?id=27767
Frédéric Delanoy frederic.delanoy@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW CC| |frederic.delanoy@gmail.com Ever Confirmed|0 |1
--- Comment #2 from Frédéric Delanoy frederic.delanoy@gmail.com 2012-02-25 09:21:43 CST --- Confirmed in 1.4-rc5
http://bugs.winehq.org/show_bug.cgi?id=27767
--- Comment #3 from Erich Hoover ehoover@mines.edu 2012-05-07 14:45:57 CDT --- Created attachment 40080 --> http://bugs.winehq.org/attachment.cgi?id=40080 Add support to hhctrl.ocx for diacritic characters
The attached patch adds support for converting the html encoded diacritic characters. If you could give this a try and let me know how it works then I'd appreciate it (it does run kinda slow).
http://bugs.winehq.org/show_bug.cgi?id=27767
Erich Hoover ehoover@mines.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ehoover@mines.edu
http://bugs.winehq.org/show_bug.cgi?id=27767
Erich Hoover ehoover@mines.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #40080|0 |1 is obsolete| |
--- Comment #4 from Erich Hoover ehoover@mines.edu 2012-05-07 14:52:52 CDT --- Created attachment 40081 --> http://bugs.winehq.org/attachment.cgi?id=40081 Add support to hhctrl.ocx for diacritic characters [v2]
(In reply to comment #3)
... The attached patch adds support for converting the html encoded diacritic characters. If you could give this a try and let me know how it works then I'd appreciate it (it does run kinda slow).
Whoops, use this one instead - the other one was missing a file.
http://bugs.winehq.org/show_bug.cgi?id=27767
Erich Hoover ehoover@mines.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #40081|0 |1 is obsolete| |
--- Comment #5 from Erich Hoover ehoover@mines.edu 2012-05-07 15:06:02 CDT --- Created attachment 40083 --> http://bugs.winehq.org/attachment.cgi?id=40083 Add support to hhctrl.ocx for diacritic characters [v3]
(In reply to comment #4)
... Whoops, use this one instead - the other one was missing a file.
Wow, still screwed it up - sorry about that :/
http://bugs.winehq.org/show_bug.cgi?id=27767
Jerome Leclanche adys.wh@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch CC| |adys.wh@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=27767
Erich Hoover ehoover@mines.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #40083|0 |1 is obsolete| |
--- Comment #6 from Erich Hoover ehoover@mines.edu 2012-05-08 13:36:12 CDT --- Created attachment 40093 --> http://bugs.winehq.org/attachment.cgi?id=40093 Add support to hhctrl.ocx for diacritic characters [v4]
I've attached a patch where I've approached this issue with a much better method (faster conversion). This version also takes into account the code page, so now the correct symbols should be used for all the characters.
http://bugs.winehq.org/show_bug.cgi?id=27767
--- Comment #7 from Hin-Tak Leung htl10@users.sourceforge.net 2012-05-18 18:35:34 CDT --- The patch seems to work okay - any chance of it being submitted properly?
http://bugs.winehq.org/show_bug.cgi?id=27767
--- Comment #8 from Erich Hoover ehoover@mines.edu 2012-05-18 19:29:12 CDT --- (In reply to comment #7)
The patch seems to work okay - any chance of it being submitted properly?
I plan on submitting after I get my AcceptEx fix for Diablo 3 in.
http://bugs.winehq.org/show_bug.cgi?id=27767
--- Comment #9 from Erich Hoover ehoover@mines.edu 2012-06-07 16:29:07 CDT --- (In reply to comment #8)
(In reply to comment #7)
The patch seems to work okay - any chance of it being submitted properly?
I plan on submitting after I get my AcceptEx fix for Diablo 3 in.
I've submitted the patches for this now, hopefully they'll get accepted with significantly less effort than the D3 patches :)
http://bugs.winehq.org/show_bug.cgi?id=27767
André H. nerv@dawncrow.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |nerv@dawncrow.de
--- Comment #10 from André H. nerv@dawncrow.de 2012-06-11 14:27:08 CDT --- *** Bug 21646 has been marked as a duplicate of this bug. ***
http://bugs.winehq.org/show_bug.cgi?id=27767
--- Comment #11 from André H. nerv@dawncrow.de 2012-06-11 14:29:33 CDT --- i just marked bug 21646 as dup, even if older. But still bug 21646 has quite some good information too (chmfile with source directly targeting german umlauts made by me and a patch from Owen)
Thx for working on that bug Erich
http://bugs.winehq.org/show_bug.cgi?id=27767
--- Comment #12 from Erich Hoover ehoover@mines.edu 2012-06-11 15:44:13 CDT --- (In reply to comment #11)
i just marked bug 21646 as dup, even if older. But still bug 21646 has quite some good information too (chmfile with source directly targeting german umlauts made by me and a patch from Owen)
Thx for working on that bug Erich
No problem, I didn't realize there was an older one. I just tested that file on my box and the patches I've submitted work for that file as well.
http://bugs.winehq.org/show_bug.cgi?id=27767
--- Comment #13 from Erich Hoover ehoover@mines.edu 2012-06-14 16:24:08 CDT --- Created attachment 40547 --> http://bugs.winehq.org/attachment.cgi?id=40547 CHM file appearance on XP
Just to double check this behavior, now nominated for the "Most Stupid Win32 API Behavior award," I've attached a screenshot from XP of the test file. Verdict: yes, it really does behave this strangely.
http://bugs.winehq.org/show_bug.cgi?id=27767
--- Comment #14 from Erich Hoover ehoover@mines.edu 2012-06-22 11:14:01 CDT --- This bug should be fixed by commit a02ad10f99fd0ce6b3d756944a30dcb2852b79ce.
http://bugs.winehq.org/show_bug.cgi?id=27767
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed by SHA1| |a02ad10f99fd0ce6b3d756944a3 | |0dcb2852b79ce Status|NEW |RESOLVED Resolution| |FIXED
--- Comment #15 from Alexandre Julliard julliard@winehq.org 2012-06-22 11:55:22 CDT --- Fixed.
http://bugs.winehq.org/show_bug.cgi?id=27767
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #16 from Alexandre Julliard julliard@winehq.org 2012-06-22 13:31:29 CDT --- Closing bugs fixed in 1.5.7.