[Bug 27854] New: ListView_SetTextBkColor doesn't work

http://bugs.winehq.org/show_bug.cgi?id=27854

Summary: ListView_SetTextBkColor doesn't work
           Product: Wine
           Version: 1.3.24
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: comctl32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Source: http://www.delphidabbler.com/download?id=art-16
Download: http://netikka.net/dev/CustomLVDemo.exe

Text should be transparent, when checkbox is checked.

Not related to transparency. Even clRed instead of CLR_NONE doesn't set
background to red. Works with native comctl32

See also bug 27711

[Bug 27854] ListView_SetTextBkColor doesn't work

http://bugs.winehq.org/show_bug.cgi?id=27854

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, source
                URL|                            |http://netikka.net/dev/Cust
                   |                            |omLVDemo.exe

[Bug 27854] ListView_SetTextBkColor doesn't work

http://bugs.winehq.org/show_bug.cgi?id=27854

--- Comment #1 from Nikolay Sivov  2011-09-29 18:03:18 CDT ---
This is not about LVM_SETTEXTBKCOLOR not working, it works fine and sets
CLR_NONE if asked to. The problem is in custom draw code that expects some
fields to be set in notification handler:

---
    infoPtr->clrTextBk = nmlvcd.clrTextBk;
    infoPtr->clrText = nmlvcd.clrText;
---

mnlvcd.* fields are not set and contain previously assigned values,
LVM_SETTEXTBKCOLOR goes after notification SendMessage() and before mentioned
lines so we never get CLR_NONE.

If you comment out first line you'll see transparent text, I feel like all
custom draw code should be inspected, cause such context dependencies are hard
to resolve without breaking anything.

[Bug 27854] Listview: custom draw code overwrites text background color when it shouldn't (it seems)

http://bugs.winehq.org/show_bug.cgi?id=27854

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|ListView_SetTextBkColor     |Listview: custom draw code
                   |doesn't work                |overwrites text background
                   |                            |color when it shouldn't (it
                   |                            |seems)

[Bug 27854] Listview: custom draw code overwrites text background color when it shouldn't (it seems)

http://bugs.winehq.org/show_bug.cgi?id=27854

--- Comment #2 from [e-mail] 2012-12-17 16:02:41 CST ---
still in wine-1.5.19-186-g1cd0c4a

[Bug 27854] Listview: custom draw code overwrites text background color when it shouldn't (it seems)

http://bugs.winehq.org/show_bug.cgi?id=27854

Daniel Jelinski  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 27854] Listview: custom draw code overwrites text background color when it shouldn't (it seems)

http://bugs.winehq.org/show_bug.cgi?id=27854

--- Comment #3 from Daniel Jelinski  2013-03-05 13:57:42 CST ---
Fixed by 704412b459cfafada2a04fa2f62be149e5597537.
Interestingly, native requires the call to SetBkMode for full transparency,
while wine's listview works fine without it.

[Bug 27854] Listview: custom draw code overwrites text background color when it shouldn't (it seems)

http://bugs.winehq.org/show_bug.cgi?id=27854

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |704412b459cfafada2a04fa2f62
                   |                            |be149e5597537
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Bruno Jesus  2013-03-05 22:34:31 CST ---
(In reply to comment #3)
> Fixed by 704412b459cfafada2a04fa2f62be149e5597537.
> Interestingly, native requires the call to SetBkMode for full transparency,
> while wine's listview works fine without it.

Yes, I can confirm it's fixed.

[Bug 27854] Listview: custom draw code overwrites text background color when it shouldn't (it seems)

http://bugs.winehq.org/show_bug.cgi?id=27854

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  2013-03-15 14:46:00 CDT ---
Closing bugs fixed in 1.5.26.