[Bug 56070] New: BVE trainsim doesn't show its logo in the main window.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56070

Bug ID: 56070
           Summary: BVE trainsim doesn't show its logo in the main window.
           Product: Wine
           Version: 9.0-rc2
          Hardware: x86-64
               URL: http://www.bvets.net/archives/bvets5-7.zip
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: d3d
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: Ubuntu

Created attachment 75735
  --> https://bugs.winehq.org/attachment.cgi?id=75735
Bve window comparision

Bve trainsim is a freeware game for Windows. It simulates train driving.
Using Wine 9.0-rc2, it doesn't show its logo in the main window.
However, the logo is shown with Wine 8.0.2.

Steps to reproduce:
 1) make a new prefix with wineboot and install Wine Mono.
 2) mkdir ${WINEPREFIX-~/.wine}/drive_c/works
 3) cd $_
 4) unzip bvets5-7.zip
 5) cd BveTs5
 6) wine BveTs.exe
 7) choose display language, English or Japanese (First time only)
 8) close "Select scenario" window to show "Bve trainsim" window.

Expected result:
 The window shows the logo in green.

Actual result:
 The window is painted all gray, and no logo is displayed.

Moreover, if you install native d3dx9_43, you can enjoy train operation by
scenario files. Cab instruments and scenery are not displayed when the logo is
not displayed.

[Bug 56070] BVE trainsim doesn't show its logo in the main window.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56070

Sagawa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, regression
    Regression SHA1|                            |215a32d643af4a8e25d4f28c5be
                   |                            |c76f6e69dca22

--- Comment #1 from Sagawa  ---
Git bisect says 215a32d643af4a8e25d4f28c5bec76f6e69dca22 is the first bad
commit.
commit 215a32d643af4a8e25d4f28c5bec76f6e69dca22
Author: Stefan Dosinger 
Date:   Thu Aug 10 20:39:35 2023 +0300

wined3d: Make wined3d_swapchain_desc in wined3d_swapchain_create const.

dlls/wined3d/adapter_gl.c      |  2 +-
 dlls/wined3d/adapter_vk.c      |  2 +-
 dlls/wined3d/directx.c         |  2 +-
 dlls/wined3d/swapchain.c       | 36 ++++++++++++++++--------------------
 dlls/wined3d/wined3d_private.h |  6 +++---
 dlls/wined3d/wined3d_vk.h      |  2 +-
 include/wine/wined3d.h         |  2 +-
 7 files changed, 24 insertions(+), 28 deletions(-)

After the commit, D3DPRESENT_PARAMETERS isn't updated when creating a device.
I'm working on this issue. In a few days I will send a merge request.

[Bug 56070] BVE trainsim doesn't show its logo in the main window.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56070

--- Comment #2 from Sagawa  ---
I sent a merge request,
https://gitlab.winehq.org/wine/wine/-/merge_requests/4741 .

[Bug 56070] BVE trainsim doesn't show its logo in the main window.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56070

Sagawa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |98b053a5b8dcdfe2e3481a36cc1
                   |                            |56e71e2d5145e
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #3 from Sagawa  ---
Fixed by 98b053a5b8dcdfe2e3481a36cc156e71e2d5145e .

[Bug 56070] BVE trainsim doesn't show its logo in the main window.

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56070

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  ---
Closing bugs fixed in 9.0-rc5.