[Bug 33789] New: Japanese are displayed vertical in 1.6rc1 but not previous version even it should be display horizontally

http://bugs.winehq.org/show_bug.cgi?id=33789

Bug #: 33789
           Summary: Japanese are displayed vertical in 1.6rc1 but not
                    previous version even it should be display
                    horizontally
           Product: Wine
           Version: 1.6-rc1
          Platform: x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: fonts
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Created attachment 44765
  --> http://bugs.winehq.org/attachment.cgi?id=44765
Screenshot of the vertically displayed Japanese fonts.

When using wine to play JosouKaikyou(女装海峡) using 1.6rc1,
the horizontally fonts are displayed vertically which is unable to read, like
the attached screenshot.

In previous version(1.5.31), there is no such problem.

Also, not every Japanese GAL is affected, Grisaia no kajitsu(グリザイアの果実) is not
affected at all.

[Bug 33789] Japanese are displayed vertical in 1.6rc1 but not previous version even it should be display horizontally

http://bugs.winehq.org/show_bug.cgi?id=33789

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
          Component|fonts                       |-unknown

--- Comment #1 from Austin English  2013-06-12 00:09:38 CDT ---
Please run a regression test:
http://wiki.winehq.org/RegressionTesting

[Bug 33789] Japanese are displayed vertical in 1.6rc1 but not previous version even it should be display horizontally

http://bugs.winehq.org/show_bug.cgi?id=33789

--- Comment #2 from [e-mail] 2013-06-12 00:15:58 CDT ---
Thanks, I'll try the regression test.

[Bug 33789] Japanese are displayed vertical in 1.6rc1 but not previous version even it should be display horizontally

http://bugs.winehq.org/show_bug.cgi?id=33789

--- Comment #3 from [e-mail] 2013-06-12 01:06:35 CDT ---
After the regression tests,
the following commit causes the bug.
---
commit cf891b04a087bcbc713e704c1adbf6b88243e996
Author: Aric Stewart 
Date:   Fri May 24 11:00:25 2013 -0500

gdi32: Fix Tategaki rotation.

Tategaki does not ignore orientation rotation, instead it always
    rotates affect glyphs by 90 degrees inside their cell.
---
Also this patch itself even makes the fonts displayed improperly.

The latest commits does not fixed this bug yet.

[Bug 33789] Japanese are displayed vertical in 1.6rc1 but not previous version even it should be display horizontally

http://bugs.winehq.org/show_bug.cgi?id=33789

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |gdi32

[Bug 33789] Japanese are displayed vertical in 1.6rc1 but not previous version even it should be display horizontally

http://bugs.winehq.org/show_bug.cgi?id=33789

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
    Regression SHA1|                            |cf891b04a087bcbc713e704c1ad
                   |                            |bf6b88243e996

[Bug 33789] Japanese are displayed vertical in 1.6rc1 but not previous version even it should be display horizontally

http://bugs.winehq.org/show_bug.cgi?id=33789

--- Comment #4 from Aric Stewart  2013-06-12 06:54:56 CDT ---
Thank you very much for the report.

Could you generate a +font log for me?

Thanks!

-aric

[Bug 33789] Japanese are displayed vertical in 1.6rc1 but not previous version even it should be display horizontally

http://bugs.winehq.org/show_bug.cgi?id=33789

--- Comment #5 from [e-mail] 2013-06-12 07:12:40 CDT ---
Created attachment 44768
  --> http://bugs.winehq.org/attachment.cgi?id=44768
+font log with wine-1.5.31 and wine-1.6rc1 respectively

[Bug 33789] Japanese are displayed vertical in 1.6rc1 but not previous version even it should be display horizontally

http://bugs.winehq.org/show_bug.cgi?id=33789

--- Comment #6 from Aric Stewart  2013-06-12 09:44:33 CDT ---
(In reply to comment #5)
> Created attachment 44768 [details]
> +font log with wine-1.5.31 and wine-1.6rc1 respectively

Thanks!

I see that "@Droid Sans Fallback" is being chosen as a font. I believe it is
being chosen for "system"

Is this something you may have set up in your wine environment?

Could you include a +rely log, It will be very large if that is an issue I can
give you an upload location.

[Bug 33789] Japanese are displayed vertical in 1.6rc1 but not previous version even it should be display horizontally

http://bugs.winehq.org/show_bug.cgi?id=33789

Qian Hong  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Qian Hong  2013-06-12 10:06:15 CDT ---
(In reply to comment #6)
> Could you include a +rely log, It will be very large if that is an issue I can
> give you an upload location.

Just a friendly reminder, it is +relay log, not +rely.

:)

[Bug 33789] Japanese are displayed vertical in 1.6rc1 but not previous version even it should be display horizontally

http://bugs.winehq.org/show_bug.cgi?id=33789

--- Comment #8 from [e-mail] 2013-06-12 23:01:00 CDT ---
(In reply to comment #6)
> (In reply to comment #5)
> > Created attachment 44768 [details]
> > +font log with wine-1.5.31 and wine-1.6rc1 respectively
>
> Thanks!
>
> I see that "@Droid Sans Fallback" is being chosen as a font. I believe it is
> being chosen for "system"
>
> Is this something you may have set up in your wine environment?

Not quite sure, but I've changed nothing about the fonts,that's to say no
fakecjk using winetrick.
I just added some dll override for dmusic and quartz related galgame.
> Could you include a +rely log, It will be very large if that is an issue I can
> give you an upload location.

I'll try to upload a little later.
I forgot to upload the log before going to work. :(

[Bug 33789] Japanese are displayed vertical in 1.6rc1 but not previous version even it should be display horizontally

http://bugs.winehq.org/show_bug.cgi?id=33789

--- Comment #9 from [e-mail] 2013-06-13 06:36:17 CDT ---
Uploaded relay log from wine1.5.31 and wine1.6rc1 respectively to google docs.
Even with xz compression, still a little larger than the 1000Kb limitation.

https://docs.google.com/file/d/0BxpkL3ehzX3pNk5LUy1WQTJJaEU/edit?usp=sharing

[Bug 33789] Japanese are displayed vertical in 1.6rc1 but not previous version even it should be display horizontally

http://bugs.winehq.org/show_bug.cgi?id=33789

Sagawa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sagawa.aki+winebugs@gmail.c
                   |                            |om

[Bug 33789] Japanese are displayed vertical in 1.6rc1 but not previous version even it should be display horizontally

http://bugs.winehq.org/show_bug.cgi?id=33789

--- Comment #10 from Sagawa  2013-06-13 07:13:31 CDT ---
Unfortunately, current wine's font enumeration order doesn't match with native
one.
If the application uses the first matched font, the text will be rotated.

In detail, Wine enumerates fonts in the following order:
@MS Gothic -> @MS Mincho -> MS Gothic -> MS Mincho

But in native, enumeration order is as follows:
MS Gothic -> @MS Gothic -> MS Mincho -> @MS Mincho

[Bug 33789] Japanese are displayed vertical in 1.6rc1 but not previous version even it should be display horizontally

http://bugs.winehq.org/show_bug.cgi?id=33789

--- Comment #11 from [e-mail] 2013-06-13 07:35:27 CDT ---
(In reply to comment #10)
> Unfortunately, current wine's font enumeration order doesn't match with native
> one.
> If the application uses the first matched font, the text will be rotated.
>
> In detail, Wine enumerates fonts in the following order:
> @MS Gothic -> @MS Mincho -> MS Gothic -> MS Mincho
>
> But in native, enumeration order is as follows:
> MS Gothic -> @MS Gothic -> MS Mincho -> @MS Mincho

Thanks for the explaination.
For me this is much easier to understand.

But I'm also curious why グリザイアの果実 is not affected at all.

BTW, will overriding gdi32 with native one help?

[Bug 33789] Japanese are displayed vertical in 1.6rc1 but not previous version even it should be display horizontally

http://bugs.winehq.org/show_bug.cgi?id=33789

--- Comment #12 from Aric Stewart  2013-06-13 07:42:33 CDT ---
(In reply to comment #10)
> Unfortunately, current wine's font enumeration order doesn't match with native
> one.
> If the application uses the first matched font, the text will be rotated.
>
> In detail, Wine enumerates fonts in the following order:
> @MS Gothic -> @MS Mincho -> MS Gothic -> MS Mincho
>
> But in native, enumeration order is as follows:
> MS Gothic -> @MS Gothic -> MS Mincho -> @MS Mincho

This is very useful and something I am sure we can fix.

I am looking into the font enumeration code to see if i can get an understandig
of it.

[Bug 33789] Japanese are displayed vertical in 1.6rc1 but not previous version even it should be display horizontally

http://bugs.winehq.org/show_bug.cgi?id=33789

--- Comment #13 from Aric Stewart  2013-06-13 09:35:15 CDT ---
Created attachment 44788
  --> http://bugs.winehq.org/attachment.cgi?id=44788
Test reording the enum list

Could you please test with this patch and see if it affects this issue?

[Bug 33789] Japanese are displayed vertical in 1.6rc1 but not previous version even it should be display horizontally

http://bugs.winehq.org/show_bug.cgi?id=33789

--- Comment #14 from Austin English  2013-06-13 14:51:32 CDT ---
(In reply to comment #11)
> BTW, will overriding gdi32 with native one help?

No, native gdi32 can't be used in wine.

[Bug 33789] Japanese are displayed vertical in 1.6rc1 but not previous version even it should be display horizontally

http://bugs.winehq.org/show_bug.cgi?id=33789

--- Comment #15 from [e-mail] 2013-06-14 06:13:02 CDT ---
(In reply to comment #13)
> Created attachment 44788 [details]
> Test reording the enum list
>
> Could you please test with this patch and see if it affects this issue?

Sorry for the late reply.

The patch seems workding great.
The problem is solved.

Thanks a lot.

Hoping the patch can be merged before 1.6.0.

BTW, should I change the bug status to SOLVED or wait until merged?

[Bug 33789] Japanese are displayed vertical in 1.6rc1 but not previous version even it should be display horizontally

http://bugs.winehq.org/show_bug.cgi?id=33789

--- Comment #16 from Aric Stewart  2013-06-14 06:40:42 CDT ---
(In reply to comment #15)
> (In reply to comment #13)
> > Created attachment 44788 [details]
> > Test reording the enum list
> >
> > Could you please test with this patch and see if it affects this issue?
>
> Sorry for the late reply.
>
> The patch seems workding great.
> The problem is solved.
>
> Thanks a lot.
>
> Hoping the patch can be merged before 1.6.0.
>
> BTW, should I change the bug status to SOLVED or wait until merged?

Hi,

I am glad that worked. It was mostly to try to prove a point to myself. I will
work on refining the patch properly and then submit it. Dont close this bug
until the final patch is committed to wine.

thanks!

[Bug 33789] Japanese are displayed vertical in 1.6rc1 but not previous version even it should be display horizontally

http://bugs.winehq.org/show_bug.cgi?id=33789

--- Comment #17 from Sagawa  2013-06-14 06:54:53 CDT ---
I'm happy to hear this.
Thank you, anonymous reporter and Aric.

[Bug 33789] Japanese are displayed vertical in 1.6rc1 but not previous version even it should be display horizontally

http://bugs.winehq.org/show_bug.cgi?id=33789

--- Comment #18 from Aric Stewart  2013-06-14 07:33:53 CDT ---
(In reply to comment #17)
> I'm happy to hear this.
> Thank you, anonymous reporter and Aric.

Thank you!  Your tip about the order of font enumeration made this much easier
to find.

[Bug 33789] Japanese are displayed vertical in 1.6rc1 but not previous version even it should be display horizontally

http://bugs.winehq.org/show_bug.cgi?id=33789

--- Comment #19 from Bruno Jesus  2013-06-21 14:56:37 CDT ---
This patch looks related to this issue:
http://source.winehq.org/git/wine.git/commitdiff/e531306f7ad6292fe0deff1533e...

[Bug 33789] Japanese are displayed vertical in 1.6rc1 but not previous version even it should be display horizontally

http://bugs.winehq.org/show_bug.cgi?id=33789

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #20 from [e-mail] 2013-06-29 23:37:41 CDT ---
Fixed in wine1.6-rc4.
So marked as fixed.

[Bug 33789] Japanese are displayed vertical in 1.6rc1 but not previous version even it should be display horizontally

http://bugs.winehq.org/show_bug.cgi?id=33789

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |e531306f7ad6292fe0deff1533e
                   |                            |25059d88df93c

[Bug 33789] Japanese are displayed vertical in 1.6rc1 but not previous version even it should be display horizontally

http://bugs.winehq.org/show_bug.cgi?id=33789

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #21 from Alexandre Julliard  2013-07-12 13:48:23 CDT ---
Closing bugs fixed in 1.6-rc5.