[Bug 36681] New: ws2_32/tests/sock.c fails on gentoo without IPX support

https://bugs.winehq.org/show_bug.cgi?id=36681

Bug ID: 36681
           Summary: ws2_32/tests/sock.c fails on gentoo without IPX
                    support
           Product: Wine
           Version: 1.7.19
          Hardware: x86
                OS: Linux
            Status: NEW
          Keywords: download, source, testcase
          Severity: normal
          Priority: P2
         Component: winsock
          Assignee: [e-mail]
          Reporter: [e-mail]

Created attachment 48725
  --> https://bugs.winehq.org/attachment.cgi?id=48725
+winsock,+tid,+seh

../../../tools/runtest -q -P wine -T ../../.. -M ws2_32.dll -p
ws2_32_test.exe.so sock && touch sock.ok
fixme:winsock:convert_socktype_w2u unhandled Windows socket type 0
fixme:winsock:WS_EnterSingleProtocolW unknown Protocol <0xffffffff>
fixme:winsock:convert_socktype_w2u unhandled Windows socket type 0
fixme:winsock:WS_EnterSingleProtocolW unknown Protocol <0x0000dead>
fixme:winsock:convert_socktype_w2u unhandled Windows socket type 0
fixme:winsock:convert_proto_w2u unhandled Windows socket protocol 57005
fixme:winsock:convert_socktype_w2u unhandled Windows socket type 57005
fixme:winsock:convert_socktype_w2u unhandled Windows socket type 57005
err:winediag:WSASocketW Failed to create a socket of type SOCK_RAW, this
requires special permissions.
sock.c:2224: Tests skipped: SOCK_RAW is not supported
sock.c:2270: Test failed: Expected 10047, received 10043
sock.c:2271: Tests skipped: IPX is not supported

+winsock attached

Linux aw25 3.13.3-gentoo-devlight-1 #1 SMP Thu Feb 20 00:10:55 Local time zone
must be set--see zic  x86_64 Intel(R) Core(TM) i7 CPU 960 @ 3.20GHz
GenuineIntel GNU/Linux

[Bug 36681] ws2_32/tests/sock.c fails on gentoo without IPX support

https://bugs.winehq.org/show_bug.cgi?id=36681

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |[e-mail]
           Assignee|[e-mail]        |[e-mail]

--- Comment #1 from Bruno Jesus  ---
I'll take a look, I see some similar issues in PC-BSD.

[Bug 36681] ws2_32/tests/sock.c fails on gentoo without IPX support

https://bugs.winehq.org/show_bug.cgi?id=36681

--- Comment #2 from Austin English  ---
(In reply to Bruno Jesus from comment #1)
> I'll take a look, I see some similar issues in PC-BSD.

Any updates Bruno? I still see this:
err:winediag:WSASocketW Failed to create a socket of type SOCK_RAW, this
requires special permissions.
sock.c:2612: Tests skipped: SOCK_RAW is not supported
sock.c:2658: Test failed: Expected 10047, received 10043
sock.c:2659: Tests skipped: IPX is not supported\

I checked my kernel config, and it lacks IPX support:
austin@austin2:~$ zcat /proc/config.gz  | grep -i ipx
# CONFIG_IPX is not set

Removing the broken check allows the test to pass:
diff --git a/dlls/ws2_32/tests/sock.c b/dlls/ws2_32/tests/sock.c
index f3ba11ceb6..a26bf8d563 100644
--- a/dlls/ws2_32/tests/sock.c
+++ b/dlls/ws2_32/tests/sock.c
@@ -2655,7 +2655,7 @@ static void test_WSASocket(void)
     if (sock == INVALID_SOCKET)
     {
         err = WSAGetLastError();
-        ok(err == WSAEAFNOSUPPORT || broken(err == WSAEPROTONOSUPPORT),
"Expected 10047, received %d\n", err);
+        ok(err == WSAEAFNOSUPPORT || err == WSAEPROTONOSUPPORT, "Expected
10047, received %d\n", err);
         skip("IPX is not supported\n");
     }
     else

[Bug 36681] ws2_32/tests/sock.c fails on gentoo without IPX support

https://bugs.winehq.org/show_bug.cgi?id=36681

tokktokk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 36681] ws2_32/tests/sock.c fails on gentoo without IPX support

https://bugs.winehq.org/show_bug.cgi?id=36681

Alex Henrie  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Alex Henrie  ---
The failing test is now marked todo_wine:
https://source.winehq.org/git/wine.git/commitdiff/2be851c955cba142dc306ab5c5...

[Bug 36681] ws2_32/tests/sock.c fails on gentoo without IPX support

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=36681

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED
                 CC|                            |[e-mail]
      Fixed by SHA1|                            |424a379f641465cde3b3a8a5e9a
                   |                            |39e5865f926f2
           Assignee|[e-mail]           |[e-mail]

--- Comment #4 from François Gouget  ---
As far as I can tell this if fixed, i.e. the todo is gone and there is no
failure.

commit 424a379f641465cde3b3a8a5e9a39e5865f926f2
Author:     Alexandre Julliard 
AuthorDate: Tue Nov 20 14:50:21 2018 +0100

server: Return a WSA error code in create_socket.

Signed-off-by: Alexandre Julliard

[Bug 36681] ws2_32/tests/sock.c fails on gentoo without IPX support

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=36681

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  ---
Closing bugs fixed in 8.0-rc1.