[Bug 9628] New: msiexec command line parsing incorrect

http://bugs.winehq.org/show_bug.cgi?id=9628

Summary: msiexec command line parsing incorrect
           Product: Wine
           Version: CVS/GIT
          Platform: PC
               URL: http://www.enterbrain.co.jp/tkool/RPG_XP/eng/download.ht
                    ml
        OS/Version: Linux
            Status: NEW
          Keywords: download, regression
          Severity: minor
          Priority: P2
         Component: wine-msi
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

In bug 9615, the reporter mentioned running the setup program to install the
game does not work.

When running SetupMenu.exe, press the "Install RPG Maker XP" button should
launch the installer. In Wine 0.9.33, pressing that button runs:

msiexec /i c:\path\to\RPG Maker XP\Setup2\RPGXP_102a.msi

In Wine 0.9.34, pressing that button runs:

msiexec c:\path\to\RPG Maker XP\Setup2\RPGXP_102a.msi

The regression is caused by:

commit 54c7b7e81b5542f015dc6e71fc6030ba3919f5d3
Author: Aric Stewart 
Date:   Thu Mar 22 08:20:16 2007 -0500

Revert 7c35db07c35db0... msiexec: Use CommandLineToArgvW instead of
process_args to reduce code duplication.

[Bug 9628] msiexec command line parsing incorrect

http://bugs.winehq.org/show_bug.cgi?id=9628

Kelly Miller  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 9628] msiexec command line parsing incorrect

http://bugs.winehq.org/show_bug.cgi?id=9628

James Hawkins  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from James Hawkins   2007-10-22 00:14:07 ---
*** Bug 10119 has been marked as a duplicate of this bug. ***

[Bug 9628] msiexec command line parsing incorrect

http://bugs.winehq.org/show_bug.cgi?id=9628

James Hawkins  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[e-mail]        |[e-mail]

--- Comment #2 from James Hawkins   2007-11-19 21:53:53 ---
Assigning to myself.

[Bug 9628] msiexec command line parsing incorrect

http://bugs.winehq.org/show_bug.cgi?id=9628

Darragh Bailey  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Darragh Bailey   2007-11-23 14:36:21 ---
Had a look at this and here's what I can make out that is happening in this
case, so I added some traces to take a look at the different command lines run.
Any of the output lines referred to with "bug 9628" are addition traces added
by me to my own code.

When msiexec is called by the setup program the command line is as follows:

trace:msiexec:main bug 9628: argv[0] = ""
trace:msiexec:main bug 9628: argv[1] = "/i"
trace:msiexec:main bug 9628: argv[2] = "Z:\home\dara\tmp\RPG Maker
XP\Setup2\RPGXP_102a.msi"

Currently when the following line is run:
process_args( GetCommandLineW(), &argc, &argvW );

argvW gets returned as
trace:msiexec:main bug 9628: argvW[0] = "L"/i""
trace:msiexec:main bug 9628: argvW[1] = "L"Z:\home\dara\tmp\RPG Maker
XP\Setup2\RPGXP_102a.msi""

and in the loop in the main function which processes the different options
starts of with:

for(i = 1; i < argc; i++)
        {
                WINE_TRACE("argvW[%d] = %s\n", i, wine_dbgstr_w(argvW[i]));

Which dumps to the console output:
trace:msiexec:main argvW[1] = L"Z:\home\dara\tmp\RPG Maker
XP\Setup2\RPGXP_102a.msi"

Which means it skips the "/i" option because its expecting to start off at the
second element.

Changing the code back to what was before the change in comment 1 was made
gives the following:
i.e. after making the following change
-       process_args( GetCommandLineW(), &argc, &argvW );
+       argvW = CommandLineToArgvW( GetCommandLineW(), &argc );

argvW now outputs as:
trace:msiexec:main bug 9628: argvW[0] = "L"""
trace:msiexec:main bug 9628: argvW[1] = "L"/i""
trace:msiexec:main bug 9628: argvW[2] = "L"Z:\home\dara\tmp\RPG Maker
XP\Setup2\RPGXP_102a.msi""

which means that in the main loop after ignoring the first option you see the
following which will get processed:

trace:msiexec:main argvW[1] = L"/i"
trace:msiexec:main argvW[2] = L"Z:\home\dara\tmp\RPG Maker
XP\Setup2\RPGXP_102a.msi"

This suggests to me that the code using CommandLineToArgvW was correct, and
that  fix exposed another bug in the installers of other applications. It also
asks the question, why in this case does the program name 
"c:\windows\system32\msiexec.exe" not appear as the value to argv[0]?

[Bug 9628] msiexec command line parsing incorrect

http://bugs.winehq.org/show_bug.cgi?id=9628

--- Comment #4 from Darragh Bailey   2007-11-23 15:10:05 ---
Looking at the output for traces for xlviewer (the application that the
installer broke due to the original change)

Command line passed into msiexec

trace:msiexec:main bug 9628: argv[0] = "c:\windows\system32\msiexec.exe"
trace:msiexec:main bug 9628: argv[1] = "/I"
trace:msiexec:main bug 9628: argv[2] = "C:\windows\temp\IXP001.TMP\XLVIEW.MSI"
trace:msiexec:main bug 9628: argv[3] = "CDCACHE=2"
trace:msiexec:main bug 9628: argv[4] = "LAUNCHEDFROMSETUP=1"
trace:msiexec:main bug 9628: argv[5] =
"SETUPEXEPATH=C:\windows\temp\IXP001.TMP" SETUPEXENAME=SETUP.EXE   /lpiwaeo
C:\windows\temp\Microsoft"
trace:msiexec:main bug 9628: argv[6] = "Office"
trace:msiexec:main bug 9628: argv[7] = "Excel"
trace:msiexec:main bug 9628: argv[8] = "Viewer"
trace:msiexec:main bug 9628: argv[9] = "2003"
trace:msiexec:main bug 9628: argv[10] = "Setup(0004)_Task(0001).txt CDCACHE=0
DWSETUPLOGFILE=C:\windows\temp\Microsoft"
trace:msiexec:main bug 9628: argv[11] = "Office"
trace:msiexec:main bug 9628: argv[12] = "Excel"
trace:msiexec:main bug 9628: argv[13] = "Viewer"
trace:msiexec:main bug 9628: argv[14] = "2003"
trace:msiexec:main bug 9628: argv[15] = "Setup(0004).txt
DWMSILOGFILE=C:\windows\temp\Microsoft"
trace:msiexec:main bug 9628: argv[16] = "Office"
trace:msiexec:main bug 9628: argv[17] = "Excel"
trace:msiexec:main bug 9628: argv[18] = "Viewer"
trace:msiexec:main bug 9628: argv[19] = "2003"
trace:msiexec:main bug 9628: argv[20] = "Setup(0004)_Task(0001).txt"

which gets converted to the following in the case of process_args
trace:msiexec:main argvW[1] = L"/I"
trace:msiexec:main argvW[2] = L"C:\windows\temp\IXP001.TMP\XLVIEW.MSI"
trace:msiexec:main argvW[3] = L"CDCACHE=2"
trace:msiexec:main argvW[4] = L"LAUNCHEDFROMSETUP=1"
trace:msiexec:main argvW[5] = L"SETUPEXEPATH=C:\windows\temp\IXP001.TMP\"
trace:msiexec:main argvW[6] = L"SETUPEXENAME=SETUP.EXE"
trace:msiexec:main argvW[7] = L"/lpiwaeo"
trace:msiexec:main argvW[8] = L"C:\windows\temp\Microsoft Office Excel
Viewer 2003 Setup(0003)_Task(0001).txt"
trace:msiexec:main argvW[9] = L"CDCACHE=0"
trace:msiexec:main argvW[10] = L"DWSETUPLOGFILE=C:\windows\temp\Microsoft
Office Excel Viewer 2003 Setup(0003).txt"
trace:msiexec:main argvW[11] = L"DWMSILOGFILE=C:\windows\temp\Microsoft
Office Excel Viewer 2003 Setup(0003)_Task(0001).txt"

and to the following when using CommandLineToArgvW

trace:msiexec:main argvW[1] = L"/I"
trace:msiexec:main argvW[2] = L"C:\windows\temp\IXP001.TMP\XLVIEW.MSI"
trace:msiexec:main argvW[3] = L"CDCACHE=2"
trace:msiexec:main argvW[4] = L"LAUNCHEDFROMSETUP=1"
trace:msiexec:main argvW[5] = L"SETUPEXEPATH=C:\windows\temp\IXP001.TMP"
SETUPEXENAME=SETUP.EXE   /lpiwaeo C:\windows\temp\Microsoft"
trace:msiexec:main argvW[6] = L"Office"
trace:msiexec:main argvW[7] = L"Excel"
trace:msiexec:main argvW[8] = L"Viewer"
trace:msiexec:main argvW[9] = L"2003"
trace:msiexec:main argvW[10] = L"Setup(0005)_Task(0001).txt CDCACHE=0
DWSETUPLOGFILE=C:\windows\temp\Microsoft"
trace:msiexec:main argvW[11] = L"Office"
trace:msiexec:main argvW[12] = L"Excel"
trace:msiexec:main argvW[13] = L"Viewer"
trace:msiexec:main argvW[14] = L"2003"
trace:msiexec:main argvW[15] = L"Setup(0005).txt
DWMSILOGFILE=C:\windows\temp\Microsoft"
trace:msiexec:main argvW[16] = L"Office"
trace:msiexec:main argvW[17] = L"Excel"
trace:msiexec:main argvW[18] = L"Viewer"
trace:msiexec:main argvW[19] = L"2003"
trace:msiexec:main argvW[20] = L"Setup(0005)_Task(0001).txt"

Looks to me that the command line being send to msiexec is incorrect in the
first place, and its only due to some unusual behaviour by process_args that
the correct command line is extracted.

[Bug 9628] msiexec command line parsing incorrect

http://bugs.winehq.org/show_bug.cgi?id=9628

--- Comment #5 from Darragh Bailey   2007-11-23 17:15:08 ---

I had to increase the string length limit on the function dbgstr_wn to be able
to see what CreateProcessW was actually passing as the command line when
calling msiexec.

trace:process:CreateProcessW app (null) cmdline
L""c:\windows\system32\msiexec.exe"  /I
C:\windows\temp\IXP002.TMP\XLVIEW.MSI CDCACHE="2" LAUNCHEDFROMSETUP="1"
SETUPEXEPATH="C:\windows\temp\IXP002.TMP\" SETUPEXENAME="SETUP.EXE"  
/lpiwaeo "C:\windows\temp\Microsoft Office Excel Viewer 2003
Setup(0003)_Task(0001).txt" CDCACHE="0"
DWSETUPLOGFILE="C:\windows\temp\Microsoft Office Excel Viewer 2003
Setup(0003).txt" DWMSILOGFILE="C:\windows\temp\Microsoft Office Excel
Viewer 2003 Setup(0003)_Task(0001).txt""

The problem appear to the PROPERTY SETUPEXEPATH

SETUPEXEPATH="C:\windows\temp\IXP002.TMP\"

this actually appears to get to msiexec as

SETUPEXEPATH="C:\windows\temp\IXP002.TMP"

which causes the command line to msiexec to appear internally as the first set
of trace output in comment 4.

If it is passed instead as 
SETUPEXEPATH="C:\windows\temp\IXP002.TMP\"

then the command line appears internally from msiexec's point of view as

trace:msiexec:main bug 9628: argv[0] = "programs/msiexec/msiexec.exe.so"
trace:msiexec:main bug 9628: argv[1] = "/I"
trace:msiexec:main bug 9628: argv[2] = "C:\windows\temp\IXP002.TMP\XLVIEW.MSI"
trace:msiexec:main bug 9628: argv[3] = "CDCACHE=2"
trace:msiexec:main bug 9628: argv[4] = "LAUNCHEDFROMSETUP=1"
trace:msiexec:main bug 9628: argv[5] =
"SETUPEXEPATH=C:\windows\temp\IXP002.TMP"
trace:msiexec:main bug 9628: argv[6] = "SETUPEXENAME=SETUP.EXE"
trace:msiexec:main bug 9628: argv[7] = "/lpiwaeo"
trace:msiexec:main bug 9628: argv[8] = "C:\windows\temp\Microsoft Office Excel
Viewer 2003 Setup(0003)_Task(0001).txt"
trace:msiexec:main bug 9628: argv[9] = "CDCACHE=0"
trace:msiexec:main bug 9628: argv[10] =
"DWSETUPLOGFILE=C:\windows\temp\Microsoft Office Excel Viewer 2003
Setup(0003).txt"
trace:msiexec:main bug 9628: argv[11] = "DWMSILOGFILE=C:\windows\temp\Microsoft
Office Excel Viewer 2003 Setup(0003)_Task(0001).txt"

This certainly looks more correct.

So it looks to me that the original patch was correct and actually highlighted
a bug in the command line processing, where a directory path with a trailing
slash  
enclosed in quotes would get passed through to the target program incorrectly,
thus mucking up the command line arguments being read in by the target program.

Guess that should probably be logged as a separate bug

[Bug 9628] msiexec command line parsing incorrect

http://bugs.winehq.org/show_bug.cgi?id=9628

Timo-Heikki Mäkelä  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail],
                   |                            |[e-mail]

--- Comment #6 from Timo-Heikki Mäkelä   2008-03-12 15:36:57 ---
This bug is still there on 0.9.57. Any fix coming?

[Bug 9628] msiexec command line parsing incorrect

http://bugs.winehq.org/show_bug.cgi?id=9628

--- Comment #7 from Darragh Bailey   2008-03-26 20:10:21 ---
I think I've worked out what's going wrong.

Basically the way RPG Maker XP is calling CreateProcess is by passing in the
msiexec executable as the appname and cmdline as " /i .....". This is slightly
different from most other cases where an application is started by passing the
entire commandline to CreateProcess, or in certain cases duplicating the
exename in the cmdline string.

I've eliminated the problem in build_argv that I previously though was present.

Using the function CommandLineToArgvW instead of process_args results in the
appname being added to the commandline and therefore becomes argv[0], however
it doesn't guarantee that remaining args are reconstructed as required.

So either changes need to be made to CommandLineToArgvW to change what it
returns so that its suitable for msiexec, or modify process_args to also
include the appname.

[Bug 9628] msiexec command line parsing incorrect

http://bugs.winehq.org/show_bug.cgi?id=9628

Juan Lang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from Juan Lang   2008-03-28 12:51:07 ---
*** Bug 12222 has been marked as a duplicate of this bug. ***

[Bug 9628] msiexec command line parsing incorrect

http://bugs.winehq.org/show_bug.cgi?id=9628

--- Comment #9 from Darragh Bailey   2008-04-09 16:52:58 ---
Actually a little more work has shown the following. When using CreateProcess
on windows, if lpApplicationName is used, the value passed will not be added to
the start of the lpCommandline string.

Therefore using GetCommandLine will never retrieve this string. However it
appears that the is a quirk left in the way the CommandLineToArgv function
works. If the string (usually the return value of GetCommandLine) passed in
starts with 1 or more spaces, then the first element of argv (argv[0]) will be
an empty string, and the rest of the command line will be broken up into the
subsequent array elements.

Obviously this means that using 
argvW = CommandLineToArgvW(GetCommandLineW(), &argc);
would fix "Install RPG Maker XP", it would at the moment break the xlviewer
installer.

Right now I've eliminated CreateProcess, the creation of argv sent to child
processes (build_argv), and GetCommandLine from being points of error.

So either CommandLineToArgvW has a bug in how it generates the command line
from the xlviewer installer, or msiexec will need to include a work around for
dealing with this special case.

[Bug 9628] msiexec command line parsing incorrect

http://bugs.winehq.org/show_bug.cgi?id=9628

--- Comment #10 from James Hawkins   2008-04-09 16:55:52 ---
You should really be adding these tests to the test suite.

[Bug 9628] msiexec command line parsing incorrect

http://bugs.winehq.org/show_bug.cgi?id=9628

--- Comment #11 from Darragh Bailey   2008-04-09 18:18:15 ---

I plan to. I've just checked CommandLineToArgvW on windows to confirm that it
garbles the same command line as passed by xlviewer. So I think that the
correct behaviour is that parse_args in msiexec duplicate the special case
behaviour of CommandLineToArgvW as well since it needs to specially reconstruct
the commandline args. That probably makes more sense than using
CommandLineToArgvW and then changing the argv strings.

I'm thinking there should be 3 test cases added
1) Test case for CommandLineToArgvW for special case when first character on
the command line is a space
2) Test case for msiexec for the same special case as CommandLineToArgvW
3) Test case for msiexec for the unusual command line parsing required by
xlviewer, slightly different command line splitting to args than default.

Unless I'm mistaken, there are currently no tests define for msiexec, all msi
tests are done on the dll?

[Bug 9628] msiexec command line parsing incorrect

http://bugs.winehq.org/show_bug.cgi?id=9628

--- Comment #12 from James Hawkins   2008-04-09 18:21:43 ---
If you test CreateProcess, GetCommandLine, and CommandLineToArgv, you don't
need to test msiexec.  We know that it's failing; it's how we can correctly fix
it that matters.  We need to know the exact behaviors of these three APIs in
the circumstances in question, and once we do, we can fix msiexec.

[Bug 9628] msiexec command line parsing incorrect

http://bugs.winehq.org/show_bug.cgi?id=9628

--- Comment #13 from Darragh Bailey   2008-04-14 15:01:16 ---
(In reply to comment #12)
> If you test CreateProcess, GetCommandLine, and CommandLineToArgv, you don't
> need to test msiexec.  We know that it's failing; it's how we can correctly fix
> it that matters.  We need to know the exact behaviors of these three APIs in
> the circumstances in question, and once we do, we can fix msiexec.

Not following the logic.

I've confirmed that CreateProcess, GetCommandLine, and CommandLineToArgv do not
behave on windows in such a manner that would allow msiexec to use them
directly and produce the observed results on windows, i.e. that the xlviewer
and RPG maker installers both function.

So AFAICT, it cannot use a win32 api call to get argv correctly for all cases
that it can handle on windows. Does this not mean that the custom handling of
argv in this case should also result in a test case added to make sure it
doesn't break in the futre? Or is there some other api call that can be used
that will satisfy the required behaviour?

[Bug 9628] msiexec command line parsing incorrect

http://bugs.winehq.org/show_bug.cgi?id=9628

--- Comment #14 from Dan Kegel   2008-04-14 23:41:25 ---
I think we need custom handling, and we need a test case.

[Bug 9628] msiexec command line parsing incorrect

http://bugs.winehq.org/show_bug.cgi?id=9628

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #15 from Louis Lenders   2008-05-14 09:59:51 ---
*** Bug 13209 has been marked as a duplicate of this bug. ***

[Bug 9628] msiexec command line parsing incorrect

http://bugs.winehq.org/show_bug.cgi?id=9628

Alexej Dwina  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 9628] msiexec command line parsing incorrect

http://bugs.winehq.org/show_bug.cgi?id=9628

James Hawkins  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #16 from James Hawkins   2008-10-15 12:27:36 ---
*** Bug 15629 has been marked as a duplicate of this bug. ***

[Bug 9628] msiexec command line parsing incorrect

http://bugs.winehq.org/show_bug.cgi?id=9628

--- Comment #17 from Patrick   2008-10-15 15:30:24 ---
(In reply to comment #14)
> I think we need custom handling, and we need a test case.

When you say you need a test case, are you saying you need an example of the
problem when trying to install an application?

I encounter the problem when I try to install "swb32c100.exe" which can be
found at:

http://www.bpsoft.com/downloads/
SIP WORKBENCH 1.0.0 for Windows XP

[Bug 9628] msiexec command line parsing incorrect

http://bugs.winehq.org/show_bug.cgi?id=9628

--- Comment #18 from Dan Kegel   2008-10-15 17:31:10 ---
That's handy to know, but no, I meant a conformance test.
Fortunately, Aric is working on one, see
http://kegel.com/wine/patchwatcher/results/3118.txt

[Bug 9628] msiexec command line parsing incorrect

http://bugs.winehq.org/show_bug.cgi?id=9628

Aric Stewart  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #19 from Aric Stewart   2008-10-16 06:59:30 ---
Yes one of our customers is having this problem so I am working to correct it.
I have submitted patches which give a first round of testing for both
CreateProcess as well as CommandLineToArgvW demonstrating the information in
this bug.

Once they are in I will submit a patch for msiexec that corrects its processing
of command lines and hopefully this will be fixed for people.

[Bug 9628] msiexec command line parsing incorrect

http://bugs.winehq.org/show_bug.cgi?id=9628

Aric Stewart  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED

--- Comment #20 from Aric Stewart   2008-10-23 13:21:17 ---
Should be corrected by 8d7fc617177e0593fd6d0461fc6c9e74be41fe00

[Bug 9628] msiexec command line parsing incorrect

http://bugs.winehq.org/show_bug.cgi?id=9628

--- Comment #21 from Patrick   2008-10-23 13:52:09 ---
(In reply to comment #20)
> Should be corrected by 8d7fc617177e0593fd6d0461fc6c9e74be41fe00

Sorry for my ignorance, but what is this number, and what do I do with it?
I have looked around FAQs etc and can't find any explanation.

[Bug 9628] msiexec command line parsing incorrect

http://bugs.winehq.org/show_bug.cgi?id=9628

--- Comment #22 from Aric Stewart   2008-10-23 13:56:33 ---
That is the commit SH1ID  really you should not have to worry about it.  The
commit was done today so any builds done with the source tree after today
should have the fix in it already.

[Bug 9628] msiexec command line parsing incorrect

http://bugs.winehq.org/show_bug.cgi?id=9628

--- Comment #23 from Austin English   2008-10-23 13:56:53 ---
(In reply to comment #21)
> (In reply to comment #20)
> > Should be corrected by 8d7fc617177e0593fd6d0461fc6c9e74be41fe00
>
> Sorry for my ignorance, but what is this number, and what do I do with it?
> I have looked around FAQs etc and can't find any explanation.

It's a commit id. The patch fixing it was committed to git. See:

http://source.winehq.org/git/wine.git/?a=commitdiff;h=8d7fc617177e0593fd6d04...

To test, update to the latest git or wait for wine 1.1.7.

[Bug 9628] msiexec command line parsing incorrect

http://bugs.winehq.org/show_bug.cgi?id=9628

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #24 from Alexandre Julliard   2008-10-24 11:12:41 ---
Closing bugs fixed in 1.1.7.

[Bug 9628] msiexec command line parsing incorrect

http://bugs.winehq.org/show_bug.cgi?id=9628

--- Comment #25 from Alexandre Julliard   2008-12-23 05:48:30 ---
*** Bug 12222 has been marked as a duplicate of this bug. ***

[Bug 9628] msiexec command line parsing incorrect

http://bugs.winehq.org/show_bug.cgi?id=9628

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|CVS/GIT                     |unspecified

[Bug 9628] msiexec command line parsing incorrect

http://bugs.winehq.org/show_bug.cgi?id=9628

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |8d7fc617177e0593fd6d0461fc6
                   |                            |c9e74be41fe00

[Bug 9628] msiexec command line parsing incorrect

http://bugs.winehq.org/show_bug.cgi?id=9628

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
    Regression SHA1|                            |54c7b7e81b5542f015dc6e71fc6
                   |                            |030ba3919f5d3

[Bug 9628] msiexec command line parsing incorrect

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=9628

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|minor                       |normal
                URL|http://www.enterbrain.co.jp |https://web.archive.org/web
                   |/tkool/RPG_XP/eng/download. |/20120606155403/http://geno
                   |html                        |tec.games.tucows.com/files/
                   |                            |RPG_Maker_XP.zip
                 CC|                            |[e-mail]
            Version|unspecified                 |0.9.34.

--- Comment #26 from Anastasius Focht  ---
Hello folks,

adding stable download link via Internet Archive for documentation.

RPG Maker XP 1.02a

Old mirror links on original vendor site snapshot in 2007:

https://web.archive.org/web/20070202022721/http://www.enterbrain.co.jp/tkool...

As expected almost all download links are broken (even archive.org) but I
digged out a working one via tucows.com.

https://web.archive.org/web/20070202022721/http://www.tucows.com/preview/421...

Download page with actual mirror links:

https://web.archive.org/web/20080212083434/http://www.tucows.com/download.ht...

One-liner to extract the original mirror links from web page and use
archive.org CDX/C API to query for any existing snapshots.

--- snip ---
$ wget -qO-
"https://web.archive.org/web/20080212083434/http://www.tucows.com/download.ht..."
| \
   sed -n "s/.*dl('([^"]*)',.*/\1/p" | \
   sed -e 's/.*http://(.*)/\1/' | \
   xargs -I {} -exec sh -c 'echo "Checking: {}" ; \
   wget http://web.archive.org/cdx/search/cdx?url=%22%7B%7D" -q -O - | \
   grep application/ ; sleep 10' ;

Checking: rhnet.games.tucows.com/files/RPG_Maker_XP.zip
Checking: netnitco.games.tucows.com/files/RPG_Maker_XP.zip
Checking: epix.games.tucows.com/files/RPG_Maker_XP.zip
Checking: theplanet.games.tucows.com/files/RPG_Maker_XP.zip
Checking: blueyonder.games.tucows.com/files/RPG_Maker_XP.zip
Checking: chariot.games.tucows.com/files/RPG_Maker_XP.zip
Checking: filearena.games.tucows.com/files/RPG_Maker_XP.zip
Checking: velocity.games.tucows.com/files/RPG_Maker_XP.zip
Checking: datafast.games.tucows.com/files/RPG_Maker_XP.zip
Checking: sercomtel.games.tucows.com/files/RPG_Maker_XP.zip
Checking: digsys.games.tucows.com/files/RPG_Maker_XP.zip
Checking: metropolis-inter.games.tucows.com/files/RPG_Maker_XP.zip
Checking: cytanet.games.tucows.com/files/RPG_Maker_XP.zip
Checking: ntua.games.tucows.com/files/RPG_Maker_XP.zip
Checking: kapatel.games.tucows.com/files/RPG_Maker_XP.zip
Checking: i-cable.games.tucows.com/files/RPG_Maker_XP.zip
Checking: gamingplace.externet.hu/files/RPG_Maker_XP.zip
Checking: games.012.net.il/files/RPG_Maker_XP.zip
Checking: fastnet.games.tucows.com/files/RPG_Maker_XP.zip
Checking: fastweb.games.tucows.com/files/RPG_Maker_XP.zip
Checking: onvol.games.tucows.com/files/RPG_Maker_XP.zip
Checking: namibia.games.tucows.com/files/RPG_Maker_XP.zip
Checking: planet.games.tucows.com/files/RPG_Maker_XP.zip
Checking: essentkabelcom.games.tucows.com/files/RPG_Maker_XP.zip
Checking: easynetnl.games.tucows.com/files/RPG_Maker_XP.zip
Checking: dips.games.tucows.com/files/RPG_Maker_XP.zip
Checking: clix.games.tucows.com/files/RPG_Maker_XP.zip
Checking: netvisao.games.tucows.com/files/RPG_Maker_XP.zip
Checking: mweb.games.tucows.com/files/RPG_Maker_XP.zip
Checking: mundo-r.games.tucows.com/files/RPG_Maker_XP.zip
aChecking: dataphone.games.tucows.com/files/RPG_Maker_XP.zip
Checking: port80.games.tucows.com/files/RPG_Maker_XP.zip
Checking: genotec.games.tucows.com/files/RPG_Maker_XP.zip
com,tucows,games,genotec)/files/rpg_maker_xp.zip 20120606155403
http://genotec.games.tucows.com/files/RPG_Maker_XP.zip application/zip 200
4UVNBGJEPYNQINJ6PWPEEXRE7F26ACXH 30987750
Checking: ows.games.tucows.com/files/RPG_Maker_XP.zip
Checking: tulumba.games.tucows.com/files/RPG_Maker_XP.zip
--- snip ---

Wohoo!

https://web.archive.org/web/20120606155403/http://genotec.games.tucows.com/f...

$ sha1sum RPG_Maker_XP.zip 
e52ad099247e1b04353e7d9e425e24f975e00ae7  RPG_Maker_XP.zip

$ du -sh RPG_Maker_XP.zip 
30M    RPG_Maker_XP.zip

--- snip ---
$ 7z l RPG_Maker_XP.zip

Listing archive: RPG_Maker_XP.zip

--
Path = RPG_Maker_XP.zip
Type = zip
Physical Size = 31035032

Date      Time    Attr         Size   Compressed  Name
------------------- ----- ------------ ------------  ------------------------
2005-08-30 11:01:00 ....A      1707856      1668189  RPG Maker XP/RPG Maker
XP/Setup1/InstMsiA.Exe
2005-08-30 11:02:00 ....A      1821008      1783150  RPG Maker XP/RPG Maker
XP/Setup1/InstMsiW.Exe
2005-08-30 11:15:00 ....A     21741568     21422183  RPG Maker XP/RPG Maker
XP/Setup1/RTP_Standard_102.msi
2005-08-30 11:15:00 ....A       110592        60306  RPG Maker XP/RPG Maker
XP/Setup1/Setup.Exe
2005-08-30 11:15:00 ....A           47           47  RPG Maker XP/RPG Maker
XP/Setup1/Setup.Ini
2005-08-30 11:16:00 ....A      1707856      1668189  RPG Maker XP/RPG Maker
XP/Setup2/InstMsiA.Exe
2005-08-30 11:17:00 ....A      1821008      1783150  RPG Maker XP/RPG Maker
XP/Setup2/InstMsiW.Exe
2005-09-20 13:04:00 ....A      2654208      2407618  RPG Maker XP/RPG Maker
XP/Setup2/RPGXP_102a.msi
2005-08-30 11:18:00 ....A       110592        60306  RPG Maker XP/RPG Maker
XP/Setup2/Setup.Exe
2005-09-20 13:04:00 ....A           41           41  RPG Maker XP/RPG Maker
XP/Setup2/Setup.Ini
2005-08-30 11:00:00 ....A       323584       178723  RPG Maker XP/RPG Maker
XP/SetupMenu.exe
------------------- ----- ------------ ------------  ------------------------
2005-09-20 13:04:00           31998360     31031902  11 files

Regards