[Bug 33164] New: row-resize / col-resize cursor is wrong (Listview)

http://bugs.winehq.org/show_bug.cgi?id=33164

Bug #: 33164
           Summary: row-resize / col-resize cursor is wrong (Listview)
           Product: Wine
           Version: 1.5.25
          Platform: x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: winex11.drv
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

I have install an X cursor theme named JYxNeon, and then I find col-resize
cursor is displayed wrongly in a Listview control. col-resize should be
vertical double arrows but is displayed horizontal.
  If I swap row-resize/col-resize icon in the cursor theme, this problem can be
solved. But when I look into Wine source, I find it may be a bug in winex11. In
mouse.c, row-resize/col-resize is wrongly used in comctl32_cursors. The
resource id of 105/106 in comctl32 should be col-resize, and 135 should be
row-resize.

[Bug 33164] row-resize / col-resize cursor is wrong (Listview)

http://bugs.winehq.org/show_bug.cgi?id=33164

--- Comment #1 from Jinhui Chen  2013-03-10 05:50:00 CDT ---
Sorry, I made a mistake in last post: col-resize should be
horizontal double arrows but is displayed vertical.
  But the bug is still there. I have sent a patch:
http://www.winehq.org/pipermail/wine-patches/2013-March/122745.html
  Please have a look.

[Bug 33164] row-resize / col-resize cursor is wrong (Listview)

http://bugs.winehq.org/show_bug.cgi?id=33164

Qian Hong  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch
                 CC|                            |[e-mail]

[Bug 33164] row-resize / col-resize cursor is wrong (Listview)

http://bugs.winehq.org/show_bug.cgi?id=33164

Jinhui Chen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.5.25                      |1.7.4

--- Comment #2 from Jinhui Chen  2013-10-24 04:29:23 CDT ---
Still issue in Wine 1.7.4

[Bug 33164] row-resize / col-resize cursor is wrong (Listview)

http://bugs.winehq.org/show_bug.cgi?id=33164

--- Comment #3 from Qian Hong  2013-10-24 04:50:39 CDT ---
Hi Jinhui Chen,

Thanks for reporting, I'd like to help you get your patch in as possible as I
can, however I'm not sure I understand the bug, could you describe in more
details?

1. Where to download the X cursor theme you test?
2. (optional) How do you install the X cursor theme
3. What's wrong exactly? Could you provide working screenshot and broken
screenshot for comparison? If there is any application needed for reproducing
the bug, please provide a download link.

[Bug 33164] row-resize / col-resize cursor is wrong (Listview)

http://bugs.winehq.org/show_bug.cgi?id=33164

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.7.4                       |1.5.25

[Bug 33164] row-resize / col-resize cursor is wrong (Listview)

http://bugs.winehq.org/show_bug.cgi?id=33164

--- Comment #4 from Jinhui Chen  2013-10-25 23:22:49 CDT ---
Hi Qian Hong,
> - Where to download the X cursor theme you test?

http://gnome-look.org/content/show.php/jyXNeon+?content=157292
> - (optional) How do you install the X cursor theme

unpack the downloaded file (157292-vxNeon024.tar.gz) to
/usr/share/cursors/xorg-x11, and then modify/create the file
"/usr/share/cursors/xorg-x11/default/index.theme" to:

[Icon Theme]
Inherits=JYxNeon
> - What's wrong exactly?

I will upload working screenshot and broken screenshot. Please see attachments.

[Bug 33164] row-resize / col-resize cursor is wrong (Listview)

http://bugs.winehq.org/show_bug.cgi?id=33164

--- Comment #5 from Jinhui Chen  2013-10-25 23:26:54 CDT ---
Created attachment 46412
  --> http://bugs.winehq.org/attachment.cgi?id=46412
broken screenshot

[Bug 33164] row-resize / col-resize cursor is wrong (Listview)

http://bugs.winehq.org/show_bug.cgi?id=33164

--- Comment #6 from Jinhui Chen  2013-10-26 00:04:45 CDT ---
Created attachment 46413
  --> http://bugs.winehq.org/attachment.cgi?id=46413
working screenshot

[Bug 33164] row-resize / col-resize cursor is wrong (Listview)

http://bugs.winehq.org/show_bug.cgi?id=33164

--- Comment #7 from Qian Hong  2013-10-27 14:03:24 CDT ---
Hello,

Thanks, I've reproduce the bug, confirming.

@@ -868,7 +868,7 @@ static const struct cursor_font_fallback fallbacks[] =
     { "circle",              XC_circle },
     { "clock",               XC_clock },
     { "coffee_mug",          XC_coffee_mug },
-    { "col-resize",          XC_sb_v_double_arrow },
+    { "row-resize",          XC_sb_v_double_arrow },
     { "cross",               XC_cross },
     { "cross_reverse",       XC_cross_reverse },
     { "crosshair",           XC_crosshair },
@@ -905,7 +905,7 @@ static const struct cursor_font_fallback fallbacks[] =
     { "right_side",          XC_right_side },
     { "right_tee",           XC_right_tee },
     { "rightbutton",         XC_rightbutton },
-    { "row-resize",          XC_sb_h_double_arrow },
+    { "col-resize",          XC_sb_h_double_arrow },
     { "rtl_logo",            XC_rtl_logo },
     { "sailboat",            XC_sailboat },
     { "sb_down_arrow",       XC_sb_down_arrow },

This part is wrong, fallbacks[] should be a sorted array, find_fallback_shape()
uses a bsearch() to find the fallback by name, your change breaks the order.

Other wise the patch looks good to me, please correct the wrong part and send a
"try 2", see http://wiki.winehq.org/SubmittingPatches for more details.

Thanks for the work!

[Bug 33164] row-resize / col-resize cursor is wrong (Listview)

http://bugs.winehq.org/show_bug.cgi?id=33164

Qian Hong  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #8 from Qian Hong  2013-10-27 14:04:04 CDT ---
Confirming.

[Bug 33164] row-resize / col-resize cursor is wrong (Listview)

http://bugs.winehq.org/show_bug.cgi?id=33164

--- Comment #9 from Jinhui Chen  2013-10-27 22:33:24 CDT ---
OK, I have made changes and summit a [Patch]try 2: Bug 33164 - row-resize /
col-resize cursor is wrong (Listview)‏.

[Bug 33164] row-resize / col-resize cursor is wrong (Listview)

http://bugs.winehq.org/show_bug.cgi?id=33164

--- Comment #10 from Qian Hong  2013-10-28 01:41:40 CDT ---
(In reply to comment #9)
> OK, I have made changes and summit a [Patch]try 2: Bug 33164 - row-resize /
> col-resize cursor is wrong (Listview)‏.

Thanks for the update. Next time please read
http://wiki.winehq.org/SubmittingPatches before submitting, there is some space
to improve, for example, you could use a better subject line
(http://wiki.winehq.org/SubmittingPatches#head-fea51bfdf6a29105a9a6fc6f5886ad...
)

Also please include a short "change log" in your newer patch, describing what
has improved from last patch, this will help to make the reviewer's life more
easier :)

[Bug 33164] row-resize / col-resize cursor is wrong (Listview)

http://bugs.winehq.org/show_bug.cgi?id=33164

--- Comment #11 from Jinhui Chen  2013-10-28 02:13:44 CDT ---
OK, I will be careful next time. Thank you!

[Bug 33164] row-resize / col-resize cursor is wrong (Listview)

http://bugs.winehq.org/show_bug.cgi?id=33164

--- Comment #12 from Qian Hong  2013-10-28 15:20:41 CDT ---
Hi Jinhui, your patch is marked as 'formatting' in
http://source.winehq.org/patches/

I would suggest to improve the subject line and generate a new patch using git,
see http://wiki.winehq.org/GitWine for more details.

[Bug 33164] row-resize / col-resize cursor is wrong (Listview)

http://bugs.winehq.org/show_bug.cgi?id=33164

--- Comment #13 from Jinhui Chen  2013-10-29 06:02:30 CDT ---
Sorry, there is an unnecessary line in the end of the patch. I have regenerated
a new patch file and summit a "try 3".

[Bug 33164] row-resize / col-resize cursor is wrong (Listview)

http://bugs.winehq.org/show_bug.cgi?id=33164

--- Comment #14 from Qian Hong  2013-10-29 09:21:53 CDT ---
(In reply to comment #13)
> Sorry, there is an unnecessary line in the end of the patch. I have regenerated
> a new patch file and summit a "try 3".

Hi, next time please also improve the subject line, you can have a look at git
log, such as: 
crypt32: Avoid NULL ptr dereferences before checks.
d3d9: Update locked_rect only if wined3d_surface_map succeeds.

You can name your patch like winex11: xxx xxx xxx ...

All these advice could be found in http://wiki.winehq.org/SubmittingPatches

[Bug 33164] row-resize / col-resize cursor is wrong (Listview)

http://bugs.winehq.org/show_bug.cgi?id=33164

--- Comment #15 from Qian Hong  2013-11-12 04:01:18 CST ---
(In reply to comment #13)
> Sorry, there is an unnecessary line in the end of the patch. I have regenerated
> a new patch file and summit a "try 3".

Hi, Jinhui, your patch is still marked as 'format issue', please fix your email
client or switch to another email client, thanks!

If you need help, you could send your patch to me before sending to
wine-patches.

[Bug 33164] row-resize / col-resize cursor is wrong (Listview)

http://bugs.winehq.org/show_bug.cgi?id=33164

--- Comment #16 from Jerome Leclanche  ---
Jinhui Chen, could you send the patch to the list as Qian explained? (see his
link)
It'd be great to get this fixed.

[Bug 33164] row-resize / col-resize cursor is wrong (Listview)

https://bugs.winehq.org/show_bug.cgi?id=33164

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 33164] row-resize / col-resize cursor is wrong (Listview)

https://bugs.winehq.org/show_bug.cgi?id=33164

--- Comment #17 from Nikolay Sivov  ---
Jinhui, do you plan to send this patch for a review?

[Bug 33164] row-resize / col-resize cursor is wrong (Listview)

https://bugs.winehq.org/show_bug.cgi?id=33164

Sebastian Lackner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 33164] row-resize / col-resize cursor is wrong (Listview)

https://bugs.winehq.org/show_bug.cgi?id=33164

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |366ed5495c33e1a8b1c60a84450
                   |                            |93f70eae34a38
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #18 from Nikolay Sivov  ---
Fixed with 366ed5495c33e1a8b1c60a8445093f70eae34a38.

[Bug 33164] row-resize / col-resize cursor is wrong (Listview)

https://bugs.winehq.org/show_bug.cgi?id=33164

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #19 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.40.