https://bugs.winehq.org/show_bug.cgi?id=36624
Bug ID: 36624 Summary: valgrind shows uninitialized memory in kernel32/tests/console.c Product: Wine Version: 1.7.19 Hardware: x86 OS: Linux Status: NEW Keywords: download, source, testcase Severity: normal Priority: P2 Component: kernel32 Assignee: wine-bugs@winehq.org Reporter: austinenglish@gmail.com
An old valgrind warning that I don't for.. ==18074== Syscall param writev(vector[...]) points to uninitialised byte(s) ==18074== at 0x4E952886: writev (in /usr/lib/libc-2.18.so) ==18074== by 0x7BC7FE6F: send_request (server.c:213) ==18074== by 0x7BC80001: wine_server_call (server.c:294) ==18074== by 0x7B82E0ED: wine_server_call_err (server.h:61) ==18074== by 0x7B82F344: WriteConsoleInputW (console.c:533) ==18074== by 0x4647B58: WCUSER_GenerateMouseInputRecord (user.c:1092) ==18074== by 0x4648005: WCUSER_Proc (user.c:1160) ==18074== by 0x535C5C1: ??? (winproc.c:173) ==18074== by 0x535C736: call_window_proc (winproc.c:244) ==18074== by 0x535E8CF: WINPROC_call_window (winproc.c:900) ==18074== by 0x531FC04: DispatchMessageW (message.c:4019) ==18074== by 0x4648BDF: WCUSER_MainLoop (user.c:1387) ==18074== by 0x464BDA6: WinMain (wineconsole.c:854) ==18074== by 0x464C09F: main (exe_main.c:49) ==18074== Address 0x4d0f74e is on thread 1's stack ==18074== Uninitialised value was created by a stack allocation ==18074== at 0x4647A54: WCUSER_GenerateMouseInputRecord (user.c:1071) ==18074==
from http://www.winehq.org/pipermail/wine-devel/2008-November/070539.html: the issue in fixing WCUSER_GenerateMouseInputRecord() is that we'll still get the same warning in valgrind from a partly initialized INPUT_RECORD from any caller to WriteConsoleInput (and the code in wineconsole is perfectly correct as it only assigns the fields it needs for a MouseEvent) the cleanest fix should be in WriteConsoleInput not to pass the undefined parts to wineserver (or to set them to zero)
https://bugs.winehq.org/show_bug.cgi?id=36624
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |valgrind