[Bug 21254] New: Word 97 needs native oleaut32 to record the first macro

http://bugs.winehq.org/show_bug.cgi?id=21254

Summary: Word 97 needs native oleaut32 to record the first
                    macro
           Product: Wine
           Version: unspecified
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: oleaut32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=25550)
 --> (http://bugs.winehq.org/attachment.cgi?id=25550)
Console log from first attempt to record a macro without any overrides (results
in failure)

This is a follow-up to bug 11415, which has been fixed for all the 200x
versions of Word, but not entirely for Word 97.

In wine-1.1.35-364-g9dc584d, Word 97 needs native oleaut32 (copied from XP) in
order to record a macro the first time. Once the first macro has been
successfully recorded, however, you can remove the override from winecfg,
delete the native oleaut32.dll from Wine's system32 and restore the fake one,
and Word 97 will continue to be able to record and play macros just fine. (I've
tested this multiple times, with the same results.)

The typelib errors and fixmes in the attached console log are not present in
subsequent runs after the problem has been fixed by the temporary override.

[Bug 21254] Word 97 needs native oleaut32 to record the first macro

http://bugs.winehq.org/show_bug.cgi?id=21254

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |1.1.35

[Bug 21254] Word 97 needs native oleaut32 to record the first macro

http://bugs.winehq.org/show_bug.cgi?id=21254

Rosanne DiMesio  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #1 from Rosanne DiMesio   2010-05-30 22:29:55 ---
Still present in 1.2-rc2.

[Bug 21254] Word 97 needs native oleaut32 to record the first macro

http://bugs.winehq.org/show_bug.cgi?id=21254

--- Comment #2 from Nikolay Sivov  2010-12-19 17:51:11 CST ---
What is a status with wine-1.3.9-164-g17e66e0 ?

[Bug 21254] Word 97 needs native oleaut32 to record the first macro

http://bugs.winehq.org/show_bug.cgi?id=21254

Rosanne DiMesio  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25550|0                           |1
        is obsolete|                            |

--- Comment #3 from Rosanne DiMesio  2010-12-19 20:33:54 CST ---
Created an attachment (id=32548)
 --> (http://bugs.winehq.org/attachment.cgi?id=32548)
failure recording macro

Still an issue. Attaching console output from testing in
wine-1.3.9-164-g17e66e0.

[Bug 21254] Word 97 needs native oleaut32 to record the first macro

http://bugs.winehq.org/show_bug.cgi?id=21254

--- Comment #4 from Nikolay Sivov  2011-01-04 05:59:15 CST ---
Please attach a +typelib2,+tid for that (with current git wine of course). Now
we should get past this line:

---
fixme:typelib2:ICreateTypeInfo2_fnSetVarHelpContext (0x1433340,0,0), stub!
---

[Bug 21254] Word 97 needs native oleaut32 to record the first macro

http://bugs.winehq.org/show_bug.cgi?id=21254

Rosanne DiMesio  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #32548|0                           |1
        is obsolete|                            |

--- Comment #5 from Rosanne DiMesio  2011-01-04 12:30:37 CST ---
Created an attachment (id=32725)
 --> (http://bugs.winehq.org/attachment.cgi?id=32725)
+typelib2,+tid in wine-1.3.10-304-gf859535

In wine-1.3.10-304-gf859535 it now crashes trying to record the first macro
without overrides.

[Bug 21254] Word 97 needs native oleaut32 to record the first macro

http://bugs.winehq.org/show_bug.cgi?id=21254

--- Comment #6 from Nikolay Sivov  2011-01-04 13:14:15 CST ---
Created an attachment (id=32726)
 --> (http://bugs.winehq.org/attachment.cgi?id=32726)
patch

Try this one please on top of wine-1.3.10-304-gf859535.

[Bug 21254] Word 97 needs native oleaut32 to record the first macro

http://bugs.winehq.org/show_bug.cgi?id=21254

--- Comment #7 from Rosanne DiMesio  2011-01-04 16:49:23 CST ---
Created an attachment (id=32727)
 --> (http://bugs.winehq.org/attachment.cgi?id=32727)
+typelib2,+tid with patch

Still crashes with the patch.

[Bug 21254] Word 97 needs native oleaut32 to record the first macro

http://bugs.winehq.org/show_bug.cgi?id=21254

--- Comment #8 from Nikolay Sivov  2011-01-16 12:23:25 CST ---
It fails this check most likely, probably because it failed to add parameters
or so:

---
    /* cNames == cParams for put or putref accessor, cParams+1 otherwise */
    if(cNames != iter->u.data[5] + (ctl2_get_invokekind(iter) &
(INVOKE_PROPERTYPUT|INVOKE_PROPERTYPUTREF) ? 0 : 1))
        return TYPE_E_ELEMENTNOTFOUND;
---

Please move this line:
---
    TRACE("function name %s\n", debugstr_w(names[0]));
---

before if () I mentioned and attach new log if specified trace output appears
in it just before a crash, it's interesting to determined a problematic method
name.

[Bug 21254] Word 97 needs native oleaut32 to record the first macro

http://bugs.winehq.org/show_bug.cgi?id=21254

--- Comment #9 from Rosanne DiMesio  2011-01-16 22:06:53 CST ---
Should I do that with or without the patch?

[Bug 21254] Word 97 needs native oleaut32 to record the first macro

http://bugs.winehq.org/show_bug.cgi?id=21254

--- Comment #10 from Nikolay Sivov  2011-01-17 14:26:45 CST ---
It doesn't matter I guess, turns out it's useless for Word 97, it was tested
with 2007 only. My guess is that even if ::AddFuncDesc() fails to add
description and Word doesn't check that, it's still interesting to figure out a
method name. I'll look at its definition in native Office typelib after that.

[Bug 21254] Word 97 needs native oleaut32 to record the first macro

http://bugs.winehq.org/show_bug.cgi?id=21254

--- Comment #11 from Nikolay Sivov  2011-01-23 09:19:32 CST ---
Ok, I can see a problem. It's a INVOKE_PROPERTYPUTREF method that fails on
::SetFuncAndParamNames() because of parameters count mismatch.

It's about to set a function name (cNames == 1) and internal count is set to
4432 for me (probably garbage value).

[Bug 21254] Word 97 needs native oleaut32 to record the first macro

http://bugs.winehq.org/show_bug.cgi?id=21254

--- Comment #12 from Nikolay Sivov  2011-01-23 18:06:20 CST ---
Looks really bad. Seems to me that typeinfo data is corrupted somehow with our
logic. I don't see any harmful calls between construction and broken call, but
at that point data is really corrupted - function count value for it is garbage
while before that it's properly initialized to 0. I'll try to valgrind it
first, maybe that will show more bugs at least, after that the only way is to
go step by step in segment allocation logic probably.

[Bug 21254] Word 97 needs native oleaut32 to record the first macro

http://bugs.winehq.org/show_bug.cgi?id=21254

nathan.n  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 21254] Word 97 needs native oleaut32 to record the first macro

http://bugs.winehq.org/show_bug.cgi?id=21254

--- Comment #13 from Rosanne DiMesio  2012-02-04 21:21:15 CST ---
Still present in 1.4-rc2.

[Bug 21254] Word 97 needs native oleaut32 to record the first macro

http://bugs.winehq.org/show_bug.cgi?id=21254

--- Comment #14 from Nikolay Sivov  2013-09-11 14:00:31 CDT ---
Hi, Rosanne.

Could you please retest with current wine? It has some typelib fixes that could
help.

[Bug 21254] Word 97 needs native oleaut32 to record the first macro

http://bugs.winehq.org/show_bug.cgi?id=21254

Rosanne DiMesio  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #15 from Rosanne DiMesio  2013-09-11 15:41:01 CDT ---
Fixed in wine-1.7.1-208-g10251e5.

[Bug 21254] Word 97 needs native oleaut32 to record the first macro

http://bugs.winehq.org/show_bug.cgi?id=21254

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #16 from Alexandre Julliard  2013-09-13 13:20:10 CDT ---
Closing bugs fixed in 1.7.2.

[Bug 21254] Word 97 needs native oleaut32 to record the first macro

http://bugs.winehq.org/show_bug.cgi?id=21254

Saulius K.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]