[Bug 56824] New: Postal 2 (20th Anniversary update) crashes when loading the map

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56824

Bug ID: 56824
           Summary: Postal 2 (20th Anniversary update) crashes when
                    loading the map
           Product: Wine
           Version: unspecified
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Keywords: regression
          Severity: normal
          Priority: P2
         Component: msvcrt
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
   Regression SHA1: 2fc773199080dedbe64a33ef66be02a4f44bcd08
      Distribution: ArchLinux

This was tested with the GOG.com version of the game, updated to the 20th
Anniversary update. Can't reproduce the problem with the original Postal 2
(released back in 2003).

The game loads the main menu fine. When I start a new game or load a saved
game, the game exception handler throws a window about a critical error and the
game quits.
Occasionally the level is loaded but there are severe issues: world geometry is
broken, the player falls through the floor and he's stuck. In a matter of
seconds the window about critical error is displayed and the game bails out.

Reverting commit 2fc773199080dedbe64a33ef66be02a4f44bcd08
on top of current git fixes the crash.

Plain terminal output doesn't show anything relevant, let me know if you need
debug logs.

wine-9.10-171-g8ba51a6f711

[Bug 56824] Postal 2 (20th Anniversary update) crashes when loading the map

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56824

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Fabian Maurer  ---
That's weird, that commit shouldn't change anything. I guess I can't test with
the steam version?

[Bug 56824] Postal 2 (20th Anniversary update) crashes when loading the map

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56824

--- Comment #2 from Béla Gyebrószki  ---
(In reply to Fabian Maurer from comment #1)
> That's weird, that commit shouldn't change anything. I guess I can't test
> with the steam version?

The bug is reproducible with the Steam version too.
https://store.steampowered.com/app/223470/POSTAL_2/

[Bug 56824] Postal 2 (20th Anniversary update) crashes when loading the map

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56824

--- Comment #3 from Fabian Maurer  ---
Created attachment 76633
  --> https://bugs.winehq.org/attachment.cgi?id=76633
Test program

Attaching a test program that uses _libm_sse2_sqrt_precise to calculate the
square root of 4

This should be 2, but on current wine it results in 4.

[Bug 56824] Postal 2 (20th Anniversary update) crashes when loading the map

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56824

--- Comment #4 from Fabian Maurer  ---
Created attachment 76634
  --> https://bugs.winehq.org/attachment.cgi?id=76634
Patch that should fix the issue

I kinda misread this as "Portal 2", so I can't actually test. Although I think
I found the underlying issue.

Can you please test the attached patch? This should fix the issue.

[Bug 56824] Postal 2 (20th Anniversary update) crashes when loading the map

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56824

--- Comment #5 from Béla Gyebrószki  ---
(In reply to Fabian Maurer from comment #4)
> Created attachment 76634 [details]
> Patch that should fix the issue
>
> Can you please test the attached patch? This should fix the issue.

The patch does fix the problem, thank you.

[Bug 56824] Postal 2 (20th Anniversary update) crashes when loading the map

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56824

--- Comment #6 from Fabian Maurer  ---
You're welcome, thank you for the regression test and testing!

I created a MR here: https://gitlab.winehq.org/wine/wine/-/merge_requests/5837

[Bug 56824] Postal 2 (20th Anniversary update) crashes when loading the map

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56824

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Fabian Maurer  ---
*** Bug 56826 has been marked as a duplicate of this bug. ***

[Bug 56824] Postal 2 (20th Anniversary update) crashes when loading the map

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56824

Vijay Kamuju  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
             Status|NEW                         |RESOLVED
      Fixed by SHA1|                            |77f3c0826aca20e247f2e82263a
                   |                            |5e39c26738894
         Resolution|---                         |FIXED

--- Comment #8 from Vijay Kamuju  ---
Fix merged -
https://source.winehq.org/git/wine.git/commitdiff/77f3c0826aca20e247f2e82263...

[Bug 56824] Postal 2 (20th Anniversary update) crashes when loading the map

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=56824

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard  ---
Closing bugs fixed in 9.11.