[Bug 22929] New: "Path not found" error prevents NCLauncher from updating itself to latest

http://bugs.winehq.org/show_bug.cgi?id=22929

Summary: "Path not found" error prevents NCLauncher from
                    updating itself to latest
           Product: Wine
           Version: 1.2-rc2
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=28376)
 --> (http://bugs.winehq.org/attachment.cgi?id=28376)
compressed log

The Launcher can successfully start and download the patch but when it tries to
apply it (im guessing at least thats what its trying to do) an error window
pops up with "Path not found" and the application closes

[Bug 22929] "Path not found" error prevents NCLauncher from updating itself to latest

http://bugs.winehq.org/show_bug.cgi?id=22929

--- Comment #1 from Pat   2010-05-29 11:56:51 ---
Created an attachment (id=28377)
 --> (http://bugs.winehq.org/attachment.cgi?id=28377)
Picture of error window

[Bug 22929] "Path not found" error prevents NCLauncher from updating itself to latest

http://bugs.winehq.org/show_bug.cgi?id=22929

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download
                URL|                            |ftp://ftp.ncsoft.com/Launch
                   |                            |er/NCsoftLauncherSetup.exe

[Bug 22929] "Path not found" error prevents NCLauncher from updating itself to latest

http://bugs.winehq.org/show_bug.cgi?id=22929

Eric Kuzmenko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #2 from Eric Kuzmenko   2010-05-30 22:41:11 ---
*** This bug has been confirmed by popular vote. ***

[Bug 22929] "Path not found" error prevents NCLauncher from updating itself to latest

http://bugs.winehq.org/show_bug.cgi?id=22929

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from Anastasius Focht   2010-06-01 01:54:09 ---
Hello,

the current version for download doesn't update itself (because it's most
recent).
If you have an older version provide log:

WINEDEBUG=+tid,+process,+exec wine ./NCLauncher.exe &> log.txt

If remember the problem correctly the launcher is started using
ShellExecuteEx(A/W) with "file" protocol scheme, e.g. "file:////c://foo.exe"
which isn't properly handled by Wine.

Regards

[Bug 22929] "Path not found" error prevents NCLauncher from updating itself to latest

http://bugs.winehq.org/show_bug.cgi?id=22929

--- Comment #4 from WaCrex   2010-06-03 04:58:08 ---
Created an attachment (id=28530)
 --> (http://bugs.winehq.org/attachment.cgi?id=28530)
Logfile for launcher update error (Path not found)

[Bug 22929] "Path not found" error prevents NCLauncher from updating itself to latest

http://bugs.winehq.org/show_bug.cgi?id=22929

--- Comment #5 from WaCrex   2010-06-03 04:59:44 ---
(From update of attachment 28530)
--- quote ---
If you have an older version provide log:

WINEDEBUG=+tid,+process,+exec wine ./NCLauncher.exe &> log.txt
--- quote ---

There you go ^^

[Bug 22929] "Path not found" error prevents NCLauncher from updating itself to latest

http://bugs.winehq.org/show_bug.cgi?id=22929

WaCrex  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from WaCrex   2010-06-03 06:34:46 ---
I have also uploaded an older version of NCLauncher (1.5.7.0) for those what
needs it.

http://www.mediafire.com/?kydmnmwm2mn

[Bug 22929] "Path not found" error prevents NCLauncher from updating itself to latest

http://bugs.winehq.org/show_bug.cgi?id=22929

--- Comment #7 from WaCrex   2010-06-13 06:52:39 ---
wine-git/dlls/shell32/shlexec.c:

Row 931: Variables with usable data left unhandled in execute_from_key() causes
it to return "Nothing appropriate found for ..." .. Technically the function
already got everything it needs.

ToDo:    Add an extra "else if" checking key & lpFile at row 982, turning
lpFile & szCommandline into something a bit more usable & execute, in case the
other variables ain't usable.

Also.... the code seems to try to parse the "string" (dword ~ char array) as an
URI before even checking if it is an URL.  It kinda sounds both stupid and as
waste time, running function after function trying to parse it as something
without even checking first.

It's kinda like; Wasting hours to make a hole in a wall to get thru, without
even checking if there already is an existing door.

[Bug 22929] "Path not found" error prevents NCLauncher from updating itself to latest

http://bugs.winehq.org/show_bug.cgi?id=22929

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from [e-mail] 2011-06-23 20:53:42 CDT ---
Its a year later, and it appears that NCsoft is making their new launcher a
requirement.  This bug is still an issue, and will prevent anyone from playing
any NCsoft games.

Is it terribly difficult to update the parsing to handle the
"file://path/filename.exe" URL type lines that the launcher is using?

[Bug 22929] "Path not found" error prevents NCLauncher from updating itself to latest

http://bugs.winehq.org/show_bug.cgi?id=22929

3vi1  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #9 from 3vi1  2011-06-24 17:41:07 CDT ---
I took a look at this over the last hour or two...

My solution to the path bug is slightly different than Patrick's.  I figured,
if it's going to try to execute it as a local path before it even checks to see
if it's a URI, why not just make SHELL_execute smart enough to rip off the
'file://' prefix?

I did, and it worked.  It finds the path, and does a few more file operations
with Nclauncher.exe and nclauncher.copy.exe.

But..  it appears this isn't the only problem to be overcome, as now that it
has no problem with the path... the .Net code that follows throws a
"System.IO.FileLoadException:  The specified user does not have a valid
profile." error while trying to load _Launcher.

I'll play with it a little more, but I'm fearful that this might be a .Net/Wine
bug that's out of my depth given my limited free time and unfamiliarity with
the Wine code.  If anyone else is working on it, I'd love for us to put our
heads together though, as I saw that CoH is going to be free-to-play soon.

0044:trace:process:__wine_kernel_init starting process
name=L"W:\games\ncsoft\nclauncher.copy.exe"
argv[0]=L"w:\games\ncsoft\nclauncher.copy.exe"
003f:trace:process:create_process_impl started process pid 0043 tid 0044
003f:trace:exec:SHELL_ExecuteW returning 33
0044:trace:process:set_entry_point setting FT_Thunk at 0x7b88b820 to 00000000
0044:fixme:advapi:RegisterTraceGuidsW (0x79fd471e, 0x131dc8,
{e13c0d23-ccbc-4e12-931b-d9cc2eee27e4}, 9, 0x7a390368, (null), (null),
0x7a38d250,): stub
0044:fixme:sync:CreateMemoryResourceNotification (0) stub
0047:err:ole:CoGetContextToken apartment not initialised
0044:fixme:shell:URL_ParseUrl failed to parse L"System"
0044:fixme:shell:URL_ParseUrl failed to parse L"_Launcher"
0044:fixme:shell:URL_ParseUrl failed to parse L"System.Windows.Forms"
0044:fixme:shell:URL_ParseUrl failed to parse L"System.Drawing"
0044:fixme:shell:URL_ParseUrl failed to parse L"NCLauncher.resources"
0044:fixme:shell:URL_ParseUrl failed to parse L"NCLauncher.resources"

-J

[Bug 22929] "Path not found" error prevents NCLauncher from updating itself to latest

http://bugs.winehq.org/show_bug.cgi?id=22929

--- Comment #10 from 3vi1  2011-06-24 19:49:12 CDT ---
(In reply to comment #9)

I tried with both .Net2.0 and 3.0... and forcing the host OS to a bunch of
values.  I also tried creating the "Document and Settings" paths, but got the
same results.  It's possible I was still missing some path that .Net is trying
before it throws this error... but it may just as well be a missing registry
setting for all I know at this point.

[Bug 22929] "Path not found" error prevents NCLauncher from updating itself to latest

http://bugs.winehq.org/show_bug.cgi?id=22929

--- Comment #11 from Pat  2011-06-25 02:12:19 CDT ---
So based on what 3v1 has said should his patch be uploaded and considered this
bug "fixed" and what hes encountering now after his patch is another problem??

[Bug 22929] "Path not found" error prevents NCLauncher from updating itself to latest

http://bugs.winehq.org/show_bug.cgi?id=22929

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
         AssignedTo|[e-mail]        |[e-mail]

[Bug 22929] "Path not found" error prevents NCLauncher from updating itself to latest

http://bugs.winehq.org/show_bug.cgi?id=22929

--- Comment #12 from François Gouget  2012-09-21 12:47:09 CDT ---
I'm preparing patches so ShellExecute() handles 'file:' URLs.

[Bug 22929] "Path not found" error prevents NCLauncher from updating itself to latest

http://bugs.winehq.org/show_bug.cgi?id=22929

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #13 from François Gouget  2012-10-13 05:17:00 CDT ---
The patch below is in Wine 1.5.15 and should fix this issue.
In my test the NCsoft installer complained about an out of memory issue but I
think that's a separate bug.

commit 53e4ddc399cef1f044fb25bdb19a478ced6178d7
Author: Francois Gouget 
Date:   Wed Oct 10 00:54:07 2012 +0200

shell32: Fix ShellExecute()'s handling of file URLs.

[Bug 22929] "Path not found" error prevents NCLauncher from updating itself to latest

http://bugs.winehq.org/show_bug.cgi?id=22929

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #14 from Alexandre Julliard  2012-10-26 13:30:53 CDT ---
Closing bugs fixed in 1.5.16.

[Bug 22929] "Path not found" error prevents NCLauncher from updating itself to latest

https://bugs.winehq.org/show_bug.cgi?id=22929

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |53e4ddc399cef1f044fb25bdb19
                   |                            |a478ced6178d7
          Component|-unknown                    |shell32