[Bug 20729] New: Logos4: wine has the ALLUSERS property set

http://bugs.winehq.org/show_bug.cgi?id=20729

Summary: Logos4: wine has the ALLUSERS property set
           Product: Wine
           Version: 1.1.33
          Platform: PC
               URL: http://www.logos.com/
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: msi
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=24777)
 --> (http://bugs.winehq.org/attachment.cgi?id=24777)
WINEDEBUG=+msi

This application's msi won't install - it complains that "Setting the ALLUSERS
property is not allowed because Logos 4 is a per-user application. Setup will
now exit."
> From the git logs, I see that back on 8/25/06, Mike McCormack committed a patch

c8548fb88d569f63f43fb009072ff8f03e562cb0 - "msi: Set the ALLUSERS property to 1
always."

[Bug 20729] Logos4: wine has the ALLUSERS property set

http://bugs.winehq.org/show_bug.cgi?id=20729

--- Comment #1 from Hans Leidekker   2009-11-16 02:39:52 ---
Created an attachment (id=24779)
 --> (http://bugs.winehq.org/attachment.cgi?id=24779)
msi: Set ALLUSERS property to 2.

Can you try this patch?

[Bug 20729] Logos4: wine has the ALLUSERS property set

http://bugs.winehq.org/show_bug.cgi?id=20729

--- Comment #2 from Nicholas van Oudtshoorn   2009-11-16 03:16:40 ---
(In reply to comment #1)
> Created an attachment (id=24779)

--> (http://bugs.winehq.org/attachment.cgi?id=24779) [details]
> msi: Set ALLUSERS property to 2.
>
> Can you try this patch?

Sorry - the problem is still persisting.

(I *can* get around it by using Orca to delete the LaunchCondition "NOT
ALLUSERS" if that's of any help)

[Bug 20729] Logos4: wine has the ALLUSERS property set

http://bugs.winehq.org/show_bug.cgi?id=20729

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #24779|0                           |1
        is obsolete|                            |

--- Comment #3 from Hans Leidekker   2009-11-16 03:39:30 ---
Created an attachment (id=24780)
 --> (http://bugs.winehq.org/attachment.cgi?id=24780)
msi: Don't set ALLUSERS property.

Thanks. How about this one?

[Bug 20729] Logos4: wine has the ALLUSERS property set

http://bugs.winehq.org/show_bug.cgi?id=20729

--- Comment #4 from Nicholas van Oudtshoorn   2009-11-16 04:40:52 ---
(In reply to comment #3)
> Created an attachment (id=24780)

--> (http://bugs.winehq.org/attachment.cgi?id=24780) [details]
> msi: Don't set ALLUSERS property.
>
> Thanks. How about this one?

Yep - that one does the trick (now I just have to worry about the .net stuff it
requires!)

Thanks for all the help. Question, though

[Bug 20729] Logos4: wine has the ALLUSERS property set

http://bugs.winehq.org/show_bug.cgi?id=20729

--- Comment #5 from Nicholas van Oudtshoorn   2009-11-16 04:42:05 ---
(In reply to comment #4)
> (In reply to comment #3)
> > Created an attachment (id=24780)

--> (http://bugs.winehq.org/attachment.cgi?id=24780) [details] [details]
> > msi: Don't set ALLUSERS property.
> >
> > Thanks. How about this one?
>
> Yep - that one does the trick (now I just have to worry about the .net stuff it
> requires!)
>
> Thanks for all the help. Question, though

To finish that thought: Question, though - won't simply disabling this cause
regressions for other installers?

[Bug 20729] Logos4: wine has the ALLUSERS property set

http://bugs.winehq.org/show_bug.cgi?id=20729

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Hans Leidekker   2009-11-16 05:01:14 ---
> To finish that thought: Question, though - won't simply disabling this cause
> regressions for other installers?

It might, I still need to write a test to confirm that the property should
not be set.

[Bug 20729] Logos4: wine has the ALLUSERS property set

http://bugs.winehq.org/show_bug.cgi?id=20729

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Louis Lenders   2009-11-16 10:48:47 ---
(In reply to comment #6)
> > To finish that thought: Question, though - won't simply disabling this cause
> > regressions for other installers?
>
> It might, I still need to write a test to confirm that the property should
> not be set.

Not sure if this is the same issue, but AF discussed another bug here
http://bugs.winehq.org/show_bug.cgi?id=6930#c11

Maybe it's the same problem?

[Bug 20729] Logos4: wine has the ALLUSERS property set

http://bugs.winehq.org/show_bug.cgi?id=20729

--- Comment #8 from Hans Leidekker   2009-11-16 13:59:49 ---
> Not sure if this is the same issue, but AF discussed another bug here
> http://bugs.winehq.org/show_bug.cgi?id=6930#c11
>
> Maybe it's the same problem?

No, that's a different problem.

[Bug 20729] Logos4: wine has the ALLUSERS property set

http://bugs.winehq.org/show_bug.cgi?id=20729

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #9 from Hans Leidekker   2009-11-17 10:10:20 ---
Fixed by commit bd4bc161475f600612fad898f09825d74d6368a9.

[Bug 20729] Logos4: wine has the ALLUSERS property set

http://bugs.winehq.org/show_bug.cgi?id=20729

--- Comment #10 from Austin English   2009-11-17 20:45:51 ---
(In reply to comment #6)
> > To finish that thought: Question, though - won't simply disabling this cause
> > regressions for other installers?
>
> It might, I still need to write a test to confirm that the property should
> not be set.

Perhaps it should be toggable by a registry key?

[Bug 20729] Logos4: wine has the ALLUSERS property set

http://bugs.winehq.org/show_bug.cgi?id=20729

--- Comment #11 from Hans Leidekker   2009-11-18 02:40:04 ---
> Perhaps it should be toggable by a registry key?

No, this property should be set by the installer and msi must decide
whether to perform a per-machine or per-user installation based on its
value and that of MSIINSTALLPERUSER as well as the privileges of the
user running the installer and the version of the OS. It's a real mess:

http://msdn.microsoft.com/en-us/library/aa367559(VS.85).aspx

[Bug 20729] Logos4: wine has the ALLUSERS property set

http://bugs.winehq.org/show_bug.cgi?id=20729

--- Comment #12 from Austin English   2009-11-18 13:35:56 ---
(In reply to comment #11)
> > Perhaps it should be toggable by a registry key?
>
> No, this property should be set by the installer and msi must decide
> whether to perform a per-machine or per-user installation based on its
> value and that of MSIINSTALLPERUSER as well as the privileges of the
> user running the installer and the version of the OS. It's a real mess:
>
> http://msdn.microsoft.com/en-us/library/aa367559(VS.85).aspx

Good to know, thanks.

[Bug 20729] Logos4: wine has the ALLUSERS property set

http://bugs.winehq.org/show_bug.cgi?id=20729

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #13 from Alexandre Julliard   2009-12-04 12:16:32 ---
Closing bugs fixed in 1.1.34.

[Bug 20729] Logos4: wine has the ALLUSERS property set

http://bugs.winehq.org/show_bug.cgi?id=20729

Hans Leidekker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |bd4bc161475f600612fad898f09
                   |                            |825d74d6368a9