[Bug 25925] New: Bioshock: installer autopatcher fails verification

http://bugs.winehq.org/show_bug.cgi?id=25925

Summary: Bioshock: installer autopatcher fails verification
           Product: Wine
           Version: 1.3.12
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Keywords: Installer, regression
          Severity: normal
          Priority: P2
         Component: crypt32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail]

Regression introduced by:

austin@midna:/ramdisk/wine$ git bisect good
966d722752b659a12ffa355a1e559f94907cd66d is the first bad commit
commit 966d722752b659a12ffa355a1e559f94907cd66d
Author: Juan Lang 
Date:   Mon Oct 4 18:16:16 2010 -0700

crypt32: Improve error checking for the base policy.

:040000 040000 f9ebbde6e36c9d0b061daf58553171e60903c5b8
f4af24892b8e82f2d4f8c3083cf712a89df83694 M    dlls

WINEDEBUG=+wininet,+crypt,+chain attached

[Bug 25925] Bioshock: installer autopatcher fails verification

http://bugs.winehq.org/show_bug.cgi?id=25925

--- Comment #1 from Austin English  2011-01-29 18:45:10 CST ---
Created an attachment (id=33043)
 --> (http://bugs.winehq.org/attachment.cgi?id=33043)
WINEDEBUG=+wininet,+crypt,+chain

[Bug 25925] Bioshock: installer autopatcher fails verification

http://bugs.winehq.org/show_bug.cgi?id=25925

--- Comment #2 from Juan Lang  2011-01-30 07:06:20 CST ---
Could you attach a +wintrust,+crypt,+chain log instead?  It appears that the
verification fails on a file, not during a SSL/TLS connection.

[Bug 25925] Bioshock: installer autopatcher fails verification

http://bugs.winehq.org/show_bug.cgi?id=25925

--- Comment #3 from Austin English  2011-01-30 15:08:38 CST ---
Created an attachment (id=33062)
 --> (http://bugs.winehq.org/attachment.cgi?id=33062)
WINEDEBUG=+wintrust,+crypt,+chain

[Bug 25925] Bioshock: installer autopatcher fails verification

http://bugs.winehq.org/show_bug.cgi?id=25925

--- Comment #4 from Juan Lang  2011-01-30 20:51:07 CST ---
Looking at the logs, I don't see how the identified commit can cause the
failure.  The only modified function is verify_base_policy, which is called by
CertVerifyCertificateChainPolicy.  The only times this is called in the log, it
returns TRUE, i.e. success.

Does reverting the commit help?  If so, please attach a +wintrust,+crypt,+chain
log of a succeeding installer.

[Bug 25925] Bioshock: installer autopatcher fails verification

http://bugs.winehq.org/show_bug.cgi?id=25925

--- Comment #5 from Austin English  2011-01-30 22:11:22 CST ---
Created an attachment (id=33068)
 --> (http://bugs.winehq.org/attachment.cgi?id=33068)
WINEDEBUG=+wintrust,+crypt,+chain of a good install

Reverting it on top of git fails, but I tested an earlier wine with that commit
reverted, yes.

Log attached (rzip'ed this time, it's 75 MB uncompressed)

[Bug 25925] Bioshock: installer autopatcher fails verification

http://bugs.winehq.org/show_bug.cgi?id=25925

--- Comment #6 from Juan Lang  2011-01-31 10:30:23 CST ---
I still don't think that's the offending commit.  Here's what I see in the good
log:
trace:crypt:CertRDNValueToStrW returning 36 (L"Take-Two Interactive Software,
Inc.")
and here's what I see in the bad one:
trace:crypt:CertRDNValueToStrW returning 38 (L""Take-Two Interactive Software,
Inc."")

Note the extra quotes.  In the failing log, the app quits shortly after the
second call to CertRDNValueToStrW that yields Take-Two, while in the succeeding
log, the app continues with more WinVerifyTrust calls.  I have a feeling that
993068038e0958ccb3f866c7faf0ebe012b9fa21 is a more likely candidate.

[Bug 25925] Bioshock: installer autopatcher fails verification

http://bugs.winehq.org/show_bug.cgi?id=25925

--- Comment #7 from Juan Lang  2011-01-31 18:55:06 CST ---
Does Christian Inci's patch (
http://www.winehq.org/pipermail/wine-patches/2011-January/098429.html ) help?

[Bug 25925] Bioshock: installer autopatcher fails verification

http://bugs.winehq.org/show_bug.cgi?id=25925

--- Comment #8 from Austin English  2011-01-31 22:10:43 CST ---
(In reply to comment #7)
> Does Christian Inci's patch (
> http://www.winehq.org/pipermail/wine-patches/2011-January/098429.html ) help?

Yes. Though I'd like to point out that I did check the regression test before
filing the bug, I suppose it just exposed previously broken behavior.

[Bug 25925] Bioshock: installer autopatcher fails verification

http://bugs.winehq.org/show_bug.cgi?id=25925

--- Comment #9 from Juan Lang  2011-02-01 10:03:33 CST ---
ACK.  Thanks for confirming.  We'll see if Christian's patches make it in.  If
not, I'll take them up myself.

[Bug 25925] Bioshock: installer autopatcher fails verification

http://bugs.winehq.org/show_bug.cgi?id=25925

--- Comment #10 from Juan Lang  2011-02-01 12:44:39 CST ---
(In reply to comment #8)
> Yes. Though I'd like to point out that I did check the regression test before
> filing the bug, I suppose it just exposed previously broken behavior.

I should also say, I believe you.  The identified commit confused me, but the
logs cleared it up.  Thanks for helping me with it.  Patches sent:
http://www.winehq.org/pipermail/wine-patches/2011-February/098467.html
http://www.winehq.org/pipermail/wine-patches/2011-February/098468.html
http://www.winehq.org/pipermail/wine-patches/2011-February/098469.html

Could you apply them and confirm that they still fix the bug?

[Bug 25925] Bioshock: installer autopatcher fails verification

http://bugs.winehq.org/show_bug.cgi?id=25925

--- Comment #11 from Austin English  2011-02-02 01:11:50 CST ---
(In reply to comment #10)
> (In reply to comment #8)
> > Yes. Though I'd like to point out that I did check the regression test before
> > filing the bug, I suppose it just exposed previously broken behavior.
>
> I should also say, I believe you.  The identified commit confused me, but the
> logs cleared it up.  Thanks for helping me with it.  Patches sent:
> http://www.winehq.org/pipermail/wine-patches/2011-February/098467.html
> http://www.winehq.org/pipermail/wine-patches/2011-February/098468.html
> http://www.winehq.org/pipermail/wine-patches/2011-February/098469.html
>
> Could you apply them and confirm that they still fix the bug?

Yep, looks good, thanks :-).

[Bug 25925] Bioshock: installer autopatcher fails verification

http://bugs.winehq.org/show_bug.cgi?id=25925

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #12 from Austin English  2011-02-02 12:56:35 CST ---
Fixed by
http://source.winehq.org/git/wine.git/?a=commitdiff;h=74cf35d2ab55a0972f7e34...

Thanks Juan!

[Bug 25925] Bioshock: installer autopatcher fails verification

http://bugs.winehq.org/show_bug.cgi?id=25925

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #13 from Alexandre Julliard  2011-02-04 13:21:28 CST ---
Closing bugs fixed in 1.3.13.