[Bug 20867] New: Music Time 2.0 saves files incorrectly

http://bugs.winehq.org/show_bug.cgi?id=20867

Summary: Music Time 2.0 saves files incorrectly
           Product: Wine
           Version: 1.1.33
          Platform: PC
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=25006)
 --> (http://bugs.winehq.org/attachment.cgi?id=25006)
Screenshot of the error dialog box

When saving a score something doesn't get written to the file properly, and
when you try opening the same file later, a windows error dialog box opens with
a message that says the file "could not be loaded in because of DOS error code
#-3".

Wine gives out the following output when saving the file:

fixme:commdlg:GetSaveFileName16 custom hook 0x11e700ba no longer supported

I've also attached the correctly saved original file, the incorrectly saved
file and a screenshot of the error dialog.

[Bug 20867] Music Time 2.0 saves files incorrectly

http://bugs.winehq.org/show_bug.cgi?id=20867

--- Comment #1 from Jussi Saarinen   2009-11-29 14:24:21 ---
Created an attachment (id=25007)
 --> (http://bugs.winehq.org/attachment.cgi?id=25007)
Original sheet music file that opens correctly

Here's the original sheet music file that opens correctly.

[Bug 20867] Music Time 2.0 saves files incorrectly

http://bugs.winehq.org/show_bug.cgi?id=20867

--- Comment #2 from Jussi Saarinen   2009-11-29 14:26:19 ---
Created an attachment (id=25008)
 --> (http://bugs.winehq.org/attachment.cgi?id=25008)
Incorrectly saved sheet music file

And here's the incorrectly saved sheet music file.

[Bug 20867] MusicTime 2.0 saves files incorrectly

http://bugs.winehq.org/show_bug.cgi?id=20867

Jussi Saarinen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Music Time 2.0 saves files  |MusicTime 2.0 saves files
                   |incorrectly                 |incorrectly

--- Comment #3 from Jussi Saarinen   2009-11-29 14:28:08 ---
Summary corrected.

[Bug 20867] MusicTime 2.0 saves files incorrectly

http://bugs.winehq.org/show_bug.cgi?id=20867

Jussi Saarinen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |win16

--- Comment #4 from Jussi Saarinen   2009-11-29 14:35:44 ---
I'm currently using ArchLinux rolling release which is up to date, though I
have encountered previously these same problems with Gentoo Linux and various
releases of Ubuntu Linux.

Also added keywords.

[Bug 20867] MusicTime 2.0 saves files incorrectly

http://bugs.winehq.org/show_bug.cgi?id=20867

Jussi Saarinen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 20867] MusicTime 2.0 saves files incorrectly

http://bugs.winehq.org/show_bug.cgi?id=20867

Jussi Saarinen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]            |

[Bug 20867] MusicTime 2.0 saves files incorrectly

http://bugs.winehq.org/show_bug.cgi?id=20867

--- Comment #5 from Juan Lang   2009-11-29 15:06:19 ---
I'd bet this was a regression introduced between 1.1.32 and 1.1.33 with commit
424472c20d8059057277ae13a0ffe5c51a818e52:
http://www.winehq.org/pipermail/wine-cvs/2009-November/061516.html

You might try with 1.1.32 and check that it works for you.

[Bug 20867] MusicTime 2.0 saves files incorrectly

http://bugs.winehq.org/show_bug.cgi?id=20867

--- Comment #6 from Jussi Saarinen   2009-11-29 15:45:41 ---
(In reply to comment #5)
> I'd bet this was a regression introduced between 1.1.32 and 1.1.33 with commit
> 424472c20d8059057277ae13a0ffe5c51a818e52:
> http://www.winehq.org/pipermail/wine-cvs/2009-November/061516.html
>
> You might try with 1.1.32 and check that it works for you.

This problem has been in Wine as long as I can remember, I just haven't had
time to report it before now.

In any case, I just tested 1.1.32 and it didn't work, so it's not a regression
between 1.1.33 and 1.1.32. Only difference was that wine gives the following
output only in 1.1.33:

fixme:commdlg:GetSaveFileName16 custom hook 0x11e700ba no longer supported

[Bug 20867] MusicTime 2.0 saves files incorrectly

http://bugs.winehq.org/show_bug.cgi?id=20867

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from [e-mail]  2010-05-24 11:10:19 ---
This bugs also affects other old 16bit applications like CorelDraw 3.0. It
prevents Corel from exporting files, because one cannot choose the correct file
and format. It worked flawlessly with 1.0.1.

Only these two lines are the problem when comparing 1.1.45 and 1.0.1:

fixme:commdlg:GetSaveFileName16 custom templates no longer supported, using
default
fixme:commdlg:GetSaveFileName16 custom hook 0x157f06d1 no longer supported

[Bug 20867] MusicTime 2.0 saves files incorrectly

http://bugs.winehq.org/show_bug.cgi?id=20867

--- Comment #8 from Alexandre Julliard   2010-05-24 11:22:44 ---
This has most likely nothing to do with this bug, please file a new report.

[Bug 20867] MusicTime 2.0 saves files incorrectly

http://bugs.winehq.org/show_bug.cgi?id=20867

--- Comment #9 from Jussi Saarinen   2010-05-30 09:12:39 ---
(In reply to comment #8)
> This has most likely nothing to do with this bug, please file a new report.

I have to agree also, since I believe my bug has been present even before Wine
version 1.0.

[Bug 20867] MusicTime 2.0 saves files incorrectly

http://bugs.winehq.org/show_bug.cgi?id=20867

--- Comment #10 from Jussi Saarinen   2010-05-30 09:15:00 ---
Does anyone have any suggestions on how to create some kind of usable log files
from this bug, or is there something else I can do to help fix this bug?

[Bug 20867] MusicTime 2.0 saves files incorrectly

http://bugs.winehq.org/show_bug.cgi?id=20867

--- Comment #11 from [e-mail]  2010-06-06 11:45:18 ---
Jussi,
I checked your binary files. It seems that the faulty version is missing a
bunch of zero bytes before the area with the ascii text.

In the save dialog, (when the "GetSaveFileName16 custom hook 0x11e700ba no
longer supported" appears), can you actually switch the file type?

The reason why I'm asking is because in my case, I can choose a different type
of file, but due to the non-execution of the custom hook, Corel draw doesn't
know about it and writes some kind of mixture of file types. But I'm not sure
if this is really the cause, so I would like to know your results.

@Alexandre: Is there a way to split my errors off or must I start from scratch?

[Bug 20867] MusicTime 2.0 saves files incorrectly

http://bugs.winehq.org/show_bug.cgi?id=20867

--- Comment #12 from Jussi Saarinen   2010-06-08 17:07:15 ---
(In reply to comment #11)
> In the save dialog, (when the "GetSaveFileName16 custom hook 0x11e700ba no
> longer supported" appears), can you actually switch the file type?

Yes I can. Beside mus-files, I can also choose to save in mid-, mts-, or
enc-formats.
> The reason why I'm asking is because in my case, I can choose a different type
> of file, but due to the non-execution of the custom hook, Corel draw doesn't
> know about it and writes some kind of mixture of file types. But I'm not sure
> if this is really the cause, so I would like to know your results.

I'll post the other types of files as soon as I can get the correctly saved
files for reference from a computer with Vista. This may take a while (a few
weeks), since I don't actually have any computers with Windows at the moment.

[Bug 20867] MusicTime 2.0 saves files incorrectly

http://bugs.winehq.org/show_bug.cgi?id=20867

--- Comment #13 from Jussi Saarinen   2010-06-08 17:22:30 ---
(In reply to comment #12)
> I'll post the other types of files as soon as I can get the correctly saved
> files for reference from a computer with Vista. This may take a while (a few
> weeks), since I don't actually have any computers with Windows at the moment.

Forgot to mention that tested to save the file in midi-format (mid-file). The
resulted file failed to play with aplaymidi-application.

[Bug 20867] MusicTime 2.0 saves files incorrectly

http://bugs.winehq.org/show_bug.cgi?id=20867

--- Comment #14 from Jussi Saarinen   2010-07-09 17:11:35 ---
Created an attachment (id=29474)
 --> (http://bugs.winehq.org/attachment.cgi?id=29474)
Files saved with Windows Vista

(In reply to comment #12)
> (In reply to comment #11)
> > In the save dialog, (when the "GetSaveFileName16 custom hook 0x11e700ba no
> > longer supported" appears), can you actually switch the file type?
>
> Yes I can. Beside mus-files, I can also choose to save in mid-, mts-, or
> enc-formats.
> > The reason why I'm asking is because in my case, I can choose a different
> > type of file, but due to the non-execution of the custom hook, Corel draw
> > doesn't know about it and writes some kind of mixture of file types. But
> > I'm not sure if this is really the cause, so I would like to know your
> > results.
>
> I'll post the other types of files as soon as I can get the correctly saved
> files for reference from a computer with Vista. This may take a while (a few
> weeks), since I don't actually have any computers with Windows at the moment.

I have now both the correctly saved ones from a Windows Vista machine and the
incorrectly saved ones.

Music Time has to different File-menu entries for saving files: "Save As" and
"Export File". With "Save As" I can make mus-, mid-, mts- and enc-files. With
"Export File" I can make mid-, mts- and enc-formats. I used Xubuntu Lucid Lynx
10.04 LTS and Wine version 1.2-rc6 for this test.

All the mid-files were saved correctly and identically (i.e. could be played
with aplaymidi). The resulting files were also identical to the one obtained
from a computer with Vista.

All the mts-files could also be opened correctly and were the same size.
However, none of the files were identical with each other. The two saved with
Vista (using "Save As" and "Export File"), and the other two saved in Xubuntu
were all unique.

The enc-files could not be opened with Music Time because the program can only
save enc-files, not open them. Both files saved with Vista where identical with
each other. The two saved with Xubuntu were the same size but had different
md5sums. They also were different size compared to the ones saved in Vista.
More interestingly, they were the same size as the incorrectly saved mus-file.

I'll attach a zip-file containing the files obtained with Vista to this message
and the Xubuntu ones to the next.

[Bug 20867] MusicTime 2.0 saves files incorrectly

http://bugs.winehq.org/show_bug.cgi?id=20867

--- Comment #15 from Jussi Saarinen   2010-07-09 17:14:16 ---
Created an attachment (id=29475)
 --> (http://bugs.winehq.org/attachment.cgi?id=29475)
Files saved with Xubuntu 10.04 LTS (Lucid Lynx)

And here are the ones saved with Xubuntu.

[Bug 20867] MusicTime 2.0 saves files incorrectly

http://bugs.winehq.org/show_bug.cgi?id=20867

--- Comment #16 from Jussi Saarinen   2010-07-09 17:23:32 ---
(In reply to comment #14)
> Music Time has to different File-menu entries for saving files: "Save As" and
> "Export File". With "Save As" I can make mus-, mid-, mts- and enc-files. With
> "Export File" I can make mid-, mts- and enc-formats. I used Xubuntu Lucid Lynx
> 10.04 LTS and Wine version 1.2-rc6 for this test.

I also tested on another machine with Xubuntu Karmic Koala and Wine version
1.3.42. With this machine all files saved with "Export File" were correctly
saved mid-files and all the files saved with "Save As" were the same as the
incorrectly saved mus-file.

[Bug 20867] MusicTime 2.0 saves files incorrectly

http://bugs.winehq.org/show_bug.cgi?id=20867

--- Comment #17 from Jussi Saarinen   2010-07-09 17:29:03 ---
(In reply to comment #16)
> (In reply to comment #14)
> > Music Time has to different File-menu entries for saving files: "Save As" and
> > "Export File". With "Save As" I can make mus-, mid-, mts- and enc-files. With
> > "Export File" I can make mid-, mts- and enc-formats. I used Xubuntu Lucid Lynx
> > 10.04 LTS and Wine version 1.2-rc6 for this test.
>
> I also tested on another machine with Xubuntu Karmic Koala and Wine version
> 1.3.42. With this machine all files saved with "Export File" were correctly
> saved mid-files and all the files saved with "Save As" were the same as the
> incorrectly saved mus-file.

That is wine version 1.1.42, not 1.3.42, of course.

Also the files saved with "Save As" were one byte smaller than the one with
Lucid.

[Bug 20867] MusicTime 2.0 saves files incorrectly

http://bugs.winehq.org/show_bug.cgi?id=20867

--- Comment #18 from Jussi Saarinen   2010-08-03 14:06:23 ---
Added up to date test results to the AppDB entry for MusicTime.

[Bug 20867] MusicTime 2.0 saves files incorrectly

http://bugs.winehq.org/show_bug.cgi?id=20867

--- Comment #19 from Jussi Saarinen  2012-03-14 18:09:11 CDT ---
Updated AppDB entry again.

[Bug 20867] MusicTime 2.0 saves files incorrectly

http://bugs.winehq.org/show_bug.cgi?id=20867

--- Comment #20 from Jussi Saarinen  2012-03-14 19:20:23 CDT ---
With wine version 1.4 I have noticed something interesting. When I choose to
save mus-files using simply "Save" instead of "Save As", the files seem to work
OK. Only when saving files using "Save As" they don't work. I am not sure yet
whether the functionality has improved since last tested or did I simply notice
this just now.

[Bug 20867] MusicTime 2.0 saves files incorrectly

http://bugs.winehq.org/show_bug.cgi?id=20867

--- Comment #21 from Jussi Saarinen  2012-03-14 20:57:10 CDT ---
(In reply to comment #20)
> With wine version 1.4 I have noticed something interesting. When I choose to
> save mus-files using simply "Save" instead of "Save As", the files seem to work
> OK. Only when saving files using "Save As" they don't work. I am not sure yet
> whether the functionality has improved since last tested or did I simply notice
> this just now.

I have now confirmed that the behavior is similar also in wine version 1.3.2.
So looks like no recent modifications have changed the program's behavior.

[Bug 20867] MusicTime 2.0 saves files incorrectly

http://bugs.winehq.org/show_bug.cgi?id=20867

--- Comment #22 from Jussi Saarinen  2012-03-15 06:34:37 CDT ---
Created attachment 39378
  --> http://bugs.winehq.org/attachment.cgi?id=39378
Missing file endings

I compared seven different mus-files. When I save them using "Save As" instead
of "Save", I notice the following differences:

1) Byte 0x3E is changed from 0x01 to 0x00. This happens with all test files.

2) On some of the files there couple of other changed bytes.

3) The "Save As" -version is missing 96 bytes from the end.

When I add the missing 96 bytes to the end of the file, the file opens
correctly. Other changes can remain as they are.

Five of the seven files have the same missing tail (4pctmp-tail-unique.bin,
johnny-tail-unique.bin, pvoctmp-tail-unique.bin, silent-tail-unique.bin and
somestuff-tail-unique.bin). Sixth one's (rore2-tail.bin) 13th byte is different
than the one in the first five files (0x02 instead of 0x03). Seventh one
(lupo-tail.bin) has the same first 9 bytes as the first, but then bytes 10 to
13 and 16 to 24 are different. The rest of the tails are the same with all the
files.

I'll attach the missing tails and their differences to this comment.

Does anyone have suggestions on how to proceed with this information? I mean,
does this help? I would like to get this program to work correctly with wine. I
am willing to do the work needed (I even have little programming experience),
but I don't know how to proceed solving this.

[Bug 20867] MusicTime 2.0 saves files incorrectly

http://bugs.winehq.org/show_bug.cgi?id=20867

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #23 from Bruno Jesus  2012-03-15 12:25:36 CDT ---
Can you reproduce the problem with musictime 1.2? I can't find a legal download
for version 2.0 anywhere. Do you know where it can be downloaded?

http://www.uselesssoftware.com/download/musictim-zip

[Bug 20867] MusicTime 2.0 saves files incorrectly

http://bugs.winehq.org/show_bug.cgi?id=20867

--- Comment #24 from Jussi Saarinen  2012-03-17 14:08:36 CDT ---
(In reply to comment #23)
> Can you reproduce the problem with musictime 1.2? I can't find a legal 
> download for version 2.0 anywhere. Do you know where it can be downloaded?
>
> http://www.uselesssoftware.com/download/musictim-zip

That is a demo version, which unfortunately can't save or print scores. Music
Time 2.0 isn't free software (not even free as in beer), and as far as I know,
it isn't sold anymore.

I have managed to get some debug logs. So far all I have managed to find from
the logs are these:

With Save-command:

0024:Call KERNEL.86: _LWRITE(0005,12af:0000,0b82) ret=1207:023a ds=121f
187.445:0024:Call KERNEL32._hwrite(00000094,00436ae8,00000b82) ret=7e8f3c1d
187.445:0024:trace:file:_hwrite 148 0x436ae8 2946
187.445:0024:trace:file:WriteFile 0x94 0x436ae8 2946 0x6fdc9c (nil)
187.445:0024:trace:ntdll:NtWriteFile
(0x94,(nil),(nil),(nil),0x6fdc38,0x436ae8,0x00000b82,(nil),(nil))!
187.445:0024:trace:ntdll:NtWriteFile = SUCCESS (2946)
187.445:0024:Ret  KERNEL32._hwrite() retval=00000b82 ret=7e8f3c1d
0024:Ret  KERNEL.86: _LWRITE() retval=00000b82 ret=1207:023a ds=121f

And with Save As -command:

0024:Call KERNEL.86: _LWRITE(0005,12af:0000,0b22) ret=1207:023a ds=121f
179.415:0024:Call KERNEL32._hwrite(000000ac,00436ae8,00000b22) ret=7e8f3c1d
179.415:0024:trace:file:_hwrite 172 0x436ae8 2850
179.415:0024:trace:file:WriteFile 0xac 0x436ae8 2850 0x6fdc9c (nil)
179.415:0024:trace:ntdll:NtWriteFile
(0xac,(nil),(nil),(nil),0x6fdc38,0x436ae8,0x00000b22,(nil),(nil))!
179.415:0024:trace:ntdll:NtWriteFile = SUCCESS (2850)
179.415:0024:Ret  KERNEL32._hwrite() retval=00000b22 ret=7e8f3c1d
0024:Ret  KERNEL.86: _LWRITE() retval=00000b22 ret=1207:023a ds=121f

MusicTime seems to write the file in four separate chunks. This is the last
one. I noticed that the write command is called in Save As -case with a length
that is 96 smaller than in Save-case. This is the exact same amount in bytes
that is missing from the files end. I haven't figured out yet why it does that.

I can post complete logs somewhere, if you think they can help. The logs are
from the point that I click the save command (from File-menu) and the save
as-command (clicking save as -button from the Save as dialog box) to the point
that I click File-menu to exit the program after. I can also get longer logs,
or logs with more or less details (these logs are with WINEDEBUG=+all).

[Bug 20867] MusicTime 2.0 saves files incorrectly

https://bugs.winehq.org/show_bug.cgi?id=20867

--- Comment #25 from Austin English  ---
This is your friendly reminder that there has been no bug activity for 2 years.
Is this still an issue in current (1.7.16 or newer) wine?

[Bug 20867] MusicTime 2.0 saves files incorrectly

https://bugs.winehq.org/show_bug.cgi?id=20867

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |ABANDONED

--- Comment #26 from Austin English  ---
(In reply to Austin English from comment #25)
> This is your friendly reminder that there has been no bug activity for 2
> years. Is this still an issue in current (1.7.16 or newer) wine?

Abandoned.

[Bug 20867] MusicTime 2.0 saves files incorrectly

https://bugs.winehq.org/show_bug.cgi?id=20867

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #27 from Austin English  ---
Closing.