[Bug 26059] New: Garena can't start warcraft frozen throne properly.

http://bugs.winehq.org/show_bug.cgi?id=26059

Summary: Garena can't start warcraft frozen throne properly.
           Product: Wine
           Version: 1.3.0
          Platform: x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: ntoskrnl
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=33229)
 --> (http://bugs.winehq.org/attachment.cgi?id=33229)
full garena error log with warcraft run tries

When I'm clicking 'start game' button, window "Programm Error" with "The
program war3.exe has encountered a seriouse problem and needs to close"
appears.
I close this window and warcraft starts, but there are no games availible in
the games-list (of course real hosts exist).
But in some magic times window "Program Error" doesn't appear and warcraft
starts properly and hosts are visible.

[Bug 26059] Garena can't start warcraft frozen throne properly.

http://bugs.winehq.org/show_bug.cgi?id=26059

--- Comment #1 from Maxim Velesyuk  2011-02-10 08:33:32 CST ---
You can see 
"wine: Call from 0x7edce662 to unimplemented function
ntoskrnl.exe.PsSetLoadImageNotifyRoutine, aborting
wine: Unimplemented function ntoskrnl.exe.PsSetLoadImageNotifyRoutine called at
address 0x7edce662 (thread 0020), starting debugger...
Unhandled exception: unimplemented function
ntoskrnl.exe.PsSetLoadImageNotifyRoutine called in 32-bit code (0x7edce662)."
at garena's start, and
"Unhandled exception: page fault on read access to 0xfb7a178e in 32-bit code
(0xfb7a178e)." on every run game action.

[Bug 26059] Garena can't start warcraft frozen throne properly.

http://bugs.winehq.org/show_bug.cgi?id=26059

yureg  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from yureg  2011-02-19 07:20:56 CST ---
The same problem.
- Debian testing latest
- Wine 1.1.44 from wine repository
When I press "Start game" in Garena it throws an error window stating there is
a bug in war3.exe. I close the window, Warcraft 3 TFT starts. But no Network
Games are seen. So, Garena is senseless without being able to play vs other
nice ppl.
And, you know, Warcraft 3 is not just a game. Garena SHOULD run under linux.
Please, fix it, if anyway possible, than apply to me for your mouney. Thanks.
Regards, yureg.

[Bug 26059] Garena can't start warcraft frozen throne properly.

http://bugs.winehq.org/show_bug.cgi?id=26059

--- Comment #3 from yureg  2011-02-20 02:42:52 CST ---
Just built Wine from source.
Everything works!!!!!!!!!!!! Super fine.
Garena+w3 TFT rocks!!!
Thank you, guys.

[Bug 26059] Garena can't start warcraft frozen throne properly.

http://bugs.winehq.org/show_bug.cgi?id=26059

--- Comment #4 from Saulius K.  2011-03-06 10:38:31 CST ---
Maxim, can you confirm it works?
It would be strange as PsSetLoadImageNotifyRoutine() still isn't stubbed out.

[Bug 26059] Garena can't start warcraft frozen throne properly.

http://bugs.winehq.org/show_bug.cgi?id=26059

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download
                URL|                            |http://cdn.garenanow.com/pl
                   |                            |atformdownload/Garena_setup
                   |                            |.exe&lang=English
                 CC|                            |[e-mail]

--- Comment #5 from Anastasius Focht  2011-03-06 11:37:40 CST ---
Hello,

(In reply to comment #4)
> Maxim, can you confirm it works?
> It would be strange as PsSetLoadImageNotifyRoutine() still isn't stubbed out.

Maybe the initial bug report was about a different issue, not related to the
helper driver crash.
The driver of course still crashes (fresh Garena client download):

--- snip ---
...
0015:trace:process:CreateProcessW app (null) cmdline
L"C:\windows\system32\winedevice.exe GGSAFERDriver" 
...
0026:trace:loaddll:load_builtin_dll Loaded L"C:\windows\system32\msvcrt.dll"
at 0x37e20000: builtin
0026:trace:loaddll:load_builtin_dll Loaded L"C:\windows\system32\hal.dll" at
0x20010000: builtin
0026:trace:loaddll:load_native_dll Loaded L"C:\Program
Files\Garena\safedrv.sys" at 0x540000: native
0026:trace:ntoskrnl:ExAllocatePoolWithTag 8 pool 0 -> 0x111e08
0026:trace:ntoskrnl:ExAllocatePoolWithTag 8 pool 0 -> 0x110f20
0026:trace:ntoskrnl:ExAllocatePoolWithTag 20 pool 0 -> 0x110f38
0026:trace:ntoskrnl:ExAllocatePoolWithTag 132 pool 0 -> 0x110f58
0026:trace:ntoskrnl:MmGetSystemRoutineAddress L"KeStackAttachProcess" ->
0x683c04fc
0026:trace:ntoskrnl:MmGetSystemRoutineAddress L"KeUnstackDetachProcess" ->
0x683c0580
0026:trace:ntoskrnl:MmGetSystemRoutineAddress L"PsSetLoadImageNotifyRoutine" ->
0x683c296c
0026:trace:ntoskrnl:MmGetSystemRoutineAddress L"PsRemoveLoadImageNotifyRoutine"
-> 0x683c27b4
0026:fixme:ntoskrnl:MmGetSystemRoutineAddress L"ObRegisterCallbacks" not found
0026:fixme:ntoskrnl:MmGetSystemRoutineAddress L"ObUnRegisterCallbacks" not
found
0026:trace:ntoskrnl:MmGetSystemRoutineAddress L"PsGetProcessId" -> 0x683c2208
0026:trace:ntoskrnl:IoCreateDevice (0x683434a0, 80, L"\Device\GGSAFER", 34,
0, 1, 0x53e624)
0026:fixme:ntoskrnl:KeInitializeEvent stub: 0x111fa8 1 0
0026:trace:ntoskrnl:IoCreateSymbolicLink L"\DosDevices\GGSAFER" ->
L"\Device\GGSAFER"
0026:trace:ntoskrnl:ExAllocatePoolWithTag 24 pool 0 -> 0x110fe8
0026:trace:ntoskrnl:ExAllocatePoolWithTag 2560 pool 0 -> 0x115970
0026:trace:ntoskrnl:ExFreePoolWithTag 0x115970
0026:trace:ntoskrnl:ExAllocatePoolWithTag 2560 pool 0 -> 0x115970
0026:trace:ntoskrnl:ExFreePoolWithTag 0x115970
0026:trace:ntoskrnl:ExFreePoolWithTag 0x110fe8
0026:trace:ntoskrnl:ExAllocatePoolWithTag 12 pool 0 -> 0x110fe8
0026:trace:seh:raise_exception code=80000100 flags=1 addr=0x7b838547
ip=7b838547 tid=0026
0026:trace:seh:raise_exception  info[0]=683ca320
0026:trace:seh:raise_exception  info[1]=683ce5e1
wine: Call from 0x7b838547 to unimplemented function
ntoskrnl.exe.PsSetLoadImageNotifyRoutine, aborting 
--- snip ---

If the w3 TFT startup issue is resolved you could make another bug about this
helper driver (missing stub).
Maybe this driver isn't needed at all...

You can extract the kernel driver for analysis from safeapi.dll resources using
resource hacker or similar tools (there are two driver binaries, 32 and 64 bit
version with res id 101 an 102) or start garena using winedbg, bpx
StartServiceW, copy driver from folder away.

Regards

[Bug 26059] Garena can't start warcraft frozen throne properly.

http://bugs.winehq.org/show_bug.cgi?id=26059

--- Comment #6 from Maxim Velesyuk  2011-03-11 21:33:23 CST ---
Created an attachment (id=33602)
 --> (http://bugs.winehq.org/attachment.cgi?id=33602)
garena log

garena crashes with latest git wine, garena's error reporting works.

[Bug 26059] Garena can't start warcraft frozen throne properly.

http://bugs.winehq.org/show_bug.cgi?id=26059

--- Comment #7 from Maxim Velesyuk  2011-03-11 21:39:31 CST ---
(In reply to comment #4)
> Maxim, can you confirm it works?
> It would be strange as PsSetLoadImageNotifyRoutine() still isn't stubbed out.

Sorry for late answer, but with latest wine from git garena doesn't start at
all. Only updater and error reporting works. Log attached.

[Bug 26059] Garena can't start warcraft frozen throne properly.

http://bugs.winehq.org/show_bug.cgi?id=26059

Stefan Leichter  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from Stefan Leichter  2011-03-12 03:01:20 CST ---
A patch stubbing out PsSetLoadImageNotifyRoutine is waiting to be include into
git (see http://source.winehq.org/patches/data/71360). You may try it on your
local git.

[Bug 26059] Garena can't start warcraft frozen throne properly.

http://bugs.winehq.org/show_bug.cgi?id=26059

Stefan Leichter  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail] |

[Bug 26059] Garena can't start warcraft frozen throne properly.

http://bugs.winehq.org/show_bug.cgi?id=26059

--- Comment #9 from Stefan Leichter  2011-03-12 10:05:30 CST ---
(In reply to comment #6)
> Created an attachment (id=33602)

--> (http://bugs.winehq.org/attachment.cgi?id=33602) [details]
> garena log
>
> garena crashes with latest git wine, garena's error reporting works.

Backtrace:
=>0 0x7ee5d742 in kernel32 (+0x1d742) (0x0053e69c)
  1 0x7ea56c88 in ntoskrnl (+0x16c87) (0x0053e6cc)
  2 0x7ea50055 in ntoskrnl (+0x10054) (0x0053e6cc)

Did you strip the debug symbols from your self build wine? If not the attached
log is not for your self build wine.

[Bug 26059] Garena can't start warcraft frozen throne properly.

http://bugs.winehq.org/show_bug.cgi?id=26059

--- Comment #10 from Maxim Velesyuk  2011-03-15 08:05:00 CDT ---
(In reply to comment #9)
Huh? Log is full output, I built and install wine as root with
tools/wineinstall.
and I've got

% wine --version
wine-1.3.15-169-ged3ce3c

[Bug 26059] Garena can't start warcraft frozen throne properly.

http://bugs.winehq.org/show_bug.cgi?id=26059

--- Comment #11 from Stefan Leichter  2011-04-02 09:24:47 CDT ---
stub for PsSetLoadImageNotifyRoutine is in Wine 1.3.17 (see
http://source.winehq.org/git/wine.git/?a=commit;h=c643aec1759c82ab3c187ff1fe...)

[Bug 26059] Garena can't start warcraft frozen throne properly.

http://bugs.winehq.org/show_bug.cgi?id=26059

Maxim Velesyuk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.3.0                       |1.3.17

[Bug 26059] Garena can't start warcraft frozen throne properly.

http://bugs.winehq.org/show_bug.cgi?id=26059

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.3.17                      |1.3.0

--- Comment #12 from Dmitry Timoshkov  2011-04-24 20:35:20 CDT ---
Please do not change an originally reported Wine version.

[Bug 26059] Garena client GGSAFER driver crashes (needs ntoskrnl.exe PsSetLoadImageNotifyRoutine stub)

http://bugs.winehq.org/show_bug.cgi?id=26059

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED
            Summary|Garena can't start warcraft |Garena client GGSAFER
                   |frozen throne properly.     |driver crashes (needs
                   |                            |ntoskrnl.exe
                   |                            |PsSetLoadImageNotifyRoutine
                   |                            |stub)

--- Comment #13 from Anastasius Focht  2011-04-25 05:29:58 CDT ---
Hello,

the stub prevents the driver crash hence this specific problem is fixed.
Thanks Stefan.

File separate bugs for _other_ issues encountered.
Adjusting summary to reflect this specific issue.

Regards

[Bug 26059] Garena client GGSAFER driver crashes (needs ntoskrnl.exe PsSetLoadImageNotifyRoutine stub)

http://bugs.winehq.org/show_bug.cgi?id=26059

--- Comment #14 from Maxim Velesyuk  2011-04-26 08:08:31 CDT ---
So this stub is for wine 1.3.17 or 1.3.17 already has it?

[Bug 26059] Garena client GGSAFER driver crashes (needs ntoskrnl.exe PsSetLoadImageNotifyRoutine stub)

http://bugs.winehq.org/show_bug.cgi?id=26059

--- Comment #15 from Anastasius Focht  2011-04-26 08:17:56 CDT ---
Hello,

--- quote ---
So this stub is for wine 1.3.17 or 1.3.17 already has it?
--- quote ---

have a look at comment #11 - the stub was already committed (part of wine
1.3.17 release).
The driver crash is gone, I've already tested.
Though that driver isn't really useful in context of Wine ;-)

Regards

[Bug 26059] Garena client GGSAFER driver crashes (needs ntoskrnl.exe PsSetLoadImageNotifyRoutine stub)

http://bugs.winehq.org/show_bug.cgi?id=26059

--- Comment #16 from Maxim Velesyuk  2011-04-27 10:43:00 CDT ---
Hello, but i still have warcraft crash when it runs from garena in 1.3.17 and
1.3.18.
Warcraft starts normally only after garena updating and/or first run after
installation.

I attached log of one failed warcraft run.
This bug marked fixed, so maybe this is a problem of my side?

[Bug 26059] Garena client GGSAFER driver crashes (needs ntoskrnl.exe PsSetLoadImageNotifyRoutine stub)

http://bugs.winehq.org/show_bug.cgi?id=26059

--- Comment #17 from Maxim Velesyuk  2011-04-27 10:44:13 CDT ---
Created an attachment (id=34374)
 --> (http://bugs.winehq.org/attachment.cgi?id=34374)
warcraft fail in wine 1.3.18

[Bug 26059] Garena client GGSAFER driver crashes (needs ntoskrnl.exe PsSetLoadImageNotifyRoutine stub)

http://bugs.winehq.org/show_bug.cgi?id=26059

--- Comment #18 from Anastasius Focht  2011-04-27 10:56:07 CDT ---
Hello,

--- quote ---
Hello, but i still have warcraft crash when it runs from garena in 1.3.17 and
1.3.18.
Warcraft starts normally only after garena updating and/or first run after
installation.

I attached log of one failed warcraft run.
This bug marked fixed, so maybe this is a problem of my side?
--- quote ---

please don't "recycle" bugs for other problems.
One bug per problem is the way to ensure each _individual_ issue can be
clarified/tracked/fixed.

Your crash occurs in warcraft executable and not in garena/driver.

--- snip ---
0000000d (D) Z:\mnt\data\games\warcraftIII\war3.exe
    0000004a    0 <==
    00000049    0
    00000048    0
Backtrace:
=>0 0x7ee5da20 in kernel32 (+0x2da20) (0x0067ea78)
  1 0x7efb7660 call_thread_entry_point+0x6f() in ntdll (0x0067eb48)
  2 0x7efc10e9 in ntdll (+0x610e8) (0x0067f398)
  3 0xf75979ae start_thread+0xbd() in libpthread.so.0 (0x0067f498)
  4 0xf751c53e __clone+0x5d() in libc.so.6 (0x00000000)
err:seh:raise_exception Unhandled exception code c0000005 flags 0 addr
0x7ee5da20
--- snip ---

Open a new bug for your problem - research wine bugzilla to make sure there
isn't already one (dupe).
Also make sure you have wine with debug symbols installed otherwise backtraces
are not really useful.

Regards

[Bug 26059] Garena client GGSAFER driver crashes (needs ntoskrnl.exe PsSetLoadImageNotifyRoutine stub)

http://bugs.winehq.org/show_bug.cgi?id=26059

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #19 from Alexandre Julliard  2011-04-29 13:15:05 CDT ---
Closing bugs fixed in 1.3.19.

[Bug 26059] Garena client GGSAFER driver crashes (needs ntoskrnl.exe PsSetLoadImageNotifyRoutine stub)

http://bugs.winehq.org/show_bug.cgi?id=26059

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |obfuscation
      Fixed by SHA1|                            |c643aec1759c82ab3c187ff1fe5
                   |                            |18e2dda1dc8bc