https://bugs.winehq.org/show_bug.cgi?id=50285
Bug ID: 50285 Summary: File renamings involving symbolic links fail Product: Wine-staging Version: unspecified Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: -unknown Assignee: wine-bugs@winehq.org Reporter: martin@martin.st CC: erich.e.hoover@gmail.com, leslie_alistair@hotmail.com, z.figura12@gmail.com Distribution: ---
Created attachment 68842 --> https://bugs.winehq.org/attachment.cgi?id=68842 Sample for case 1
Two cases of file renamings involving symlinks fail:
Case 1: A regular file, named "regular", and a symlink named "symlink" pointing at "regular". Rename "regular" to "symlink" (which should overwrite the existing symlink). This should leave one single file, a regular file, named "symlink". In practice, no rename happens (but no error is reported either).
Case 2: A symlink pointing at a missing file. Renaming the symlink with MoveFileEx fails.
https://bugs.winehq.org/show_bug.cgi?id=50285
--- Comment #1 from Martin Storsjö martin@martin.st --- Created attachment 68843 --> https://bugs.winehq.org/attachment.cgi?id=68843 Sample for case 2
https://bugs.winehq.org/show_bug.cgi?id=50285
--- Comment #2 from Martin Storsjö martin@martin.st --- These two issues remain with the latest version of the wine-staging patchset.
Also similar to these two, DeleteFileA fails to remove a symlink, if the link points at a missing file - I'll attach a testcase for that.
https://bugs.winehq.org/show_bug.cgi?id=50285
--- Comment #3 from Martin Storsjö martin@martin.st --- Created attachment 69315 --> https://bugs.winehq.org/attachment.cgi?id=69315 Sample for case 3
https://bugs.winehq.org/show_bug.cgi?id=50285
--- Comment #4 from Erich E. Hoover erich.e.hoover@gmail.com --- (In reply to Martin Storsjö from comment #2)
These two issues remain with the latest version of the wine-staging patchset. ...
Yup, thanks Martin - I had a chance to figure out the hard one (Case 1) over the weekend, but ran out of time before tackling Case 2. I should be able to get to it (and Case 3) this weekend and push out a minor update to address this bug and Bug #50586.
https://bugs.winehq.org/show_bug.cgi?id=50285
--- Comment #5 from Erich E. Hoover erich.e.hoover@gmail.com --- When you get a chance to retest, these issues should be fixed by staging commit 750044c08c49c7a117fcc911506a198969379144.
https://bugs.winehq.org/show_bug.cgi?id=50285
--- Comment #6 from Martin Storsjö martin@martin.st --- (In reply to Erich E. Hoover from comment #5)
When you get a chance to retest, these issues should be fixed by staging commit 750044c08c49c7a117fcc911506a198969379144.
Thanks! This does seem to work correctly now. And with that in place, the vast majority of the libc++ std::filesystem tests now run correctly in Wine. There's one or a few issues left though, but the overall status seems to be that almost everything works as it should, at least the aspects that the std::filesystem tests look at (which might not be the whole picture).
https://bugs.winehq.org/show_bug.cgi?id=50285
Zebediah Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |6.0-rc1 Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED Fixed by SHA1| |750044c08c49c7a117fcc911506 | |a198969379144
--- Comment #7 from Zebediah Figura z.figura12@gmail.com --- Marking fixed then.
https://bugs.winehq.org/show_bug.cgi?id=50285
--- Comment #8 from Erich E. Hoover erich.e.hoover@gmail.com --- (In reply to Martin Storsjö from comment #6)
... Thanks! This does seem to work correctly now. And with that in place, the vast majority of the libc++ std::filesystem tests now run correctly in Wine.
Happy I could help, I really appreciate you putting together these test cases - it's helped me to flush out how a lot of this is supposed to work.
There's one or a few issues left though, but the overall status seems to be that almost everything works as it should, at least the aspects that the std::filesystem tests look at (which might not be the whole picture).
If you file bugs for any other issues you see and tag me then I will do my best to look into them :)
https://bugs.winehq.org/show_bug.cgi?id=50285
Erich E. Hoover erich.e.hoover@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #9 from Erich E. Hoover erich.e.hoover@gmail.com --- Fixed in wine-staging 6.4.
-
WineHQ Bugzilla