[Bug 43536] New: Magic Online (Magic The Gathering: Online) Renders set/ mana/etc icons with black background

https://bugs.winehq.org/show_bug.cgi?id=43536

Bug ID: 43536
           Summary: Magic Online  (Magic The Gathering: Online) Renders
                    set/mana/etc icons with black background
           Product: Wine
           Version: 2.14
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: windowscodecs
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 58933
  --> https://bugs.winehq.org/attachment.cgi?id=58933
wine windowscodecs

Has proper transparent background with native windowscodecs (see screenshots)
Not really sure how to debug. 
I'll see if i can make a small test case doing the same that the game is doing.

[Bug 43536] Magic Online (Magic The Gathering: Online) Renders set/mana/ etc icons with black background

https://bugs.winehq.org/show_bug.cgi?id=43536

--- Comment #1 from Anton Romanov  ---
Created attachment 58934
  --> https://bugs.winehq.org/attachment.cgi?id=58934
native windowscodecs

[Bug 43536] WIC can't encode to GUID_WICPixelFormat32bppPBGRA PNG

https://bugs.winehq.org/show_bug.cgi?id=43536

Anton Romanov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Magic Online  (Magic The    |WIC can't encode to
                   |Gathering: Online) Renders  |GUID_WICPixelFormat32bppPBG
                   |set/mana/etc icons with     |RA PNG
                   |black background            |

[Bug 43536] WIC can't encode to GUID_WICPixelFormat32bppPBGRA PNG

https://bugs.winehq.org/show_bug.cgi?id=43536

--- Comment #2 from Anton Romanov  ---
So, this happens since app renders to PNG specifying
GUID_WICPixelFormat32bppPBGRA pixelformat and wine's windowscodesc does not
support that and falls back to RGB and loses alpha channel completely
If I just add 
{&GUID_WICPixelFormat32bppPBGRA, 32, 8, PNG_COLOR_TYPE_RGB_ALPHA, 0, 1},

to png_pixelformats in pngformat.c then it all works perfectly

(though only because all pictures it uses have either 0 or 255 alpha)

[Bug 43536] WIC can't encode to GUID_WICPixelFormat32bppPBGRA PNG

https://bugs.winehq.org/show_bug.cgi?id=43536

--- Comment #3 from Anton Romanov  ---
actually, I guess just moving 32bppRGBA to be the first one so that its
returned if no match found is better. No need to worry about premultiplied
alpha and default pixelformat still has alpha

[Bug 43536] WIC can't encode to GUID_WICPixelFormat32bppPBGRA PNG

https://bugs.winehq.org/show_bug.cgi?id=43536

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Gijs Vermeulen  ---
Should be fixed by
https://source.winehq.org/git/wine.git/commit/267bca1f3b17ee22ba24972ad10757...

[Bug 43536] WIC can't encode to GUID_WICPixelFormat32bppPBGRA PNG

https://bugs.winehq.org/show_bug.cgi?id=43536

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
      Fixed by SHA1|                            |267bca1f3b17ee22ba24972ad10
                   |                            |757d997d01a20
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #5 from Alistair Leslie-Hughes  ---
Reported as fixed.

[Bug 43536] WIC can't encode to GUID_WICPixelFormat32bppPBGRA PNG

https://bugs.winehq.org/show_bug.cgi?id=43536

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard  ---
Closing bugs fixed in 2.16.

[Bug 43536] WIC can't encode to GUID_WICPixelFormat32bppPBGRA PNG

https://bugs.winehq.org/show_bug.cgi?id=43536

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |2.0.x

[Bug 43536] WIC can't encode to GUID_WICPixelFormat32bppPBGRA PNG

https://bugs.winehq.org/show_bug.cgi?id=43536

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|2.0.x                       |---

--- Comment #7 from Michael Stefaniuc  ---
Removing the 2.0.x milestone from bugs included in 2.0.4.