[Bug 39875] New: Starcraft can't see Direct Cable Connection games hosted on another computer

https://bugs.winehq.org/show_bug.cgi?id=39875

Bug ID: 39875
           Summary: Starcraft can't see Direct Cable Connection games
                    hosted on another computer
           Product: Wine
           Version: 1.9.0
          Hardware: x86
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: ntdll
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 53242
  --> https://bugs.winehq.org/attachment.cgi?id=53242
hack

To reproduce:
1. Add 8250.nr_uarts=<n> to the Linux kernel command line on both computers,
where <n> is the number of serial ports physically present on your motherboard.
This is necessary because of bug 39793.
2. Reboot both computers to reload the kernel parameters.
3. Hook up your null modem serial cable.
4. On both computers, open Starcraft and click Multiplayer, Direct Cable
Connection, Ok.
5. Create a game.

The game does not appear on the other computer until the hosts leaves. Then the
game appears, but you get an error dialog if you try to join it.

If one of the two connected computers is a real Windows machine, there is no
problem as long as the Linux machine hosts the game.

The attached patch fixes Starcraft, but almost certainly breaks some other
application.

[Bug 39875] Starcraft can't see Direct Cable Connection games hosted on another computer

https://bugs.winehq.org/show_bug.cgi?id=39875

Alex Henrie  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 39875] Starcraft can't see Direct Cable Connection games hosted on another computer

https://bugs.winehq.org/show_bug.cgi?id=39875

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 39875] Starcraft can't see Direct Cable Connection games hosted on another computer

https://bugs.winehq.org/show_bug.cgi?id=39875

--- Comment #1 from Alex Henrie  ---
Created attachment 53426
  --> https://bugs.winehq.org/attachment.cgi?id=53426
Test program that demonstrates the problem

Testing revealed that Starcraft sets ReadIntervalTimeout to 5 and all other
COMMTIMEOUTS members to 0. The problem, as demonstrated by the attached test
program, appears to be that Wine ignores ReadIntervalTimeout if the read is
asynchronous and so the read operation never times out.

I've tried editing server/serial.c to take the interval timeout into account,
but nothing I can think of is very elegant. Help from other developers would
really be appreciated.

[Bug 39875] Starcraft can't see Direct Cable Connection games hosted on another computer

https://bugs.winehq.org/show_bug.cgi?id=39875

Alex Henrie  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |hardware, patch, testcase

[Bug 39875] Starcraft can't see Direct Cable Connection games hosted on another computer

https://bugs.winehq.org/show_bug.cgi?id=39875

Alex Henrie  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|ntdll                       |wineserver

[Bug 39875] Starcraft can't see Direct Cable Connection games hosted on another computer

https://bugs.winehq.org/show_bug.cgi?id=39875

Saulius K.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 39875] Starcraft can't see Direct Cable Connection games hosted on another computer

https://bugs.winehq.org/show_bug.cgi?id=39875

Alex Henrie  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |bc0bf9e505922b81df1c317d649
                   |                            |3665bbe946554
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #2 from Alex Henrie  ---
Fixed by
https://source.winehq.org/git/wine.git/commitdiff/bc0bf9e505922b81df1c317d64...

[Bug 39875] Starcraft can't see Direct Cable Connection games hosted on another computer

https://bugs.winehq.org/show_bug.cgi?id=39875

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
   Target Milestone|---                         |1.8.x

[Bug 39875] Starcraft can't see Direct Cable Connection games hosted on another computer

https://bugs.winehq.org/show_bug.cgi?id=39875

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Alexandre Julliard  ---
Closing bugs fixed in 1.9.3.

[Bug 39875] Starcraft can't see Direct Cable Connection games hosted on another computer

https://bugs.winehq.org/show_bug.cgi?id=39875

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|1.8.x                       |---

--- Comment #4 from Michael Stefaniuc  ---
Removing 1.8.x milestone from bugs included in 1.8.2.

[Bug 39875] Starcraft can' t see Direct Cable Connection games hosted on another computer

https://bugs.winehq.org/show_bug.cgi?id=39875

Alex Henrie  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |https://bugs.winehq.org/sho
                   |                            |w_bug.cgi?id=40540