[Bug 13015] New: ProntoEdit NG 2.1.8 help: some images broken

http://bugs.winehq.org/show_bug.cgi?id=13015

Summary: ProntoEdit NG 2.1.8 help: some images broken
           Product: Wine
           Version: 0.9.61.
          Platform: Other
               URL: http://www.remotecentral.com/cgi-
                    bin/files/rcfiles.cgi?area=prontong&db=other&br=programs
                    &dv=philipsprontong&md=philipsprontoproeditng&kw=&st=&ar
                    =&dt=&so=&pg=1&file=prontong/programs/ProntoProEditNG_v2
                    .1.8.zip
        OS/Version: other
            Status: NEW
          Keywords: download
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

ProntoEdit's help seems to work, but all the images show up
as broken icons.

To work around bug 13013, do
  sh winetricks vcrun6 cc580
before starting.

Then to reproduce the problem, press F1 and open the help
page "Help Pages".  You will see some text and a row of broken icons.

[Bug 13015] ProntoEdit NG 2.1.8 help: some images broken

http://bugs.winehq.org/show_bug.cgi?id=13015

--- Comment #1 from Tijl Coosemans   2008-05-07 04:33:50 ---
FL Studio 8 Demo has the same problem.

[Bug 13015] ProntoEdit NG 2.1.8 help: some images broken

http://bugs.winehq.org/show_bug.cgi?id=13015

Sylvain Petreolle  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 13015] ProntoEdit NG 2.1.8 help: some images broken

http://bugs.winehq.org/show_bug.cgi?id=13015

--- Comment #2 from Jeff Zaroyko   2008-12-23 05:11:53 ---
confirming still present with 1.1.11, also affects PowerBasic help.

[Bug 13015] ProntoEdit NG 2.1.8 help: some images broken

http://bugs.winehq.org/show_bug.cgi?id=13015

--- Comment #3 from Jeff Zaroyko   2008-12-23 05:26:30 ---
Looking the various .chm files I have on my system it also affects
GraphicsGale, TortoiseSVN and LiteC help, probably dozens more.

[Bug 13015] ProntoEdit NG 2.1.8 help: some images broken

http://bugs.winehq.org/show_bug.cgi?id=13015

James Fuller  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 13015] images broken in many chm files

http://bugs.winehq.org/show_bug.cgi?id=13015

Jeff Zaroyko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major
            Summary|ProntoEdit NG 2.1.8 help:   |images broken in many chm
                   |some images broken          |files

--- Comment #4 from Jeff Zaroyko   2008-12-30 21:52:50 ---
I've had a dig at this, it seems the wrong URLs for images are being passed to
itss.  Here's an excerpt trace for a chm that has a relative image
"pics/tuto00.gif".

0009:Call urlmon.CoInternetCombineUrl(01c071d0
L"mk:@MSITStore:Z:/home/jeffz/chm/GaleUS.chm::tutorial01.html",0032a0d0
L"pics/tuto00.gif",06000000,0032b118 L"\60d0\01e7@",00000824,0032c160,00000000)
ret=7e\
159e14
0009:trace:urlmon:parse_schema
(L"mk:@MSITStore:Z:/home/jeffz/chm/GaleUS.chm::tutorial01.html" 00000000
0x329f10 64 0x329f90)
0009:Call shlwapi.UrlCombineW(01c071d0
L"mk:@MSITStore:Z:/home/jeffz/chm/GaleUS.chm::tutorial01.html",0032a0d0
L"pics/tuto00.gif",0032b118 L"\60d0\01e7@",00329fe8,06000000) ret=7e3cdc97

0009:trace:shell:UrlCombineW no scheme detected in Relative
...
0009:trace:shell:UrlCanonicalizeW
(L"mk:@MSITStore:Z:/home/jeffz/chm/GaleUS.chm::tutorial01.html/pics/tuto00.gif",
0x18c918, 0x329fe8, 0x06000000) *pcchCanonicalized: 2084
...
0009:Ret  shlwapi.UrlCombineW() retval=00000000 ret=7e3cdc97
0009:Ret  urlmon.CoInternetCombineUrl() retval=00000000 ret=7e159e14

incorrect URL appears: should be
mk:@MSITStore:Z:/home/jeffz/chm/GaleUS.chm::/pics/tuto00.gif
And then in itss: the resulting bad url is used:

0009:trace:itss:ITS_IParseDisplayNameImpl_ParseDisplayName 0x1e75040
L"@MSITStore:Z:/home/jeffz/chm/GaleUS.chm::tutorial01.html/pics/tuto00.gif"
0x32e0c0 0x32e
0009:trace:itss:ITS_IMoniker_create -> 0x1c0a460
L"Z:/home/jeffz/chm/GaleUS.chm" L"tutorial01.html/pics/tuto00.gif"0cc
0009:trace:itss:ITSS_IStorageImpl_OpenStream Resolving
L"/tutorial01.html/pics/tuto00.gif"
0009:warn:itss:ITSS_IStorageImpl_OpenStream Could not resolve object

And so the broken image place holder is displayed instead.  Revising summary
and setting severity to major as this affects many applications.

[Bug 13015] images broken in many chm files

http://bugs.winehq.org/show_bug.cgi?id=13015

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |1.2.0

--- Comment #5 from Dan Kegel   2008-12-30 21:57:30 ---
That analysis seems like it might be enough for
someone to fix it.  Since it affects lots of
apps, nominating for 1.2.

[Bug 13015] images broken in many chm files

http://bugs.winehq.org/show_bug.cgi?id=13015

nathan.n  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 13015] images broken in many chm files

http://bugs.winehq.org/show_bug.cgi?id=13015

Ken Sharp  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 13015] images broken in many chm files

http://bugs.winehq.org/show_bug.cgi?id=13015

--- Comment #6 from nathan.n   2009-05-17 09:03:53 ---
Possibly relevant.

Missing Pictures in Windows Help and Support 
(
http://www.geoffchappell.com/viewer.htm?doc=notes/windows/help/lostimages.ht...
)

[Bug 13015] images broken in many chm files

http://bugs.winehq.org/show_bug.cgi?id=13015

--- Comment #7 from Dan Kegel   2009-05-17 09:49:25 ---
That web page is over quota, but I read it from Google's cache.
It says the cause of images broken in winhlp is often because registry entries
like
    * HKEY_CLASSES_ROOT.png
    * HKEY_CLASSES_ROOT\pngfile
are missing.  I don't think that's the problem.

The help viewer now crashes instead of showing broken images.
Cleanest way to reproduce is
$ wine start ProntoProEdit\ NG.chm 
Here's the core bit:

0017:Call oleaut32.SysAllocString(001990c8 L"mk:@MSITStore:C:/Program
Files/Philips/ProntoProEdit NG/ProntoProEdit NG.chm::ProntoProEdit.htm")
ret=7e01bba7
0017:Ret  oleaut32.SysAllocString() retval=0019bba4 ret=7e01bba7
0017:Call advapi32.RegOpenKeyW(80000000,0019bba0 L"MIME\Database\Content
Type\\6964\3e76\213c\2d2d\7d7d\6e65\2164\616b\6f64\2d76\3e2d\0a0d\703c\6320\616c\7373\453d\646e\542d\706f\6369\263e\626e\7073\3c3b\702f\0d3e\0d0a\3c0a\622f\646f\3e79\0a0d\0a0d\2f3c\7468\6c6d\0d3e\nt/html",0033f444)
ret=7e281c76
0017:Ret  advapi32.RegOpenKeyW() retval=00000002 ret=7e281c76
fixme:urlmon:create_object Could not find object for MIME
L"\6964\3e76\213c\2d2d\7d7d\6e65\2164\616b\6f64\2d76\3e2d\0a0d\703c\6320\616c\7373\453d\646e\542d\706f\6369\263e\626e\7073\3c3b\702f\0d3e\0d0a\3c0a\622f\646f\3e79\0a0d\0a0d\2f3c\7468\6c6d\0d3e\nt/html"
trace:seh:raise_exception code=c0000005 flags=0 addr=0x7e283fd0 ip=7e283fd0
tid=0017

Oddly, I don't then get a backtrace.  (Is our new crash dialog blocking that?)

[Bug 13015] images broken in many chm files

http://bugs.winehq.org/show_bug.cgi?id=13015

Jeff Zaroyko  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #8 from Jeff Zaroyko   2009-08-07 19:02:32 ---
fixed by:
commit c689451cd1e39e93b174043e345d0f64c14273d2
Author: Vincent Povirk 
Date:   Fri Aug 7 15:27:18 2009 +0200

hhctrl.ocx: Ensure that the topic within MSITStore url's begins with /.

Tested three different chm's litec.chm, PainterHlp.chm, QuickStartTutorials.chm
- all display the images fine now.  Marking fixed.

[Bug 13015] images broken in many chm files

http://bugs.winehq.org/show_bug.cgi?id=13015

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard   2009-08-21 12:15:12 ---
Closing bugs fixed in 1.1.28.

[Bug 13015] images broken in many chm files

http://bugs.winehq.org/show_bug.cgi?id=13015

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard  2009-08-21 12:15:12 CDT ---
Closing bugs fixed in 1.1.28.