[Bug 13659] New: dogfood: xchat-2.8.4-1 does not install (quoting between CreateProcessW and wmain)
http://bugs.winehq.org/show_bug.cgi?id=13659
Summary: dogfood: xchat-2.8.4-1 does not install (quoting between CreateProcessW and wmain) Product: Wine Version: 1.0-rc3 Platform: PC URL: http://appdb.winehq.org/objectManager.php?sClass=version &iId=12209 OS/Version: Linux Status: NEW Keywords: download, Installer, source Severity: normal Priority: P2 Component: kernel32 AssignedTo: wine-bugs@winehq.org ReportedBy: wine.dev@web.de
Created an attachment (id=13647) --> (http://bugs.winehq.org/attachment.cgi?id=13647) +loaddll,+tid,+process,+cmd and extra printf
Install of xchat-2.8.4-1.exe (http://www.silverex.org/download/xchat-2.8.4-1.exe ) fails due to a quote Problem between CreateProcessW and libs/wine/loader.c:
Still correct: 0040:trace:process:CreateProcessW app (null) cmdline L""C:\windows\system32\cmd.exe" /C ""C:\windows\temp\is-TNQIK.tmp\update-modules.bat" "C:\Programme\X-Chat 2\lib\pango-querymodules.exe" "C:\Programme\X-Chat 2\etc\pango\pango.modules"""
Broken in cmd.exe: 001c:trace:cmd:wmain /c command line: 'L""C:\windows\temp\is-TNQIK.tmp\update-modules.bat C:\Programme\X-Chat" "2\lib\pango-querymodules.exe C:\Programme\X-Chat" 2\etc\pango\pango.modules"'
the update-modules is really simple: --- cut ---
%1 > %2
--- cut ---
http://bugs.winehq.org/show_bug.cgi?id=13659
--- Comment #1 from Austin English austinenglish@gmail.com 2008-12-26 17:55:16 --- Still present in git.
http://bugs.winehq.org/show_bug.cgi?id=13659
Erich Hoover ehoover@mines.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ehoover@mines.edu
--- Comment #2 from Erich Hoover ehoover@mines.edu 2009-01-31 22:17:07 --- I ran into this recently looking into another issue, are you sure this is a problem in CreateProcess? My memory of creating command-line windows applications was that the application had to handle any quoted strings. You could try grabbing a windows cmd.exe, use winecfg to have it take priority, and then test to see if that works around the problem.
http://bugs.winehq.org/show_bug.cgi?id=13659
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |focht@gmx.net
--- Comment #3 from Anastasius Focht focht@gmx.net 2009-02-01 04:33:22 --- Hello,
--- quote --- My memory of creating command-line windows applications was that the application had to handle any quoted strings. You could try grabbing a windows cmd.exe, use winecfg to have it take priority, and then test to see if that works around the problem. --- quote ---
Correct. I described the problem in bug 14786 (technically a duplicate of this bug). In short: Cmd.exe "/C" is a bit special hence C runtime argvW[] can't be used. You need to use GetCommandLineW and manually apply quoting/dequoting rules.
Regards
http://bugs.winehq.org/show_bug.cgi?id=13659
Jeff Zaroyko jeffz@jeffz.name changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jeffz@jeffz.name
http://bugs.winehq.org/show_bug.cgi?id=13659
Jerome Leclanche adys.wh@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |adys.wh@gmail.com
--- Comment #4 from Jerome Leclanche adys.wh@gmail.com 2009-06-16 23:56:49 --- Still present in git.
C:\Program Files\X-Chat 2\lib>C:\Program" > Files\X-Chat File not found
fixme:shell:DllCanUnloadNow stub fixme:shell:DllCanUnloadNow stub fixme:shell:DllCanUnloadNow stub C:\Program Files\X-Chat 2\lib>C:\Program" gtk-2.0\2.10.0\loaders*.dll > Files\X-Chat File not found
C:\Program Files\X-Chat 2\lib>C:\Program" > Files\X-Chat File not found
GTK doesn't install, xchat cannot be started.
http://bugs.winehq.org/show_bug.cgi?id=13659
--- Comment #5 from Jerome Leclanche adys.wh@gmail.com 2009-10-25 17:39:17 --- Still present in wine-1.1.32.
http://bugs.winehq.org/show_bug.cgi?id=13659
nathan.n saturn_systems@yahoo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |saturn_systems@yahoo.com
--- Comment #6 from nathan.n saturn_systems@yahoo.com 2010-11-04 03:41:21 CDT --- Installation fails in wine 1.3.6
Current terminal output -- C:\Program Files\X-Chat 2\lib>C:\Program" > Files\X-Chat File not found
C:\Program Files\X-Chat 2\lib>C:\Program" gtk-2.0\2.10.0\loaders*.dll > Files\X-Chat File not found
C:\Program Files\X-Chat 2\lib>C:\Program" > Files\X-Chat File not found
http://bugs.winehq.org/show_bug.cgi?id=13659
--- Comment #7 from Austin English austinenglish@gmail.com 2011-05-02 13:41:01 CDT --- Still in 1.3.19.
http://bugs.winehq.org/show_bug.cgi?id=13659
Frédéric Delanoy frederic.delanoy@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic.delanoy@gmail.com, | |us@edmeades.me.uk
--- Comment #8 from Frédéric Delanoy frederic.delanoy@gmail.com 2013-07-06 08:26:34 CDT --- Still in wine-1.6-rc4-52-g9a0b434
http://bugs.winehq.org/show_bug.cgi?id=13659
--- Comment #9 from Jason Edmeades us@edmeades.me.uk 2013-07-07 14:49:44 CDT ---
Still in wine-1.6-rc4-52-g9a0b434
Are you sure? Wine cmd changed ages ago away from argv/c processing of its command line to a 'getcommanelinew' form. I ran the installer, and it looks ok?
jason@jason-VirtualBox:/media/sf_VMShared$ wine xchat-2.8.4-1.exe fixme:msg:ChangeWindowMessageFilter c045 00000001 fixme:win:DisableProcessWindowsGhosting : stub fixme:sfc:SfcIsFileProtected ((nil), L"C:\Program Files\X-Chat 2\unins000.exe") stub
C:\Program Files\X-Chat 2\lib>"C:\Program Files\X-Chat 2\lib\gtk-query-immodules-2.0.exe" > "C:\Program Files\X-Chat 2\etc\gtk-2.0\gtk.immodules"
C:\Program Files\X-Chat 2\lib>"C:\Program Files\X-Chat 2\lib\gdk-pixbuf-query-loaders.exe" gtk-2.0\2.10.0\loaders*.dll > "C:\Program Files\X-Chat 2\etc\gtk-2.0\gdk-pixbuf.loaders"
C:\Program Files\X-Chat 2\lib>"C:\Program Files\X-Chat 2\lib\pango-querymodules.exe" > "C:\Program Files\X-Chat 2\etc\pango\pango.modules"
This looks fixed to me (on 1.6rc2, but to be honest I don't think anything has changed in this area since then - just building rc4 at the moment to test on)
http://bugs.winehq.org/show_bug.cgi?id=13659
--- Comment #10 from Frédéric Delanoy frederic.delanoy@gmail.com 2013-07-07 15:31:59 CDT --- (In reply to comment #9)
Still in wine-1.6-rc4-52-g9a0b434
Are you sure? Wine cmd changed ages ago away from argv/c processing of its command line to a 'getcommanelinew' form. I ran the installer, and it looks ok?
Probably not related to cmd anymore, bug xchat doesn't install correctly yet, e.g. the libgtk aren't installed correctly:
err:module:import_dll Library libgtk-win32-2.0-0.dll (which is needed by L"C:\Program Files\X-Chat 2\xchat.exe") not found err:module:import_dll Library libgdk-win32-2.0-0.dll (which is needed by L"C:\Program Files\X-Chat 2\xchat.exe") not found ...
when you try to run it.
https://bugs.winehq.org/show_bug.cgi?id=13659
Frédéric Delanoy frederic.delanoy@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED
--- Comment #11 from Frédéric Delanoy frederic.delanoy@gmail.com --- Original bug fixed. Marking resolved.
https://bugs.winehq.org/show_bug.cgi?id=13659
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #12 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 1.7.53.
-
wine-bugs＠winehq.org