[Bug 14828] New: Fine-tuning for include parameters

http://bugs.winehq.org/show_bug.cgi?id=14828

Summary: Fine-tuning for include parameters
           Product: Wine
           Version: CVS/GIT
          Platform: All
        OS/Version: All
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P3
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=15376)
 --> (http://bugs.winehq.org/attachment.cgi?id=15376)
conditional construction of the variable "INCLUDES"

I have noticed a command like the following during the build process on my
system.

gcc -m32 -c -I. -I. -I../../include -I../../include   -D_REENTRANT -fPIC -Wall
-pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings
-Wtype-limits -Wpointer-arith  -g -O2  -o send.o send.c

Would you like to avoid duplicate include parameters for the compilation?

http://source.winehq.org/git/wine.git?a=blob;f=Make.rules.in;h=b46a573e69d85...

[Bug 14828] Fine-tuning for include parameters

http://bugs.winehq.org/show_bug.cgi?id=14828

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 14828] Fine-tuning for include parameters

http://bugs.winehq.org/show_bug.cgi?id=14828

Markus Elfring  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #15376|0                           |1
        is obsolete|                            |

--- Comment #1 from Markus Elfring   2008-08-11 09:15:21 ---
Created an attachment (id=15377)
 --> (http://bugs.winehq.org/attachment.cgi?id=15377)
conditional construction of the variable "INCLUDES"

Are the suggested conditions portable enough for your software requirements?

[Bug 14828] Fine-tuning for include parameters

http://bugs.winehq.org/show_bug.cgi?id=14828

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|CVS/GIT                     |unspecified

--- Comment #2 from Austin English   2009-01-20 02:39:49 ---
Removing deprecated CVS/GIT version tag. Please retest in current git. If the
bug is still present in today's wine, but was not present in some earlier
version of wine, please update version field to earliest known version of wine
that had the bug. Thanks!

[Bug 14828] Fine-tuning for include parameters

http://bugs.winehq.org/show_bug.cgi?id=14828

--- Comment #3 from Austin English   2009-07-21 13:06:47 ---
Please send patches to [e-mail]

[Bug 14828] Fine-tuning for include parameters

http://bugs.winehq.org/show_bug.cgi?id=14828

--- Comment #4 from Alexandre Julliard   2009-07-22 14:16:51 ---
No, if() conditions in makefiles are not portable.

[Bug 14828] Fine-tuning for include parameters

http://bugs.winehq.org/show_bug.cgi?id=14828

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
           Platform|All                         |Other
         Resolution|                            |WONTFIX
         OS/Version|All                         |other

--- Comment #5 from Dmitry Timoshkov   2009-07-22 20:33:05 ---
Wontfix.

[Bug 14828] Fine-tuning for include parameters

http://bugs.winehq.org/show_bug.cgi?id=14828

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Dmitry Timoshkov   2009-07-22 20:33:32 ---
Closing.

[Bug 14828] Fine-tuning for include parameters

http://bugs.winehq.org/show_bug.cgi?id=14828

Markus Elfring  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|CLOSED                      |UNCONFIRMED
         Resolution|WONTFIX                     |

--- Comment #7 from Markus Elfring   2009-07-23 02:02:16 ---
Can a special autoconf macro build the variable content without duplicate data?
Would you like to suggest an alternative way to perform the makefile clean-up
with condition support?

[Bug 14828] Fine-tuning for include parameters

http://bugs.winehq.org/show_bug.cgi?id=14828

--- Comment #8 from Alexandre Julliard   2009-07-23 03:21:02 ---
It's not worth the trouble. A couple of extra -I options doesn't hurt anything.

[Bug 14828] Fine-tuning for include parameters

http://bugs.winehq.org/show_bug.cgi?id=14828

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |WONTFIX

--- Comment #9 from Dmitry Timoshkov   2009-07-23 03:38:27 ---
Wontfix.

[Bug 14828] Fine-tuning for include parameters

http://bugs.winehq.org/show_bug.cgi?id=14828

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #10 from Dmitry Timoshkov   2009-07-23 03:38:50 ---
Closing.