[Bug 47278] New: Europa Universalis 4 Golden Century require TGA support in D3DXSaveSurfaceToFileInMemory

https://bugs.winehq.org/show_bug.cgi?id=47278

Bug ID: 47278
           Summary: Europa Universalis 4 Golden Century require TGA
                    support in D3DXSaveSurfaceToFileInMemory
           Product: Wine
           Version: 4.9
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: directx-d3dx9
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

HI.
As the title says, Europa Universalis 4 Golden Century (so version 1.28.3
Spain), require TGA file support for D3DXSaveSurfaceToFileInMemory function.
In the log there is :
0057:fixme:d3dx:D3DXSaveSurfaceToFileInMemory File format 0x2 is not supported
yet

After the line the application catch a MEMORY_ACCESS_VIOLATION  and close
itself.

In the log there is also a bunch of:
0057:fixme:d3dx:D3DXLoadSurfaceFromMemory Unhandled filter 0x80004.

For now winetricks d3d9x_43 is a workaround

[Bug 47278] Europa Universalis 4 Golden Century require TGA support in D3DXSaveSurfaceToFileInMemory

https://bugs.winehq.org/show_bug.cgi?id=47278

--- Comment #1 from Lorenzo Ferrillo  ---
Created attachment 64578
  --> https://bugs.winehq.org/attachment.cgi?id=64578
D3DXSaveSurfaceToFileInMemory allow TGA destination format

This patch allow the game to work without native d3dx9_43.dll

Note that to fully work it will require native d3dcompiler.

[Bug 47278] Europa Universalis 4 Golden Century require TGA support in D3DXSaveSurfaceToFileInMemory

https://bugs.winehq.org/show_bug.cgi?id=47278

--- Comment #2 from Lorenzo Ferrillo  ---
Created attachment 64579
  --> https://bugs.winehq.org/attachment.cgi?id=64579
Add test for TGA

Also the relevant test addition

I submitted a job on the testbot. If it don't fail then I will try to submit
the patch on devel

[Bug 47278] Europa Universalis 4 Golden Century require TGA support in D3DXSaveSurfaceToFileInMemory

https://bugs.winehq.org/show_bug.cgi?id=47278

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 47278] Europa Universalis 4 Golden Century require TGA support in D3DXSaveSurfaceToFileInMemory

https://bugs.winehq.org/show_bug.cgi?id=47278

pattietreutel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 47278] Multiple games and applications require TGA support in D3DXSaveSurfaceToFileInMemory (Europa Universalis 4 Golden Century, ShaderMap 4.x)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47278

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
            Summary|Europa Universalis 4 Golden |Multiple games and
                   |Century require TGA support |applications require TGA
                   |in                          |support in
                   |D3DXSaveSurfaceToFileInMemo |D3DXSaveSurfaceToFileInMemo
                   |ry                          |ry (Europa Universalis 4
                   |                            |Golden Century, ShaderMap
                   |                            |4.x)
                URL|                            |https://web.archive.org/web
                   |                            |/20201001100355/https://sha
                   |                            |dermap.com/downloads/_softw
                   |                            |are.php?v=4
     Ever confirmed|0                           |1
           Keywords|                            |download
             Status|UNCONFIRMED                 |NEW

--- Comment #3 from Anastasius Focht  ---
Hello folks,

ShaderMap 4.x from bug 48217 also needs this:

https://web.archive.org/web/20201001100355/https://shadermap.com/downloads/_...

--- snip ---
$ pwd
/home/focht/.wine/drive_c/Program Files/ShaderMap 4/bin

$ wine ./ShaderMap.exe
...
wine: Call from 000000007B012AF2 to unimplemented function
msvcr120.dll.?_NewCollection@_AsyncTaskCollection@details@Concurrency@@SAPEAV123@PEAV_CancellationTokenState@23@@Z,
aborting
wine: Unimplemented function
msvcr120.dll.?_NewCollection@_AsyncTaskCollection@details@Concurrency@@SAPEAV123@PEAV_CancellationTokenState@23@@Z
called at address 000000007B012AF2 (thread 00c0), starting debugger...
--- snip ---

After 'winetricks -q vcrun2013':

--- snip ---
00c0:fixme:d3dcompiler:compile_shader Compilation target "fx_2_0" not yet
supported
--- snip ---

-> 'winetricks -q d3dcompiler_47'

--- snip ---
01f4:fixme:d3dx:D3DXLoadSurfaceFromMemory Unhandled filter 0x80004.
01f4:fixme:d3dx:D3DXSaveSurfaceToFileInMemory File format 0x2 is not supported
yet
--- snip ---

$ sha1sum ShaderMap_v4_3_4.exe 
9c375685823246e0b8d76fbdb8288a47ad01fdbd  ShaderMap_v4_3_4.exe

$ du -sh ShaderMap_v4_3_4.exe 
46M    ShaderMap_v4_3_4.exe

$ wine --version
wine-6.0-rc2

Regards

[Bug 47278] Multiple games and applications require TGA support in D3DXSaveSurfaceToFileInMemory (Europa Universalis 4 Golden Century, ShaderMap 4.x)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47278

--- Comment #4 from Gijs Vermeulen  ---
Created attachment 76429
  --> https://bugs.winehq.org/attachment.cgi?id=76429
slightly updated patch

Still present with wine-9.8. I've attached a slightly updated patch.

Lorenzo, did you ever send this upstream and if not, would you mind trying now?

[Bug 47278] Multiple games and applications require TGA support in D3DXSaveSurfaceToFileInMemory (Europa Universalis 4 Golden Century, ShaderMap 4.x)

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=47278

Vijay Kamuju  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #5 from Vijay Kamuju  ---
(In reply to Gijs Vermeulen from comment #4)
> Created attachment 76429 [details]
> slightly updated patch
>
> Still present with wine-9.8. I've attached a slightly updated patch.
>
> Lorenzo, did you ever send this upstream and if not, would you mind trying
> now?

It would be better you send in the MR as it would take a lot of time,
mentioning that its based on patch from Lorenzo.