[Bug 13340] New: dicom image viewer aborts because IMultiLanguage2_GetCharsetInfo doesn' t like "ISO8859-1"

http://bugs.winehq.org/show_bug.cgi?id=13340

Summary: dicom image viewer aborts because
                    IMultiLanguage2_GetCharsetInfo doesn't like "ISO8859-1"
           Product: Wine
           Version: CVS/GIT
          Platform: Other
        OS/Version: other
            Status: NEW
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

I had an MRI recently, and got a copy on cd-rom.  The viewer app
crashed quickly on Wine.

trace:mlang:fnIMultiLanguage2_GetCharsetInfo 0x19dce8 L"ISO8859-1" 0x32f5b4
...
0009:Call KERNEL32.lstrcmpiW(01031d58 L"ISO8859-1",0032f524 L"iso-8859-1")
ret=7d52ed97
...
0009:Call oleaut32.SysAllocString(01577b00 L"System does not support the
specified encoding.\r\n") ret=69bf1378
...
wine: Unhandled exception 0x80000003 at address 0x7b83d7c1 (thread 0009),
starting debugger...
Backtrace:
=>1 0x7b83d7c1 DebugBreak+0x3() [wine-git/include/winternl.h:1828] in kernel32
  2 0x7bc54140 call_entry_point+0x20() in ntdll 
  3 0x7bc55118 relay_call_from_32+0x1a1(descr=0x7b8b416c, idx=?,
stack=0x32f8fc) [wine-git/dlls/ntdll/relay.c:372] in ntdll 
  4 0x7b8273c1 in kernel32 (+0x73c1) 
  5 0x69b20265 in msxml4 (+0x10265)
  6 0x004b8a53 in efilmlt (+0xb8a53)

Looks like Windows is more forgiving about how callers
identify charsets.  We were only accepting names
like "iso-8859-1", but Windows accepts "ISO8859-1".

I have test that passes on WinXP, and a patch that fixes both the
test and the real app.  Will send to wine-patches.

[Bug 13340] dicom image viewer aborts because IMultiLanguage2_GetCharsetInfo doesn' t like "ISO8859-1"

http://bugs.winehq.org/show_bug.cgi?id=13340

--- Comment #1 from Dan Kegel   2008-05-23 15:28:29 ---
Patches sent, 
http://winehq.org/pipermail/wine-patches/2008-May/055105.html
http://winehq.org/pipermail/wine-patches/2008-May/055107.html

[Bug 13340] dicom image viewer aborts because IMultiLanguage2_GetCharsetInfo doesn't like "ISO8859-1"

http://bugs.winehq.org/show_bug.cgi?id=13340

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #2 from Austin English   2008-11-23 15:48:11 ---
Is this still an issue in current (1.1.9 or newer) wine?

[Bug 13340] dicom image viewer aborts because IMultiLanguage2_GetCharsetInfo doesn't like "ISO8859-1"

http://bugs.winehq.org/show_bug.cgi?id=13340

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|CVS/GIT                     |unspecified

--- Comment #3 from Austin English   2009-01-19 15:16:04 ---
Removing deprecated CVS/GIT version tag. Please retest in current git. If the
bug is still present in today's wine, but was not present in some earlier
version of wine, please update version field to earliest known version of wine
that had the bug. Thanks!

[Bug 13340] dicom image viewer aborts because IMultiLanguage2_GetCharsetInfo doesn't like "ISO8859-1"

http://bugs.winehq.org/show_bug.cgi?id=13340

Stuart Hillman  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Stuart Hillman   2009-12-05 17:26:36 ---
I'm getting a pop-up telling me the same thing
wine-1.1.33

XML Parser Error
LoadXMLFile:
Error:
Code = 0xc00ce56e
Source = Line: 1; Char: 43
Error Description = System does not support the specified encoding.

I don't get anything out on the commandline.
except maybe 
fixme:ntdll:RtlNtStatusToDosErrorNoTeb no mapping for c0000109

[Bug 13340] dicom image viewer aborts because IMultiLanguage2_GetCharsetInfo doesn't like "ISO8859-1"

http://bugs.winehq.org/show_bug.cgi?id=13340

--- Comment #5 from Dan Kegel   2009-12-05 17:42:13 ---
(It doesn't look like my patches were applied, possibly because
I screwed up the last time I sent them and sent one of them twice?
There's been a lot of work on that file since then, I'd be surprised
if it still has the same bug, but somebody should try my test again.
I would but I'm tied up getting valgrind going with chromium on wine.)

[Bug 13340] dicom image viewer aborts because IMultiLanguage2_GetCharsetInfo doesn't like "ISO8859-1"

http://bugs.winehq.org/show_bug.cgi?id=13340

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from [e-mail]  2010-01-17 06:07:22 ---
I don't know how to use the patches from Dan Kegel

can you say me how to install,
beause i habe the same problem

I'm getting a pop-up telling me the same thing
wine-1.1.36

XML Parser Error
LoadXMLFile:
Error:
Code = 0xc00ce56e
Source = Line: 1; Char: 43
Error Description = System does not support the specified encoding.

I don't know what to do???

I also don't know what to do with the patches I have suse 11.2 with kde

thanks a lot

[Bug 13340] dicom image viewer aborts because IMultiLanguage2_GetCharsetInfo doesn't like "ISO8859-1"

http://bugs.winehq.org/show_bug.cgi?id=13340

--- Comment #7 from [e-mail]  2010-01-17 06:10:35 ---
(In reply to comment #6)
> I don't know how to use the patches from Dan Kegel
>
> can you say me how to install,
> beause i habe the same problem
>
> I'm getting a pop-up telling me the same thing
> wine-1.1.36
>
> XML Parser Error
> LoadXMLFile:
> Error:
> Code = 0xc00ce56e
> Source = Line: 1; Char: 43
> Error Description = System does not support the specified encoding.
>
> I don't know what to do???
>
> I also don't know what to do with the patches I have suse 11.2 with kde
>
> thanks a lot

fixme:actctx:parse_depend_manifests Could not find dependent assembly
L"Microsoft.VC80.MFCLOC" (8.0.50608.0)
fixme:actctx:parse_depend_manifests Could not find dependent assembly
L"Microsoft.VC80.MFCLOC" (8.0.50608.0)
err:shell:SHGetFileInfoW pidl is null!
fixme:win:EnumDisplayDevicesW ((null),0,0x32f0d0,0x00000000), stub!
fixme:d3d:WineD3D_ChoosePixelFormat Add OpenGL context recreation support to
SetDepthStencilSurface
fixme:win:EnumDisplayDevicesW ((null),0,0x32f498,0x00000000), stub!
fixme:win:EnumDisplayDevicesW (L"\\.\DISPLAY1",0,0x32f494,0x00000000), stub!
fixme:win:EnumDisplayDevicesW (L"\\.\DISPLAY1",1,0x32f494,0x00000000), stub!
fixme:win:EnumDisplayDevicesW ((null),1,0x32f494,0x00000000), stub!

this is what in the console view

[Bug 13340] dicom image viewer aborts because IMultiLanguage2_GetCharsetInfo doesn't like "ISO8859-1"

http://bugs.winehq.org/show_bug.cgi?id=13340

--- Comment #8 from Dan Kegel   2010-01-17 08:41:58 ---
User reports app is "dicom viewer efilm xlite"

There is a list of free dicom viewers at
http://www.sph.sc.edu/comd/rorden/dicom.html
some of which support Linux, perhaps that will help as a workaround.

There are trial versions of efilm at 
https://www.merge.com/na/estore/content.aspx?productID=220  (2.x)
https://www.merge.com/na/estore/content.aspx?productID=317  (3.x)
which supposedly come with "efilm lite", which might be what the user is
trying to run.  3.x install fails for me when it tries to install 
SQL Server Express, haven't tried 2.x install yet.

[Bug 13340] dicom image viewer aborts because IMultiLanguage2_GetCharsetInfo doesn't like "ISO8859-1"

http://bugs.winehq.org/show_bug.cgi?id=13340

--- Comment #9 from [e-mail]  2010-01-17 09:07:06 ---
(In reply to comment #8)
> User reports app is "dicom viewer efilm xlite"
>
> There is a list of free dicom viewers at
> http://www.sph.sc.edu/comd/rorden/dicom.html
> some of which support Linux, perhaps that will help as a workaround.
>
> There are trial versions of efilm at 
> https://www.merge.com/na/estore/content.aspx?productID=220  (2.x)
> https://www.merge.com/na/estore/content.aspx?productID=317  (3.x)
> which supposedly come with "efilm lite", which might be what the user is
> trying to run.  3.x install fails for me when it tries to install 
> SQL Server Express, haven't tried 2.x install yet.

Can you explain me how to install your patches?

[Bug 13340] dicom image viewer aborts because IMultiLanguage2_GetCharsetInfo doesn't like "ISO8859-1"

http://bugs.winehq.org/show_bug.cgi?id=13340

--- Comment #10 from Dan Kegel   2010-01-17 09:55:51 ---
Created an attachment (id=25773)
 --> (http://bugs.winehq.org/attachment.cgi?id=25773)
Updated patch, untested

Here's the patch, rediffed against current git (1.1.36)
I only ran the mlang tests, not the affected app, so I don't
know if it still fixes the problem.
See http://wiki.winehq.org/FAQ#head-7ed3c3163e2b932ee2030a48f9c5e553dc41817b
for how to apply patches.

[Bug 13340] dicom image viewer aborts because IMultiLanguage2_GetCharsetInfo doesn't like "ISO8859-1"

http://bugs.winehq.org/show_bug.cgi?id=13340

--- Comment #11 from Dmitry Timoshkov   2010-01-18 23:18:03 ---
Probably charset names should be normalized before comparison, like
dlls/kernel32/locale.c,find_charset() does.

[Bug 13340] dicom image viewer aborts because IMultiLanguage2_GetCharsetInfo doesn't like "ISO8859-1"

http://bugs.winehq.org/show_bug.cgi?id=13340

--- Comment #12 from Dan Kegel   2010-01-18 23:27:12 ---
Isn't that what my patch does?

[Bug 13340] dicom image viewer aborts because IMultiLanguage2_GetCharsetInfo doesn't like "ISO8859-1"

http://bugs.winehq.org/show_bug.cgi?id=13340

--- Comment #13 from Dmitry Timoshkov   2010-01-19 01:01:07 ---
(In reply to comment #12)
> Isn't that what my patch does?

Not really. dlls/kernel32/locale.c,find_charset() removes all non alpha-numeric
characters before comparison and has no special handling for iso or other
charsets.

[Bug 13340] dicom image viewer aborts because IMultiLanguage2_GetCharsetInfo doesn't like "ISO8859-1"

http://bugs.winehq.org/show_bug.cgi?id=13340

joaopa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #14 from joaopa  2011-08-06 04:56:18 CDT ---
still  a bug in current wine?

[Bug 13340] DICOM Viewer (eFilm Workstation 2.x/3.x) aborts because IMultiLanguage2_GetCharsetInfo doesn't like "ISO8859-1"

https://bugs.winehq.org/show_bug.cgi?id=13340

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |0.9.61.
                URL|                            |download.informer.com/win-1
                   |                            |192927756-5dde07e3-53ae07a6
                   |                            |/efilm34.zip
           Keywords|                            |download
           Hardware|Other                       |x86
          Component|-unknown                    |kernel32
                 CC|                            |[e-mail]
            Summary|dicom image viewer aborts   |DICOM Viewer (eFilm
                   |because                     |Workstation 2.x/3.x) aborts
                   |IMultiLanguage2_GetCharsetI |because
                   |nfo doesn't like            |IMultiLanguage2_GetCharsetI
                   |"ISO8859-1"                 |nfo doesn't like
                   |                            |"ISO8859-1"
                 OS|other                       |Linux

--- Comment #15 from Anastasius Focht  ---
Hello folks,

updating fields.
Found only 'eFilm Workstation' v3.4 for download.

--- snip ---
$ ls -1 *.prq
DotNet FrameWork 2.0.prq
Microsoft Data Access Components 2.8 SP1.prq
Microsoft SQL Server 2005 Express.prq
System Requirement check.prq
--- snip ---

The app requires .NET Framework 1.1 + SP1
.NET Framework 2.0 is required for Microsoft SQL Server 2005 Express

Install is blocked by Microsoft SQL Server 2005 Express bugs (hence it
complains "no Microsoft SQL Server found" after running SQLEXPR installer).

$ sha1sum efilm34.zip 
du9a58eeaf6b16880d5cb3a2125bd01d5848114dd1  efilm34.zip

$ du -sh efilm34.zip 
199M    efilm34.zip

$ wine --version
wine-1.7.25

Regards

[Bug 13340] DICOM Viewer (eFilm Workstation 2.x/3.x) aborts because IMultiLanguage2_GetCharsetInfo doesn't like "ISO8859-1"

https://bugs.winehq.org/show_bug.cgi?id=13340

Bernhard Übelacker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #16 from Bernhard Übelacker  ---
Created attachment 55441
  --> https://bugs.winehq.org/attachment.cgi?id=55441
how to extract efilmlite from efilm34.zip .txt

Tried to reproduce this issue with a DVD handed to me.

But could not get the crash described in comment 0.

Instead I get the same message shown in comment 4
except "Error Description" being empty.

This is probably because my version of eFilmLite is from 2010 and
comment 0 is from 2008.
For anyone who wants to test - attached is a description how
to extract the eFilmLite directory from the efilm34.zip download.
  Version 3.4.0 (Build 10)
  Built: Dec  2 2010 04:55:23

If we assume the crash in comment 0 and the message in comment 4 has
the same cause, but is just handled different in the version of 2008 and 2010.
Then this disappeared between wine-1.3.1 and wine-1.3.2

In that time wine got a builtin implementation of msxml6.

Using wine-1.9.17 with native msxml6 via winetricks
leads to the same error message as in comment 4.
(Also with the same "Error Description".)

The error message is not visible with wine-1.9.17 and builtin msxml6.

[Bug 13340] DICOM Viewer (eFilm Workstation 2.x/3.x) aborts because IMultiLanguage2_GetCharsetInfo doesn't like "ISO8859-1"

https://bugs.winehq.org/show_bug.cgi?id=13340

Vijay Kamuju  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #17 from Vijay Kamuju  ---
can anyone test this on wine 4.x, I am having issues installing SQL Server
Express 2005 for this.

[Bug 13340] DICOM Viewer (eFilm Workstation 2.x/3.x) aborts because IMultiLanguage2_GetCharsetInfo doesn't like "ISO8859-1"

https://bugs.winehq.org/show_bug.cgi?id=13340

--- Comment #18 from Bernhard Übelacker  ---
Hello Vijay,
yes I could reproduce this with wine-4.3 and native msxml6
installed via winetricks, when running eFilmLt.exe from dvd.
With builtin msxml6 I could not reproduce the error.

Back in 2016 I got a test committed showing the issue [1].

I found also a local patch from 2016 also trying to fix this.
I am going to attach a rebased version; find a testbot
run in [3].

But this I never submitted because it may have revealed some issue
with word sorting I tried to get some response in [2] first.
Unfortunately then I lost track of it.

Kind regards,
Bernhard

[1]
https://source.winehq.org/git/wine.git/commit/6f3b45d2fb560e5853e26a5ec8b610...

[2] https://www.winehq.org/pipermail/wine-patches/2016-August/153962.html

[3] https://testbot.winehq.org/JobDetails.pl?Key=48571

[Bug 13340] DICOM Viewer (eFilm Workstation 2.x/3.x) aborts because IMultiLanguage2_GetCharsetInfo doesn't like "ISO8859-1"

https://bugs.winehq.org/show_bug.cgi?id=13340

--- Comment #19 from Bernhard Übelacker  ---
Created attachment 63758
  --> https://bugs.winehq.org/attachment.cgi?id=63758
Another attempt to patch IMultiLanguage_GetCharsetInfo.

[Bug 13340] DICOM Viewer (eFilm Workstation 2.x/3.x) aborts because IMultiLanguage2_GetCharsetInfo doesn't like "ISO8859-1"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=13340

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 13340] DICOM Viewer (eFilm Workstation 2.x/3.x) aborts because IMultiLanguage2_GetCharsetInfo doesn't like "ISO8859-1"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=13340

Bernhard Übelacker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #55441|0                           |1
        is obsolete|                            |

--- Comment #20 from Bernhard Übelacker  ---
Created attachment 75292
  --> https://bugs.winehq.org/attachment.cgi?id=75292
how to extract efilmlite from efilm34.zip (2023) and some output.txt

[Bug 13340] DICOM Viewer (eFilm Workstation 2.x/3.x) aborts because IMultiLanguage2_GetCharsetInfo doesn't like "ISO8859-1"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=13340

Bernhard Übelacker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #63758|0                           |1
        is obsolete|                            |

--- Comment #21 from Bernhard Übelacker  ---
Created attachment 75293
  --> https://bugs.winehq.org/attachment.cgi?id=75293
Patch IMultiLanguage_GetCharsetInfo to allow "ISO8859-1"

[Bug 13340] DICOM Viewer (eFilm Workstation 2.x/3.x) aborts because IMultiLanguage2_GetCharsetInfo doesn't like "ISO8859-1"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=13340

--- Comment #22 from Bernhard Übelacker  ---
Revisited this bug and it is still visible.
Download is still possible from:
https://efilm-workstation.software.informer.com/3.4/
Updated the howto to create a directory like on a CD.

The sorting issue I mentioned in comment 18 looks like it
got fixed by wine-7.10 with some Unicode update.

Running with native msxml6 still shows this fault:
> XML Parser Error
> LoadXMLFile 'C:\efilmlite_dvd\eFilmLite\Profiles\
> ToolBarProperties.xml':
> Error:
> Code = 0xc00ce56e
> Source = Line: 1; Char: 43
> Error Description = System does not support the specified encoding.

Updated my patch which adds the alias "iso8859-1" to allow
mlang to recognize it (affects just native msxml6).

[Bug 13340] DICOM Viewer (eFilm Workstation 2.x/3.x) aborts because IMultiLanguage2_GetCharsetInfo doesn't like "ISO8859-1"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=13340

--- Comment #23 from Vijay Kamuju  ---
can you please create an MR for this?

[Bug 13340] DICOM Viewer (eFilm Workstation 2.x/3.x) aborts because IMultiLanguage2_GetCharsetInfo doesn't like "ISO8859-1"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=13340

--- Comment #24 from Bernhard Übelacker  ---
Thanks for having a look, I created a MR:
https://gitlab.winehq.org/wine/wine/-/merge_requests/4616

[Bug 13340] DICOM Viewer (eFilm Workstation 2.x/3.x) aborts because IMultiLanguage2_GetCharsetInfo doesn't like "ISO8859-1"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=13340

Vijay Kamuju  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
      Fixed by SHA1|                            |5a0321ac8cb956cddbad760c5fb
                   |                            |803bdb3c04913

--- Comment #25 from Vijay Kamuju  ---
Fix now committed - 5a0321ac8cb956cddbad760c5fb803bdb3c04913

[Bug 13340] DICOM Viewer (eFilm Workstation 2.x/3.x) aborts because IMultiLanguage2_GetCharsetInfo doesn't like "ISO8859-1"

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=13340

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #26 from Alexandre Julliard  ---
Closing bugs fixed in 9.0-rc1.