[Bug 22696] New: RCT2 crashes when changing screen resolution

http://bugs.winehq.org/show_bug.cgi?id=22696

Summary: RCT2 crashes when changing screen resolution
           Product: Wine
           Version: 1.1.44
          Platform: x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=27963)
 --> (http://bugs.winehq.org/attachment.cgi?id=27963)
RCT2 Crashes with Access Violation error

In Roller Coaster Tycoon 2 when trying to change the screen resolution.
A dialog box is shown (see screenshot) and the application crashes.

This error happens every time when the menu option is clicked.

This function seemed to work in previous versions.

OpenSuse 11.2
ATI Radeon driver 6.12.4 (Mesa 7.8.1) on a ATI X1270
Resolution RCT2 at startup = 1024x768

[Bug 22696] RCT2 crashes when changing screen resolution

http://bugs.winehq.org/show_bug.cgi?id=22696

--- Comment #1 from [e-mail]  2010-05-14 13:45:47 ---
Created an attachment (id=27964)
 --> (http://bugs.winehq.org/attachment.cgi?id=27964)
Output glxinfo

[Bug 22696] RCT2 crashes when changing screen resolution

http://bugs.winehq.org/show_bug.cgi?id=22696

--- Comment #2 from [e-mail]  2010-05-14 13:46:25 ---
Created an attachment (id=27965)
 --> (http://bugs.winehq.org/attachment.cgi?id=27965)
/var/log/Xorg.0.log

[Bug 22696] RCT2 crashes when changing screen resolution

http://bugs.winehq.org/show_bug.cgi?id=22696

--- Comment #3 from [e-mail]  2010-05-14 13:50:24 ---
Created an attachment (id=27966)
 --> (http://bugs.winehq.org/attachment.cgi?id=27966)
Wine output standard error

[Bug 22696] RCT2 crashes when changing screen resolution

http://bugs.winehq.org/show_bug.cgi?id=22696

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Wylda   2010-05-15 18:14:30 ---

Hi Jan, i test the demo and under 1.1.44 i see this only for first time, i.e.
second or latter run i can change resolution. I think it related with file
Data/game.cfg which has after installation just 4 bytes. On latter runs it has
cca 2KB and game does not crash (if i put back the fresh original 4 bytes, game
crashes again on first following run).

Confirming.

[Bug 22696] RCT2 crashes when changing screen resolution

http://bugs.winehq.org/show_bug.cgi?id=22696

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.1.44                      |1.2-rc2

--- Comment #5 from [e-mail]  2010-06-05 12:10:14 ---
Problem is still there with 1.2 RC2

[Bug 22696] RCT2 crashes when changing screen resolution

http://bugs.winehq.org/show_bug.cgi?id=22696

--- Comment #6 from [e-mail]  2010-06-05 12:16:39 ---
With version packetversion wine-1.1.28-2.3.i586
There is no problem at all changing the screen resolution, so somewhere on the
road this problem issue must have slipped in.

[Bug 22696] RCT2 crashes when changing screen resolution

http://bugs.winehq.org/show_bug.cgi?id=22696

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.2-rc2                     |1.1.44

--- Comment #7 from Dmitry Timoshkov   2010-06-08 01:38:16 ---
Adding a comment is enough.

[Bug 22696] RCT2 crashes when changing screen resolution

http://bugs.winehq.org/show_bug.cgi?id=22696

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

--- Comment #8 from Dmitry Timoshkov   2010-06-08 01:39:16 ---
(In reply to comment #6)
> With version packetversion wine-1.1.28-2.3.i586
> There is no problem at all changing the screen resolution, so somewhere on the
> road this problem issue must have slipped in.

Please perform the regression testing and post the results here:
http://wiki.winehq.org/RegressionTesting

[Bug 22696] RCT2 crashes when changing screen resolution

http://bugs.winehq.org/show_bug.cgi?id=22696

--- Comment #9 from [e-mail]  2010-06-11 11:35:12 ---
(In reply to comment #8)
> Please perform the regression testing and post the results here:
> http://wiki.winehq.org/RegressionTesting

Regression testing has been done:
914c8cb8ea1e5cbcfa18558961185dd94313b26d is the first bad commit
commit 914c8cb8ea1e5cbcfa18558961185dd94313b26d
Author: Henri Verbeet 
Date:   Wed Mar 17 21:59:49 2010 +0100

ddraw: Acquire/release the focus window from the correct location.

:040000 040000 7b888e2899b0ce7578c776287fcd5d5597d3625e
db3c70fcea916fc051b1d6b5f19a5e9b4175a6a2 M    dlls
:040000 040000 3fa4b272bdfcdd6f386e8b968a26497aae09d789
31ebd3615f1d2bbbbc991e191c813d77fc16635e M    include

Cannot add: Author: Henri Verbeet  to CC list

[Bug 22696] RCT2 crashes when changing screen resolution

http://bugs.winehq.org/show_bug.cgi?id=22696

--- Comment #10 from Wylda   2010-06-11 12:12:59 ---

I gave it second shot, this time with full version, but can't confirm. Works
perfectly here for full version. Tested under:
 * 1.1.44, 1.2-rc2-288-g95aaaf2
 * nvidia GT240 v195.36.24

Full version of RCT2 gives me 16 available resolutions. I tried them all in
both wine versions. No such problem. Maybe ATI related.

[Bug 22696] RCT2 crashes when changing screen resolution

http://bugs.winehq.org/show_bug.cgi?id=22696

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 22696] RCT2 crashes when changing screen resolution

http://bugs.winehq.org/show_bug.cgi?id=22696

--- Comment #11 from [e-mail]  2010-06-11 15:38:42 ---
Created an attachment (id=28744)
 --> (http://bugs.winehq.org/attachment.cgi?id=28744)
RCT2 standard error on crash

This is the standaard error that is produced when crashing.

[Bug 22696] RCT2 crashes when changing screen resolution

http://bugs.winehq.org/show_bug.cgi?id=22696

--- Comment #12 from [e-mail]  2010-06-11 15:48:31 ---
I can reproduce the error with radeon and radeonhd driver. I do not have a
system without ati board to test with.
The error even occurs when I turn of DRI.

[Bug 22696] RCT2 crashes when changing screen resolution

http://bugs.winehq.org/show_bug.cgi?id=22696

Jörg Höhle  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
                   |                            |t

--- Comment #13 from Jörg Höhle   2010-06-11 19:11:25 ---
I confirm the crash and screenshot with Intel i915 graphics in Ubuntu Intrepid
and the offending commit in comment #9. The crash happens as soon as I click
the 1024x768 button in the options menu, which would normally popup a list of
various resolutions.

Note that the crash only occurs in full-screen mode. Inside a virtual desktop,
everything is fine.

Additionally, that commit causes fullscreen mode to not manage to display the
intro images and animations. Desktop window mode still displays them.

BTW, some admin should probably mark bug #22754 as a duplicate of this one.
And probably add the download keyword, as bug #22754, comment #8 mentions a
demo.

[Bug 22696] RCT2 crashes when changing screen resolution

http://bugs.winehq.org/show_bug.cgi?id=22696

--- Comment #14 from Jörg Höhle   2010-06-11 19:36:08 ---
commit 914c8cb8ea1e5cbcfa18558961185dd94313b26d past wine-1.1.40
affects yet another application: "Käpt'n Säbelzahn die Piratenprüfung"
(a seemingly Swedish production: Sabeltann from Gyldendal Multimedia)
I've not yet found the time to write an AppDB entry for it.

It causes the intro and extro videos not to appear nicely centered in the
640x480 virtual desktop anymore.  Instead, there's a tiny ~200x150 region in
the upper left, with scrollbars(!) but without borders that shows a tiny
section of the videos.  Scrolling the bars reveals more of the video, yet the
videos are larger than that region thus never shown in full.

Logs are similar with git checkout of that commit or its ancestor^:
err:x11settings:X11DRV_ChangeDisplaySettingsEx No matching mode found
640x480x24 @0! (desktop)
fixme:x11drv:X11DRV_desktop_SetCurrentMode Cannot change screen BPP from 32 to
16
err:d3d:swapchain_setup_fullscreen_window Changing the window style for window
0x1007c, but another style (94080000, 00010008) is already stored.

Sadly, another instance where fixing one bug #21426, comment #15 causes new
ones.

Some admin, please set the component to directx-ddraw, like bug #22754.

[Bug 22696] RCT2 crashes when changing screen resolution

http://bugs.winehq.org/show_bug.cgi?id=22696

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #15 from Wylda   2010-06-12 00:18:10 ---
*** Bug 22754 has been marked as a duplicate of this bug. ***

[Bug 22696] RCT2 crashes when changing screen resolution

http://bugs.winehq.org/show_bug.cgi?id=22696

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download
                URL|                            |http://www.fileplanet.com/1
                   |                            |13311/110000/fileinfo/Rolle
                   |                            |rCoaster-Tycoon-Demo-[BMult
                   |                            |i-Lingual]
          Component|-unknown                    |directx-ddraw
            Version|1.1.44                      |1.1.41

--- Comment #16 from Wylda   2010-06-12 00:27:59 ---

Other reports mention, that RTC1 multilingual demo is affected too.

[Bug 22696] RCT2 crashes when changing screen resolution

http://bugs.winehq.org/show_bug.cgi?id=22696

--- Comment #17 from Dmitry Timoshkov   2010-06-12 01:20:55 ---
(In reply to comment #11)
> Created an attachment (id=28744)

--> (http://bugs.winehq.org/attachment.cgi?id=28744) [details]
> RCT2 standard error on crash
>
> This is the standaard error that is produced when crashing.
> fixme:xvidmode:X11DRV_XF86VM_SetCurrentMode Cannot change screen BPP from 32 to 8
> fixme:xrender:X11DRV_AlphaBlend not supported - XRENDER headers were missing at compile time
> fixme:xrender:X11DRV_AlphaBlend not supported - XRENDER headers were missing at compile time
> fixme:xrender:X11DRV_AlphaBlend not supported - XRENDER headers were missing at compile time

Most likely that's your problem. Your Wine is missing xrender support, and
you probably need to manually switch to 8 bpp screen mode.

[Bug 22696] RCT2 crashes when changing screen resolution

http://bugs.winehq.org/show_bug.cgi?id=22696

--- Comment #18 from [e-mail]  2010-06-12 13:26:54 ---
(In reply to comment #17)
> (In reply to comment #11)
> > Created an attachment (id=28744)

--> (http://bugs.winehq.org/attachment.cgi?id=28744) [details] [details]
> > RCT2 standard error on crash
> >
> > This is the standaard error that is produced when crashing.
> > fixme:xvidmode:X11DRV_XF86VM_SetCurrentMode Cannot change screen BPP from 32 to 8
> > fixme:xrender:X11DRV_AlphaBlend not supported - XRENDER headers were missing at compile time
> > fixme:xrender:X11DRV_AlphaBlend not supported - XRENDER headers were missing at compile time
> > fixme:xrender:X11DRV_AlphaBlend not supported - XRENDER headers were missing at compile time
>
> Most likely that's your problem. Your Wine is missing xrender support, and
> you probably need to manually switch to 8 bpp screen mode.

I'am sure this is because i missed some library develop files during
compilation.
The pre compiled package probably will have the correct support. But this was
not a problem during regression testing.

[Bug 22696] RCT2 crashes when changing screen resolution

http://bugs.winehq.org/show_bug.cgi?id=22696

Nicolas  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #19 from Nicolas  2010-12-10 13:58:52 CST ---
*** This bug has been confirmed by popular vote. ***

[Bug 22696] RCT2 crashes when changing screen resolution

http://bugs.winehq.org/show_bug.cgi?id=22696

--- Comment #20 from Jörg Höhle  2010-12-15 03:41:08 CST ---
in comment #13 I confirmed the crash.  Now I can say it's gone in 1.2.1 and
1.2.2.
Switching resolutions works (640/800/1024).

So I say: the crash bug is fixed.

Whether in full screen mode the intro images and animations are displayed or
not depends on the previously stored resolutions: present in 1024x768, absent
in 800x600 and 640x480.

In virtual desktop mode, they are almost always ok, but it seems the desktop
size set in winecfg influences results. Starting with non-matching default
desktop size does not work perfectly: rct2 may use the upper left 640x480 of a
800x600 Wine desktop window only and leave the remaining area in a splendid
green.

What I've not tested again is: did the intros render in all resolutions prior
to the offending commit?

[Bug 22696] RCT2 crashes when changing screen resolution

http://bugs.winehq.org/show_bug.cgi?id=22696

--- Comment #21 from Henri Verbeet  2011-03-07 06:41:21 CST ---
Is this fixed?

[Bug 22696] RCT2 crashes when changing screen resolution

http://bugs.winehq.org/show_bug.cgi?id=22696

Nicolas  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #22 from Nicolas  2011-03-08 09:59:13 CST ---
(In reply to comment #21)
> Is this fixed?

No, this bug is still present in 1.3.15.

[Bug 22696] RCT2 crashes when changing screen resolution

http://bugs.winehq.org/show_bug.cgi?id=22696

--- Comment #23 from [e-mail] 2011-03-10 03:52:37 CST ---
(In reply to comment #22)
> (In reply to comment #21)
> > Is this fixed?
>
> No, this bug is still present in 1.3.15.

AFAIK you can set you resolution lower to workaround the bug.

E.g.
#!/bin/bash
xrandr -s 1280x1024 -r 60
env WINEPREFIX="/home/username/.wine" wine "C:\Program
Files\Infogrames\RollerCoaster Tycoon 2\rct2.exe"
xrandr -s 1920x1200 -r 60

This set the resolution to a value that will work.
After closing the app the resolution will be set back.

This way an error will be avoided and the resolution can be set.

Perhaps Wine should detect better what screen size and coreect them if theay
are not supported in some way is to avoid these problems.

[Bug 22696] RCT2 crashes when changing screen resolution

http://bugs.winehq.org/show_bug.cgi?id=22696

--- Comment #24 from Jörg Höhle  2011-04-22 01:04:12 CDT ---
Nicolas> No, this bug is still present in 1.3.15.
me> Now I can say it's gone in 1.2.1 and 1.2.2. the crash bug is fixed.

I apologize.  Perhaps I fooled myself by incomplete testing (only in virtual
desktop mode?).  As I I wrote in comment #13:
> Note that the crash only occurs in full-screen mode.
> Inside a virtual desktop, everything is fine.

Exactly.  The bug is still present in 1.3.18.
I rebuilt 1.2.1 and the bug is there too.
> What I've not tested again is: did the intros render in
> all resolutions prior to the offending commit?

Yes, they did.

Jan is right in comment #23.  Launching RCT2 in wine-1.3.18 with xrandr set to
1024x768, there's no crash with the change resolution dialog.  It even offers
1280x1024, switches to it but then there's a blue border to the left and
bottom: the usable resolution is still the old one.  Starting with xrandr set
to 1280x1024 (the maximum on list) enabled RCT2 to switch to all proposed
resolutions (640x480 up to 1280x1024, 1400x1050 is always missing).

The symptoms of this bug are really weird.

[Bug 22696] RCT2 crashes when changing screen resolution

http://bugs.winehq.org/show_bug.cgi?id=22696

--- Comment #25 from Jörg Höhle  2011-04-30 03:28:58 CDT ---
Käpt'n Säbelzahn / Captain Sabeltann - see commment #14 - works correctly as of
wine-1.3.19 in both virtual desktop mode and full screen (if the HW can still
switch to 320x240 for the intro).

BTW, my previous comment #24 implies that you cannot observe the bug with RCT2
if your HW offers no resolution above 1280x1024.

In wine-1.3.19, RCT2 does not switch resolutions in virtual desktop mode
anymore.  This is a new regression.  The virtual desktop resizes but the app
leaves the bottom and right border unused.

[Bug 22696] RCT2 crashes when changing screen resolution

http://bugs.winehq.org/show_bug.cgi?id=22696

--- Comment #26 from Wylda  2011-06-21 04:05:51 CDT ---

I retested with yesterday's git with full version and resolution change crashed
for the first time and then on another run it worked correctly. So following is
still valid (from comment #4):

...i see this only for first time, i.e. second or latter run i can change
resolution. I think it related with file Data/game.cfg which has after
installation just 4 bytes. On latter runs it has cca 2KB and game does not
crash (if i put back the fresh original 4 bytes, game crashes again on first
following run).

Sure i could make a backup of .wine dir and examine better.

[Bug 22696] RCT2 crashes when changing screen resolution

http://bugs.winehq.org/show_bug.cgi?id=22696

Henri Verbeet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |914c8cb8ea1e5cbcfa185589611
                   |                            |85dd94313b26d

[Bug 22696] RCT2 crashes when changing screen resolution

http://bugs.winehq.org/show_bug.cgi?id=22696

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|directx-ddraw               |directx-d3d

[Bug 22696] RCT2 crashes when changing screen resolution

http://bugs.winehq.org/show_bug.cgi?id=22696

--- Comment #27 from Henri Verbeet  2012-01-30 10:21:24 CST ---
Created attachment 38603
  --> http://bugs.winehq.org/attachment.cgi?id=38603
patch

I pretty much just can't reproduce this bug with the demo, even on first run.
However, I did notice some memory corruption caused by the application writing
outside a surface. Does the attached patch make any difference?

[Bug 22696] RCT2 crashes when changing screen resolution

http://bugs.winehq.org/show_bug.cgi?id=22696

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://www.fileplanet.com/1 |
                   |13311/110000/fileinfo/Rolle |
                   |rCoaster-Tycoon-Demo-[BMult |
                   |i-Lingual]                  |
                 CC|                            |[e-mail]

--- Comment #28 from Bruno Jesus  2012-07-05 21:20:45 CDT ---
(In reply to comment #27)
> Created attachment 38603 [details]
> patch
>
> I pretty much just can't reproduce this bug with the demo, even on first run.
> However, I did notice some memory corruption caused by the application writing
> outside a surface. Does the attached patch make any difference?

Does not help for RCT2.

Note: the game works flawlessly inside virtual desktop.

[Bug 22696] RCT2 crashes when changing screen resolution

http://bugs.winehq.org/show_bug.cgi?id=22696

--- Comment #29 from Henri Verbeet  2012-08-31 07:54:15 CDT ---
(In reply to comment #28)
> Does not help for RCT2.
>
> Note: the game works flawlessly inside virtual desktop.

What window manager are you using?

[Bug 22696] RCT2 crashes when changing screen resolution

http://bugs.winehq.org/show_bug.cgi?id=22696

--- Comment #30 from Bruno Jesus  2012-09-01 08:10:22 CDT ---
(In reply to comment #29)
> What window manager are you using?

I use a standard debian Gnome 2 installation. The game still works in the
virtual desktop and I can't get it to run without it, I'm getting a libxi crash
just like in the other bug, as soon as they fix this I'll test more.

[Bug 22696] RCT2 crashes when changing screen resolution

http://bugs.winehq.org/show_bug.cgi?id=22696

--- Comment #31 from Henri Verbeet  2012-09-02 09:33:15 CDT ---
(In reply to comment #30)
> I use a standard debian Gnome 2 installation. The game still works in the
> virtual desktop and I can't get it to run without it, I'm getting a libxi crash
> just like in the other bug, as soon as they fix this I'll test more.

Ok. I'm mostly wondering if there's any chance this is related to bug 30603 /
bug 23745. A +seh,+tid,+win,+event TRACE may be useful in that case.

[Bug 22696] RCT2 crashes when changing screen resolution

http://bugs.winehq.org/show_bug.cgi?id=22696

--- Comment #32 from Bruno Jesus  2012-09-02 19:17:19 CDT ---
Almost all games are not running anymore due to the libxi crash. I tried the
latest 1.6.1 version but the crashes still occur. I need to get this fixed to
start testing things again.

[Bug 22696] RCT2 crashes when changing screen resolution

http://bugs.winehq.org/show_bug.cgi?id=22696

--- Comment #33 from Bruno Jesus  2012-11-04 19:08:03 CST ---
After fixing libxi and testing in wine-git I could not longer reproduce the
crashes in resolution changing. I think this can be marked as fixed.

[Bug 22696] RCT2 crashes when changing screen resolution

http://bugs.winehq.org/show_bug.cgi?id=22696

Henri Verbeet  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #34 from Henri Verbeet  2012-11-05 04:05:48 CST ---
(In reply to comment #33)
> After fixing libxi and testing in wine-git I could not longer reproduce the
> crashes in resolution changing. I think this can be marked as fixed.

Resolving FIXED. We can reopen it if anyone can still reproduce this.

[Bug 22696] RCT2 crashes when changing screen resolution

http://bugs.winehq.org/show_bug.cgi?id=22696

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #35 from Alexandre Julliard  2012-11-09 13:00:22 CST ---
Closing bugs fixed in 1.5.17.