[Bug 25149] New: Explzh: show the first letter only in listview or treeview.

http://bugs.winehq.org/show_bug.cgi?id=25149

Summary: Explzh: show the first letter only in listview or
                    treeview.
           Product: Wine
           Version: 1.3.7
          Platform: x86
               URL: http://www.ponsoftware.com/en/archiver/download.htm
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: comctl32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=31897)
 --> (http://bugs.winehq.org/attachment.cgi?id=31897)
Screenshot of Explzh (on wine, winxp)

"Explzh for Windows" is one of well-known file compression/decompression
utility in Japan.

There are two binary version, Japanese version (Ver.5.69a) and English one
(Ver.5.69a_en). English version is still release candidate version.

Both Japanese version and English one show compressed item names with the first
letter only in listview or treeview area when I load an archive file in wine.

How to reproduce:
1) Launch EXPLZH.EXE
2) Open a compressed file. ([File]-[Open Archive] or Drag & drop)
Note: We need a plugin dll file except for lzh/zip/cab/rar archive.

The attachment is showing the problem.
Opening archive is Crystal Disk Mark 3.0i (CrystalDiskMark_3_0_0i.zip). You can
download from http://en.sourceforge.jp/projects/crystaldiskmark/releases/.
But this problem is *not* archive file specific.

[Bug 25149] Explzh: show the first letter only in listview or treeview.

http://bugs.winehq.org/show_bug.cgi?id=25149

--- Comment #1 from Nikolay Sivov  2010-11-13 08:07:17 CST ---
Does native comctl32 help?

[Bug 25149] Explzh: show the first letter only in listview or treeview.

http://bugs.winehq.org/show_bug.cgi?id=25149

--- Comment #2 from Sagawa  2010-11-13 08:40:16 CST ---
Created an attachment (id=31901)
 --> (http://bugs.winehq.org/attachment.cgi?id=31901)
test application

This problem is caused by changing the code of WM_NOTIFY.

In other words, this application acts as follows:
1. Wine (and Windows)'s listview control sends WM_NOTIFY message to
ExplzhWClass window to get item info with LVN_GETDISPINFOA code.
2. Then its window procedure fills LV_DISPINFO structure, and changes the code
to LVN_GETDISPINFOW.
3. Even so, Windows can display correctly on NT systems. But Wine doesn't.

I didn't find any documents of this behavior. Wine should follow this behavior
or not?

I create a small test application of this behavior, and attach it.
Thank you.

[Bug 25149] Explzh: show the first letter only in listview or treeview.

http://bugs.winehq.org/show_bug.cgi?id=25149

Sagawa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

[Bug 25149] Explzh: show the first letter only in listview or treeview.

http://bugs.winehq.org/show_bug.cgi?id=25149

--- Comment #3 from Nikolay Sivov  2010-11-13 08:59:24 CST ---
(In reply to comment #2)
> Created an attachment (id=31901)

--> (http://bugs.winehq.org/attachment.cgi?id=31901) [details]
> test application
>
> This problem is caused by changing the code of WM_NOTIFY.
>
> In other words, this application acts as follows:
> - Wine (and Windows)'s listview control sends WM_NOTIFY message to
>
> ExplzhWClass window to get item info with LVN_GETDISPINFOA code.
> 2. Then its window procedure fills LV_DISPINFO structure, and changes the code
> to LVN_GETDISPINFOW.
> 3. Even so, Windows can display correctly on NT systems. But Wine doesn't.
>
> I didn't find any documents of this behavior. Wine should follow this behavior
> or not?

Does it actually fill with WCHARs while changing code to -W?
Wine controls don't expect a code to be changed, so such sequence will fail
indeed, I'm almost sure about that.

If this works on Windows, then Wine should follow, no doubts.
> I create a small test application of this behavior, and attach it.

Thanks for a test, I'll take a look.

[Bug 25149] Explzh: show the first letter only in listview or treeview.

http://bugs.winehq.org/show_bug.cgi?id=25149

--- Comment #4 from Sagawa  2010-11-13 09:36:24 CST ---
(In reply to comment #3)
> Does it actually fill with WCHARs while changing code to -W?

Yes. It needs to fill with WCHARs.

[Bug 25149] Explzh: show the first letter only in listview or treeview.

http://bugs.winehq.org/show_bug.cgi?id=25149

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |testcase

[Bug 25149] Explzh: show the first letter only in listview or treeview.

http://bugs.winehq.org/show_bug.cgi?id=25149

--- Comment #5 from Nikolay Sivov  2010-11-13 18:20:36 CST ---
Attached archive is broken, this is what Gnome Archive Manager outputs:

---
gzip: stdin: unexpected end of file
tar: Unexpected EOF in archive
tar: Error is not recoverable: exiting now
---

[Bug 25149] Explzh: show the first letter only in listview or treeview.

http://bugs.winehq.org/show_bug.cgi?id=25149

Sagawa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31901|0                           |1
        is obsolete|                            |

--- Comment #6 from Sagawa  2010-11-13 22:30:31 CST ---
Created an attachment (id=31910)
 --> (http://bugs.winehq.org/attachment.cgi?id=31910)
test application

(In reply to comment #5)
> Attached archive is broken, this is what Gnome Archive Manager outputs:

Sorry for the trouble. I've re-uploaded it.

[Bug 25149] Explzh: show the first letter only in listview or treeview.

http://bugs.winehq.org/show_bug.cgi?id=25149

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
         AssignedTo|[e-mail]        |[e-mail]
     Ever Confirmed|0                           |1

--- Comment #7 from Nikolay Sivov  2010-11-14 06:25:22 CST ---
Confirming. I have a test for Listview already, for TreeView will be something
similar.

[Bug 25149] Explzh: show the first letter only in listview or treeview.

http://bugs.winehq.org/show_bug.cgi?id=25149

--- Comment #8 from Nikolay Sivov  2010-11-17 11:15:14 CST ---
Listview problem fixed with 119860b05f8c22d1525b573e461afe95e430a63b, similar
Treeview problem fixed with 0517abf184cdc863b74b953b2acfecb1b331ed1b. Please
retest with today git.

[Bug 25149] Explzh: show the first letter only in listview or treeview.

http://bugs.winehq.org/show_bug.cgi?id=25149

Sagawa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #9 from Sagawa  2010-11-18 10:08:59 CST ---
Thank you, Nikolay.

I got today's source from git, built and tested Explzh again.
Now, the application shows all letters in listview and treeview window when I
load an archive file.

[Bug 25149] Explzh: show the first letter only in listview or treeview.

http://bugs.winehq.org/show_bug.cgi?id=25149

--- Comment #10 from Nikolay Sivov  2010-11-18 10:23:47 CST ---
Ok, thanks for testing.

[Bug 25149] Explzh: show the first letter only in listview or treeview.

http://bugs.winehq.org/show_bug.cgi?id=25149

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #11 from Alexandre Julliard  2010-11-26 13:14:03 CST ---
Closing bugs fixed in 1.3.8.

[Bug 25149] Explzh: show the first letter only in listview or treeview.

http://bugs.winehq.org/show_bug.cgi?id=25149

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |119860b05f8c22d1525b573e461
                   |                            |afe95e430a63b

[Bug 25149] Explzh: show the first letter only in listview or treeview.

https://bugs.winehq.org/show_bug.cgi?id=25149

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]        |[e-mail]