[Bug 29239] New: Age of Empires 1 & 2 rendering broken with OpenGL renderer (DDR=opengl)

http://bugs.winehq.org/show_bug.cgi?id=29239

Bug #: 29239
           Summary: Age of Empires 1 & 2 rendering broken with OpenGL
                    renderer (DDR=opengl)
           Product: Wine
           Version: 1.3.30
          Platform: x86-64
               URL: http://www.microsoft.com/games/age2/downloads.htm
        OS/Version: Mac OS X
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: directx-d3d
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail], [e-mail]
    Classification: Unclassified

"The colors appear messed up and the screen flickers, changing colors every
frame. Occasionally there is a frame with the correct colors."

1.3.30 did not fix http://bugs.winehq.org/show_bug.cgi?id=28348, only helped to
alleviate the acid trip problem by a tiny bit by having that "occasional frame
with the correct colors" every couple seconds.

In 1.3.31 & onwards, all the frames are completely messed up & the screen
flickers constantly, especially in fullscreen mode. No occasional frame with
the correct colors.

Still present in 1.3.34

URL for downloading AOE2 Trial:
http://www.microsoft.com/games/age2/downloads.htm
URL for downloading AOE1 Trial:
http://www.microsoft.com/games/empires/downloads.htm

[Bug 29239] Age of Empires 1 & 2 rendering broken with OpenGL renderer (DDR=opengl)

http://bugs.winehq.org/show_bug.cgi?id=29239

PommeGolden  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
           See Also|                            |http://bugs.winehq.org/show
                   |                            |_bug.cgi?id=28348

[Bug 29239] Age of Empires 1 & 2 rendering broken with OpenGL renderer (DDR=opengl)

http://bugs.winehq.org/show_bug.cgi?id=29239

PommeGolden  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, regression

[Bug 29239] Age of Empires 1 & 2 rendering broken with OpenGL renderer (DDR=opengl)

http://bugs.winehq.org/show_bug.cgi?id=29239

--- Comment #1 from Dmitry Timoshkov  2011-12-03 23:38:18 CST ---
If this is a regression please post the results of your regression testing.

[Bug 29239] Age of Empires 1 & 2 rendering broken with OpenGL renderer (DDR=opengl)

http://bugs.winehq.org/show_bug.cgi?id=29239

PommeGolden  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|regression                  |

[Bug 29239] Age of Empires 1 & 2 rendering broken with OpenGL renderer (DDR=opengl)

http://bugs.winehq.org/show_bug.cgi?id=29239

PommeGolden  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.3.30                      |unspecified

--- Comment #2 from PommeGolden  2011-12-04 00:45:47 CST ---
(In reply to comment #1)
> If this is a regression please post the results of your regression testing.

I think the original regression commit reported in
http://bugs.winehq.org/show_bug.cgi?id=28348 is fundamentally wrong.. Before
1.3.28, DirectDrawRenderer was defaulted to gdi instead of opengl. The acid
trip problem definitely exists well before 1.3.27 when DDR=opengl

I'm trying to find out exactly since when the acid trip problem starts to
appear when DDR=opengl

My preliminary test shows the acid trip bug was not present in 1.1.5 although
the screen flicker problem was present.

[Bug 29239] Age of Empires 1 & 2 rendering broken with OpenGL renderer (DDR=opengl)

http://bugs.winehq.org/show_bug.cgi?id=29239

PommeGolden  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

[Bug 29239] Age of Empires 1 & 2 rendering broken with OpenGL renderer (DDR=opengl)

http://bugs.winehq.org/show_bug.cgi?id=29239

--- Comment #3 from PommeGolden  2011-12-04 01:21:49 CST ---
Created attachment 37776
  --> http://bugs.winehq.org/attachment.cgi?id=37776
Screenshot showing acid trip problem in 1.3.34 (DDR=opengl)

[Bug 29239] Age of Empires 1 & 2 rendering broken with OpenGL renderer (DDR=opengl)

http://bugs.winehq.org/show_bug.cgi?id=29239

--- Comment #4 from PommeGolden  2011-12-04 01:27:24 CST ---
Created attachment 37777
  --> http://bugs.winehq.org/attachment.cgi?id=37777
Screenshot showing acid trip bug not present when DDR=gdi in 1.3.33

DDR=gdi will crash wine in 1.3.34, so i posted the screenshot of 1.3.33 instead

[Bug 29239] Age of Empires 1 & 2 rendering broken with OpenGL renderer (DDR=opengl)

http://bugs.winehq.org/show_bug.cgi?id=29239

PommeGolden  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           See Also|                            |http://bugs.winehq.org/show
                   |                            |_bug.cgi?id=29213

[Bug 29239] Age of Empires 1 & 2 rendering broken with OpenGL renderer (DDR=opengl)

http://bugs.winehq.org/show_bug.cgi?id=29239

PommeGolden  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |1.1.28

[Bug 29239] Age of Empires 1 & 2 rendering broken with OpenGL renderer (DDR=opengl)

http://bugs.winehq.org/show_bug.cgi?id=29239

--- Comment #5 from PommeGolden  2011-12-04 01:56:38 CST ---
Created attachment 37778
  --> http://bugs.winehq.org/attachment.cgi?id=37778
Screenshot showing acid trip problem starting to show up in 1.1.28 (DDR=opengl)

Note the screen is upside down too

Please note it is 1.****1****.28, NOT 1.3.28

[Bug 29239] Age of Empires 1 & 2 rendering broken with OpenGL renderer (DDR=opengl)

http://bugs.winehq.org/show_bug.cgi?id=29239

--- Comment #6 from PommeGolden  2011-12-04 01:59:16 CST ---
Created attachment 37779
  --> http://bugs.winehq.org/attachment.cgi?id=37779
Screenshot showing no acid trip problem in 1.1.27 (DDR=opengl)

[Bug 29239] Age of Empires 1 & 2 rendering broken with OpenGL renderer (DDR=opengl)

http://bugs.winehq.org/show_bug.cgi?id=29239

--- Comment #7 from PommeGolden  2011-12-04 02:05:55 CST ---
Created attachment 37780
  --> http://bugs.winehq.org/attachment.cgi?id=37780
Screenshot showing acid trip problem in 1.1.29 (DDR=opengl)

Note the screen is also upside down.

[Bug 29239] Age of Empires 1 & 2 rendering broken with OpenGL renderer (DDR=opengl)

http://bugs.winehq.org/show_bug.cgi?id=29239

--- Comment #8 from PommeGolden  2011-12-04 02:12:53 CST ---
Created attachment 37781
  --> http://bugs.winehq.org/attachment.cgi?id=37781
Screenshot showing acid trip problem in 1.1.30 (DDR=opengl)

Note the screen is now not upside down (as compared to 1.1.28 & 1.1.29)

[Bug 29239] Age of Empires 1 & 2 rendering broken with OpenGL renderer (DDR=opengl)

http://bugs.winehq.org/show_bug.cgi?id=29239

--- Comment #9 from PommeGolden  2011-12-04 03:48:06 CST ---
Created attachment 37782
  --> http://bugs.winehq.org/attachment.cgi?id=37782
wine 1.1.28 log (DDR=opengl)

[Bug 29239] Age of Empires 1 & 2 rendering broken with OpenGL renderer (DDR=opengl)

http://bugs.winehq.org/show_bug.cgi?id=29239

--- Comment #10 from PommeGolden  2011-12-04 03:50:27 CST ---
Created attachment 37783
  --> http://bugs.winehq.org/attachment.cgi?id=37783
wine 1.1.29 log (DDR=opengl)

[Bug 29239] Age of Empires 1 & 2 rendering broken with OpenGL renderer (DDR=opengl)

http://bugs.winehq.org/show_bug.cgi?id=29239

--- Comment #11 from PommeGolden  2011-12-04 03:56:28 CST ---
Created attachment 37784
  --> http://bugs.winehq.org/attachment.cgi?id=37784
wine 1.3.34 log

[Bug 29239] Age of Empires 1 & 2 rendering broken with OpenGL renderer (DDR=opengl)

http://bugs.winehq.org/show_bug.cgi?id=29239

--- Comment #12 from Henri Verbeet  2011-12-04 04:16:23 CST ---
(In reply to comment #11)
> fixme:d3d:WineD3D_ChoosePixelFormat Add OpenGL context recreation support to SetDepthStencilSurface

I'm not sure what version that log is from, but it's not 1.3.34.
WineD3D_ChoosePixelFormat() is gone since 1.3.27. The AOE1 demo seems to work
fine for me with the OpenGL renderer. Are you running this in a clean prefix?
This may also be specific to OS X.

[Bug 29239] Age of Empires 1 & 2 rendering broken with OpenGL renderer (DDR=opengl)

http://bugs.winehq.org/show_bug.cgi?id=29239

--- Comment #13 from PommeGolden  2011-12-04 04:36:09 CST ---
(In reply to comment #12)
> (In reply to comment #11)
> > fixme:d3d:WineD3D_ChoosePixelFormat Add OpenGL context recreation support to SetDepthStencilSurface
>
> I'm not sure what version that log is from, but it's not 1.3.34.
> WineD3D_ChoosePixelFormat() is gone since 1.3.27. The AOE1 demo seems to work
> fine for me with the OpenGL renderer. Are you running this in a clean prefix?
> This may also be specific to OS X.

maybe i mixed up with the logs when i tried to upload...
i will check again.....

1.1.27 is the last good build for me (though with the screen flicker problem)

[Bug 29239] Age of Empires 1 & 2 rendering broken with OpenGL renderer (DDR=opengl)

http://bugs.winehq.org/show_bug.cgi?id=29239

PommeGolden  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37784|0                           |1
        is obsolete|                            |

[Bug 29239] Age of Empires 1 & 2 rendering broken with OpenGL renderer (DDR=opengl)

http://bugs.winehq.org/show_bug.cgi?id=29239

PommeGolden  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37782|0                           |1
        is obsolete|                            |

[Bug 29239] Age of Empires 1 & 2 rendering broken with OpenGL renderer (DDR=opengl)

http://bugs.winehq.org/show_bug.cgi?id=29239

PommeGolden  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37783|0                           |1
        is obsolete|                            |

[Bug 29239] Age of Empires 1 & 2 rendering broken with OpenGL renderer (DDR=opengl)

http://bugs.winehq.org/show_bug.cgi?id=29239

--- Comment #14 from PommeGolden  2011-12-04 04:55:23 CST ---
Created attachment 37785
  --> http://bugs.winehq.org/attachment.cgi?id=37785
wine 1.3.34 log running 1.3.34 (AOE1 Trial)

i deleted everything just to make sure this time

[Bug 29239] Age of Empires 1 & 2 rendering broken with OpenGL renderer (DDR=opengl)

http://bugs.winehq.org/show_bug.cgi?id=29239

--- Comment #15 from PommeGolden  2011-12-04 04:57:07 CST ---
Created attachment 37786
  --> http://bugs.winehq.org/attachment.cgi?id=37786
screenshot showing acid trip problem in 1.3.34 (DDR=opengl, AOE1 Trial)

[Bug 29239] Age of Empires 1 & 2 rendering broken with OpenGL renderer (DDR=opengl)

http://bugs.winehq.org/show_bug.cgi?id=29239

PommeGolden  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37785|application/octet-stream    |text/plain
          mime type|                            |

[Bug 29239] Age of Empires 1 & 2 rendering broken with OpenGL renderer (DDR=opengl)

http://bugs.winehq.org/show_bug.cgi?id=29239

--- Comment #16 from PommeGolden  2011-12-04 05:04:39 CST ---
Created attachment 37787
  --> http://bugs.winehq.org/attachment.cgi?id=37787
Screenshot showing acid trip bug NOT present when DDR=gdi in 1.3.33

DDR=gdi will crash wine in 1.3.34 so i uploaded 1.3.33 instead

[Bug 29239] Age of Empires 1 & 2 rendering broken with OpenGL renderer (DDR=opengl)

http://bugs.winehq.org/show_bug.cgi?id=29239

--- Comment #17 from PommeGolden  2011-12-04 05:09:25 CST ---
Created attachment 37788
  --> http://bugs.winehq.org/attachment.cgi?id=37788
Screenshot showing acid trip problem starting to show up in 1.1.28 (DDR=opengl,
AOE1 Trial)

[Bug 29239] Age of Empires 1 & 2 rendering broken with OpenGL renderer (DDR=opengl)

http://bugs.winehq.org/show_bug.cgi?id=29239

--- Comment #18 from PommeGolden  2011-12-04 05:13:06 CST ---
Created attachment 37789
  --> http://bugs.winehq.org/attachment.cgi?id=37789
Screenshot showing no acid trip problem in 1.1.27 (DDR=opengl, AOE1 Trial)

[Bug 29239] Age of Empires 1 & 2 rendering broken with OpenGL renderer (DDR=opengl)

http://bugs.winehq.org/show_bug.cgi?id=29239

--- Comment #19 from PommeGolden  2011-12-04 09:21:00 CST ---
(In reply to comment #2)
> (In reply to comment #1)
> > If this is a regression please post the results of your regression testing.
>
> I think the original regression commit reported in
> http://bugs.winehq.org/show_bug.cgi?id=28348 is fundamentally wrong.. Before
> 1.3.28, DirectDrawRenderer was defaulted to gdi instead of opengl. The acid
> trip problem definitely exists well before 1.3.27 when DDR=opengl
>
> I'm trying to find out exactly since when the acid trip problem starts to
> appear when DDR=opengl
>
> My preliminary test shows the acid trip bug was not present in 1.1.5 although
> the screen flicker problem was present.

I read again about the original regression report.

http://source.winehq.org/git/wine.git/commit/94ae743ea668e49d40ae4e2dc5fe1f5...
absolutely is not the first bad commit causing the opengl renderer to break

http://source.winehq.org/git/wine.git/commit/94ae743ea668e49d40ae4e2dc5fe1f5...
is actually *exactly* when DDR is now defaulted to opengl instead of gdi

ddraw: Make the OpenGL renderer the default one.
author    Henri Verbeet     
Tue, 30 Aug 2011 18:12:31 +0000 (20:12 +0200)
committer    Alexandre Julliard     
Wed, 31 Aug 2011 10:08:02 +0000 (12:08 +0200)
commit    94ae743ea668e49d40ae4e2dc5fe1f5d9be018cb
tree    75defd48d249b352aca96bd256ab9781a393d526    tree | snapshot
parent    dd462052c62c3bca78dc51f6bcaa91dec0dfa59f    commit | diff
ddraw: Make the OpenGL renderer the default one.

[Bug 29239] Age of Empires 1 & 2 rendering broken with OpenGL renderer (DDR=opengl)

http://bugs.winehq.org/show_bug.cgi?id=29239

--- Comment #20 from PommeGolden  2011-12-04 10:05:04 CST ---
I am currently having some difficulties getting those old git builds compiled
on my Mac OS X 10.7.2 intel machine...

The first bad commit should be somewhere between 1.1.27 and 1.1.28

Exact commit is to be determined, probably those commits related to wined3d??

[Bug 29239] Age of Empires 1 & 2 rendering broken with OpenGL renderer (DDR=opengl)

http://bugs.winehq.org/show_bug.cgi?id=29239

--- Comment #21 from Henri Verbeet  2011-12-05 05:46:12 CST ---
Created attachment 37805
  --> http://bugs.winehq.org/attachment.cgi?id=37805
patch

Does this patch work for you?

[Bug 29239] Age of Empires 1 & 2 rendering broken with OpenGL renderer (DDR=opengl)

http://bugs.winehq.org/show_bug.cgi?id=29239

--- Comment #22 from PommeGolden  2011-12-05 08:31:26 CST ---
Created attachment 37807
  --> http://bugs.winehq.org/attachment.cgi?id=37807
wine 1.3.34 log after applying the patch (AOE1 Trial)

[Bug 29239] Age of Empires 1 & 2 rendering broken with OpenGL renderer (DDR=opengl)

http://bugs.winehq.org/show_bug.cgi?id=29239

--- Comment #23 from PommeGolden  2011-12-05 08:35:24 CST ---
(In reply to comment #21)
> Created attachment 37805 [details]
> patch
>
> Does this patch work for you?

Does not seem to have any noticeable difference. Both the acid trip & flicker
are still present.

The log is slightly different this time with one additional err about "wgl":

err:d3d_surface:d3dfmt_p8_init_palette This code should never get entered for
DirectDraw!, expect problems
err:wgl:internal_SetPixelFormat Invalid operation on root_window

[Bug 29239] Age of Empires 1 & 2 rendering broken with OpenGL renderer (DDR=opengl)

http://bugs.winehq.org/show_bug.cgi?id=29239

--- Comment #24 from Henri Verbeet  2011-12-05 08:49:12 CST ---
No idea then, that patch makes it work for me on OS X.

[Bug 29239] Age of Empires 1 & 2 rendering broken with OpenGL renderer (DDR=opengl)

http://bugs.winehq.org/show_bug.cgi?id=29239

--- Comment #25 from PommeGolden  2011-12-05 20:56:51 CST ---
My machine is:

Mac OS X 10.7.2 (64 bit)
Intel Core 2 Duo 2 GHz cpu
2GB DDR2 RAM
Intel onboard GMA 950 display 64MB running stock driver from Mac OS X 10.7.2

[Bug 29239] Age of Empires 1 & 2 rendering broken with OpenGL renderer (DDR=opengl)

http://bugs.winehq.org/show_bug.cgi?id=29239

--- Comment #26 from PommeGolden  2011-12-06 23:00:12 CST ---
Created attachment 37842
  --> http://bugs.winehq.org/attachment.cgi?id=37842
Screenshot showing acid trip problem fixed running unpatched
1fa1ab54376bace57f78d27ac13b7229caa56a2e (DDR=opengl)

[Bug 29239] Age of Empires 1 & 2 rendering broken with OpenGL renderer (DDR=opengl)

http://bugs.winehq.org/show_bug.cgi?id=29239

--- Comment #27 from PommeGolden  2011-12-06 23:29:53 CST ---
(In reply to comment #24)
> No idea then, that patch makes it work for me on OS X.

Running the latest unpatched GIT master:
http://source.winehq.org/git/wine.git/snapshot/1fa1ab54376bace57f78d27ac13b7...

I am pleased to report the acid trip problem seems to have been fixed
(DDR=opengl) !
The fullscreen flicker problem is still present though. Not sure if the flicker
is related to the opengl renderer.

Should I open a separate bug for the flicker? The flicker problem was also
present in 1.1.5-1.1.27 & later

[Bug 29239] Age of Empires 1 & 2 rendering broken with OpenGL renderer (DDR=opengl)

http://bugs.winehq.org/show_bug.cgi?id=29239

--- Comment #28 from Henri Verbeet  2011-12-07 04:18:40 CST ---
(In reply to comment #27)
> Should I open a separate bug for the flicker? The flicker problem was also
> present in 1.1.5-1.1.27 & later

Probably. It would be good to know if that's a regression or something that was
always present.

[Bug 29239] Age of Empires 1 & 2 rendering broken with OpenGL renderer (DDR=opengl)

http://bugs.winehq.org/show_bug.cgi?id=29239

PommeGolden  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED

--- Comment #29 from PommeGolden  2011-12-07 04:32:42 CST ---
(In reply to comment #28)
> (In reply to comment #27)
> > Should I open a separate bug for the flicker? The flicker problem was also
> > present in 1.1.5-1.1.27 & later
>
> Probably. It would be good to know if that's a regression or something that was
> always present.

Yeah, i'm closing now.
Not sure that flicker is a regression or or a new old bug.

I believe Wine 0.9 or before can't possibly be compiled on Mac OS X. That
flicker was present from 1.1.5 to 1.3.34 as far as i can tell & is affecting
quite some other games, such as SimCity 3000 Demo & quite some games when
DDR=opengl.

[Bug 29239] Age of Empires 1 & 2 rendering broken with OpenGL renderer (DDR=opengl)

http://bugs.winehq.org/show_bug.cgi?id=29239

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #30 from Alexandre Julliard  2011-12-16 13:29:32 CST ---
Closing bugs fixed in 1.3.35.