[Bug 21160] New: ui button skin icons (.bmp) fail to load on wine version 1.1.32 and after playing Perfect world

http://bugs.winehq.org/show_bug.cgi?id=21160

Summary: ui button skin icons (.bmp) fail to load on wine
                    version 1.1.32 and after playing Perfect world
           Product: Wine
           Version: 1.1.35
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: ole32
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

ui button skin icons (.bmp) fail to load on wine version 1.1.32 and after
playing Perfect world. using git has identified bad patch in /dll/storage.c
patch info: 7b475390e4a661a60c708097850c411cb4ae4ca4 is the first bad commit
commit 7b475390e4a661a60c708097850c411cb4ae4ca4
Author: Andrew Eikum 
Date:   Fri Oct 9 10:53:31 2009 -0500

ole32: Use rgiidExclude in StorageImpl::CopyTo.

:040000 040000 87c779e1c776bdbcb36fe12a8440a5210478c63c
6dd87ed409cb8418b9ad43f9bef3bddc24d14839 M       dlls

reversing the patch fixed problem in git.

[Bug 21160] ui button skin icons (.bmp) fail to load on wine version 1.1.32 and after playing Perfect world

http://bugs.winehq.org/show_bug.cgi?id=21160

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
                 CC|                            |[e-mail]
              Alias|BD                          |

[Bug 21160] ui button skin icons (.bmp) fail to load in Perfect world

http://bugs.winehq.org/show_bug.cgi?id=21160

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|ui button skin icons (.bmp) |ui button skin icons (.bmp)
                   |fail to load on wine        |fail to load in Perfect
                   |version 1.1.32 and after    |world
                   |playing Perfect world       |

[Bug 21160] ui button skin icons (.bmp) fail to load in Perfect world

http://bugs.winehq.org/show_bug.cgi?id=21160

Vincent Povirk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 21160] ui button skin icons (.bmp) fail to load in Perfect world

http://bugs.winehq.org/show_bug.cgi?id=21160

--- Comment #1 from Vincent Povirk   2009-12-25 13:49:46 ---
Can you get a +storage log of the failure?

[Bug 21160] ui button skin icons (.bmp) fail to load in Perfect world

http://bugs.winehq.org/show_bug.cgi?id=21160

--- Comment #2 from BD   2009-12-26 13:32:55 ---
(In reply to comment #1)
> Can you get a +storage log of the failure?

no, but bug is narrowed down to /dlls/gdi32 folder so i'll report back soon.

[Bug 21160] ui button skin icons (.bmp) fail to load in Perfect world

http://bugs.winehq.org/show_bug.cgi?id=21160

--- Comment #3 from BD   2009-12-26 14:56:02 ---
(In reply to comment #2)
> (In reply to comment #1)
> > Can you get a +storage log of the failure?
>
> no, but bug is narrowed down to /dlls/gdi32 folder so i'll report back soon.

it appears that the 16bit stuff was changed. bidi16.c etc removed from wine
1.1.32 and newer versions. makefile.in now shows include winebase16.h  this is
as far as my limited skills go so i hope someone can fix this. thanks

[Bug 21160] ui button skin icons (.bmp) fail to load in Perfect world

http://bugs.winehq.org/show_bug.cgi?id=21160

Wylda  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Wylda   2009-12-26 15:18:16 ---
(In reply to comment #3)
> > Can you get a +storage log of the failure?
>
> no... ...so i hope someone can fix this. thanks

You want help & fix and concurrently you don't want to attach simple console
log to this bug report as you were kindly asked??

[Bug 21160] ui button skin icons (.bmp) fail to load in Perfect world

http://bugs.winehq.org/show_bug.cgi?id=21160

--- Comment #5 from BD   2009-12-26 15:47:41 ---
(In reply to comment #4)
> (In reply to comment #3)
> > > Can you get a +storage log of the failure?
> >
> > no... ...so i hope someone can fix this. thanks
>
> You want help & fix and concurrently you don't want to attach simple console
> log to this bug report as you were kindly asked??

sorry but i couldnt figure out how to get the storage log.. explain how and i
will.

[Bug 21160] ui button skin icons (.bmp) fail to load in Perfect world

http://bugs.winehq.org/show_bug.cgi?id=21160

--- Comment #6 from Wylda   2009-12-26 16:03:35 ---
(In reply to comment #5)
> sorry but i couldnt figure out how to get the storage log.. explain how and i
> will.

It is easy:

WINEDEBUG=+storage wine your_app.exe &> console_log_with_storage.txt

[Bug 21160] ui button skin icons (.bmp) fail to load in Perfect world

http://bugs.winehq.org/show_bug.cgi?id=21160

--- Comment #7 from BD   2009-12-26 16:12:29 ---
(In reply to comment #6)
> (In reply to comment #5)
> > sorry but i couldnt figure out how to get the storage log.. explain how and i
> > will.
>
> It is easy:
>
> WINEDEBUG=+storage wine your_app.exe &> console_log_with_storage.txt

thanks, i'm compiling fresh 1.1.35  will i need to use git for this?

[Bug 21160] ui button skin icons (.bmp) fail to load in Perfect world

http://bugs.winehq.org/show_bug.cgi?id=21160

--- Comment #8 from Wylda   2009-12-26 16:17:51 ---
(In reply to comment #7)
> thanks, i'm compiling fresh 1.1.35  will i need to use git for this?

No, WINEDEBUG works even with distro wine, so no need to compile if you have
1.1.35 package. Git would be useful for regression test (you already did that
in comment #0) or just to test, if it is already fixed by some patch (without
waiting to 1.1.36).

[Bug 21160] ui button skin icons (.bmp) fail to load in Perfect world

http://bugs.winehq.org/show_bug.cgi?id=21160

--- Comment #9 from BD   2009-12-26 17:19:54 ---
Created an attachment (id=25406)
 --> (http://bugs.winehq.org/attachment.cgi?id=25406)
storage log

[Bug 21160] ui button skin icons (.bmp) fail to load in Perfect world

http://bugs.winehq.org/show_bug.cgi?id=21160

--- Comment #10 from Vincent Povirk   2009-12-26 20:00:46 ---
The log shows no uses of ole32 storage.

Is it possible that the real problem happens at install time?

[Bug 21160] ui button skin icons (.bmp) fail to load in Perfect world

http://bugs.winehq.org/show_bug.cgi?id=21160

--- Comment #11 from BD   2009-12-26 21:15:26 ---
(In reply to comment #10)
> The log shows no uses of ole32 storage.
>
> Is it possible that the real problem happens at install time?

i build and run from the source folder and build and install with same results.

im showing no errors at all, the buttons fail to show on the start screen but
when game loads everything works (start screen ends when game loads). i can put
 the wine-1.1.31 /dlls/gdi32 source folder into the the wine-1.1.35 source and
compile. no errors and everything works. investigating the changes from version
31 to 32 shows a rework of the gdi32 16b support to use winebase16. i can test
stuff people can recommend but with such a drastic change in 16b support im at
a loss what to do next. hope this helps.

[Bug 21160] ui button skin icons (.bmp) fail to load in Perfect world

http://bugs.winehq.org/show_bug.cgi?id=21160

--- Comment #12 from Austin English   2009-12-27 00:28:12 ---
(In reply to comment #11)
> (In reply to comment #10)
> > The log shows no uses of ole32 storage.
> >
> > Is it possible that the real problem happens at install time?
>
> i build and run from the source folder and build and install with same results.
>
> im showing no errors at all, the buttons fail to show on the start screen but
> when game loads everything works (start screen ends when game loads). i can put
>  the wine-1.1.31 /dlls/gdi32 source folder into the the wine-1.1.35 source and
> compile. no errors and everything works. investigating the changes from version
> 31 to 32 shows a rework of the gdi32 16b support to use winebase16. i can test
> stuff people can recommend but with such a drastic change in 16b support im at
> a loss what to do next. hope this helps.

That implies a patch in dlls/gdi32 is responsible for the failure, not
/dells/ol32. Have you tried reverting the patch in comment #0?

[Bug 21160] ui button skin icons (.bmp) fail to load in Perfect world

http://bugs.winehq.org/show_bug.cgi?id=21160

--- Comment #13 from BD   2009-12-27 02:48:36 ---
(In reply to comment #12)
> (In reply to comment #11)
> > (In reply to comment #10)
> > > The log shows no uses of ole32 storage.
> > >
> > > Is it possible that the real problem happens at install time?
> >
> > i build and run from the source folder and build and install with same results.
> >
> > im showing no errors at all, the buttons fail to show on the start screen but
> > when game loads everything works (start screen ends when game loads). i can put
> >  the wine-1.1.31 /dlls/gdi32 source folder into the the wine-1.1.35 source and
> > compile. no errors and everything works. investigating the changes from version
> > 31 to 32 shows a rework of the gdi32 16b support to use winebase16. i can test
> > stuff people can recommend but with such a drastic change in 16b support im at
> > a loss what to do next. hope this helps.
>
> That implies a patch in dlls/gdi32 is responsible for the failure, not
> /dells/ol32. Have you tried reverting the patch in comment #0?

yes, i reverted the patch but it didnt help. starting in wine-1.1.32 a new
folder was added called /dlls/gdi.exe16 and all the 16.c files were removed
from /dlls/gdi32 folder, ie: bidi16.c, gdi16.c etc. my guess is all the 16b
support was centralized into the new gdi.exe16 folder. im still working at it
so i will post on any other developments i come across.

[Bug 21160] ui button skin icons (.bmp) fail to load in Perfect world

http://bugs.winehq.org/show_bug.cgi?id=21160

--- Comment #14 from Wylda   2009-12-27 03:20:11 ---

OK, let's start from the begining ;) Currently i am downloading this MMORPG
game. It will take a lot of time. In the mean time:

A) please attach two screen shot of the problem, i.e. 1x which is OK and 1x
which shows the problem. Resolution 800x600 and JPEG will be enough.

B) write shortest description how to simulate that problem (i.e.
Menu->setting->some options->run the game etc.)

Consider +DOWNLOAD:
http://pwi.perfectworld.com/download

[Bug 21160] ui button skin icons (.bmp) fail to load in Perfect world

http://bugs.winehq.org/show_bug.cgi?id=21160

--- Comment #15 from BD   2009-12-27 04:09:33 ---
(In reply to comment #14)
> OK, let's start from the begining ;) Currently i am downloading this MMORPG
> game. It will take a lot of time. In the mean time:
>
> A) please attach two screen shot of the problem, i.e. 1x which is OK and 1x
> which shows the problem. Resolution 800x600 and JPEG will be enough.
>
> B) write shortest description how to simulate that problem (i.e.
> Menu->setting->some options->run the game etc.)
>
> Consider +DOWNLOAD:
> http://pwi.perfectworld.com/download

compiling fresh wine now and will post pics shortly.

[Bug 21160] ui button skin icons (.bmp) fail to load in Perfect world

http://bugs.winehq.org/show_bug.cgi?id=21160

--- Comment #16 from BD   2009-12-27 05:20:28 ---
Created an attachment (id=25415)
 --> (http://bugs.winehq.org/attachment.cgi?id=25415)
v-31

[Bug 21160] ui button skin icons (.bmp) fail to load in Perfect world

http://bugs.winehq.org/show_bug.cgi?id=21160

--- Comment #17 from BD   2009-12-27 05:21:58 ---
Created an attachment (id=25416)
 --> (http://bugs.winehq.org/attachment.cgi?id=25416)
v-35

[Bug 21160] ui button skin icons (.bmp) fail to load in Perfect world

http://bugs.winehq.org/show_bug.cgi?id=21160

--- Comment #18 from BD   2009-12-27 05:26:10 ---
nothing special to run the program, i use this command.
wine '/home/bd/.wine/drive_c/Program Files/Perfect World Entertainment/Perfect
World International/patcher/patcher.exe'

[Bug 21160] ui button skin icons (.bmp) fail to load in Perfect world

http://bugs.winehq.org/show_bug.cgi?id=21160

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|ole32                       |-unknown

--- Comment #19 from Nikolay Sivov   2009-12-27 07:24:50 ---
Please next time perform a normal regression test without directory moving,
without replacing etc. http://wiki.winehq.org/RegressionTesting.

Anyway now it's a bug 20598 duplicate.

[Bug 21160] ui button skin icons (.bmp) fail to load in Perfect world

http://bugs.winehq.org/show_bug.cgi?id=21160

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

[Bug 21160] ui button skin icons (.bmp) fail to load in Perfect world

http://bugs.winehq.org/show_bug.cgi?id=21160

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |DUPLICATE

--- Comment #20 from Dmitry Timoshkov   2009-12-27 23:31:38 ---
Duplicate then.

*** This bug has been marked as a duplicate of bug 20598 ***

[Bug 21160] ui button skin icons (.bmp) fail to load in Perfect world

http://bugs.winehq.org/show_bug.cgi?id=21160

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #21 from Dmitry Timoshkov   2009-12-27 23:31:54 ---
Closing duplicate.