[Bug 52466] New: Toolbar: Wrong size returned by TB_GETMAXSIZE message for toolbars with TBSTYLE_WRAPABLE style
https://bugs.winehq.org/show_bug.cgi?id=52466
Bug ID: 52466 Summary: Toolbar: Wrong size returned by TB_GETMAXSIZE message for toolbars with TBSTYLE_WRAPABLE style Product: Wine Version: unspecified Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: comctl32 Assignee: wine-bugs@winehq.org Reporter: yal@csoftcom.com Distribution: ---
Under Windows (I've tested Win10/11) TB_GETMAXSIZE always returns size for single row of buttons regardless of wrapped it or not. WINE calculates size for current wrapping. For example: under Win toolbar with initial size (0,0) and 2 buttons (20,20) TB_GETMAXSIZE always returns(40,20), WINE returns (20,40) - 2 rows wrapping.
https://bugs.winehq.org/show_bug.cgi?id=52466
Nikolay Sivov bunglehead@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Ever confirmed|0 |1
--- Comment #1 from Nikolay Sivov bunglehead@gmail.com --- Yes, looks like it just returns maximum extents, only considering vertical case, and we don't have any tests for this. Are you going to send a fix for this?
https://bugs.winehq.org/show_bug.cgi?id=52466
--- Comment #2 from YAL yal@csoftcom.com --- Yes, I'll try. And test also.
https://bugs.winehq.org/show_bug.cgi?id=52466
Fabian Maurer dark.shadow4@web.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |7.0 CC| |dark.shadow4@web.de
https://bugs.winehq.org/show_bug.cgi?id=52466
--- Comment #3 from Nikolay Sivov bunglehead@gmail.com --- YAL, do you have time to follow up on this? If you don't, let me know and I'll look at it.
https://bugs.winehq.org/show_bug.cgi?id=52466
--- Comment #4 from YAL yal@csoftcom.com --- Created attachment 72143 --> https://bugs.winehq.org/attachment.cgi?id=72143 Patch for /wine/dlls/comctl32/toolbar.c
https://bugs.winehq.org/show_bug.cgi?id=52466
--- Comment #5 from YAL yal@csoftcom.com --- Created attachment 72144 --> https://bugs.winehq.org/attachment.cgi?id=72144 Patch for /wine/dlls/comctl32/tests/toolbar.c
https://bugs.winehq.org/show_bug.cgi?id=52466
--- Comment #6 from YAL yal@csoftcom.com --- Patches for /wine/dlls/comctl32/toolbar.c and /wine/dlls/comctl32/tests/toolbar.c are attached.
/wine/dlls/comctl32/toolbar.c - TOOLBAR_GetMaxSize was rewritten. /wine/dlls/comctl32/tests/toolbar.c - Test test_GetMaxSize() was added to main tests chain.
Please have a look.
https://bugs.winehq.org/show_bug.cgi?id=52466
--- Comment #7 from Nikolay Sivov bunglehead@gmail.com --- Thank you. This needs some cleanup, e.g. cpp comments style is not used in wine, some simplification is possible, and tests should run for both v5 and v6. Patches are not picked up from bug reports, see https://wiki.winehq.org/Submitting_Patches for instructions. Alternatively I can send them too, but I'll need your name to properly attribute authorship.
-
WineHQ Bugzilla