[Bug 43962] New: msvcrt/string tests fail

https://bugs.winehq.org/show_bug.cgi?id=43962

Bug ID: 43962
           Summary: msvcrt/string tests fail
           Product: Wine
           Version: 2.20
          Hardware: x86
                OS: Linux
            Status: NEW
          Keywords: download, testcase
          Severity: normal
          Priority: P2
         Component: msvcrt
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: Debian

string.c:2799: Test failed: errno = -559038737
string.c:2809: Test failed: ret = d0
string.c:1878: Test failed: d =
1000000000000000482416141386308708571867933472627945326741491900144172904106310050588962644037102476595408159456210748972770600252972845262058045244417464426905986489749230528825980973749133650163621397243851020732242333839884529407361024.000000
string.c:2710: Test failed: ret = ffffff81
string.c:2713: Test failed: ret = ffffff9f
string.c:2716: Test failed: ret = ffffffe0
string.c:2877: Test failed: d.x = 0.000000e+000, expected 0
string.c:2880: Test failed: d.x = 0.000000e+000, expected 0

there's a lot of:
fixme:msvcrt:_control87 not implemented
fixme:msvcrt:_control87 not implemented

[Bug 43962] msvcrt/string tests fail on arm

https://bugs.winehq.org/show_bug.cgi?id=43962

Vijay Kamuju  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
            Summary|msvcrt/string tests fail    |msvcrt/string tests fail on
                   |                            |arm

--- Comment #1 from Vijay Kamuju  ---
I think its on arm as _control_87 is not implemented for arm

[Bug 43962] msvcrt/string tests fail on arm

https://bugs.winehq.org/show_bug.cgi?id=43962

--- Comment #2 from Austin English  ---
(In reply to Vijay Kamuju from comment #1)
> I think its on arm as _control_87 is not implemented for arm

Maybe. I tried your patch:
https://source.winehq.org/patches/data/138515

but I get the same failures before/after:
(stretch)austin@localhost:~/wine-git/dlls/msvcrt/tests$ grep -c 'Test failed'
log*
log:8
log2:8
(stretch)austin@localhost:~/wine-git/dlls/msvcrt/tests$ grep -c 'Test succeeded
inside todo block' log*
log:4
log2:4

[Bug 43962] msvcrt/string tests fail on arm

https://bugs.winehq.org/show_bug.cgi?id=43962

--- Comment #3 from Vijay Kamuju  ---
on what platform(board) are you testing

[Bug 43962] msvcrt/string tests fail on arm

https://bugs.winehq.org/show_bug.cgi?id=43962

--- Comment #4 from Austin English  ---
armv7l

[Bug 43962] msvcrt/string tests fail on arm

https://bugs.winehq.org/show_bug.cgi?id=43962

--- Comment #5 from Vijay Kamuju  ---
(In reply to Austin English from comment #4)
> armv7l

I believe its raspberry pi 3 B (I plan to buy it again, I gave away my Pi 2 B)

[Bug 43962] msvcrt/string tests fail on arm

https://bugs.winehq.org/show_bug.cgi?id=43962

--- Comment #6 from Austin English  ---
I'm testing on a chromebook actually.

[Bug 43962] msvcrt/string tests fail on arm

https://bugs.winehq.org/show_bug.cgi?id=43962

Fabian Maurer  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Hardware|x86                         |arm
                 CC|                            |[e-mail]

[Bug 43962] msvcrt/string tests fail on arm

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=43962

Piotr Caban  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Piotr Caban  ---
It's because long double has the same size as double. In order to fix it strtod
needs to be reimplemented. It will also fix bug 36165.

[Bug 43962] msvcrt/string tests fail on arm

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=43962

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |c22af971c287933a137c9fbecc8
                   |                            |1823812e12b7a

--- Comment #8 from Austin English  ---
This works now, fixed by:
commit c22af971c287933a137c9fbecc81823812e12b7a
Author: Erich Hoover 
Date:   Wed Dec 18 15:48:11 2019 -0700

msvcrt: Implement strtod without using 'long double'.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=48160
    Signed-off-by: Erich E. Hoover 
    Signed-off-by: Alexandre Julliard

Thanks Erich!

[Bug 43962] msvcrt/string tests fail on arm

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=43962

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard  ---
Closing bugs fixed in 5.9.