[Bug 29031] New: Game borderlands does not start

http://bugs.winehq.org/show_bug.cgi?id=29031

Bug #: 29031
           Summary: Game borderlands does not start
           Product: Wine
           Version: 1.3.32
          Platform: x86-64
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Game does not start. Aborts with following output:
wine Borderlands.exe
err:module:map_image Could not map shared section .extra
err:module:map_image Could not map shared section .extra
wine: Bad EXE format for C:\Program
Files\Steam\steamapps\common\borderlands\Binaries\Borderlands.exe

This is not a duplicate of bug 23962 .

[Bug 29031] Game borderlands does not start

http://bugs.winehq.org/show_bug.cgi?id=29031

--- Comment #1 from Vitaliy Margolen  2011-11-08 14:53:21 CST ---
Created attachment 37385
  --> http://bugs.winehq.org/attachment.cgi?id=37385
Winedump of Borderlands.exe

[Bug 29031] Game borderlands does not start

http://bugs.winehq.org/show_bug.cgi?id=29031

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |obfuscation

--- Comment #2 from Vitaliy Margolen  2011-11-08 14:54:07 CST ---
Most likely side-affects of SecureRom.

[Bug 29031] Game borderlands does not start

http://bugs.winehq.org/show_bug.cgi?id=29031

jhgf  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch
                 CC|                            |[e-mail]
          Component|-unknown                    |ntdll

--- Comment #3 from jhgf  2011-11-08 14:59:11 CST ---
that's fixed by http://source.winehq.org/patches/data/79830 and
http://source.winehq.org/patches/data/79831
(not commited yet)

[Bug 29031] Game borderlands does not start

http://bugs.winehq.org/show_bug.cgi?id=29031

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|ntdll                       |-unknown

--- Comment #4 from Vitaliy Margolen  2011-11-08 15:01:30 CST ---
Relevant part of +module trace:

trace:module:map_image clearing 0x1a40200 - 0x1a41000
trace:module:map_image mapping section .rdata at 0x1a41000 off 1640400 size
4c2800 virt 4c26d7 flags 40000040
trace:module:map_image clearing 0x1f03800 - 0x1f04000
trace:module:map_image mapping section .data at 0x1f04000 off 1b02c00 size
43600 virt 14e19c flags c0000040
trace:module:map_image clearing 0x1f47600 - 0x1f48000
trace:module:map_image mapping section .rsrc at 0x2053000 off 1b46200 size
f4200 virt f4090 flags 40000040
trace:module:map_image clearing 0x2147200 - 0x2148000
trace:module:map_image mapping section .reloc at 0x2148000 off 1c3a400 size
2a1600 virt 2a1566 flags 42000040
trace:module:map_image clearing 0x23e9600 - 0x23ea000
trace:module:map_image mapping section Stext at 0x23ea000 off 1edba00 size
50c800 virt a18df0 flags e0000020
trace:module:map_image clearing 0x28f6800 - 0x28f7000
trace:module:map_image mapping section Sitext at 0x2e03000 off 23e8200 size
8000 virt 7260 flags 60000020
trace:module:map_image mapping section Srdata at 0x2e0b000 off 23f0200 size
87000 virt 86b10 flags 60000040
trace:module:map_image mapping section Sdata at 0x2e92000 off 2477200 size
116e00 virt 34381c flags e0000040
trace:module:map_image clearing 0x2fa8e00 - 0x2fa9000
trace:module:map_image mapping section Sidata at 0x31d6000 off 258e000 size
7000 virt 6308 flags c0000040
trace:module:map_image mapping section .securom at 0x31dd000 off 2595000 size
1e2000 virt 1e1ea5 flags e0000020
trace:module:map_image mapping shared section .extra at 0x33bf000 off 17bee875
(0) size 3000 (3000) flags 97bab8b8
err:module:map_image Could not map shared section .extra

[Bug 29031] Game borderlands does not start

http://bugs.winehq.org/show_bug.cgi?id=29031

--- Comment #5 from Vitaliy Margolen  2011-11-08 15:07:50 CST ---
Patches do help indeed.

[Bug 29031] Game borderlands does not start

http://bugs.winehq.org/show_bug.cgi?id=29031

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |ntdll

[Bug 29031] Game borderlands does not start

http://bugs.winehq.org/show_bug.cgi?id=29031

Kuro  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #6 from Kuro  2011-11-20 10:00:52 CST ---
(In reply to comment #5)
> Patches do help indeed.

Agreed, testet with 1.3.32

[Bug 29031] Game borderlands does not start

http://bugs.winehq.org/show_bug.cgi?id=29031

André Fettouhi  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from André Fettouhi  2011-12-03 15:40:14 CST ---
Error is still present in wine 1.3.34

[Bug 29031] Game borderlands does not start

http://bugs.winehq.org/show_bug.cgi?id=29031

--- Comment #8 from Erich Hoover  2011-12-04 12:00:17 CST ---
Created attachment 37793
  --> http://bugs.winehq.org/attachment.cgi?id=37793
Reverse the order of section mapping

I see that those patches aren't applied yet, it also works to reverse the order
of the section mapping (attached).

[Bug 29031] Game borderlands does not start

http://bugs.winehq.org/show_bug.cgi?id=29031

--- Comment #9 from Vitaliy Margolen  2011-12-04 15:14:38 CST ---
(In reply to comment #8)
That fixes it too.

[Bug 29031] Game borderlands does not start

http://bugs.winehq.org/show_bug.cgi?id=29031

DreamSoul  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 29031] Game borderlands does not start

http://bugs.winehq.org/show_bug.cgi?id=29031

Sylvain Petreolle  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 29031] Game borderlands does not start

http://bugs.winehq.org/show_bug.cgi?id=29031

--- Comment #10 from André Fettouhi  2012-01-14 06:22:24 CST ---
Still present in wine 1.3.37!

[Bug 29031] Game borderlands does not start

http://bugs.winehq.org/show_bug.cgi?id=29031

David  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 29031] Game borderlands does not start

http://bugs.winehq.org/show_bug.cgi?id=29031

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #11 from Vitaliy Margolen  2012-02-12 10:54:03 CST ---
The bus is still present in wine-1.4-rc3 and the patch from comment 8 still
fixes it.
Erich, are you going to submit this patch to wine-patches?

[Bug 29031] Game borderlands does not start

http://bugs.winehq.org/show_bug.cgi?id=29031

--- Comment #12 from Erich Hoover  2012-02-12 14:07:25 CST ---
(In reply to comment #11)
> The bus is still present in wine-1.4-rc3 and the patch from comment 8 still
> fixes it.
> Erich, are you going to submit this patch to wine-patches?

Should I?  Reversing the mapping order seems like a no-no.

[Bug 29031] Game borderlands does not start

http://bugs.winehq.org/show_bug.cgi?id=29031

--- Comment #13 from Erich Hoover  2012-02-13 15:41:27 CST ---
(In reply to comment #12)
> (In reply to comment #11)
> > The bus is still present in wine-1.4-rc3 and the patch from comment 8 still
> > fixes it.
> > Erich, are you going to submit this patch to wine-patches?
>
> Should I?  Reversing the mapping order seems like a no-no.

I should probably clarify, I feel like we might just be covering the issue up
if we reverse the mapping order.  It seems to me like Bernhard Loos's solution
is more appropriate.  I have no idea why it didn't get accepted, but I doubt my
quicky solution will get in when Bernhard's didn't.

[Bug 29031] Game borderlands does not start

http://bugs.winehq.org/show_bug.cgi?id=29031

--- Comment #14 from Erich Hoover  2012-02-17 11:53:39 CST ---
Created attachment 38929
  --> http://bugs.winehq.org/attachment.cgi?id=38929
ntdll: Fix mapping sections for applications that map over the section headers.

(In reply to comment #13)
> I should probably clarify, I feel like we might just be covering the issue up
> if we reverse the mapping order.  It seems to me like Bernhard Loos's solution
> is more appropriate.  I have no idea why it didn't get accepted, but I doubt my
> quicky solution will get in when Bernhard's didn't.

I think something like the attached would make a better candidate for
inclusion, this way it won't matter how applications map over the section
headers.

[Bug 29031] Game borderlands does not start

http://bugs.winehq.org/show_bug.cgi?id=29031

--- Comment #15 from Vitaliy Margolen  2012-02-20 08:28:23 CST ---
(In reply to comment #14)
Finally had a chance to test this patch and it works. Thanks!

[Bug 29031] Game borderlands does not start

http://bugs.winehq.org/show_bug.cgi?id=29031

--- Comment #16 from Erich Hoover  2012-02-20 12:16:43 CST ---
(In reply to comment #15)
> (In reply to comment #14)
> Finally had a chance to test this patch and it works. Thanks!

I've submitted the patch, we'll see how it goes:
http://source.winehq.org/patches/data/83769

[Bug 29031] Game borderlands does not start

http://bugs.winehq.org/show_bug.cgi?id=29031

--- Comment #17 from Erich Hoover  2012-02-21 14:32:39 CST ---
(In reply to comment #16)
> ...
> I've submitted the patch, we'll see how it goes:
> http://source.winehq.org/patches/data/83769

The patch has just been flagged as deferred, so after Wine 1.4 hits then I'll
resubmit.

[Bug 29031] Game borderlands does not start

http://bugs.winehq.org/show_bug.cgi?id=29031

Dennis Straffin  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 29031] Game borderlands does not start

http://bugs.winehq.org/show_bug.cgi?id=29031

GyB  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 29031] Game borderlands does not start

http://bugs.winehq.org/show_bug.cgi?id=29031

James Eder  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #18 from James Eder  2012-03-16 13:04:41 CDT ---
Looks like the patch made it in! 3dd58d8bfbf266430130f49dd223e284e628b4bc

[Bug 29031] Game borderlands does not start

http://bugs.winehq.org/show_bug.cgi?id=29031

--- Comment #19 from Erich Hoover  2012-03-16 14:27:06 CDT ---
(In reply to comment #18)
> Looks like the patch made it in! 3dd58d8bfbf266430130f49dd223e284e628b4bc

Excellent!  Have you tried the latest git un-patched to confirm that it works? 
It should, but I think that the powers that be appreciate that confirmation
before closing bugs.

[Bug 29031] Game borderlands does not start

http://bugs.winehq.org/show_bug.cgi?id=29031

--- Comment #20 from Erich Hoover  2012-03-16 21:27:29 CDT ---
(In reply to comment #19)
> (In reply to comment #18)
> > Looks like the patch made it in! 3dd58d8bfbf266430130f49dd223e284e628b4bc
>
> Excellent!  Have you tried the latest git un-patched to confirm that it works? 
> It should, but I think that the powers that be appreciate that confirmation
> before closing bugs.

Wow, I didn't realize that today was release day - you should be able to test
against Wine 1.5.0 :)

[Bug 29031] Game borderlands does not start

http://bugs.winehq.org/show_bug.cgi?id=29031

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #21 from Vitaliy Margolen  2012-03-16 21:50:49 CDT ---
Yup fixed. Thanks!

[Bug 29031] Game borderlands does not start

http://bugs.winehq.org/show_bug.cgi?id=29031

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |3dd58d8bfbf266430130f49dd22
                   |                            |3e284e628b4bc
                 CC|                            |[e-mail]

[Bug 29031] Game borderlands does not start

http://bugs.winehq.org/show_bug.cgi?id=29031

Sylvain Petreolle  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]         |

[Bug 29031] Game borderlands does not start

http://bugs.winehq.org/show_bug.cgi?id=29031

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #22 from Alexandre Julliard  2012-03-30 13:34:41 CDT ---
Closing bugs fixed in 1.5.1.

[Bug 29031] Game borderlands does not start

http://bugs.winehq.org/show_bug.cgi?id=29031

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |1.4.x

[Bug 29031] Game borderlands does not start

http://bugs.winehq.org/show_bug.cgi?id=29031

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|1.4.x                       |---