[Bug 22862] New: Setting the default button in a PropertySheetPage does not work

http://bugs.winehq.org/show_bug.cgi?id=22862

Summary: Setting the default button in a PropertySheetPage does
                    not work
           Product: Wine
           Version: 1.1.44
          Platform: x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=28255)
 --> (http://bugs.winehq.org/attachment.cgi?id=28255)
Winecfg.exe that behaves differently on Wine than on Vista

I stripped Winecfg, left only the Libraries tab, and I added the SendMessage
call after the call for enabling the Add button:

{
    enable(IDC_DLLS_ADDDLL);
    SendMessage(dialog, DM_SETDEFID, (WPARAM)IDC_DLLS_ADDDLL, 0);
}

The winecfg.exe I obtained (attached) behaves different on Vista than on Wine
1.1.44.
- Start winecfg.exe, type "x", press ENTER.
On Vista it generates a click on the Add button, but on Wine it closes the
window.

[Bug 22862] Setting the default button in a PropertySheetPage does not work

http://bugs.winehq.org/show_bug.cgi?id=22862

--- Comment #1 from Nikolay Sivov   2010-05-24 17:14:44 ---
Could you produce a standalone test app for that problem with a single
propertysheet that displays a bug? We will need it anyway to include in tests.

P.S. if it's really a property sheet bug native comctl32 will help.

[Bug 22862] Setting the default button in a PropertySheetPage does not work

http://bugs.winehq.org/show_bug.cgi?id=22862

André H.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |12804

[Bug 22862] Setting the default button in a PropertySheetPage does not work

http://bugs.winehq.org/show_bug.cgi?id=22862

--- Comment #2 from Alex Balut   2010-05-29 18:21:05 ---
I wrote a test that checks this behaviour. Succeeds on Vista, fails on Wine.
http://www.winehq.org/pipermail/wine-patches/2010-May/089057.html

Is there someone to whom we should assign this bug?

[Bug 22862] Setting the default button in a PropertySheetPage does not work

http://bugs.winehq.org/show_bug.cgi?id=22862

André H.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |[e-mail]
          Component|-unknown                    |comctl32
     Ever Confirmed|0                           |1

--- Comment #3 from André H.   2010-06-29 15:00:45 ---
confirming

[Bug 22862] Setting the default button in a PropertySheetPage does not work

http://bugs.winehq.org/show_bug.cgi?id=22862

André H.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|comctl32                    |-unknown

--- Comment #4 from André H.   2010-06-29 15:25:37 ---
sorry, i was wrong. native comctl32 does not help!

[Bug 22862] Setting the default button in a PropertySheetPage does not work

http://bugs.winehq.org/show_bug.cgi?id=22862

André H.  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |user32

--- Comment #5 from André H.   2010-06-29 16:14:33 ---
I found the problem in user32, but it is too late here to send a proper fix.
I know i have to hurry up...
Problem is also that my temporary fix causes some tests to fail :/

[Bug 22862] Setting the default button in a PropertySheetPage does not work

http://bugs.winehq.org/show_bug.cgi?id=22862

--- Comment #6 from Dmitry Timoshkov   2010-06-30 02:16:20 ---
(In reply to comment #5)
> I found the problem in user32, but it is too late here to send a proper fix.

What's the problem is that? Do you have a test case?

[Bug 22862] Setting the default button in a PropertySheetPage does not work

http://bugs.winehq.org/show_bug.cgi?id=22862

--- Comment #7 from André H.   2010-06-30 10:18:59 ---
patch sent:
http://www.winehq.org/pipermail/wine-patches/2010-June/090129.html

[Bug 22862] Setting the default button in a PropertySheetPage does not work

http://bugs.winehq.org/show_bug.cgi?id=22862

Jerome Leclanche  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from Jerome Leclanche  2011-04-01 09:34:32 CDT ---
(In reply to comment #7)
> patch sent:
> http://www.winehq.org/pipermail/wine-patches/2010-June/090129.html

+patch

Patch was not committed.

[Bug 22862] Setting the default button in a PropertySheetPage does not work

http://bugs.winehq.org/show_bug.cgi?id=22862

--- Comment #9 from André H.  2011-08-19 16:00:39 CDT ---
@Alex
I added a user32 version [1] of the test you added in comctl32 and my fix [2]
for it was committed. Anyway your propsheet test didn't fully reflect what
happens in winecfg, so if you could provide a better test i would try to fix
it.

[1]
http://source.winehq.org/git/wine.git/commitdiff/b3fbdfa908d122f713078d69291...
[2]
http://source.winehq.org/git/wine.git/commitdiff/a3551214144c2b973a5a048e81e...

[Bug 22862] Setting the default button in a PropertySheetPage does not work

http://bugs.winehq.org/show_bug.cgi?id=22862

--- Comment #10 from Alex Balut  2011-08-19 16:24:21 CDT ---
André, thanks for the fix you added. It's not very clear, does your commit
actually fix this bug?

[Bug 22862] Setting the default button in a PropertySheetPage does not work

http://bugs.winehq.org/show_bug.cgi?id=22862

--- Comment #11 from André H.  2011-08-20 10:03:33 CDT ---
(In reply to comment #10)
> André, thanks for the fix you added. It's not very clear, does your commit
> actually fix this bug?

no. when i talked about winecfg i meant one with your SETDEFID patch (so that
the add button is default, but still ENTER closes winecfg)

At one point i had the feeling that one part of providing a better test is to
really have more than one tab in the propsheet, but i'm not sure.
I also already tried to send the key event to the editbox, but that didn't work
as i expected. Anyway after much tries i gave up providing a better testcase.

[Bug 22862] Setting the default button in a PropertySheetPage does not work

http://bugs.winehq.org/show_bug.cgi?id=22862

--- Comment #12 from Alex Balut  2011-08-20 17:35:22 CDT ---
I'm busy with something else, I cannot provide a testcase.

[Bug 22862] Setting the default button in a PropertySheetPage does not work

http://bugs.winehq.org/show_bug.cgi?id=22862

--- Comment #13 from Austin English  2013-11-13 16:48:15 CST ---
This is your friendly reminder that there has been no bug activity for 2 years.
Is this still an issue in current (1.7.6 or newer) wine? If so, please attach
the terminal output in 1.7.6 (see http://wiki.winehq.org/FAQ#get_log).

[Bug 22862] Setting the default button in a PropertySheetPage does not work

http://bugs.winehq.org/show_bug.cgi?id=22862

Julian Rüger  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 22862] Setting the default button in a PropertySheetPage does not work

http://bugs.winehq.org/show_bug.cgi?id=22862

Alex Henrie  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 22862] Setting the default button in a PropertySheetPage does not work

https://bugs.winehq.org/show_bug.cgi?id=22862

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |ABANDONED

--- Comment #14 from Austin English  ---
(In reply to Austin English from comment #13)
> This is your friendly reminder that there has been no bug activity for 2
> years. Is this still an issue in current (1.7.6 or newer) wine? If so,
> please attach the terminal output in 1.7.6 (see
> http://wiki.winehq.org/FAQ#get_log).

Abandoned.

[Bug 22862] Setting the default button in a PropertySheetPage does not work

https://bugs.winehq.org/show_bug.cgi?id=22862

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #15 from Austin English  ---
Closing.