[Bug 16501] New: Some moving objects in Myst IV - Revelation turn black on most camera angles

http://bugs.winehq.org/show_bug.cgi?id=16501

Summary: Some moving objects in Myst IV - Revelation turn black
                    on most camera angles
           Product: Wine
           Version: 1.1.10
          Platform: PC-x86-64
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: enhancement
          Priority: P3
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=17923)
 --> (http://bugs.winehq.org/attachment.cgi?id=17923)
The needed patch to run Myst IV - Revelation

Hello,

the game Myst IV - Revelation offers some "special effects". That means that
more objects in the world are animated. Revelation is completely based on
pre-rendered images, and everything that moves is done through a video.
On some places, with many moving objects, these moving objects get black in
specific camera angles(you can rotate the camera free by 360°), and normal in
other angles. Most of the time during game that objects are just flickering or
black, since the "right" camera angle is very small. Regardless if the objects
are black or normal, they are moving correctly. I will attach 2 screenshots
which show the situation.
I will also attach a "hack" patch, which is needed to start Revelation. Without
it, the game just crashes.

[Bug 16501] Some moving objects in Myst IV - Revelation turn black on most camera angles

http://bugs.winehq.org/show_bug.cgi?id=16501

--- Comment #1 from Lisa Denia   2008-12-14 09:39:01 ---
Created an attachment (id=17924)
 --> (http://bugs.winehq.org/attachment.cgi?id=17924)
Shows the situation with the "right" camera angle

[Bug 16501] Some moving objects in Myst IV - Revelation turn black on most camera angles

http://bugs.winehq.org/show_bug.cgi?id=16501

--- Comment #2 from Lisa Denia   2008-12-14 09:40:13 ---
Created an attachment (id=17925)
 --> (http://bugs.winehq.org/attachment.cgi?id=17925)
Shows the situation with all other camera angles

[Bug 16501] Some moving objects in Myst IV - Revelation turn black on most camera angles

http://bugs.winehq.org/show_bug.cgi?id=16501

--- Comment #3 from Lisa Denia   2008-12-14 09:43:24 ---
Created an attachment (id=17926)
 --> (http://bugs.winehq.org/attachment.cgi?id=17926)
Output with "wine Myst4" in the Revelation directory. Start, load the Savegame,
turn the camera around, exit the game.

[Bug 16501] Some moving objects in Myst IV - Revelation turn black on most camera angles

http://bugs.winehq.org/show_bug.cgi?id=16501

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

[Bug 16501] Some moving objects in Myst IV - Revelation turn black on most camera angles

http://bugs.winehq.org/show_bug.cgi?id=16501

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from [e-mail]  2008-12-22 15:00:56 ---
I applied Lisa's hack to start the game. That works, which is cool. I can
confirm the problems with the black or flickering objects. I also have them.
Also the hand-cursor is a bit blurry in some scenes. Don't know if this is
related to the bug.
Leo.

[Bug 16501] Some moving objects in Myst IV - Revelation turn black on most camera angles

http://bugs.winehq.org/show_bug.cgi?id=16501

Lisa Denia  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #5 from Lisa Denia   2008-12-23 12:00:25 ---
*** This bug has been confirmed by popular vote. ***

[Bug 16501] Some moving objects in Myst IV - Revelation turn black on most camera angles

http://bugs.winehq.org/show_bug.cgi?id=16501

--- Comment #6 from Lisa Denia   2008-12-27 14:10:54 ---
Unfortunately, there is no place in the Revelation demo which shows this issue.
The problem does only, as far as I can see, occur in places with many moving
objects, which is especially the case in Haven. Haven is sadly only accessible
in the full version. 
So, the game is very old and only a few persons do own it. Sometimes it may be
a bit difficult to get it. Has anyone _any_ idea what *could* cause this
problem, so I can mess around a bit and maybe fix it?

Thank you

[Bug 16501] Some moving objects in Myst IV - Revelation turn black on most camera angles

http://bugs.winehq.org/show_bug.cgi?id=16501

--- Comment #7 from Lisa Denia   2009-01-08 18:44:16 ---
Ubisoft released an official noDVD patch, see
http://forums.ubi.com/eve/forums/a/tpc/f/580100736/m/7241013324 for more
details.

[Bug 16501] Some moving objects in Myst IV - Revelation turn black on most camera angles

http://bugs.winehq.org/show_bug.cgi?id=16501

--- Comment #8 from joaopa   2009-04-04 06:45:21 ---
This bug should be marked as INVALID probably. The hack prevents surfaces to be
fulfilled. So, it is not surprising that there are black parts in the screen.

Probably, when bug 10758 is fixed, this one will be too.

[Bug 16501] Some moving objects in Myst IV - Revelation turn black on most camera angles

http://bugs.winehq.org/show_bug.cgi?id=16501

--- Comment #9 from Lisa Denia   2009-04-05 07:07:35 ---
Tried Jim Camerons POC solution from
http://bugs.winehq.org/show_bug.cgi?id=10758, which should work fine. The
problem persists, so I think that workaround isn't causing it.

[Bug 16501] Some moving objects in Myst IV - Revelation turn black on most camera angles

http://bugs.winehq.org/show_bug.cgi?id=16501

--- Comment #10 from Lisa Denia   2009-05-22 21:41:40 ---
Still present in Wine 1.1.22.

[Bug 16501] Some moving objects in Myst IV - Revelation turn black on most camera angles

http://bugs.winehq.org/show_bug.cgi?id=16501

--- Comment #11 from Lisa Denia   2009-07-03 15:38:45 ---
Also true for Wine 1.1.25.

[Bug 16501] Some moving objects in Myst IV - Revelation turn black on most camera angles

http://bugs.winehq.org/show_bug.cgi?id=16501

--- Comment #12 from Lisa Denia   2009-07-04 08:05:42 ---
I finally got some time to dig into the source, and I found a solution. Maybe.
As there weren't any useful hints in Wine's output, I started adding "Just
return if I pressed F12" patches to various, often used functions. It turned
out that SetRenderState does something related to this bug. If it gets disabled
during runtime, the screen will get totally messed up(you may have guessed...),
BUT all that moving objects are rendererd correctly.
So I tried a couple of things, including just ignoring several states. Ignoring
WINED3DRS_EMISSIVEMATERIALSOURCE prevents the objects from turning black, by
introducing new bugs in the UI. So I traced what is done when, and the attached
patch resulted ;).
As far as I can see, it fixes all black objects. Tested in Tomahna, Spire and
Haven, everything looks perfectly nice. Also the UI looks like it should, in
contrast to just ignoring WINED3DRS_EMISSIVEMATERIALSOURCE.

I wonder if this patch will be considered as clean(and should be committed
then) or not. Any suggestions appreciated.

[Bug 16501] Some moving objects in Myst IV - Revelation turn black on most camera angles

http://bugs.winehq.org/show_bug.cgi?id=16501

--- Comment #13 from Lisa Denia   2009-07-04 08:07:10 ---
Created an attachment (id=22172)
 --> (http://bugs.winehq.org/attachment.cgi?id=22172)
Experimental patch enabling correct rendering of all moving objects

[Bug 16501] Some moving objects in Myst IV - Revelation turn black on most camera angles

http://bugs.winehq.org/show_bug.cgi?id=16501

joaopa  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #14 from joaopa   2009-07-04 09:12:23 ---
The patch should be sent to Wine-patches. There, it will be reviewed by Wine
D3D gurus.

[Bug 16501] Some moving objects in Myst IV - Revelation turn black on most camera angles

http://bugs.winehq.org/show_bug.cgi?id=16501

--- Comment #15 from Henri Verbeet   2009-07-05 16:06:41 ---
What are the values of the various material source renderstates (ambient in
particular) when the code that patch adds is triggered?

[Bug 16501] Some moving objects in Myst IV - Revelation turn black on most camera angles

http://bugs.winehq.org/show_bug.cgi?id=16501

--- Comment #16 from Lisa Denia   2009-09-24 15:11:43 ---
In Haven, the place shown in my first 2 screenshots,
WINED3DRS_DIFFUSEMATERIALSOURCE, WINED3DRS_AMBIENTMATERIALSOURCE and
WINED3DRS_SPECULARMATERIALSOURCE are always 0, WINED3DRS_EMISSIVEMATERIALSOURCE
is always 1. However, using GL_EMISSION instead of GL_AMBIENT doesn't give us
correct results. Haven gets rendered correctly. But another one, Spire, will
suffer from the same bug as Haven without any patches. This misbehavior does
not happen if I don't add any patches. 
In Spire, the material source renderstates are sometines the same as in Haven,
sometimes WINED3DRS_DIFFUSEMATERIALSOURCE is 1 and everything else 0.

[Bug 16501] Some moving objects in Myst IV - Revelation turn black on most camera angles

http://bugs.winehq.org/show_bug.cgi?id=16501

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 16501] Some moving objects in Myst IV - Revelation turn black on most camera angles

http://bugs.winehq.org/show_bug.cgi?id=16501

Xavier Vachon  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #17 from Xavier Vachon   2010-07-10 09:59:00 ---
In current git (1.2-rc7), I am unable to reproduce this bug.

Lisa, can you try again and post your results?

[Bug 16501] Some moving objects in Myst IV - Revelation turn black on most camera angles

http://bugs.winehq.org/show_bug.cgi?id=16501

--- Comment #18 from Lisa Denia   2010-07-13 23:08:08 ---
Yes, this bug seems to be fixed in latest git(running wine-1.2-rc7-44-g03742f4
here). I think we can close this as FIXED.

[Bug 16501] Some moving objects in Myst IV - Revelation turn black on most camera angles

http://bugs.winehq.org/show_bug.cgi?id=16501

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #19 from Dmitry Timoshkov   2010-07-14 00:14:19 ---
Reported fixed.

[Bug 16501] Some moving objects in Myst IV - Revelation turn black on most camera angles

http://bugs.winehq.org/show_bug.cgi?id=16501

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #20 from Alexandre Julliard   2010-07-30 12:56:29 ---
Closing bugs fixed in 1.3.0.