[Bug 20094] New: messui.exe: instantly crashes

http://bugs.winehq.org/show_bug.cgi?id=20094

Summary: messui.exe: instantly crashes
           Product: Wine
           Version: 1.1.29
          Platform: PC
               URL: http://www.mess.org/download.php
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Created an attachment (id=23657)
 --> (http://bugs.winehq.org/attachment.cgi?id=23657)
wine debug output after closing the error-window

hello,

- my first report, i hope its all ok.

- wine version wine-1.1.29 (also with earlier versions)
- running on a 32-bit fedora 11 installation.

- messui.exe is the gui for mess' windows version.
http://appdb.winehq.org/objectManager.php?sClass=application&iId=5988

- starting it, gui is visible and an error-window appears. closing the error
window gives different dubeugging infos ( see attachement).

i hope it can be fixed. thanks in advance.

best regards

[Bug 20094] messui.exe: instantly crashes

http://bugs.winehq.org/show_bug.cgi?id=20094

--- Comment #1 from Nikolay Sivov   2009-09-19 11:14:12 ---
Hi,

first of all try 'winetricks cc580'.

That's interesting:

---
err:listview:LISTVIEW_WindowProc unknown msg 1200 wp=00000000 lp=00000000   
---

it's an application bug or ListView should handle header messages too...I'll
test it.

[Bug 20094] messui.exe: instantly crashes

http://bugs.winehq.org/show_bug.cgi?id=20094

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download

[Bug 20094] messui.exe: instantly crashes

http://bugs.winehq.org/show_bug.cgi?id=20094

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |source
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #2 from Nikolay Sivov   2009-09-19 12:55:37 ---
Confirming.

I was right about a bug in application itself, but it isn't a problem here -
this program crashes with native comctl32 module too.

I've filed a bug found here if somebody cares:

http://bugzilla.mess.org/show_bug.cgi?id=1861

[Bug 20094] messui.exe: instantly crashes

http://bugs.winehq.org/show_bug.cgi?id=20094

--- Comment #3 from [e-mail]  2009-09-19 14:18:30 ---
Hi,

thanks a lot Nikolay, that was really quick. also thanks for the bugreport :)

best regards!

[Bug 20094] messui.exe: instantly crashes

http://bugs.winehq.org/show_bug.cgi?id=20094

--- Comment #4 from [e-mail]  2009-09-19 14:27:24 ---
Created an attachment (id=23660)
 --> (http://bugs.winehq.org/attachment.cgi?id=23660)
wine debug output after adding "winetricks cc580"

[Bug 20094] messui.exe: instantly crashes

http://bugs.winehq.org/show_bug.cgi?id=20094

--- Comment #5 from [e-mail]  2009-09-19 15:48:42 ---
(From update of attachment 23660)
hello, i've added the cc580 package and the problem perists.

[Bug 20094] messui.exe: instantly crashes

http://bugs.winehq.org/show_bug.cgi?id=20094

--- Comment #6 from Nikolay Sivov   2009-09-19 15:52:45 ---
(In reply to comment #5)
> (From update of attachment 23660 [details])
> hello, i've added the cc580 package and the problem perists.

I know that:

(In reply to comment #2)
> this program crashes with native comctl32 module too.

[Bug 20094] messui.exe: instantly crashes

http://bugs.winehq.org/show_bug.cgi?id=20094

Peter Dons Tychsen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #7 from Peter Dons Tychsen   2009-09-20 18:49:57 ---
Hello.

I took a look at this.

After rebuilding MESS with allot of debug and prints i suddenly realized that
MESS was also crashing at the very same spot (in a timer callback function).

The odd thing was that no unhandled-exception was thrown like in Wine. First i
thought it was an exception handler cleverly installed. But no.

It seemed that Windows was hiding this exception. Then i found this:

http://www.experts-exchange.com/Programming/Languages/CPP/Q_22041925.html

Which is the same. So i think that windows for some reason protects timer
callbacks (from WM_TIMER) with a TRY/CATCH or similar. Very annoying.

I will construct some tests and a fix.

Thanks,

/pedro

[Bug 20094] messui.exe: instantly crashes

http://bugs.winehq.org/show_bug.cgi?id=20094

--- Comment #8 from Peter Dons Tychsen   2009-09-20 18:51:29 ---
> > After rebuilding MESS with allot of debug and prints i suddenly realized that
> > MESS was also crashing at the very same spot (in a timer callback function).

I meant in Windows of course....

Also: To sum it up this is a bug in MESS hidden by a feature in Windows.

[Bug 20094] messui.exe: instantly crashes

http://bugs.winehq.org/show_bug.cgi?id=20094

--- Comment #9 from Nikolay Sivov   2009-09-20 19:21:29 ---
(In reply to comment #7)

Hi, Peter.
> I will construct some tests and a fix.

Great. So this is a bug in DispatchMessage(), right?

[Bug 20094] messui.exe: instantly crashes

http://bugs.winehq.org/show_bug.cgi?id=20094

--- Comment #10 from Peter Dons Tychsen   2009-09-20 19:35:00 ---
> > Great. So this is a bug in DispatchMessage(), right?

Yes.

I fixed it in DispatchMessageA and DispatchMessageW.

/pedro

[Bug 20094] messui.exe: instantly crashes

http://bugs.winehq.org/show_bug.cgi?id=20094

--- Comment #11 from Peter Dons Tychsen   2009-09-20 19:37:44 ---
Created an attachment (id=23682)
 --> (http://bugs.winehq.org/attachment.cgi?id=23682)
Patch for exception handling for WM_TIMER callback

Here is the patch (wine-patches is sleeping....)

[Bug 20094] messui.exe: instantly crashes

http://bugs.winehq.org/show_bug.cgi?id=20094

--- Comment #12 from Peter Dons Tychsen   2009-09-20 19:38:41 ---
Sent to wine-patches....

[Bug 20094] messui.exe: instantly crashes

http://bugs.winehq.org/show_bug.cgi?id=20094

--- Comment #13 from Peter Dons Tychsen   2009-09-20 19:41:51 ---
Nikolay, after this bug is fixed there is a little work on list-control to be
done i think.

When using the game browser the current selection jumps up and down and it is
hard to select other entries than the first (32X). This is another bug of
course..... but thought you might like to know.

[Bug 20094] messui.exe: instantly crashes

http://bugs.winehq.org/show_bug.cgi?id=20094

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |user32

--- Comment #14 from Nikolay Sivov   2009-09-20 19:52:03 ---
(In reply to comment #13)
> Nikolay, after this bug is fixed there is a little work on list-control to be
> done i think.
>
> When using the game browser the current selection jumps up and down and it is
> hard to select other entries than the first (32X). This is another bug of
> course..... but thought you might like to know.

Fine, just open a bug.

(In reply to comment #11)
> Created an attachment (id=23682)

--> (http://bugs.winehq.org/attachment.cgi?id=23682) [details]
> Patch for exception handling for WM_TIMER callback
>
> Here is the patch (wine-patches is sleeping....)

The only comment here is to use indentation consistent with surrounding code
(spaces without tabs).

[Bug 20094] messui.exe: instantly crashes

http://bugs.winehq.org/show_bug.cgi?id=20094

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23682|application/octet-stream    |text/plain
          mime type|                            |
  Attachment #23682|0                           |1
           is patch|                            |

[Bug 20094] messui.exe: instantly crashes

http://bugs.winehq.org/show_bug.cgi?id=20094

--- Comment #15 from [e-mail]  2009-09-26 16:45:14 ---
thanks a lot Peter. unfortunatly i cant test it at the moment - there is no rpm
build for my machine as of now :(
on the other hand, i cant find the bug-number in the latest changelog:
http://www.winehq.org/announce/1.1.30
do i have to set the status or something else, or whats wrong?

thanks again Nikolay & Peter!

[Bug 20094] messui.exe: instantly crashes

http://bugs.winehq.org/show_bug.cgi?id=20094

--- Comment #16 from Nikolay Sivov   2009-09-26 16:50:22 ---
(In reply to comment #15)
> thanks a lot Peter. unfortunatly i cant test it at the moment - there is no rpm
> build for my machine as of now :(
> on the other hand, i cant find the bug-number in the latest changelog:
> http://www.winehq.org/announce/1.1.30
> do i have to set the status or something else, or whats wrong?

Nothing. Patch wasn't committed yet. It affects WM_TIMER message dispatching in
general so we have to wait for review.

BTW, Peter will you resend a patch on Monday or something?

[Bug 20094] messui.exe: instantly crashes

http://bugs.winehq.org/show_bug.cgi?id=20094

--- Comment #17 from [e-mail]  2009-09-26 16:57:40 ---
(In reply to comment #16)
> Nothing. Patch wasn't committed yet. It affects WM_TIMER message dispatching in
> general so we have to wait for review.

ok. thanks for info. will watch the progress on this bug. hope it gets into the
svn soon.

[Bug 20094] messui.exe: instantly crashes

http://bugs.winehq.org/show_bug.cgi?id=20094

--- Comment #18 from Peter Dons Tychsen   2009-09-29 16:40:38 ---
> > BTW, Peter will you resend a patch on Monday or something?

Patch resent as TRY2 (removed tabs). Lets hope he buys it! :-)

[Bug 20094] messui.exe: instantly crashes

http://bugs.winehq.org/show_bug.cgi?id=20094

Juan Lang  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #19 from Juan Lang   2009-09-30 14:07:29 ---
It appears this was fixed by commit f20f411925e789a2aecf740776f441335837ac5f (
http://www.winehq.org/pipermail/wine-cvs/2009-September/059929.html ).  Please
reopen if that's not the case.

[Bug 20094] messui.exe: instantly crashes

http://bugs.winehq.org/show_bug.cgi?id=20094

--- Comment #20 from Nikolay Sivov   2009-10-01 19:43:06 ---
(In reply to comment #13)
> Nikolay, after this bug is fixed there is a little work on list-control to be
> done i think.
>
> When using the game browser the current selection jumps up and down and it is
> hard to select other entries than the first (32X). This is another bug of
> course..... but thought you might like to know.

Hi, Peter.

When this is fixed could you describe this listview issue in details? I don't
see any selection problems, feel free to open a bug for that if it's still a
problem.

[Bug 20094] messui.exe: instantly crashes

http://bugs.winehq.org/show_bug.cgi?id=20094

--- Comment #21 from Peter Dons Tychsen   2009-10-02 04:51:12 ---
> > When this is fixed could you describe this listview issue in details? I don't
> > see any selection problems, feel free to open a bug for that if it's still a
> > problem.

Hmm. You are right. It works now!
Must have been fixed i the mean time, or something else was jinxing my setup.
Fixed!

[Bug 20094] messui.exe: instantly crashes

http://bugs.winehq.org/show_bug.cgi?id=20094

--- Comment #22 from [e-mail]  2009-10-02 14:57:30 ---
great! thanks a lot, its now working without problems - tested c64-emulation,
starts as expected, returns to gui after closing the emu-window - as intended
:)

have been trying some mess-guis for linux, but all are bloated, ugly or slow -
the windows one is simply the best - more responsive - even while emulated
using wine!

thanks again, and cya at the next bug report ;)

[Bug 20094] messui.exe: instantly crashes

http://bugs.winehq.org/show_bug.cgi?id=20094

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #23 from Alexandre Julliard   2009-10-09 11:14:24 ---
Closing bugs fixed in 1.1.31.