[Bug 26728] New: d3d_compiler/reflection test shows a ton of valgrind warnings

http://bugs.winehq.org/show_bug.cgi?id=26728

Summary: d3d_compiler/reflection test shows a ton of valgrind
                    warnings
           Product: Wine
           Version: 1.3.17
          Platform: x86
        OS/Version: Linux
            Status: NEW
          Keywords: download, source, testcase
          Severity: minor
          Priority: P2
         Component: directx-d3dx9
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
                CC: [e-mail], [e-mail]

Invalid write of size 4
    at  copy_name (reflection.c:166)
    by  d3dcompiler_parse_type_members (reflection.c:1176)
    by  d3dcompiler_parse_type (reflection.c:1247)
    by  get_reflection_type (reflection.c:1293)
    by  d3dcompiler_parse_variables (reflection.c:1353)
    by  d3dcompiler_parse_rdef (reflection.c:1522)
    by  d3dcompiler_shader_reflection_init (reflection.c:1711)
    by  D3DReflect (reflection.c:1840)
    by  test_reflection_constant_buffer (reflection.c:1233)
    by  func_reflection (reflection.c:1515)
    by  run_test (test.h:556)
    by  main (test.h:624)
  Address 0x7f037adc is 0 bytes after a block of size 12 alloc'd
    at  notify_alloc (heap.c:254)
    by  RtlAllocateHeap (heap.c:1702)
    by  d3dcompiler_parse_type (reflection.c:1238)
    by  get_reflection_type (reflection.c:1293)
    by  d3dcompiler_parse_variables (reflection.c:1353)
    by  d3dcompiler_parse_rdef (reflection.c:1522)
    by  d3dcompiler_shader_reflection_init (reflection.c:1711)
    by  D3DReflect (reflection.c:1840)
    by  test_reflection_constant_buffer (reflection.c:1233)
    by  func_reflection (reflection.c:1515)
    by  run_test (test.h:556)
    by  main (test.h:624)

[Bug 26728] d3d_compiler/reflection test shows a ton of valgrind warnings

http://bugs.winehq.org/show_bug.cgi?id=26728

--- Comment #1 from Austin English  2011-04-11 14:28:27 CDT ---
Created an attachment (id=34049)
 --> (http://bugs.winehq.org/attachment.cgi?id=34049)
valgrind log

[Bug 26728] d3d_compiler/reflection test shows a ton of valgrind warnings

http://bugs.winehq.org/show_bug.cgi?id=26728

--- Comment #2 from Rico  2011-04-11 17:39:14 CDT ---
Created an attachment (id=34053)
 --> (http://bugs.winehq.org/attachment.cgi?id=34053)
Fix allocated size for members.

Could you please give the attached patch a try? Does it fix all issues?

[Bug 26728] d3d_compiler/reflection test shows a ton of valgrind warnings

http://bugs.winehq.org/show_bug.cgi?id=26728

--- Comment #3 from Austin English  2011-04-11 19:49:25 CDT ---
(In reply to comment #2)
> Created an attachment (id=34053)

--> (http://bugs.winehq.org/attachment.cgi?id=34053) [details]
> Fix allocated size for members.
>
> Could you please give the attached patch a try? Does it fix all issues?

Nearly, one left:
24 bytes in 1 blocks are definitely lost in loss record 166 of 623
   at 0x7BC4728D: notify_alloc (heap.c:254)
   by 0x7BC4BAB1: RtlAllocateHeap (heap.c:1702)
   by 0x479DA5C: d3dcompiler_parse_type (reflection.c:1238)
   by 0x479DD1C: get_reflection_type (reflection.c:1293)
   by 0x479E1BC: d3dcompiler_parse_variables (reflection.c:1353)
   by 0x479F177: d3dcompiler_parse_rdef (reflection.c:1522)
   by 0x479FE99: d3dcompiler_shader_reflection_init (reflection.c:1711)
   by 0x47A0688: D3DReflect (reflection.c:1840)
   by 0x476567C: test_reflection_constant_buffer (reflection.c:1233)
   by 0x4767CED: func_reflection (reflection.c:1515)
   by 0x4768957: run_test (test.h:556)
   by 0x4768D4A: main (test.h:624)

[Bug 26728] d3d_compiler/reflection test shows a ton of valgrind warnings

http://bugs.winehq.org/show_bug.cgi?id=26728

Rico  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34053|0                           |1
        is obsolete|                            |

--- Comment #4 from Rico  2011-04-12 01:56:08 CDT ---
Created an attachment (id=34056)
 --> (http://bugs.winehq.org/attachment.cgi?id=34056)
Fix HeapAlloc + HeapFree type members

The attached patch should solve the issue. Could you please retry? It contains
the previous one, so only the second one should be needed.

[Bug 26728] d3d_compiler/reflection test shows a ton of valgrind warnings

http://bugs.winehq.org/show_bug.cgi?id=26728

--- Comment #5 from Austin English  2011-04-12 11:49:46 CDT ---
(In reply to comment #4)
> Created an attachment (id=34056)

--> (http://bugs.winehq.org/attachment.cgi?id=34056) [details]
> Fix HeapAlloc + HeapFree type members
>
> The attached patch should solve the issue. Could you please retry? It contains
> the previous one, so only the second one should be needed.

Looks great, thanks!

[Bug 26728] d3d_compiler/reflection test shows a ton of valgrind warnings

http://bugs.winehq.org/show_bug.cgi?id=26728

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #6 from Austin English  2011-04-13 11:00:33 CDT ---
Fixed by
http://source.winehq.org/git/wine.git/commitdiff/c49f09d6f8f84cccd02a131e2ca...

Thanks Rico!

[Bug 26728] d3d_compiler/reflection test shows a ton of valgrind warnings

http://bugs.winehq.org/show_bug.cgi?id=26728

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #7 from Alexandre Julliard  2011-04-15 12:49:57 CDT ---
Closing bugs fixed in 1.3.18.