[Bug 28939] New: Notepad2: page fault when saving or opening files [download, source]

http://bugs.winehq.org/show_bug.cgi?id=28939

Bug #: 28939
           Summary: Notepad2: page fault when saving or opening files
                    [download, source]
           Product: Wine
           Version: 1.3.31
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

Created attachment 37198
  --> http://bugs.winehq.org/attachment.cgi?id=37198
console output of testing typing some html code and trying to save it.

* Saving a file via GUI: app crashes after selecting the destination file name/
  path. file contents are saved, however (in my test case - don't rely on it).
* Opening a file via GUI: app crashes after selecting source file name/path.
* Opening a file via CLI: app crasheson startup when passing a filename as
  single first parameter on command line. (on windows: opens that file)

I'll attach the error logs. I first thought it had to do with the message
> fixme:commdlg:GetFileName95 Flags 0x02000000 not yet implemented

but seems that is no problem since it appears every time I open the file select
window, but when I cancel that instead of opening or saving the file, the app
won't crash.

I'm missing the keywords field in the bug report form, so I've added them in
the
subject and will try to add "download source" after submitting.

[Bug 28939] Notepad2: page fault when saving or opening files [download, source]

http://bugs.winehq.org/show_bug.cgi?id=28939

Anthony Hanes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, source
                URL|                            |http://www.flos-freeware.ch
                   |                            |/notepad2.html

[Bug 28939] Notepad2: page fault when saving or opening files [download, source]

http://bugs.winehq.org/show_bug.cgi?id=28939

--- Comment #1 from Anthony Hanes  2011-10-30 05:08:10 CDT ---
Created attachment 37199
  --> http://bugs.winehq.org/attachment.cgi?id=37199
console output of trying to open some small html file.

[Bug 28939] Notepad2: page fault when saving or opening files

http://bugs.winehq.org/show_bug.cgi?id=28939

Anthony Hanes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Notepad2: page fault when   |Notepad2: page fault when
                   |saving or opening files     |saving or opening files
                   |[download, source]          |

[Bug 28939] Notepad2: page fault when saving or opening files

http://bugs.winehq.org/show_bug.cgi?id=28939

--- Comment #2 from Anthony Hanes  2011-10-30 08:03:06 CDT ---
Workaround for people who can make do with an old version:
The Wayback Machine still has version 4.0.23 around. To get it, visit
http://web.archive.org/web/20091206072228/http://flos-freeware.ch/notepad2.h...
and follow the download link from there.

[Bug 28939] Notepad2: page fault when saving or opening files

http://bugs.winehq.org/show_bug.cgi?id=28939

--- Comment #3 from Austin English  2011-10-30 17:31:26 CDT ---
=>0 0x68707977 PathIsUNCW+0x27() in shlwapi (0x0033c16c)
  1 0x6870a30c PathAppendW+0x4b() in shlwapi (0x0033c1bc)

Try native shlwapi.

[Bug 28939] Notepad2: page fault when saving or opening files

http://bugs.winehq.org/show_bug.cgi?id=28939

--- Comment #4 from Anthony Hanes  2011-11-01 18:17:15 CDT ---
works, thank you. :) i'll recheck this bug to help with further testing if
someone wants to try and modify wine's shlwapi.

Extended howto using proprietary Windows DLL:
* copy %windir%\system32\shlwapi.dll from WinXP Pro SP 3 to same path where
Notepad2.exe is.
* run wincfg and add a dll override: if you drop down the combo box first and
type "shl", it's already there. click the add button and winecfg puts in some
default values.
* works. :)

[Bug 28939] Notepad2: page fault when saving or opening files

http://bugs.winehq.org/show_bug.cgi?id=28939

--- Comment #5 from Austin English  2011-11-01 18:27:00 CDT ---
Please attach a +shlwapi trace (with debugging symbols installed). You'll need
to use wine's builtin dll for this.

[Bug 28939] Notepad2: page fault when saving or opening files

http://bugs.winehq.org/show_bug.cgi?id=28939

--- Comment #6 from Anthony Hanes  2011-11-07 05:21:38 CST ---
Created attachment 37350
  --> http://bugs.winehq.org/attachment.cgi?id=37350
WINEDEBUG=+shlwapi wine Notepad2.exe Notepad2.ini

hello Austin, I hope I understood your request right, then here it is. :)

[Bug 28939] Notepad2: page fault when saving or opening files

http://bugs.winehq.org/show_bug.cgi?id=28939

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #7 from Austin English  2011-11-07 13:13:31 CST ---
Backtrace:
=>0 0x7eaec379 PathIsUNCW+0x29(lpszPath="")
[/home/austin/wine-git/dlls/shlwapi/path.c:2203] in shlwapi (0x0033ec18)
  1 0x7eaed68c PathAppendW+0x4b(lpszPath="C:\users\austin\My Documents",
lpszAppend="") [/home/austin/wine-git/dlls/shlwapi/path.c:105] in shlwapi
(0x0033ec68)
  2 0x0045c862 in notepad2 (+0x5c861) (0x0033f094)
  3 0x0045ca36 in notepad2 (+0x5ca35) (0x0033f2c0)
  4 0x00463292 in notepad2 (+0x63291) (0x0033f90c)
  5 0x0046391a in notepad2 (+0x63919) (0x00494a20)
  6 0x0068005c (0x003a005a)
  7 0x00000000 (0x00000000)
0x7eaec379 PathIsUNCW+0x29 [/home/austin/wine-git/dlls/shlwapi/path.c:2203] in
shlwapi: cmpw    $92,0x0(%esi)
2203      if (lpszPath && (lpszPath[0]=='\') && (lpszPath[1]=='\'))

The debug channel should've been shell (my mistake). I'll attach that log.
Confimring in 1.3.32.

c91154f83dbab37747ce354c69b59599e9990129  /home/austin/notepad2_4.2.25_x86.zip

[Bug 28939] Notepad2: page fault when saving or opening files

http://bugs.winehq.org/show_bug.cgi?id=28939

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37350|0                           |1
        is obsolete|                            |

--- Comment #8 from Austin English  2011-11-07 13:14:12 CST ---
Created attachment 37357
  --> http://bugs.winehq.org/attachment.cgi?id=37357
+shell trace

[Bug 28939] Notepad2: page fault when saving or opening files

http://bugs.winehq.org/show_bug.cgi?id=28939

Bruno Jesus  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #9 from Bruno Jesus  2013-02-23 18:17:56 CST ---
I'm not able to reproduce this issue in wine 1.5.24, can anyone else retest?

[Bug 28939] Notepad2: page fault when saving or opening files

http://bugs.winehq.org/show_bug.cgi?id=28939

Frédéric Delanoy  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |[e-mail]
         Resolution|---                         |FIXED

--- Comment #10 from Frédéric Delanoy  ---
Works as well for me in 1.7.11.

Marking fixed.

[Bug 28939] Notepad2: page fault when saving or opening files

https://bugs.winehq.org/show_bug.cgi?id=28939

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #11 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.12.