[Bug 50110] New: Elite Dangerous Launcher (wine-5.21): AccessViolationException Protected Memory

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50110

Bug ID: 50110
           Summary: Elite Dangerous Launcher (wine-5.21):
                    AccessViolationException Protected Memory
           Product: Wine
           Version: 5.21
          Hardware: x86-64
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 68601
  --> https://bugs.winehq.org/attachment.cgi?id=68601
shell output from wine-staging-5.21

In wine-5.21 and wine-staging-5.21 (tested both) the Elite Dangerous launcher
exits immediately with this error:

Unhandled Exception: Attempted to read or write protected memory. This is often
an indication that other memory is corrupt.

See the attachment for shell output by wine-stating-5.21.
wine and wine-staging 5.20 worked fine (and still work fine - so my hardware
memory definitely shouldn't be corrupt).

OS: Debian-11 Beta (Bullseye)
CPU: AMD Phenom(tm) II X4 955 Processor
memory / RAM: 12 GB

Wine-5.21 from https://dl.winehq.org/wine-builds/debian/

Wine-Staging-5.21: compiled myself
CFLAGS: -march=amdfam10 -O2
(with wine-staging version 5.19 and 5.20 these CFLAGS worked fine)

Notes:

The launcher worked with wine-staging-5.20.
But if you actually want to launch the game with wine-staging >= 5.16 you need
the patch from this bug report.
https://bugs.winehq.org/show_bug.cgi?id=49782

Some problems the launcher had with Wine versions < 5.15
https://bugs.winehq.org/show_bug.cgi?id=49609
https://bugs.winehq.org/show_bug.cgi?id=48132

[Bug 50110] Elite Dangerous Launcher (wine-5.21): AccessViolationException Protected Memory

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50110

Peter van de Werken  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 50110] Elite Dangerous Launcher (wine-5.21): AccessViolationException Protected Memory

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50110

--- Comment #1 from kolAflash  ---
Did a git-bisect.

First bad commit:
https://source.winehq.org/git/wine.git/commit/d5a10e2d2882a8f2a7dbeb7dafb8db...

[Bug 50110] Elite Dangerous Launcher (wine-5.21): AccessViolationException Protected Memory

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50110

--- Comment #2 from kolAflash  ---
(In reply to kolAflash from comment #1)
> First bad commit:
> https://source.winehq.org/git/wine.git/commit/
> d5a10e2d2882a8f2a7dbeb7dafb8db2bd96f2cdd

Reverted that commit on wine-staging-5.21 and the bug is gone.

[Bug 50110] Elite Dangerous Launcher (wine-5.21): AccessViolationException Protected Memory

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50110

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]
          Component|-unknown                    |mshtml
           Keywords|                            |regression
    Regression SHA1|                            |d5a10e2d2882a8f2a7dbeb7dafb
                   |                            |8db2bd96f2cdd

[Bug 50110] Elite Dangerous Launcher (wine-5.21): AccessViolationException Protected Memory

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50110

--- Comment #3 from Rafał Mużyło  ---
...
Likely unrelated to this bug, but it would seem that commit preserved an old
typo.

Cause unless I'm missing something, "fuchsia" is the correct spelling, not
"fushsia". So, unless that's to preserve a Windows bug...

[Bug 50110] Elite Dangerous Launcher (wine-5.21): AccessViolationException Protected Memory

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50110

Paul Gofman  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Paul Gofman  ---
I could not reproduce the issue. I tried even with the exact Wine 5.21 binaries
for  Debian Bullseye from here: https://dl.winehq.org/wine-builds/debian/

The launcher is crashing early with an unrelated Mono error. I suppose this bug
was reported with native .Net, I guess it wasn't working with Mono before. With
native dotnet40 the launcher does have issues (doesn't download contents at
least with my version of gnutls, which I worked around by some tweaks in the
code for now to make sure the crash won't appear when it downloads smth;
disappearing & appearing back GUI elements). But it does not crash for me.

Can you please attach WINEDEBUG=+pid,+loaddll,+timestamp,+seh log (with
mainstream Wine 5.21, official Debian Bullseye binaries from winehq.org)?

[Bug 50110] Elite Dangerous Launcher (wine-5.21): AccessViolationException Protected Memory

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50110

--- Comment #5 from kolAflash  ---
Created attachment 68611
  --> https://bugs.winehq.org/attachment.cgi?id=68611
WINEDEBUG=+pid,+loaddll,+timestamp,+seh

(In reply to Paul Gofman from comment #4)
> [...]
> The launcher is crashing early with an unrelated Mono error. I suppose this
> bug was reported with native .Net, I guess it wasn't working with Mono
> before. With native dotnet40 the launcher does have issues (doesn't download
> contents at least with my version of gnutls, which I worked around by some
> tweaks in the code for now to make sure the crash won't appear when it
> downloads smth; disappearing & appearing back GUI elements). But it does not
> crash for me.

It's been a while since I set up that wine prefix.
But I remember that I needed to twiddle around with .NET.

Control Panel (wine control) -> Software
says "Microsoft .NET Framework 4.5.2" is installed.
> [...]
> Can you please attach WINEDEBUG=+pid,+loaddll,+timestamp,+seh log (with
> mainstream Wine 5.21, official Debian Bullseye binaries from winehq.org)?

Sure, it's attached.

And I've used the wine-devel-5.21~bullseye binaries from:
https://dl.winehq.org/wine-builds/debian/

[Bug 50110] Elite Dangerous Launcher (wine-5.21): AccessViolationException Protected Memory

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50110

--- Comment #6 from Paul Gofman  ---
Thanks. I finally could reproduce the crash, the culprit was how I run
EDLaunch.exe. It is a pure .Net assembly and I can reproduce the crash when
running that as 64 bit with wine64.

The blamed commit is not at fault, there is out of bound access in mshtml which
just didn't cause access violation previously by chance.

I sent a possible fix: https://source.winehq.org/patches/data/195803

[Bug 50110] Elite Dangerous Launcher (wine-5.21): AccessViolationException Protected Memory

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50110

--- Comment #7 from kolAflash  ---
(In reply to Paul Gofman from comment #6)
> [...]
> I sent a possible fix: https://source.winehq.org/patches/data/195803

Works great!
Tested with wine-staging-5.21

Would someone mind setting this bug to CONFIRMED ?

[Bug 50110] Elite Dangerous Launcher (wine-5.21): AccessViolationException Protected Memory

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50110

Michael Stefaniuc  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
      Fixed by SHA1|                            |8ea89841964c6df98aa6230cc66
                   |                            |ef1fd07c543eb
         Resolution|---                         |FIXED

--- Comment #8 from Michael Stefaniuc  ---
Fixed by
https://source.winehq.org/git/wine.git/?a=commit;h=8ea89841964c6df98aa6230cc...

[Bug 50110] Elite Dangerous Launcher (wine-5.21): AccessViolationException Protected Memory

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50110

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #9 from Alexandre Julliard  ---
Closing bugs fixed in 5.22.

[Bug 50110] Elite Dangerous Launcher (wine-5.21): AccessViolationException Protected Memory

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=50110

Peter van de Werken  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]      |