[Bug 51789] New: Applications fails to start due to gdi32 initialization failure

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51789

Bug ID: 51789
           Summary: Applications fails to start due to gdi32
                    initialization failure
           Product: Wine
           Version: 6.17
          Hardware: x86-64
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: gdi32
          Assignee: [e-mail]
          Reporter: [e-mail]
   Regression SHA1: 3eeb37f86a4d0a8c826fa72d8f657e13b8d159e4
      Distribution: ---

Bisect points to this one:

3eeb37f86a4d0a8c826fa72d8f657e13b8d159e4 is the first bad commit
commit 3eeb37f86a4d0a8c826fa72d8f657e13b8d159e4
Author: Jacek Caban 
Date:   Thu Sep 23 13:44:05 2021 +0100

gdi32: Directly use ntdll in add_face_to_cache.

Signed-off-by: Jacek Caban 
    Signed-off-by: Huw Davies 
    Signed-off-by: Alexandre Julliard

dlls/gdi32/font.c | 46 ++++++++++++++++++++++++++++++++++++----------
 1 file changed, 36 insertions(+), 10 deletions(-)

Default output shows loader error for gdi32. I'll attach some logs.

[Bug 51789] Fatal crash in gdi32 during initialization

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51789

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Applications fails to start |Fatal crash in gdi32 during
                   |due to gdi32 initialization |initialization
                   |failure                     |

[Bug 51789] Fatal crash in gdi32 during initialization

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51789

--- Comment #1 from Nikolay Sivov  ---
It crashes on NULL value name here:

---
+static void set_reg_value( HKEY hkey, const WCHAR *name, UINT type, const void
*value, DWORD count )
+{
+    unsigned int name_size = lstrlenW( name ) * sizeof(WCHAR);
+    UNICODE_STRING nameW = { name_size, name_size, (WCHAR *)name };
+    NtSetValueKey( hkey, &nameW, 0, type, value, count );
+}
---
     if (face->family->second_name[0])
-        RegSetValueExW( hkey_family, NULL, 0, REG_SZ, (BYTE
*)face->family->second_name,
-                        (lstrlenW( face->family->second_name ) + 1) *
sizeof(WCHAR) );
+        set_reg_value( hkey_family, NULL, REG_SZ, face->family->second_name,
+                       (lstrlenW( face->family->second_name ) + 1) *
sizeof(WCHAR) );
---

Patch sent
https://www.winehq.org/pipermail/wine-devel/2021-September/196288.html

[Bug 51789] Fatal crash in gdi32 during initialization

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51789

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |5e481ab965b85c26c20c7179909
                   |                            |3383562b9522c

--- Comment #2 from Nikolay Sivov  ---
This is fixed in wine 6.18, 5e481ab965b85c26c20c71799093383562b9522c.

[Bug 51789] Fatal crash in gdi32 during initialization

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51789

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression

[Bug 51789] Fatal crash in gdi32 during initialization

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51789

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #3 from Alexandre Julliard  ---
Closing bugs fixed in 6.19.