http://bugs.winehq.org/show_bug.cgi?id=17824
Summary: winemenubuilder.c: "Desktop" string not localized -> no icons Product: Wine Version: 1.1.17 Platform: All OS/Version: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: programs AssignedTo: wine-bugs@winehq.org ReportedBy: giulioo@gmail.com
Note: I just grepped the source and I think the problem is winemenubuilder.c and its 2 occurrences of location = heap_printf("%s/Desktop/%s.desktop", getenv("HOME") ... however even it's that is not the culprit the problem remains.
===============
System: Ubuntu 8.04 and Ubuntu 8.10 Wine 1.1.17 (binary from WineHQ APT Repository)
I install a Windows app which will create desktop links (.lnk) in the "all users" desktop folder, in Wine it's: drive_c/users/Public/Desktop/*.lnk
What happens to these desktop icons seem to depend on the locale I use when installing ubuntu:
1) If I use EN (no problems) - My desktop folder will be /home/user1/Desktop - winecfg will show a map "Desktop -> /home/user1/Desktop" - After the install I'll get *.desktop files corresponding to the *.lnk in /home/user1/Desktop - All is fine
2) If I use IT (Italian, abnormal behavior is observed) - My desktop folder will be /home/user1/Scrivania - winecfg will show a correct map "Desktop -> /home/user1/Scrivania" - drive_c/users/user1/Desktop -> /home/user1/Scrivania - After the install I WON'T get any *.desktop files/icons - If I do $ mkdir Desktop (thus creating /home/user1/Desktop) then after the install *.desktop files will be created in this dir, however this is not my real desktop folder, so no icons will show up on the desktop anyway.
Wine-1.0.1 has a similar problem: - With IT locale by default it will put files into /home/user1/*.desktop (ie: in the homedir instead of in the desktop dir), if I create /home/user1/Desktop then it will put them there.
I hope this can be fixed both on 1.0.x and 1.1.x.
http://bugs.winehq.org/show_bug.cgi?id=17824
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |minor Platform|All |Other
--- Comment #1 from Vitaliy Margolen vitaliy@kievinfo.com 2009-03-22 19:52:24 --- http://bugs.winehq.org/page.cgi?id=fields.html#bug_severity
http://bugs.winehq.org/show_bug.cgi?id=17824
Damjan Jovanovic damjan.jov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |damjan.jov@gmail.com Status|UNCONFIRMED |ASSIGNED Difficulty|--- |Minutes Ever Confirmed|0 |1
--- Comment #2 from Damjan Jovanovic damjan.jov@gmail.com 2009-03-23 03:20:15 --- Looks like there's an undocumented environment variable, XDG_DESKTOP_DIR, which needs to be used when set, and defaults to $HOME/Desktop when absent.
I'll make a patch when I get home.
http://bugs.winehq.org/show_bug.cgi?id=17824
Vincent Povirk madewokherd@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |madewokherd@gmail.com
--- Comment #3 from Vincent Povirk madewokherd@gmail.com 2009-03-23 10:35:01 --- I think you're meant to use http://www.freedesktop.org/wiki/Software/xdg-user-dirs. shell32 already uses this. It defines (but does not export) XDG_UserDirLookup for this.
If XDG_DESKTOP_DIR is being set as an environment variable, that may only be coincidence.
http://bugs.winehq.org/show_bug.cgi?id=17824
Vincent Povirk madewokherd@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |madewokherd@gmail.com
--- Comment #3 from Vincent Povirk madewokherd@gmail.com 2009-03-23 10:35:01 --- I think you're meant to use http://www.freedesktop.org/wiki/Software/xdg-user-dirs. shell32 already uses this. It defines (but does not export) XDG_UserDirLookup for this.
If XDG_DESKTOP_DIR is being set as an environment variable, that may only be coincidence.
--- Comment #4 from Damjan Jovanovic damjan.jov@gmail.com 2009-03-24 13:48:43 --- Created an attachment (id=20108) --> (http://bugs.winehq.org/attachment.cgi?id=20108) Lookup the desktop directory from user-dirs
Please try this patch. It's already been sent to wine-patches.
http://bugs.winehq.org/show_bug.cgi?id=17824
--- Comment #5 from Vincent Povirk madewokherd@gmail.com 2009-03-24 13:55:13 --- I'm pretty sure that won't work, as shell32 doesn't export that function.
http://bugs.winehq.org/show_bug.cgi?id=17824
--- Comment #6 from Giulio giulioo@gmail.com 2009-03-24 17:25:35 --- I tried the patch and it works, now icons are created inside the localized Desktop dir $HOME/Scrivania and visible on the "desktop".
Thanks.
When you close this bug, have a look at http://bugs.winehq.org/show_bug.cgi?id=15762 I think it's the same issue.
http://bugs.winehq.org/show_bug.cgi?id=17824
Damjan Jovanovic damjan.jov@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Difficulty|Minutes |Hours
--- Comment #7 from Damjan Jovanovic damjan.jov@gmail.com 2009-03-26 13:37:53 --- Unfortunately I have to patch this differently. I'll use the shell32 generated desktop link, but that link itself has to refresh when you change locale.
I've sent in a patch for the first part, but the second will take some thought.
http://bugs.winehq.org/show_bug.cgi?id=17824
--- Comment #8 from Giulio giulioo@gmail.com 2009-03-26 15:41:33 --- Be aware that changing locale is already somehow broken (at least on ubuntu) both on Linux and on Wine:
1) Logout 2) I change locale from IT to EN and login 3) I'm asked "do you want to keep the old locale folder names or you want them changed to the new locale names"; if I leave them alone all is fine, however if I ask for them to be renamed: - At the next login the $HOME/Desktop" (EN name) folder is the new "desktop" folder, and is empty (desktop workspace empty), the old $HOME/Scrivania" (IT) folder is still there with all the files (both wine links and other stuff) - Wine -> "Desktop integration" still shows the link to old $HOME/Scrivania
So, at least on Ubuntu, if the OS handled changing locale well you shouldn't have to do anything as far as where wine *.desktop links are located.
http://bugs.winehq.org/show_bug.cgi?id=17824
--- Comment #9 from Damjan Jovanovic damjan.jov@gmail.com 2009-03-31 13:44:48 --- My patch to use shell32's directory is in the latest Git now.
Do you want to research what the right behaviour is for a desktop's localized user directories some more, or should I close this bug?
http://bugs.winehq.org/show_bug.cgi?id=17824
--- Comment #10 from Giulio giulioo@gmail.com 2009-03-31 15:33:16 --- You can close this bug, thanks.
http://bugs.winehq.org/show_bug.cgi?id=17824
Austin English austinenglish@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED
--- Comment #11 from Austin English austinenglish@gmail.com 2009-03-31 15:37:27 --- Fixed.
http://bugs.winehq.org/show_bug.cgi?id=17824
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #12 from Alexandre Julliard julliard@winehq.org 2009-04-10 11:24:23 --- Closing bugs fixed in 1.1.19.
-
wine-bugs＠winehq.org