[Bug 40282] New: mIRC 7.43 options dialog does not accept focus / user input

https://bugs.winehq.org/show_bug.cgi?id=40282

Bug ID: 40282
           Summary: mIRC 7.43 options dialog does not accept focus / user
                    input
           Product: Wine
           Version: 1.9.5
          Hardware: x86
               URL: http://www.mirc.com/get.html
                OS: Linux
            Status: NEW
          Keywords: download, regression
          Severity: normal
          Priority: P2
         Component: user32
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail], [e-mail]
   Regression SHA1: 0d7116b968edae3f5912112bda436df8924911fb
      Distribution: ---

Mentioned as side-note in https://bugs.winehq.org/show_bug.cgi?id=40280.

Steps to reproduce:

* Download and install mIRC from http://www.mirc.com/get.html (current version
is 7.43, sha1: 4c779241fc6ea84d981bc0e720594bc610da0109).
* Start mirc.exe. Click two times on "Continue" to get rid of the startup
dialogs. It is necessary to wait a bit before you can click the second time.
* The options dialog opens op, but does not accept the focus or any user input.
Since its not possible to close the options dialog, the whole application
cannot be used anymore.

Bisecting returns:

--- snip ---
0d7116b968edae3f5912112bda436df8924911fb is the first bad commit
commit 0d7116b968edae3f5912112bda436df8924911fb
Author: Jacek Caban 
Date:   Wed Mar 2 15:04:24 2016 +0100

user32: Use proper window as dialog owner.

Signed-off-by: Jacek Caban 
    Signed-off-by: Alexandre Julliard

:040000 040000 5d332005ebbd6ff9625ce42299e5d7db2780a6c1
0294a64212edf6212f7d4a22205d0d20a4f7b215 M    dlls
--- snip ---

Reverting only this commit does _NOT_ fix the issue, the follow-up commit
0d7116b968edae3f5912112bda436df8924911fb has to be reverted aswell. I haven't
investigated this issue further yet, but it shouldn't be too difficult to
reproduce since the affected application is freely available.

[Bug 40282] mIRC 7.43 options dialog does not accept focus / user input

https://bugs.winehq.org/show_bug.cgi?id=40282

--- Comment #1 from Sebastian Lackner  ---
(In reply to Sebastian Lackner from comment #0)
> Reverting only this commit does _NOT_ fix the issue, the follow-up commit
> 0d7116b968edae3f5912112bda436df8924911fb has to be reverted aswell. I
> haven't investigated this issue further yet, but it shouldn't be too
> difficult to reproduce since the affected application is freely available.

Oops, I meant the follow-up commit d75991d80e77ac9d93b85b8369c6fce39bd4fdb2 of
course.

[Bug 40282] mIRC 7.43 options dialog does not accept focus / user input

https://bugs.winehq.org/show_bug.cgi?id=40282

Sebastian Lackner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |STAGED
                 CC|                            |erich.e.hoover@wine-staging
                   |                            |.com, [e-mail],
                   |                            |[e-mail]
    Staged patchset|                            |https://github.com/wine-com
                   |                            |pholio/wine-staging/tree/ma
                   |                            |ster/patches/user32-Dialog_
                   |                            |Owner

[Bug 40282] mIRC 7.43 options dialog does not accept focus / user input

https://bugs.winehq.org/show_bug.cgi?id=40282

--- Comment #2 from Jacek Caban  ---
I submitted the first part of the fix:
http://source.winehq.org/patches/data/121017

[Bug 40282] mIRC 7.43 options dialog does not accept focus / user input

https://bugs.winehq.org/show_bug.cgi?id=40282

Jacek Caban  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|STAGED                      |RESOLVED
      Fixed by SHA1|                            |2f8f9d20aa50b5ae0c65f42196d
                   |                            |3c7f513a61fe6
         Resolution|---                         |FIXED

--- Comment #3 from Jacek Caban  ---
Fixed in Git, thanks for the report.

[Bug 40282] mIRC 7.43 options dialog does not accept focus / user input

https://bugs.winehq.org/show_bug.cgi?id=40282

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #4 from Alexandre Julliard  ---
Closing bugs fixed in 1.9.8.