[Bug 58066] New: Virtual desktop doesn't resize correctly (missing window border) when VD size = desktop size

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=58066

Bug ID: 58066
           Summary: Virtual desktop doesn't resize correctly (missing
                    window border) when VD size = desktop size
           Product: Wine
           Version: 10.5
          Hardware: x86-64
               URL: https://www.moddb.com/games/airline-tycoon/downloads/a
                    irline-tycoon-demo
                OS: Linux
            Status: NEW
          Keywords: download, regression
          Severity: normal
          Priority: P2
         Component: winex11.drv
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
   Regression SHA1: 7020807d11415b32341fa13f2354bd1e5477175b
      Distribution: ArchLinux

Hello,

I have one more issue or rather an annoyance regarding the use of virtual
desktop since Wine-10.5.

When I set up a virtual desktop in winecfg that matches the size of my screen
(1440X900) and I start a game that uses a lower resolution (640X480, 800X600
etc) then the game appears in the upper left corner but the rest of the virtual
desktop is black. In other words the virtual desktop isn't resized to match the
game resolution.
The problem doesn't occur when I start the game in virtual desktop sized
smaller than my desktop (1024X768 etc).

Reverting the following commit restores the old behavior for me:
7020807d11415b32341fa13f2354bd1e5477175b
winex11: Use the state tracker for the desktop window _NET_WM_STATE.

The issue is somewhat similar to bug #56149.

You can reproduce the problem with Airline Tycoon demo. The game uses a fixed
640X480 resolution.

X.Org X Server 1.21.1.16
XFCE/XFWM 4.20

[Bug 58066] Virtual desktop doesn't resize correctly (missing window border) when VD size = desktop size

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=58066

--- Comment #1 from Rémi Bernon  ---
I believe https://gitlab.winehq.org/wine/wine/-/merge_requests/7757 should fix
this (or help).

[Bug 58066] Virtual desktop doesn't resize correctly (missing window border) when VD size = desktop size

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=58066

--- Comment #2 from Béla Gyebrószki  ---
(In reply to Rémi Bernon from comment #1)
> I believe https://gitlab.winehq.org/wine/wine/-/merge_requests/7757 should
> fix this (or help).

The patch doesn't work for me :(

[Bug 58066] Virtual desktop doesn't resize correctly (missing window border) when VD size = desktop size

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=58066

TOM  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #3 from TOM  ---
Created attachment 78329
  --> https://bugs.winehq.org/attachment.cgi?id=78329
Screenshot before patch

[Bug 58066] Virtual desktop doesn't resize correctly (missing window border) when VD size = desktop size

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=58066

--- Comment #4 from TOM  ---
Created attachment 78330
  --> https://bugs.winehq.org/attachment.cgi?id=78330
Screenshot after patch

the MR patch is working for me.

I am testing with latest master

[Bug 58066] Virtual desktop doesn't resize correctly (missing window border) when VD size = desktop size

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=58066

--- Comment #5 from Rémi Bernon  ---
(In reply to Béla Gyebrószki from comment #2)
> (In reply to Rémi Bernon from comment #1)
> > I believe https://gitlab.winehq.org/wine/wine/-/merge_requests/7757 should
> > fix this (or help).
>
> The patch doesn't work for me :(

Hmm... Would you mind attaching a
WINEDEBUG=+pid,+loaddll,+x11drv,+event,+system log?

[Bug 58066] Virtual desktop doesn't resize correctly (missing window border) when VD size = desktop size

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=58066

--- Comment #6 from Béla Gyebrószki  ---
Created attachment 78331
  --> https://bugs.winehq.org/attachment.cgi?id=78331
WINEDEBUG=+pid,+loaddll,+x11drv,+event,+system

Logfile was created with wine-10.5-42-g856efc7a958.

[Bug 58066] Virtual desktop doesn't resize correctly (missing window border) when VD size = desktop size

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=58066

--- Comment #7 from Béla Gyebrószki  ---
Created attachment 78332
  --> https://bugs.winehq.org/attachment.cgi?id=78332
debug log with MR7757 applied

The same log with MR7757 applied (no visible change in the appearance).

[Bug 58066] Virtual desktop doesn't resize correctly (missing window border) when VD size = desktop size

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=58066

--- Comment #8 from Rémi Bernon  ---
Thanks, I have updated the MR mentioned above with some additional change that
could make it work for you, could you try it?

[Bug 58066] Virtual desktop doesn't resize correctly (missing window border) when VD size = desktop size

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=58066

--- Comment #9 from Béla Gyebrószki  ---
(In reply to Rémi Bernon from comment #8)
> Thanks, I have updated the MR mentioned above with some additional change
> that could make it work for you, could you try it?

This new version of the patch fixes the problem for me. Thank you!

[Bug 58066] Virtual desktop doesn't resize correctly (missing window border) when VD size = desktop size

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=58066

Rémi Bernon  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |bf7b57c7bd76aa203179b6edd2a
                   |                            |66735a894d759
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #10 from Rémi Bernon  ---
Should be fixed after bf7b57c7bd76aa203179b6edd2a66735a894d759