http://bugs.winehq.org/show_bug.cgi?id=14686
Summary: Max Payne 2: FB effect issues with backbuffer ORM Product: Wine Version: CVS/GIT Platform: PC-x86-64 OS/Version: Linux Status: UNCONFIRMED Severity: enhancement Priority: P2 Component: directx-d3d AssignedTo: wine-bugs@winehq.org ReportedBy: liquid.acid@gmx.net CC: onety-three@gmx.net
Hi there,
opening a separate bug for the issues described in bug #14038.
The problem currently only seems to appear with GeforceFX 5xxx cards (series 5). Multiple driver versions were tested, without success.
The issue: When the OffscreenRenderingMode is backbuffer and postprocessing effects are enabled in the ingame config menu of MP2 there are visual errors/slowdown effects.
There are two options (three when you also count OFF) for PP effect: (i) medium -> leads to visual errors (ii) high -> leads to really BAD performance
What is BAD performance for me: Rendering a frame every 5 seconds, making the game essentially unplayable.
PP effects are used in multiple ways in MP2, two examples: (i) bullettime mode, which is essential for the gameplay (ii) ingame cutscenes
Describing now how bullettime mode should look like correctly: It's a sepia tone filter that applies to the entire screen.
Describing now the visual errors with PPE (postprocessing effects) set to medium: The sepia filter is applied, but the screen is cropped. For a screenshot illustrating this problem see http://bugs.winehq.org/attachment.cgi?id=14361 (attached in bug #14038).
Cropping is either done by a black bar on the right of the screen, or from the bottom. It never happens from the left or from the top.
The cropping issue is related to the ingame resolution that's selected from the MP2 options: (1) 640x480: screen is cropped, black bar at the bottom (2) 800x600: screen is cropped, black bar at the right (3) 1024x768: screen is NOT cropped (4) 1152x864: screen is cropped, black bar at the bottom (5) 1280x1024: screen is NOT cropped
Notice that the cropping issue does NOT appear when one of the height/width parameters of the resolution has POT (power-of-two) dimensions. All resolutions that are cropped have both dimensions NPOT.
I still have to take a look if enabling/disabling GLSL changes anything here. I think I currently have it turned OFF globally.
Greets, Tobias
PS: Adding Frank Roscher since he did verify the issue on his NVFX card.
http://bugs.winehq.org/show_bug.cgi?id=14686
Tobias Jakobi liquid.acid@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jb.faq@gmx.de
http://bugs.winehq.org/show_bug.cgi?id=14686
Tobias Jakobi liquid.acid@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |alexd4@inbox.lv
http://bugs.winehq.org/show_bug.cgi?id=14686
Tobias Jakobi liquid.acid@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |stefandoesinger@gmx.at
http://bugs.winehq.org/show_bug.cgi?id=14686
Tobias Jakobi liquid.acid@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |hverbeet@gmail.com
http://bugs.winehq.org/show_bug.cgi?id=14686
Tobias Jakobi liquid.acid@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |vitaliy@kievinfo.com
http://bugs.winehq.org/show_bug.cgi?id=14686
Vitaliy Margolen vitaliy@kievinfo.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|vitaliy@kievinfo.com |
--- Comment #1 from Vitaliy Margolen vitaliy@kievinfo.com 2008-07-29 08:53:32 --- DO NOT add me to the CC!
http://bugs.winehq.org/show_bug.cgi?id=14686
--- Comment #2 from Tobias Jakobi liquid.acid@gmx.net 2008-07-29 08:56:36 --- Any reason why I should not? You posted in the bug #14038, so...
http://bugs.winehq.org/show_bug.cgi?id=14686
--- Comment #3 from Vitaliy Margolen vitaliy@kievinfo.com 2008-07-29 08:59:27 --- Because I said so.
http://bugs.winehq.org/show_bug.cgi?id=14686
--- Comment #4 from Tobias Jakobi liquid.acid@gmx.net 2008-07-29 12:09:44 --- Hi there,
my colleague Jan Bücken was so kind today to let me test this issue on his card.
Graphics card: ATI Mobility Radeon HD2600 Drivers: ati-drivers-8.512 (=8.7, =8.51.3) (fglrx)
Test was done with latest wine git master (snapshot from today): last commit = 6a21ab270b2a9dc04ad38714f410e1ab27872f02
ORM is backbuffer, GLSL is disabled for the application.
Ingame settings: PPE=medium pixel shader skins=off
640x480: works, crop at bottom 800x600: works, crop at right 1024x768: works, no cropping 1280x800: works, crop bottom
Since this is a laptop there are no further res to test. works in this context means: rendering doesn't have errors (apart from the cropping issue) Performance is good with all 4 resolutions.
Now the cropping issue is a little bit different here, see this attachment from the other bug: http://bugs.winehq.org/attachment.cgi?id=14271
Seems like a different clamping mode (repeat) is used here.
Now switching PPE to high: All 4 resolutions work fine now without cropping. I didn't look that much into the performance issue though. Going to check this again with developer mode (to have a FPS counter).
However this verifies that the cropping is not restricted to nvidia cards, but also happens with ATI products.
Greets, Tobias
http://bugs.winehq.org/show_bug.cgi?id=14686
--- Comment #5 from Tobias Jakobi liquid.acid@gmx.net 2008-07-29 15:33:08 --- (In reply to comment #0)
I still have to take a look if enabling/disabling GLSL changes anything here. I think I currently have it turned OFF globally.
No, it was enabled. But disabling it didn't change the issue.
http://bugs.winehq.org/show_bug.cgi?id=14686
--- Comment #6 from Tobias Jakobi liquid.acid@gmx.net 2008-07-31 12:48:30 --- Update: This other bug, http://bugs.winehq.org/show_bug.cgi?id=14034, posted by me seems to be directly tied to the cropping issue explained here.
http://bugs.winehq.org/show_bug.cgi?id=14686
--- Comment #7 from Alexander Dorofeyev alexd4@inbox.lv 2008-07-31 15:30:59 --- Damn, I now has this problem too on geforce6100! I think I didn't just a few days ago. Must either be a further regression in last few days, or the bug isn't stably reproducible.
http://bugs.winehq.org/show_bug.cgi?id=14686
Tobias Jakobi liquid.acid@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- URL| |http://www.rockstargames.com | |/maxpayne2/mp2_downloads.htm | |l Keywords| |download
http://bugs.winehq.org/show_bug.cgi?id=14686
Tobias Jakobi liquid.acid@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Max Payne 2: FB effect |Max Payne 2: PP effect |issues with backbuffer ORM |issues with backbuffer ORM
--- Comment #8 from Tobias Jakobi liquid.acid@gmx.net 2008-08-05 14:55:06 --- Short update: This bug (#14686) is now only about the cropping bug, since the performance issues are fixed in git master.
http://bugs.winehq.org/show_bug.cgi?id=14686
H. Verbeet hverbeet@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC|hverbeet@gmail.com |
http://bugs.winehq.org/show_bug.cgi?id=14686
--- Comment #9 from Peter Belm peterbelm@gmail.com 2008-09-28 11:29:04 --- Created an attachment (id=16327) --> (http://bugs.winehq.org/attachment.cgi?id=16327) Original .exe Output
http://bugs.winehq.org/show_bug.cgi?id=14686
Peter Belm peterbelm@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Attachment #16327|application/octet-stream |text/plain mime type| |
http://bugs.winehq.org/show_bug.cgi?id=14686
Peter Belm peterbelm@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |peterbelm@gmail.com
--- Comment #10 from Peter Belm peterbelm@gmail.com 2008-09-28 11:32:00 --- (In reply to comment #9)
Created an attachment (id=16327)
--> (http://bugs.winehq.org/attachment.cgi?id=16327) [details]
Original .exe Output
Please ignore this attachment, for some reason Bugzilla keeps redirecting me to this bug whenever I update the bug I'm trying to change.
http://bugs.winehq.org/show_bug.cgi?id=14686
--- Comment #11 from Tobias Jakobi liquid.acid@gmx.net 2008-10-07 15:21:51 --- Reconfirming with wine-1.1.5 and wine git master.
http://bugs.winehq.org/show_bug.cgi?id=14686
Tobias Jakobi liquid.acid@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution| |WONTFIX
--- Comment #12 from Tobias Jakobi liquid.acid@gmx.net 2008-11-02 18:53:41 --- Forgot to resolve this one to WONTFIX.
I remember a chat with Alexander who mentioned that this was a (non-fixable) limitation of the backbuffer OffscreenRenderingMode.
For framebuffer effects (and PPE=medium) MP2 seems to allocate a surface, which sometimes exceeds the dimensions of the current backbuffer.
With an ingame resolution of 800x600 this seems to be the case. With an ingame res of 1024x768 the backbuffer seems to be large enough for the surface to fit in.
In this case the effect is rendered correctly, without cropping. However if the surface does NOT fit, the parts that are effectively "outside" the backbuffer are simply not rendered at all.
When the surface is blitted back to the backbuffer you can see the cropping artifacts.
Since this works for ORM=fbo I'm resolving this to WONTFIX. I'm also adding a comment to AppDB.
http://bugs.winehq.org/show_bug.cgi?id=14686
James Hawkins truiken@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #13 from James Hawkins truiken@gmail.com 2008-11-02 18:58:29 --- Closing.
http://bugs.winehq.org/show_bug.cgi?id=14686
Dan Kegel dank@kegel.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|CVS/GIT |unspecified