[Bug 53035] New: Out-GridView (when winversion >win7) is broken since 182feddd4b02e83f3c69863bc2e6e63945eb2df1

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53035

Bug ID: 53035
           Summary: Out-GridView  (when winversion >win7) is broken since
                    182feddd4b02e83f3c69863bc2e6e63945eb2df1
           Product: Wine
           Version: 7.9
          Hardware: x86-64
               URL: https://github.com/PowerShell/PowerShell/releases/down
                    load/v7.0.3/PowerShell-7.0.3-win-x64.msi
                OS: Linux
            Status: NEW
          Keywords: download, regression
          Severity: normal
          Priority: P2
         Component: dwmapi
          Assignee: [e-mail]
          Reporter: [e-mail]
                CC: [e-mail]
   Regression SHA1: 182feddd4b02e83f3c69863bc2e6e63945eb2df1
      Distribution: ---

Since the mentioned commit now an "Unhandled division by zero" is encountered
when trying to display Out-GridView in Powershell Core; (the
DwmGetCompositionTiming is apparently only called when winversion > win7)

Maybe returning a non-zero value in one of the DWM_TIMING_INFO members is
enough to fix this, but i haven`t tested

crash:
wine: Unhandled division by zero at address 00000000243E54D3 (thread 0158),
starting debugger...

Steps to reproduce: 
1. Install
https://github.com/PowerShell/PowerShell/releases/download/v7.0.3/PowerShell...

2. Set windows version to win10 (or win81)

3. Then do for example:

'wine pwsh -c Get-Process | Out-gridview'

(Note: the backslash is only needed to escape the pipe operator in bash)

Workaround for now: disable dwmapi, makes it work again

[Bug 53035] Out-GridView (when winversion >win7) is broken since 182feddd4b02e83f3c69863bc2e6e63945eb2df1

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53035

--- Comment #1 from Jactry Zeng  ---
Created attachment 72404
  --> https://bugs.winehq.org/attachment.cgi?id=72404
hack

Looks like memset the struct with 1 instead of 0 makes it happy. Probably,
filling more values in the struct will help.

Louis, could you have a try with this hack?
Thanks.

[Bug 53035] Out-GridView (when winversion >win7) is broken since 182feddd4b02e83f3c69863bc2e6e63945eb2df1

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53035

--- Comment #2 from Louis Lenders  ---
(In reply to Jactry Zeng from comment #1)
> Created attachment 72404 [details]
> hack
>
> Looks like memset the struct with 1 instead of 0 makes it happy. Probably,
> filling more values in the struct will help.
>
> Louis, could you have a try with this hack?
> Thanks.

Hi Jactry, the window now comes up but for me it is not exactly responsive
really.

One should be able to select rows (thought it has no use with this command) and
also "Add criteria" (the dropdown box in the upper left corner). When I click
that the window just dissappears :(

Do you see other behaviour?

Note: you can check how it should behave by disabling dwmapi
WINEDLLOVERRIDES=dwmapi=d wine  pwsh -c Get-Process | Out-gridview

[Bug 53035] Out-GridView (when winversion >win7) is broken since 182feddd4b02e83f3c69863bc2e6e63945eb2df1

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53035

Jactry Zeng  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #72404|0                           |1
        is obsolete|                            |

--- Comment #3 from Jactry Zeng  ---
Created attachment 72410
  --> https://bugs.winehq.org/attachment.cgi?id=72410
hack v2

Hello Louis,
(In reply to Louis Lenders from comment #2)
> (In reply to Jactry Zeng from comment #1)
> > Created attachment 72404 [details]
> > hack
> >
> > Looks like memset the struct with 1 instead of 0 makes it happy. Probably,
> > filling more values in the struct will help.
> >
> > Louis, could you have a try with this hack?
> > Thanks.
>
> Hi Jactry, the window now comes up but for me it is not exactly responsive
> really.
>
> One should be able to select rows (thought it has no use with this command)
> and also "Add criteria" (the dropdown box in the upper left corner). When I
> click that the window just dissappears :(
>
> Do you see other behaviour?

Yes, this looks like another issue, because of the unimplemented DwmFlush().
Please try it again with this hack.

[Bug 53035] Out-GridView (when winversion >win7) is broken since 182feddd4b02e83f3c69863bc2e6e63945eb2df1

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53035

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #4 from Louis Lenders  ---
(In reply to Jactry Zeng from comment #3)
> Created attachment 72410 [details]
> hack v2
>
> Yes, this looks like another issue, because of the unimplemented DwmFlush().
> Please try it again with this hack.

Yes, this hack v2 makes everything work as expected again. Thanks!

[Bug 53035] Displaying Out-GridView in Powershell Core crashes with WinVer > Win7

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53035

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Out-GridView  (when         |Displaying Out-GridView in
                   |winversion >win7) is broken |Powershell Core crashes
                   |since                       |with WinVer > Win7
                   |182feddd4b02e83f3c69863bc2e |
                   |6e63945eb2df1               |

[Bug 53035] Displaying Out-GridView in Powershell Core crashes with WinVer > Win7

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53035

Jactry Zeng  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]        |[e-mail]

[Bug 53035] Displaying Out-GridView in Powershell Core crashes with WinVer > Win7

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53035

Alistair Leslie-Hughes  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Staged patchset|                            |https://github.com/wine-sta
                   |                            |ging/wine-staging/tree/mast
                   |                            |er/patches/dwmapi-DwmGetCom
                   |                            |positionTimingInfo
                 CC|                            |[e-mail]
             Status|NEW                         |STAGED

[Bug 53035] Displaying Out-GridView in Powershell Core crashes with WinVer > Win7

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53035

Jactry Zeng  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|STAGED                      |RESOLVED
      Fixed by SHA1|                            |f397807415b4807aeabac7243a1
                   |                            |3a15599008ee7
         Resolution|---                         |FIXED

--- Comment #5 from Jactry Zeng  ---
Fixed by
https://source.winehq.org/git/wine.git/?a=commit;h=f397807415b4807aeabac7243a13a15599008ee7.

[Bug 53035] Displaying Out-GridView in Powershell Core crashes with WinVer > Win7

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53035

Jactry Zeng  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[e-mail]       |
           Assignee|[e-mail]          |[e-mail]

[Bug 53035] Displaying Out-GridView in Powershell Core crashes with WinVer > Win7

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=53035

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #6 from Alexandre Julliard  ---
Closing bugs fixed in 7.11.