[Bug 12666] New: Wine should refuse to run if pointed at a real Windows

http://bugs.winehq.org/show_bug.cgi?id=12666

Summary: Wine should refuse to run if pointed at a real Windows
           Product: Wine
           Version: CVS/GIT
          Platform: Other
        OS/Version: other
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

Several people have recently screwed up their Windows systems
by pointing Wine at their real C:\Windows directories.
Wine should detect this condition and refuse to run.

[Bug 12666] Wine should refuse to run if pointed at a real Windows

http://bugs.winehq.org/show_bug.cgi?id=12666

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |1.2.0

--- Comment #1 from Austin English   2008-04-20 01:48:00 ---
(In reply to comment #0)
> Several people have recently screwed up their Windows systems
> by pointing Wine at their real C:\Windows directories.
> Wine should detect this condition and refuse to run.

Where were you seeing this? I saw a couple on the mailing list a couple weeks
ago, but none recently...

Nominating for 1.2.

[Bug 12666] Wine should refuse to run if pointed at a real Windows

http://bugs.winehq.org/show_bug.cgi?id=12666

Dan Kegel  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|enhancement                 |critical
           Priority|P2                          |P1
   Target Milestone|1.2.0                       |1.0.0

--- Comment #2 from Dan Kegel   2008-04-20 02:32:09 ---
Just today,
http://www.linuxforums.org/forum/wine/119917-can-wine-create-problems-window...

That makes at least two in fairly quick succession.
I think that's a trend -- we'll get a lot of these
after 1.0.  So IMHO this merits attention for 1.0,
nominating.  Also raising severity to critical and priority
to P1 since it can screw a user's windows system.

[Bug 12666] Wine should refuse to run if pointed at a real Windows

http://bugs.winehq.org/show_bug.cgi?id=12666

--- Comment #3 from Alexandre Julliard   2008-04-21 08:53:44 ---
Created an attachment (id=12361)
 --> (http://bugs.winehq.org/attachment.cgi?id=12361)
Disable changing the config of the C drive

I don't think we can refuse to run, but how about a patch like this? Does this
address your concerns?

[Bug 12666] Wine should refuse to run if pointed at a real Windows

http://bugs.winehq.org/show_bug.cgi?id=12666

--- Comment #4 from Dan Kegel   2008-04-21 11:47:29 ---
Sure, that would probably suffice.

[Bug 12666] Wine should refuse to run if pointed at a real Windows

http://bugs.winehq.org/show_bug.cgi?id=12666

--- Comment #5 from Austin English   2008-04-21 12:16:08 ---
(In reply to comment #3)
> Created an attachment (id=12361)

--> (http://bugs.winehq.org/attachment.cgi?id=12361) [details]
> Disable changing the config of the C drive
>
> I don't think we can refuse to run, but how about a patch like this? Does this
> address your concerns?

Doesn't prevent someone from changing it manually via symlinks...

[Bug 12666] Wine should refuse to run if pointed at a real Windows

http://bugs.winehq.org/show_bug.cgi?id=12666

--- Comment #6 from Dan Kegel   2008-04-21 12:16:58 ---
That's probably ok.  We don't want to stop the wizards, just the innocent.

[Bug 12666] Wine should refuse to run if pointed at a real Windows

http://bugs.winehq.org/show_bug.cgi?id=12666

--- Comment #7 from Alexandre Julliard   2008-04-21 13:00:46 ---
(In reply to comment #5)
> Doesn't prevent someone from changing it manually via symlinks...

Yes that's on purpose, there needs to be a way to work around the check for
people who know what they are doing.

[Bug 12666] Wine should refuse to run if pointed at a real Windows

http://bugs.winehq.org/show_bug.cgi?id=12666

--- Comment #8 from Lei Zhang   2008-04-21 13:30:54 ---
What about running stat() in winecfg on the target directory and displaying a
warning if the target directory is ntfs/fat32?

[Bug 12666] Wine should refuse to run if pointed at a real Windows

http://bugs.winehq.org/show_bug.cgi?id=12666

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #9 from Alexandre Julliard   2008-04-22 06:54:59 ---
I don't think warnings are helpful, people have been conditioned by MS to click
through all warnings.

Anyway I put in my fix for now, we'll see if users complain.

[Bug 12666] Wine should refuse to run if pointed at a real Windows

http://bugs.winehq.org/show_bug.cgi?id=12666

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #10 from Alexandre Julliard   2008-05-02 12:37:29 ---
Closing bugs fixed in 0.9.61.

[Bug 12666] Wine should refuse to run if pointed at a real Windows

http://bugs.winehq.org/show_bug.cgi?id=12666

--- Comment #11 from Austin English   2008-05-22 15:56:43 ---
Seems some users are still doing this, but by avoiding C:
-------------------------
unfortunately nothing happens, when I would like to start the application. The
path in the winecfg is set to:
H: /windows/C/Programme/ipacs/AeroFly Professional Deluxe/

I tried to start wine H:\flyrun.exe but nothing was going on.

Other application work correctly, if start them directly in the origin XP
environment. -> start application with -> wine 
-------------------------

http://forum.winehq.org/viewtopic.php?t=987

[Bug 12666] Wine should refuse to run if pointed at a real Windows

http://bugs.winehq.org/show_bug.cgi?id=12666

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #12 from [e-mail]  2008-05-24 10:42:12 ---
Would it work to block for all drive letters?

[Bug 12666] Wine should refuse to run if pointed at a real Windows

http://bugs.winehq.org/show_bug.cgi?id=12666

--- Comment #13 from Austin English   2008-05-25 22:26:23 ---
(In reply to comment #12)
> Would it work to block for all drive letters?

Currently, we don't allow changing c in winecfg, but you can do anything by
manual symlinks. We don't detect windows in anyway, which is how the user is
getting around it.

Something like Lei's suggestion may be needed...

[Bug 12666] Wine should refuse to run if pointed at a real Windows

http://bugs.winehq.org/show_bug.cgi?id=12666

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|CVS/GIT                     |unspecified