[Bug 36188] New: valgrind shows an invalid free for comctl32/tests/listview.c

https://bugs.winehq.org/show_bug.cgi?id=36188

Bug ID: 36188
           Summary: valgrind shows an invalid free for
                    comctl32/tests/listview.c
           Product: Wine
           Version: 1.7.17
          Hardware: x86
                OS: Linux
            Status: NEW
          Keywords: download, source, testcase
          Severity: normal
          Priority: P2
         Component: comctl32
          Assignee: [e-mail]
          Reporter: [e-mail]

==7218== Invalid free() / delete / delete[] / realloc()
==7218==    at 0x7BC4C704: notify_free (heap.c:263)
==7218==    by 0x7BC51049: RtlFreeHeap (heap.c:1762)
==7218==    by 0x7B845837: HeapFree (heap.c:276)
==7218==    by 0x7B8467DB: GlobalFree (heap.c:751)
==7218==    by 0x7B846EDF: LocalFree (heap.c:1016)
==7218==    by 0x5160A33: Free (comctl32undoc.c:119)
==7218==    by 0x5182D36: notify_forward_header (listview.c:806)
==7218==    by 0x5198A0C: LISTVIEW_Notify (listview.c:10451)
==7218==    by 0x519B585: LISTVIEW_WindowProc (listview.c:11594)
==7218==    by 0x542943D: ??? (winproc.c:173)
==7218==    by 0x54295B2: call_window_proc (winproc.c:244)
==7218==    by 0x542A7A0: WINPROC_CallProcAtoW (winproc.c:603)
==7218==    by 0x542B991: CallWindowProcA (winproc.c:961)
==7218==    by 0x4E89125: listview_subclass_proc (listview.c:619)
==7218==    by 0x542943D: ??? (winproc.c:173)
==7218==    by 0x54295B2: call_window_proc (winproc.c:244)
==7218==    by 0x542B5DF: WINPROC_CallProcWtoA (winproc.c:858)
==7218==    by 0x542B78A: WINPROC_call_window (winproc.c:902)
==7218==    by 0x53E80F8: call_window_proc (message.c:2223)
==7218==    by 0x53EAF96: send_message (message.c:3260)
==7218==  Address 0x513fb28 is on thread 1's stack
==7218==

doesn't require a virtual desktop to occur

[Bug 36188] valgrind shows an invalid free for comctl32/tests/listview.c

https://bugs.winehq.org/show_bug.cgi?id=36188

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]        |[e-mail]

[Bug 36188] valgrind shows an invalid free for comctl32/tests/listview.c

https://bugs.winehq.org/show_bug.cgi?id=36188

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |valgrind

[Bug 36188] valgrind shows an invalid free for comctl32/tests/listview.c

http://bugs.winehq.org/show_bug.cgi?id=36188

Sebastian Lackner  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #1 from Sebastian Lackner  ---
Created attachment 48852
  --> http://bugs.winehq.org/attachment.cgi?id=48852
comctl32: Allocate new memory in notify_forward_header() to avoid Free() on
wrong pointer.

Does this help? It doesn't really make the code look better, but ... ;)

[Bug 36188] valgrind shows an invalid free for comctl32/tests/listview.c

https://bugs.winehq.org/show_bug.cgi?id=36188

--- Comment #2 from Austin English  ---
(In reply to Sebastian Lackner from comment #1)
> Created attachment 48852 [details]
> comctl32: Allocate new memory in notify_forward_header() to avoid Free() on
> wrong pointer.
>
> Does this help? It doesn't really make the code look better, but ... ;)

Works, thanks.

[Bug 36188] valgrind shows an invalid free for comctl32/tests/listview.c

https://bugs.winehq.org/show_bug.cgi?id=36188

--- Comment #3 from Austin English  ---
*** Bug 36189 has been marked as a duplicate of this bug. ***

[Bug 36188] valgrind shows an invalid free for comctl32/tests/listview.c

https://bugs.winehq.org/show_bug.cgi?id=36188

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|[e-mail]        |[e-mail]

[Bug 36188] valgrind shows an invalid free for comctl32/tests/listview.c

https://bugs.winehq.org/show_bug.cgi?id=36188

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |392321f4f68cb3d26453680c78a
                   |                            |aa81910e15846
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Austin English  ---
https://source.winehq.org/git/wine.git/commitdiff/392321f4f68cb3d26453680c78...

[Bug 36188] valgrind shows an invalid free for comctl32/tests/listview.c

https://bugs.winehq.org/show_bug.cgi?id=36188

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  ---
Closing bugs fixed in 1.7.21.