https://bugs.winehq.org/show_bug.cgi?id=49501
Bug ID: 49501 Summary: Star Citizen: No mic input audio (used for voip) Product: Wine Version: unspecified Hardware: x86 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: winepulse.drv Assignee: wine-bugs@winehq.org Reporter: simonnatella@gmail.com Distribution: ---
Created attachment 67628 --> https://bugs.winehq.org/attachment.cgi?id=67628 Fixes Star Citizen voip naively
Mic input within Star Citizen does not work, despite audio devices being recognised and audio output working correctly.
I've done some debugging and produced the attached very naive fix - I'm aware it's Pulse only and it does not actually handle the required mmdevapi flags, it just doesn't error on seeing them. I'm not a C developer, so unfortunately writing handling for these flags is well beyond my skills.
The missing flags are described on https://docs.microsoft.com/en-gb/windows/win32/coreaudio/audclnt-streamflags... as AUDCLNT_STREAMFLAGS_AUTOCONVERTPCM and AUDCLNT_STREAMFLAGS_SRC_DEFAULT_QUALITY
The whitelist in AudioClient_Initialize for Pulse doesn't acknowledge these (heck, mmdevapi doesn't have the constants defined) and so when provided them bails out, this patch just lets the code continue.
The fix has been used by ourselves for a few weeks and by TkG in his wine builds, and so far we've not seen any side effects, except working mic input in SC of course.
https://bugs.winehq.org/show_bug.cgi?id=49501
rawfox rawfox@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |rawfox@freenet.de
--- Comment #1 from rawfox rawfox@freenet.de --- Confirming this.
After applying the patch, my voip in StarCitizen is working. Im on Pulseaudio and people can hear me ingame.
https://bugs.winehq.org/show_bug.cgi?id=49501
Vijay Kamuju infyquest@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |infyquest@gmail.com
--- Comment #2 from Vijay Kamuju infyquest@gmail.com --- Please send the patch to wine-devel@winehq.org with your sign off. Also test the patch for other audio drivers like winealsa and wineoss
https://bugs.winehq.org/show_bug.cgi?id=49501
ImperatorS79 fevrier.simon@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fevrier.simon@gmail.com
--- Comment #3 from ImperatorS79 fevrier.simon@gmail.com --- Can I send myself this patch and sign-off molotov ? As far as I understand this should just allow more apps to work without affecting any other previous apps so it should be accepted.
https://bugs.winehq.org/show_bug.cgi?id=49501
winetest@luukku.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |winetest@luukku.com
--- Comment #4 from winetest@luukku.com --- the bug report is missing patch keyword. Since the issue is known and patch has been made I hope that wine-staging picks it.
https://bugs.winehq.org/show_bug.cgi?id=49501
François Gouget fgouget@codeweavers.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch CC| |fgouget@codeweavers.com
https://bugs.winehq.org/show_bug.cgi?id=49501
molotov simonnatella@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|UNCONFIRMED |RESOLVED
--- Comment #5 from molotov simonnatella@gmail.com --- Hey all, looks like someone already included my patch in https://github.com/wine-mirror/wine/commit/2e1934598d035b852bcceb8ef01eac181... with a much more complete fix.
Looks like it was in for wine-5.13
https://bugs.winehq.org/show_bug.cgi?id=49501
Gijs Vermeulen gijsvrm@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |5.11 Component|winepulse.drv |mmdevapi Fixed by SHA1| |2e1934598d035b852bcceb8ef01 | |eac181d8415ca
https://bugs.winehq.org/show_bug.cgi?id=49501
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #6 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 7.12.