[Bug 29043] New: Wine crash when performing searches in CHM files

http://bugs.winehq.org/show_bug.cgi?id=29043

Bug #: 29043
           Summary: Wine crash when performing searches in CHM files
           Product: Wine
           Version: unspecified
          Platform: x86
        OS/Version: Mac OS X
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: hhctrl.ocx
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]
    Classification: Unclassified

In CHM files, if you perform the same search within hh.exe, Wine crashes. So
open a chm that has the search tab enabled. Perform a search and then perform
the same search, Wine crashes.

[Bug 29043] Wine crash when performing searches in CHM files

http://bugs.winehq.org/show_bug.cgi?id=29043

Jason Wong  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|hhctrl.ocx                  |-unknown

[Bug 29043] Wine crash when performing searches in CHM files

http://bugs.winehq.org/show_bug.cgi?id=29043

--- Comment #1 from Nikolay Sivov  2011-11-09 14:11:33 CST ---
What is your wine version? Attach a terminal output and .chm test file to
reproduce.

[Bug 29043] Wine crash when performing searches in CHM files

http://bugs.winehq.org/show_bug.cgi?id=29043

--- Comment #2 from Jason Wong  2011-11-09 17:36:43 CST ---
Created attachment 37416
  --> http://bugs.winehq.org/attachment.cgi?id=37416
Executable to display the chm file

gzip -d wine_chm_test.exe.gz to decompress the file. Then run the exe within
Wine and press the 'open chm file' button

[Bug 29043] Wine crash when performing searches in CHM files

http://bugs.winehq.org/show_bug.cgi?id=29043

--- Comment #3 from Jason Wong  2011-11-09 17:39:14 CST ---
Created attachment 37417
  --> http://bugs.winehq.org/attachment.cgi?id=37417
Chm test file

trying searching for 'time' twice in succession. There are other search terms
which will crash on first search, but that may be a different bug.

[Bug 29043] Wine crash when performing searches in CHM files

http://bugs.winehq.org/show_bug.cgi?id=29043

--- Comment #4 from Jason Wong  2011-11-09 17:53:22 CST ---
Created attachment 37418
  --> http://bugs.winehq.org/attachment.cgi?id=37418
terminal output

[Bug 29043] Wine crash when performing searches in CHM files

http://bugs.winehq.org/show_bug.cgi?id=29043

--- Comment #5 from Jason Wong  2011-11-09 17:55:47 CST ---
I am using version 1.3.30

[Bug 29043] Performing searches in CHM files lead to a crash

http://bugs.winehq.org/show_bug.cgi?id=29043

Dmitry Timoshkov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |1.3.30
            Summary|Wine crash when performing  |Performing searches in CHM
                   |searches in CHM files       |files lead to a crash

[Bug 29043] Performing searches in CHM files lead to a crash

http://bugs.winehq.org/show_bug.cgi?id=29043

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37418|0                           |1
        is obsolete|                            |

--- Comment #6 from Austin English  2011-11-10 14:02:46 CST ---
Created attachment 37433
  --> http://bugs.winehq.org/attachment.cgi?id=37433
better backtrace

Looks like heap corruption. Running with warn+heap prevents the crash (but
searching doesn't work).

[Bug 29043] Performing searches in CHM files lead to a crash

http://bugs.winehq.org/show_bug.cgi?id=29043

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #7 from Austin English  2011-11-10 14:03:04 CST ---
Confirming.

[Bug 29043] Performing searches in CHM files lead to a crash

http://bugs.winehq.org/show_bug.cgi?id=29043

Vincent Povirk  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |hhctrl.ocx

[Bug 29043] Performing searches in CHM files lead to a crash

http://bugs.winehq.org/show_bug.cgi?id=29043

Erich Hoover  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #8 from Erich Hoover  2011-11-28 11:41:39 CST ---
Interesting, I don't see this problem with a couple other chm files I use for
testing.  Based on the backtrace, I'd say it looks like something isn't being
handled right for this particular file in the itss (storage) component.  Have
you been able to reproduce this issue with other help files?

[Bug 29043] Performing searches in CHM files lead to a crash

http://bugs.winehq.org/show_bug.cgi?id=29043

--- Comment #9 from Jason Wong  2011-11-29 17:53:45 CST ---
Created attachment 37701
  --> http://bugs.winehq.org/attachment.cgi?id=37701
Another file which crashes

[Bug 29043] Performing searches in CHM files lead to a crash

http://bugs.winehq.org/show_bug.cgi?id=29043

--- Comment #10 from Jason Wong  2011-11-29 17:54:28 CST ---
I got it to crash with this file but it wasnt consistent. After performing
nothing but arbitrary searches for 30 secs or so, it would eventually crash.

[Bug 29043] Performing searches in CHM files lead to a crash

http://bugs.winehq.org/show_bug.cgi?id=29043

--- Comment #11 from Erich Hoover  2012-01-25 14:27:05 CST ---
Created attachment 38554
  --> http://bugs.winehq.org/attachment.cgi?id=38554
itss: Enlarge buffer to include space for a catenated value.

Could you please try the attached patch?  I believe it will fix the problem.

[Bug 29043] Performing searches in CHM files lead to a crash

http://bugs.winehq.org/show_bug.cgi?id=29043

--- Comment #12 from Erich Hoover  2012-01-27 11:54:28 CST ---
This should be fixed by commit 88f6e898c617c6c4ffc560922c6c19ba9bebe915.

[Bug 29043] Performing searches in CHM files lead to a crash

http://bugs.winehq.org/show_bug.cgi?id=29043

--- Comment #13 from Erich Hoover  2012-04-18 10:23:10 CDT ---
(In reply to comment #12)
> This should be fixed by commit 88f6e898c617c6c4ffc560922c6c19ba9bebe915.

Could you please confirm that this issue is fixed so that this bug can be
closed?

[Bug 29043] Performing searches in CHM files lead to a crash

http://bugs.winehq.org/show_bug.cgi?id=29043

--- Comment #14 from Jason Wong  2012-04-30 15:49:48 CDT ---
Bug appears to be fixed. You may close this bug.

Thanks

[Bug 29043] Performing searches in CHM files lead to a crash

http://bugs.winehq.org/show_bug.cgi?id=29043

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #15 from Austin English  2012-04-30 16:14:24 CDT ---
(In reply to comment #14)
> Bug appears to be fixed. You may close this bug.
>
> Thanks

Fixed.

[Bug 29043] Performing searches in CHM files lead to a crash

http://bugs.winehq.org/show_bug.cgi?id=29043

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #16 from Alexandre Julliard  2012-05-11 13:21:55 CDT ---
Closing bugs fixed in 1.5.4.

[Bug 29043] Performing searches in CHM files lead to a crash

http://bugs.winehq.org/show_bug.cgi?id=29043

Anastasius Focht  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
      Fixed by SHA1|                            |88f6e898c617c6c4ffc560922c6
                   |                            |c19ba9bebe915
                 CC|                            |[e-mail]