[Bug 40384] New: dinput8:dinput regression caused by new compiler

https://bugs.winehq.org/show_bug.cgi?id=40384

Bug ID: 40384
           Summary: dinput8:dinput regression caused by new compiler
           Product: Wine
           Version: 1.9.6
          Hardware: x86
                OS: Windows
            Status: NEW
          Severity: normal
          Priority: P2
         Component: directx-dinput
          Assignee: [e-mail]
          Reporter: [e-mail]

The WineHQ upgrade changed the cross-compiler used to generate the reference
WineTest executables. Since the upgrade the dinput8:dinput test has these
failures on all 32 bit Windows platforms:

dinput.c:519: Test failed: EnumDevicesBySemantics did not call the callback
hr=80070057
dinput.c:520: Test failed: EnumDevicesBySemantics should enumerate the keyboard
dinput.c:521: Test failed: EnumDevicesBySemantics should enumerate the mouse
dinput.c:527: Test failed: EnumDevicesBySemantics failed hr=80070057
dinput.c:535: Test failed: EnumDevicesBySemantics failed hr=80070057
dinput.c:536: Test failed: There should be devices available before action
mapping available=0
dinput.c:543: Test failed: EnumDevicesBySemantics failed: hr=80070057
dinput.c:548: Test failed: EnumDevicesBySemantics failed hr=80070057
dinput.c:554: Test failed: EnumDevicesBySemantics failed: hr=80070057
dinput.c:559: Test failed: EnumDevicesBySemantics failed hr=80070057
dinput.c:565: Test failed: EnumDevicesBySemantics failed hr=80070057
dinput.c:571: Test failed: EnumDevicesBySemantics failed hr=80070057
dinput.c:577: Test failed: EnumDevicesBySemantics failed hr=80070057

See:
https://test.winehq.org/data/tests/dinput8:dinput.html
https://www.winehq.org/pipermail/wine-devel/2016-March/112371.html

I can reproduce the problem with this compiler:
$ i686-w64-mingw32-gcc --version
i686-w64-mingw32-gcc (GCC) 5.3.1 20160205

But if I recompile the tests with -O0 the failures go away which points to a
compiler bug.
We need to either:
* Switch to a non buggy compiler to build the reference WineTest executables.
  (which might involve reporting the bug in the first place)

* Add 'CFLAGS = -g -O0' to the test's Makefile.in as a workaround.
  (preferably once we can point to a relevant compiler bug)

* Find some other nicer workaround in the C file.

[Bug 40384] dinput8:dinput regression caused by new compiler

https://bugs.winehq.org/show_bug.cgi?id=40384

François Gouget  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |source, testcase
                URL|                            |https://test.winehq.org/dat
                   |                            |a/tests/dinput8:dinput.html

[Bug 40384] dinput8:dinput regression caused by new compiler

https://bugs.winehq.org/show_bug.cgi?id=40384

--- Comment #1 from François Gouget  ---
Created attachment 54352
  --> https://bugs.winehq.org/attachment.cgi?id=54352
Shrunk test case

Simplified dinput8:dinput test that still reproduces one of the failures.
Failure goes away if compiled with -O0 instead of -O2.

[Bug 40384] dinput8:dinput regression caused by new compiler

https://bugs.winehq.org/show_bug.cgi?id=40384

[e-mail] changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 40384] dinput8:dinput regression caused by new compiler

https://bugs.winehq.org/show_bug.cgi?id=40384

Detlef Riekenberg  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

[Bug 40384] dinput8:dinput regression caused by new compiler

https://bugs.winehq.org/show_bug.cgi?id=40384

Bernhard Übelacker  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #2 from Bernhard Übelacker  ---
GCC bisect:
https://www.winehq.org/pipermail/wine-devel/2016-July/113928.html

Patch sent for comments.
https://www.winehq.org/pipermail/wine-patches/2016-August/153002.html

[Bug 40384] dinput8:dinput regression caused by new compiler

https://bugs.winehq.org/show_bug.cgi?id=40384

--- Comment #3 from Bernhard Übelacker  ---
Patch got committed:
http://source.winehq.org/git/wine.git/commit/86cdf0b1cb7a15cb43dd0c600b66f66...

First test run after commit looks good to me:
https://test.winehq.org/data/tests/dinput8:dinput.html

[Bug 40384] dinput8:dinput regression caused by new compiler

https://bugs.winehq.org/show_bug.cgi?id=40384

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Fixed by SHA1|                            |86cdf0b1cb7a15cb43dd0c600b6
                   |                            |6f6665aea87d2
             Status|NEW                         |RESOLVED

--- Comment #4 from Nikolay Sivov  ---
Thank you.

[Bug 40384] dinput8:dinput regression caused by new compiler

https://bugs.winehq.org/show_bug.cgi?id=40384

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #5 from Alexandre Julliard  ---
Closing bugs fixed in 1.9.17.