[Bug 51077] New: "The Settlers V: Heritage of Kings" fails to launch with Wine >=5.21

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51077

Bug ID: 51077
           Summary: "The Settlers V: Heritage of Kings" fails to launch
                    with Wine >=5.21
           Product: Wine
           Version: 5.21
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: -unknown
          Assignee: [e-mail]
          Reporter: [e-mail]
      Distribution: ---

Created attachment 69940
  --> https://bugs.winehq.org/attachment.cgi?id=69940
Backtrace and Terminal Output

I'm using the German DVD ROM Version of "Die Siedler: Das Erbe der Könige Gold
Edition" / "The Settlers: Heritage of Kings"
With Wine-staging 5.20 and below the game launches and works as expected. With
5.21-staging or higher (tried various versions up to 6.7) the game fails to
launch and shows a Wine crash report window instead.

REPRODUCE:
1.) Install "The Settlers V" in a fresh Wine prefix with wine 5.21 or higher
(the free demo will work too)
2.) Try to launch the game afterwards

OBSERVED RESULT:
The game doesn't launch / immediately crashes

EXPECTED RESULT:
The game launches normally, like it does with older versions of wine.

There is a free demo of the game that shows the same symptoms and thus could be
used for testing. The game is quite old so there doesn't seem to be an official
download site anymore but I downloaded it from here (German demo):
https://www.4players.de/4players.php/download_info/Downloads/Download/7636/D...

[Bug 51077] "The Settlers V: Heritage of Kings" fails to launch with Wine >=5.21

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51077

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download, regression
                URL|                            |https://dl.4players.de/f1/p
                   |                            |c/diesiedler5/siedler_V_dem
                   |                            |o.zip

--- Comment #1 from Gijs Vermeulen  ---
Adding download + keywords. Will try to reproduce later.

$ sha1sum siedler_V_demo.zip 
da1ff4409c8eb9c23675003d5d5b409b3611389f  siedler_V_demo.zip

$ du -sh siedler_V_demo.zip 
384M    siedler_V_demo.zip

[Bug 51077] "The Settlers V: Heritage of Kings" fails to launch with Wine >=5.21

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51077

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
                 CC|                            |[e-mail]

--- Comment #2 from Louis Lenders  ---
Confirming the crash, couldn`t find obvious cause of error from debuglog

I also checked it starts fine in wine-5.0

So I guess regression test is the way to go. Maybe I do later if no-one beats
me to it...

[Bug 51077] "The Settlers V: Heritage of Kings" fails to launch with Wine >=5.21

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51077

Louis Lenders  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
    Regression SHA1|                            |d5c089f5fa71e2ae568b2f1bcb9
                   |                            |158223c552040
                 CC|                            |[e-mail]

--- Comment #3 from Louis Lenders  ---
This comes out of regressiontest:

d5c089f5fa71e2ae568b2f1bcb9158223c552040 is the first bad commit
commit d5c089f5fa71e2ae568b2f1bcb9158223c552040
Author: Alexandre Julliard 
Date:   Thu Oct 29 16:49:29 2020 +0100

winebuild: Set PE timestamps to a hash of the file name.

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=44061
    Signed-off-by: Alexandre Julliard

tools/winebuild/spec32.c | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

[Bug 51077] "The Settlers V: Heritage of Kings" fails to launch with Wine >=5.21

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51077

--- Comment #4 from Gijs Vermeulen  ---
(In reply to Louis Lenders from comment #3)
> -snip-

I can confirm this, reverting that commit on current -git (reverts cleanly)
makes it work again.

[Bug 51077] "The Settlers V: Heritage of Kings" fails to launch with Wine >=5.21

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51077

--- Comment #5 from Alexandre Julliard  ---
Stupid app apparently doesn't allow negative timestamps.
Does it run on a recent Windows? They have hashed timestamps too nowadays.

[Bug 51077] "The Settlers V: Heritage of Kings" fails to launch with Wine >=5.21

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51077

--- Comment #6 from [e-mail] ---
(In reply to Alexandre Julliard from comment #5)
> Stupid app apparently doesn't allow negative timestamps.
> Does it run on a recent Windows? They have hashed timestamps too nowadays.

I'm pretty sure I ran this game just fine without modifications on Windows 10
before but now that you're saying it I do seem to remember that some people had
problems running the game on Win10. I don't currently have a machine running
Windows 10 to test though.

I totally forgot about this but apparently there's a patched version that works
on Windows 10.
I have no idea who made this patch and the download link I found is literally
some random file sharing site and the link was shared on some forum by someone.
Seems legit. The .exe files check out fine on VirusTotal though.
https://www.siedler-maps.de/forum.php?action=showthread&postid=147456 (german
forum)
https://workupload.com/file/VwbhS5Z (sketchy download link)

And someone in the forum mentioned something about timestamps that causes
problems with Win10.
I just tried this patched executable and it actually does launch with Wine 6.7.
I could have sworn last time I tried it this patch did not work in Wine at all,
with any version. Oh well.
Also, I think there are problems with LAN Multiplayer with this patched
version, particularly when mixing games with and without the patch.

[Bug 51077] "The Settlers V: Heritage of Kings" fails to launch with Wine >=5.21

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51077

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |NOTOURBUG
             Status|NEW                         |RESOLVED

--- Comment #7 from Alexandre Julliard  ---
OK thanks, that's an app bug then, or at least an incompatibility with recent
Windows.

[Bug 51077] "The Settlers V: Heritage of Kings" fails to launch with Wine >=5.21

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51077

--- Comment #8 from Louis Lenders  ---
To confirm:

I just tested on windows 10, and "nothing" happens.

It doesn`t crash but doesn`t start either, just returns to the consoleprompt
when started from console, and when started through explorer  nothing happens
either

[Bug 51077] "The Settlers V: Heritage of Kings" fails to launch with Wine >=5.21

[WineHQ Bugzilla]

https://bugs.winehq.org/show_bug.cgi?id=51077

Gijs Vermeulen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED
         Resolution|NOTOURBUG                   |INVALID

--- Comment #9 from Gijs Vermeulen  ---
Let's go with INVALID since it's an app bug.