https://bugs.winehq.org/show_bug.cgi?id=50362
Bug ID: 50362 Summary: Fl Studio 20.8 crashes on startup Product: Wine Version: unspecified Hardware: x86-64 OS: Linux Status: UNCONFIRMED Severity: normal Priority: P2 Component: kernel32 Assignee: wine-bugs@winehq.org Reporter: John.kinigos@gmail.com Distribution: ---
Created attachment 68968 --> https://bugs.winehq.org/attachment.cgi?id=68968 The patch
After version 20.8 on all versions of wine Fl Studio Crashes on startup with a list out of bounds error. After we did some debugging work on the Fl Studio forum (Thanks Praash), we discovered that the error occurs exactly after the program trying to use CompareString function with a flag that isn't supported by wine (SORT_DIGITSASNUMBERS). I managed to make a patch (by adding that flag) that made the program work and didn't break anything else. I already submitted the patch at upstream but that admittedly wasn't the best course of action cause I am not really a developer resulting to it being ignored. However the patch works great and I even managed to make a small test for it. So my question is: could we probably include this in wine-staging since it breaks one of the biggest programs running in wine and affects a lot of users. Thank you in advance
https://bugs.winehq.org/show_bug.cgi?id=50362
--- Comment #1 from John.kinigos@gmail.com --- Created attachment 68969 --> https://bugs.winehq.org/attachment.cgi?id=68969 The test
https://bugs.winehq.org/show_bug.cgi?id=50362
John.kinigos@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |z.figura12@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=50362
Zebediah Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Keywords| |patch Version|unspecified |6.0-rc3
--- Comment #2 from Zebediah Figura z.figura12@gmail.com --- I think the patch is probably good enough for upstream, at least after some tweaks in the subject line. It may not be accepted at the moment, though, since we're in code freeze. I'd recommend the following modifications:
* prepend the component (i.e. kernelbase)
* change the subject to reflect what the patch is actually doing (something like "Ignore SORT_DIGITSASNUMBERS in CompareStringEx()." seems appropriate to me)
* mention the bug report using the Wine-Bug tag rather than in the subject (as e.g. https://source.winehq.org/patches/data/197608)
https://bugs.winehq.org/show_bug.cgi?id=50362
--- Comment #3 from John.kinigos@gmail.com --- (In reply to Zebediah Figura from comment #2)
I think the patch is probably good enough for upstream, at least after some tweaks in the subject line. It may not be accepted at the moment, though, since we're in code freeze. I'd recommend the following modifications:
prepend the component (i.e. kernelbase)
change the subject to reflect what the patch is actually doing (something
like "Ignore SORT_DIGITSASNUMBERS in CompareStringEx()." seems appropriate to me)
- mention the bug report using the Wine-Bug tag rather than in the subject
Thanks for your reply! So I added these modifications to the patch. Should I now just resubmit it?
https://bugs.winehq.org/show_bug.cgi?id=50362
--- Comment #4 from John.kinigos@gmail.com --- Created attachment 68970 --> https://bugs.winehq.org/attachment.cgi?id=68970 Updated patch
https://bugs.winehq.org/show_bug.cgi?id=50362
--- Comment #5 from Zebediah Figura z.figura12@gmail.com --- Yes, probably. There's still a good chance it'll be deferred until after code freeze.
https://bugs.winehq.org/show_bug.cgi?id=50362
Alexander Robb alex765@protonmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |alex765@protonmail.com
https://bugs.winehq.org/show_bug.cgi?id=50362
tom@tom-mcc.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tom@tom-mcc.com
https://bugs.winehq.org/show_bug.cgi?id=50362
Anastasius Focht focht@gmx.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |NEW Keywords| |download URL| |https://web.archive.org/web | |/20210126185208/https://dem | |odownload.image-line.com/fl | |studio/flstudio_win_20.8.0. | |2115.exe CC| |focht@gmx.net Ever confirmed|0 |1
--- Comment #6 from Anastasius Focht focht@gmx.net --- Hello folks,
confirming and adding stable download link via Internet Archive:
https://web.archive.org/web/20210126185208/https://demodownload.image-line.c...
$ sha1sum flstudio_win_20.8.0.2115.exe 84541d85fe536905fa5e548965a0a8dc9cee3931 flstudio_win_20.8.0.2115.exe
$Â du -sh flstudio_win_20.8.0.2115.exe 591M flstudio_win_20.8.0.2115.exe
$Â wine --version wine-6.1
Regards
https://bugs.winehq.org/show_bug.cgi?id=50362
makslane makslane@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |makslane@hotmail.com
--- Comment #7 from makslane makslane@hotmail.com --- There are any chance of apply the John's patch? This bug is keeping several users from using FL Studio on Linux.
https://bugs.winehq.org/show_bug.cgi?id=50362
Kari Saaranen sarka9000@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |sarka9000@gmail.com
https://bugs.winehq.org/show_bug.cgi?id=50362
winehq@trummer.xyz changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |winehq@trummer.xyz
--- Comment #8 from winehq@trummer.xyz --- OS: Tumbleweed 20210223
Still crashes with FL Studio 20.8.2 released today, and Wine 6.2. FL Studio 20.7.3 and Wine 6.2 on the same machine works.
https://bugs.winehq.org/show_bug.cgi?id=50362
John Yani vanuan@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |vanuan@gmail.com
--- Comment #9 from John Yani vanuan@gmail.com --- There are some comments regarding this patch:
https://www.winehq.org/pipermail/wine-devel/2020-December/178749.htm
This breaks the tests:
tools/runtest -q -P wine -T . -M kernel32.dll -p dlls/kernel32/tests/kernel32_test.exe locale && touch dlls/kernel32/tests/locale.ok locale.c:1880: Test failed: unexpected error code -559038737 locale.c:1882: Test failed: CompareStringA must fail with invalid flag make: *** [Makefile:67005: dlls/kernel32/tests/locale.ok] Error 2
https://bugs.winehq.org/show_bug.cgi?id=50362
Ahmad Moghazi moghaaazi@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |moghaaazi@gmail.com
--- Comment #10 from Ahmad Moghazi moghaaazi@gmail.com --- same on wine-6.3 & flstudio_win_20.8.2.2247 how can I fix this issue? can I install fl sdudio with another app like lutris? plz help me. it show me this error every time I open fl studio flengine.dll error flengine.dll error with a lot of number I can't even copy the error or close the app, I close the app with a terminal system monitor like (bottom)
https://bugs.winehq.org/show_bug.cgi?id=50362
--- Comment #11 from Ahmad Moghazi moghaaazi@gmail.com --- Same on wine-6.3 & flstudio_win_20.8.2.2247 every time I open the fl studio it show me this error flengine.dll with a lot of number I can't even copy the error or close the app, I close the app with a terminal system monitor like bottom
https://bugs.winehq.org/show_bug.cgi?id=50362
--- Comment #12 from winehq@trummer.xyz --- (In reply to Ahmad Moghazi from comment #10)
same on wine-6.3 & flstudio_win_20.8.2.2247 how can I fix this issue? can I install fl sdudio with another app like lutris? plz help me.
Please read the thread. There is already a patch, but not yet merged upstream. Using Lutris won't help because it's just a wrapper for Wine.
You can either keep using 20.7.3 for now, or apply the patch and compile it yourself to use 20.8.
https://bugs.winehq.org/show_bug.cgi?id=50362
mips171@icloud.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |mips171@icloud.com
--- Comment #13 from mips171@icloud.com --- This bug also affects me. I hope the patch can be fixed up and merged asap.
https://bugs.winehq.org/show_bug.cgi?id=50362
jdawin@math.uni-bielefeld.de changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |jdawin@math.uni-bielefeld.d | |e
--- Comment #14 from jdawin@math.uni-bielefeld.de --- Created attachment 69604 --> https://bugs.winehq.org/attachment.cgi?id=69604 patch-for-tests
Corresponding patch for dlls/kernel32/tests/locale.c
https://bugs.winehq.org/show_bug.cgi?id=50362
--- Comment #15 from jdawin@math.uni-bielefeld.de --- (In reply to John Yani from comment #9)
There are some comments regarding this patch:
https://www.winehq.org/pipermail/wine-devel/2020-December/178749.htm
This breaks the tests:
tools/runtest -q -P wine -T . -M kernel32.dll -p dlls/kernel32/tests/kernel32_test.exe locale && touch dlls/kernel32/tests/locale.ok locale.c:1880: Test failed: unexpected error code -559038737 locale.c:1882: Test failed: CompareStringA must fail with invalid flag make: *** [Makefile:67005: dlls/kernel32/tests/locale.ok] Error 2
Hi,
the test error can be fixed with the attached patch "patch-for-tests". Is this sufficient for the original patch to be tested and considered again?
Regards, Jean Rene
https://bugs.winehq.org/show_bug.cgi?id=50362
--- Comment #16 from Ahmad Moghazi moghaaazi@gmail.com --- (In reply to winehq from comment #12)
(In reply to Ahmad Moghazi from comment #10)
same on wine-6.3 & flstudio_win_20.8.2.2247 how can I fix this issue? can I install fl sdudio with another app like lutris? plz help me.
Please read the thread. There is already a patch, but not yet merged upstream. Using Lutris won't help because it's just a wrapper for Wine.
You can either keep using 20.7.3 for now, or apply the patch and compile it yourself to use 20.8.
I installed 20.7.3 version, worked but buttons don't respond to mouse clicks, also there's no sound, and I tried all solutions, anyway I'm using now (Bitwig)
https://bugs.winehq.org/show_bug.cgi?id=50362
--- Comment #17 from Gijs Vermeulen gijsvrm@gmail.com --- This should be fixed now by https://source.winehq.org/git/wine.git/commit/0a366f7e4a68c9375b54ace5289989bd81b65d22, please retest.
https://bugs.winehq.org/show_bug.cgi?id=50362
--- Comment #18 from jdawin@math.uni-bielefeld.de --- (In reply to Gijs Vermeulen from comment #17)
This should be fixed now by https://source.winehq.org/git/wine.git/commit/ 0a366f7e4a68c9375b54ace5289989bd81b65d22, please retest.
Yes, for me that fixes it. Thanks.
https://bugs.winehq.org/show_bug.cgi?id=50362
Zebediah Figura z.figura12@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED Fixed by SHA1| |0a366f7e4a68c9375b54ace5289 | |989bd81b65d22
--- Comment #19 from Zebediah Figura z.figura12@gmail.com --- Marking fixed.
https://bugs.winehq.org/show_bug.cgi?id=50362
Alexandre Julliard julliard@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |CLOSED
--- Comment #20 from Alexandre Julliard julliard@winehq.org --- Closing bugs fixed in 6.5.
https://bugs.winehq.org/show_bug.cgi?id=50362
--- Comment #21 from makslane makslane@hotmail.com --- Thank you all
https://bugs.winehq.org/show_bug.cgi?id=50362
Michael Stefaniuc mstefani@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |6.0.x
https://bugs.winehq.org/show_bug.cgi?id=50362
Michael Stefaniuc mstefani@winehq.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|6.0.x |---
--- Comment #22 from Michael Stefaniuc mstefani@winehq.org --- Removing the 6.0.x milestone from bug fixes included in 6.0.2.