[Bug 22607] New: When I'm trying to exit from TextPad it's crashing in Ubuntu 10.04

http://bugs.winehq.org/show_bug.cgi?id=22607

Summary: When I'm trying to exit from TextPad it's crashing in
                    Ubuntu 10.04
           Product: Wine
           Version: 1.1.42
          Platform: x86
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P1
         Component: -unknown
        AssignedTo: [e-mail]
        ReportedBy: [e-mail]

When I change an option on Configure Tab -> Preferences -> Tabulations ->
Change from tab to spaces.

This change is not working, and when I'm trying to exit the application, it's
crashing with the following message:

The program TextPad.exe has encountered a serious problem and need to close. We
are sorry for the inconvenience.

[Bug 22607] TextPad crashes on exit

http://bugs.winehq.org/show_bug.cgi?id=22607

Vitaliy Margolen  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P1                          |P2
            Summary|When I'm trying to exit     |TextPad crashes on exit
                   |from TextPad it's crashing  |
                   |in Ubuntu 10.04             |
              Alias|Tavo                        |
           Severity|normal                      |minor

--- Comment #1 from Vitaliy Margolen   2010-05-06 22:20:55 ---
Attach as a plain text file complete terminal output of running the program.
Also make sure to try with wine-1.1.43

[Bug 22607] TextPad crashes on exit

http://bugs.winehq.org/show_bug.cgi?id=22607

--- Comment #2 from NSLW  2010-10-25 11:58:13 CDT ---
Created an attachment (id=31515)
 --> (http://bugs.winehq.org/attachment.cgi?id=31515)
Terminal output on Wine-1.3.5

download link 
http://download.textpad.com/download/v54/txpeng540.exe

[Bug 22607] TextPad crashes on exit

http://bugs.winehq.org/show_bug.cgi?id=22607

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |download
                URL|                            |http://download.textpad.com
                   |                            |/download/v54/txpeng540.exe

--- Comment #3 from Nikolay Sivov  2010-10-25 12:02:49 CDT ---
(In reply to comment #2)
> Created an attachment (id=31515)

--> (http://bugs.winehq.org/attachment.cgi?id=31515) [details]
> Terminal output on Wine-1.3.5

Hm, thanks. Could you attach a log with wine debug symbols?

[Bug 22607] TextPad crashes on exit

http://bugs.winehq.org/show_bug.cgi?id=22607

Adam Martinson  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[e-mail]

--- Comment #4 from Adam Martinson  2010-10-25 13:09:47 CDT ---
It's one of the XSLPattern built-in functions that's unimplemented.  Need a log
with +msxml please.

[Bug 22607] TextPad crashes on exit

http://bugs.winehq.org/show_bug.cgi?id=22607

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1

--- Comment #5 from Austin English  2010-10-25 13:28:26 CDT ---
I see it to, confirming. You can just install, start, close and get a crash.

+msxml/debug symbols incoming.

[Bug 22607] TextPad crashes on exit

http://bugs.winehq.org/show_bug.cgi?id=22607

--- Comment #6 from Austin English  2010-10-25 13:28:45 CDT ---
Created an attachment (id=31521)
 --> (http://bugs.winehq.org/attachment.cgi?id=31521)
+msxml/backtrace

[Bug 22607] TextPad crashes on exit

http://bugs.winehq.org/show_bug.cgi?id=22607

--- Comment #7 from Nikolay Sivov  2010-10-25 13:42:00 CDT ---
No, I don't think it's a XSLPattern crash, but still showed fixme should be
fixed probably.

The reason it crashes is another case when developers ignore arguments type.

---
trace:msxml:domdoc_createProcessingInstruction (0x14a570)->(L"xml"
L"version="1.0" encoding="UTF-8"" 0x32ec80)
...
=>0 0x7ecd26cf SysAllocStringByteLen+0x5f(str="", len=0x8455355)
---

Processing instruction body passed as WCHAR string instead of be properly
allocated BSTR.

This could be verified with tracing passed pointer and +relay to catch all
SysAllocString() return values.

Fix is simple, already done for some methods with tests.

[Bug 22607] TextPad crashes on exit

http://bugs.winehq.org/show_bug.cgi?id=22607

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|-unknown                    |msxml3

[Bug 22607] TextPad crashes on exit

http://bugs.winehq.org/show_bug.cgi?id=22607

--- Comment #8 from Adam Martinson  2010-10-25 14:44:24 CDT ---
(In reply to comment #7)
> No, I don't think it's a XSLPattern crash, but still showed fixme should be
> fixed probably.

The XSLPattern stuff doesn't cause the crash, but probably the crash wouldn't
be exposed if the XSLPattern query worked correctly.

[Bug 22607] TextPad crashes on exit

http://bugs.winehq.org/show_bug.cgi?id=22607

--- Comment #9 from Nikolay Sivov  2010-10-25 15:58:34 CDT ---
Created an attachment (id=31526)
 --> (http://bugs.winehq.org/attachment.cgi?id=31526)
patch

This should fix a crash.

[Bug 22607] TextPad crashes on exit

http://bugs.winehq.org/show_bug.cgi?id=22607

Austin English  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch

--- Comment #10 from Austin English  2010-10-25 16:30:49 CDT ---
(In reply to comment #9)
> Created an attachment (id=31526)

--> (http://bugs.winehq.org/attachment.cgi?id=31526) [details]
> patch
>
> This should fix a crash.

Partially. That fixes:
run, close
but if you do:
run, open preferences, close preferences, close app

still get a crash.

[Bug 22607] TextPad crashes on exit

http://bugs.winehq.org/show_bug.cgi?id=22607

--- Comment #11 from Nikolay Sivov  2010-10-25 16:32:20 CDT ---
Ok, another log please.

[Bug 22607] TextPad crashes on exit

http://bugs.winehq.org/show_bug.cgi?id=22607

--- Comment #12 from Austin English  2010-10-25 23:23:15 CDT ---
Created an attachment (id=31531)
 --> (http://bugs.winehq.org/attachment.cgi?id=31531)
+msxml

Seems got a crash in glibc. Fun. I added it on the end.

[Bug 22607] TextPad crashes on exit

http://bugs.winehq.org/show_bug.cgi?id=22607

--- Comment #13 from Nikolay Sivov  2010-10-26 12:40:42 CDT ---
First crash is fixed by adfd3058212e4caa71777fae1364fb8dfdd07c62.

[Bug 22607] TextPad crashes on exit

http://bugs.winehq.org/show_bug.cgi?id=22607

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31526|0                           |1
        is obsolete|                            |

[Bug 22607] TextPad crashes on exit

http://bugs.winehq.org/show_bug.cgi?id=22607

--- Comment #14 from Adam Martinson  2010-11-03 13:24:43 CDT ---
This one works fine for me with current git.  For those of you who still get
crashes, what libxml version are you using?

[Bug 22607] TextPad crashes on exit

http://bugs.winehq.org/show_bug.cgi?id=22607

--- Comment #15 from Austin English  2010-11-03 14:26:52 CDT ---
Works for me in git / libxml 2.7.3-r2 (gentoo).

Octaviano, please retest.

[Bug 22607] TextPad crashes on exit

http://bugs.winehq.org/show_bug.cgi?id=22607

Nikolay Sivov  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #16 from Nikolay Sivov  2011-03-13 05:34:37 CDT ---
I don't see a crash on exit with build e030b3ce56a5 (plus some local patches
for msxml to be sent). Marking fixed.

[Bug 22607] TextPad crashes on exit

http://bugs.winehq.org/show_bug.cgi?id=22607

Alexandre Julliard  changed:

What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |CLOSED

--- Comment #17 from Alexandre Julliard  2011-03-18 14:39:28 CDT ---
Closing bugs fixed in 1.3.16.